Border API feedback [158160576]

Fixed

Bug

Status Update

No update yet.

Description

ma...@google.com

created issue #1

Jun 4, 2020 10:16AM

From compose API council:

Border discussion notes

Remove Border data class used by Box?
- Duplicates functionality found elsewhere
Rename Modifier.outline to Modifier.border *This modifier should affect layout and pad in the layout by the size of the border
How do I know how to write an API when these are the potential moving parts:
- Border class
- Shape
- Parameters
- Modifier
Decision!
- Rename Border data class to Stroke
- Remove Modifier.drawBorder modifiers, replace with Modifier.border() * border modifier should also incorporate layout and clip+shape modification
- border parameter on Box becomes "border: Stroke? = null"
- Stroke should have a Color-based convenience factory/constructor *Nice effects: * OutlinedButton now has a shape and a stroke; not conflating the "border" conceptual space * "border" is now a unified concept of shape+stroke parameters+padding+clip behavior * "border" never appears as a parameter; encourage that usage as a modifier * "outline" is part of the OutlinedButton's content

Comments

ja...@google.com <ja...@google.com> #2Jul 31, 2020 12:08PM

Any updates on this? Timeframe?

ma...@google.com <ma...@google.com> #3Jul 31, 2020 12:18PM

Hey. I have a commit already for this, that is almost ready (not a CL yet). I hope I can lend it before alpha, but not all of the stuff described above will happen:

All renaming will be done
There will be NO padding build-in. This is in general not what you want and most of the design sizes come from the edge of the component, not from the border edge. Also it's hard to opt-out of it.
there will be no clipping. Clipping makes little to no sense without padding there and also I asked few people about it and it's not what they would expect.

ap...@google.com <ap...@google.com> #4Aug 11, 2020 05:38PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit d21bfdad68f4c6e66171c3d93e2fdeb356a0cdc5
Author: Matvei Malkov <malkov@google.com>
Date: Mon Aug 10 16:03:41 2020

Modifier.drawBorder -> Modifier.border

This CL renamed drawBorder to border per API council request. Also fixes the problem where border is drawn incorrectly when the shape is a rounded corner rect.

Change-Id: I4257d62b222e27c9ad67e1b2581b162cc9392c9e
Relnote: "Modifier.drawBorder has been deprecated. Use Modifier.border instead. Border data class has been replaced by BorderStroke"
Fixes: 158160576
Test: fixed appropriatelly. Will add screenshot tests separately

M ui/integration-tests/src/main/java/androidx/ui/integration/test/core/SimpleRadioButton1TestCase.kt
M ui/integration-tests/src/main/java/androidx/ui/integration/test/core/SimpleRadioButton2TestCase.kt
M ui/integration-tests/src/main/java/androidx/ui/integration/test/core/SimpleRadioButton4TestCase.kt
M ui/ui-core/integration-tests/ui-core-demos/src/main/java/androidx/compose/ui/demos/gestures/DoubleTapGestureDetectorDemo.kt
M ui/ui-core/integration-tests/ui-core-demos/src/main/java/androidx/compose/ui/demos/gestures/DoubleTapInTapDemo.kt
M ui/ui-core/integration-tests/ui-core-demos/src/main/java/androidx/compose/ui/demos/gestures/HorizontalScrollersInVerticalScrollerDemo.kt
M ui/ui-core/integration-tests/ui-core-demos/src/main/java/androidx/compose/ui/demos/gestures/LongPressGestureDetectorDemo.kt
M ui/ui-core/integration-tests/ui-core-demos/src/main/java/androidx/compose/ui/demos/gestures/NestedLongPressDemo.kt
M ui/ui-core/integration-tests/ui-core-demos/src/main/java/androidx/compose/ui/demos/gestures/NestedPressDemo.kt
M ui/ui-core/integration-tests/ui-core-demos/src/main/java/androidx/compose/ui/demos/gestures/NestedScrollingDemo.kt
M ui/ui-core/integration-tests/ui-core-demos/src/main/java/androidx/compose/ui/demos/gestures/PointerInputDuringSubCompDemo.kt
M ui/ui-core/integration-tests/ui-core-demos/src/main/java/androidx/compose/ui/demos/gestures/PressIndicatorGestureDetectorDemo.kt
M ui/ui-core/integration-tests/ui-core-demos/src/main/java/androidx/compose/ui/demos/gestures/TapGestureDetectorDemo.kt
M ui/ui-core/integration-tests/ui-core-demos/src/main/java/androidx/compose/ui/demos/gestures/VerticalScrollerInDrawerLayoutDemo.kt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/BoxDemo.kt
M ui/ui-foundation/samples/src/main/java/androidx/compose/foundation/samples/BorderSamples.kt
M ui/ui-foundation/samples/src/main/java/androidx/compose/foundation/samples/BoxSamples.kt
M ui/ui-foundation/samples/src/main/java/androidx/compose/foundation/samples/InteractionStateSample.kt
M ui/ui-foundation/samples/src/main/java/androidx/compose/foundation/samples/ZoomableSample.kt
M ui/ui-foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/BorderTest.kt
M ui/ui-foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/BoxTest.kt
M ui/ui-foundation/src/commonMain/kotlin/androidx/compose/foundation/Border.kt
A ui/ui-foundation/src/commonMain/kotlin/androidx/compose/foundation/BorderStroke.kt
M ui/ui-foundation/src/commonMain/kotlin/androidx/compose/foundation/Box.kt
D ui/ui-foundation/src/commonMain/kotlin/androidx/compose/foundation/DrawBorder.kt
M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/ButtonDemo.kt
M ui/ui-material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/ColorPickerDemo.kt
M ui/ui-material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/ElevationDemo.kt
M ui/ui-material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/ProgressIndicatorDemo.kt
M ui/ui-material/samples/src/main/java/androidx/compose/material/samples/ScaffoldSamples.kt
M ui/ui-material/samples/src/main/java/androidx/compose/material/samples/TabSamples.kt
M ui/ui-material/src/androidAndroidTest/kotlin/androidx/compose/material/AlertDialogTest.kt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/Button.kt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/Card.kt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/Surface.kt
M ui/ui-tooling/src/androidTest/java/androidx/ui/tooling/inspector/ParameterFactoryTest.kt
M ui/ui-tooling/src/main/java/androidx/ui/tooling/inspector/ParameterFactory.kt

https://android-review.googlesource.com/1394768

Issue 158160576

Description

Issue summary

Comments

ja...@google.com <ja...@google.com> #2Jul 31, 2020 12:08PM

ma...@google.com <ma...@google.com> #3Jul 31, 2020 12:18PM

ap...@google.com <ap...@google.com> #4Aug 11, 2020 05:38PM

Add comment

Issue metadata