Preview doesn't render BottomAppBar cutout [158551084]

Fixed

Bug

Status Update

No update yet.

Description

cl...@google.com

created issue #1

Jun 9, 2020 11:28AM

Component used: BottomAppBar

Version used: AS 4.1 Canary 8 + Compose snapshot at 6557927

I created a BottomAppBar with a FAB and cutout, and running the emulator it appears correct but in the preview the cutout is not rendered correctly.

Code:

@Composable
fun ReplyScaffold(content: @Composable () -> Unit) {
    Scaffold(
        backgroundColor = AppBackground,
        bottomBar = { ReplyBottomBar() },
        floatingActionButton = { ReplyFAB() },
        floatingActionButtonPosition = Scaffold.FabPosition.Center,
        isFloatingActionButtonDocked = true
    ) {
        content()
    }
}

@Composable
fun ReplyBottomBar() {
    // TODO: cutout doesn't work on preview
    BottomAppBar(cutoutShape = RoundedCornerShape(50)) {
        IconButton(onClick = {}) {
            Icon(Icons.Default.KeyboardArrowUp)
        }
        Spacer(modifier = Modifier.weight(1f))
        IconButton(onClick = {}) {
            Icon(Icons.Default.Search)
        }
    }
}

@Composable
fun ReplyFAB() {
    FloatingActionButton(
        onClick = {}
    ) {
        Icon(Icons.Default.Edit)
    }
}

@Preview
@Composable
fun ScaffoldPreview() {
    AppTheme {
        ReplyScaffold {
            Text("Hello")
        }
    }
}

Screenshot 2020-06-09 at 12.25.42.png

333 KB

View

Download

Comments

lp...@google.com <lp...@google.com> #2Jun 9, 2020 11:30AM

Project: platform/frameworks/support
Branch: androidx-main

commit 9082f62682f853ad5251a1c79dde9eccba7abdd9
Author: Max Alfonso-Ying <maxying@google.com>
Date: Thu Apr 18 00:34:40 2024

[M2 text field] Apply background to decoration box

...instead of to the BasicTextField, so changing the
backgroundColor will properly change the decoration
box's background color.

Fixes:

b/307694651

Test: added unit tests
Relnote: "Fix backgroundColor not applying to
TextFieldDecorationBox and OutlinedTextFieldDecorationBox.
Decoration boxes now accept a `shape` parameter."
Change-Id: I371c26718597cb36ac537e9412ce476532afb40d

M compose/material/material/api/current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/TextFieldDecorationBoxDemos.kt
M compose/material/material/src/androidInstrumentedTest/kotlin/androidx/compose/material/textfield/TextFieldDecorationBoxTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/OutlinedTextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextFieldDefaults.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextFieldImpl.kt

https://android-review.googlesource.com/3046833

an...@google.com <an...@google.com> #3Jun 9, 2020 11:36AM

I actually had an idea to try to start using subcomposition similar to the one we have in WithConstraints for TabRow and Scaffold to fix this one frame lag

[Deleted User] <[Deleted User]> #4Jun 11, 2020 02:32PM

<purged>

[Deleted User] <[Deleted User]> #5Jun 11, 2020 02:35PM

<purged>

an...@google.com <an...@google.com> Jul 21, 2020 05:09PM

Reassigned to an...@google.com.

an...@google.com <an...@google.com> #6Aug 4, 2020 04:27PM

Reassigned to ma...@google.com.

It will be fixed when we migrate Scaffold to SubcomposeLayout

lp...@google.com <lp...@google.com> Sep 16, 2020 04:26PM

Reassigned to lp...@google.com.

lp...@google.com <lp...@google.com> Sep 29, 2020 07:50PM

Marked as fixed.

ap...@google.com <ap...@google.com> #7Sep 29, 2020 07:50PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit e243833b9705e35184bb8aec84cb9ef49f66eb76
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Mon Sep 14 16:10:51 2020

Refactors Scaffold to use SubcomposeLayout, avoiding frame delays in calculating the content padding / FAB cutout location

Also removes nullable type from Composable lambda parameters, these now just default to emptyContent()

Bug:

b/157633857

Bug:

b/158551084

Test: ScaffoldTest
Test: ScaffoldScreenshotTest
Relnote: "Removes nullable type from Scaffold lambda parameters, you can use emptyContent() to represent no content for a given parameter."
Change-Id: I2b3181de9314b8b0dd48c30e2f663cddc0d62448

M compose/material/material/api/current.txt
M compose/material/material/api/public_plus_experimental_current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/MaterialDemos.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/ScaffoldScreenshotTest.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/ScaffoldTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/AppBar.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Scaffold.kt

https://android-review.googlesource.com/1426753