Button component icon [158677863]

Fixed

Feature Request

Status Update

No update yet.

Description

ka...@google.com

created issue #1

Jun 10, 2020 07:05PM

Component used: Button
Version used: dev-12
Devices/Android versions reproduced on: n/a

The material button component should support icons next to text.

https://material.io/components/buttons#contained-button

Comments

cl...@google.com <cl...@google.com> #2Jun 11, 2020 10:19AM

Assigned to an...@google.com.

Hi, thanks for reaching out and reporting this issue! Can you check and verify if you're seeing the same error when using API explorer link?

Message last modified on Jun 11, 2020 10:19AM

an...@google.com <an...@google.com> #3Jun 11, 2020 10:43AM

Hi,

Thank you for quick response. Yes, I actually copied curl code above from the API explorer.

I also tried with Python code below:

request = youtube.search().list(
    part="snippet",
    maxResults=50,
    order="viewCount",
    publishedAfter="2024-09-01T00:00:00Z",
    q="artificial intelligence",
    videoPaidProductPlacement="true",
)
response = request.execute()
return response

This also gave me invalid parameter error:

TypeError: Got an unexpected keyword argument videoPaidProductPlacement

ka...@google.com <ka...@google.com> #4Jun 11, 2020 07:20PM

Hello,

I wanted to check if there are any updates regarding this issue, as it is critical for my application. Could you share whether it's planned to be resolved and if there is an estimated timeline for a fix?

I would greatly appreciate any insights you can provide.

Thank you for your time and support.

ap...@google.com <ap...@google.com> #5Jun 26, 2020 11:47AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 038a5eba68197ebfd3c07ae01d5c21fa827b16bb
Author: Andrey Kulikov <andreykulikov@google.com>
Date: Mon Jun 22 19:29:07 2020

Make Button's content slot to be Row

Plus add a sample how to make Button with icon and text

Relnote: Button's content slot now behaves as Row (useful when you need to have an icon with a text, see samples on Button how to write it)
Test: new nests
Fixes: 158677863
Change-Id: I0ff10603b1a290a8f9b0c27988008572ecf0927a

M ui/ui-material/api/0.1.0-dev15.txt
M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_0.1.0-dev15.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/integration-tests/material-demos/src/main/java/androidx/ui/material/demos/ButtonDemo.kt
M ui/ui-material/samples/src/main/java/androidx/ui/material/samples/ButtonSamples.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/Button.kt
M ui/ui-tooling/src/androidTest/java/androidx/ui/tooling/inspector/LayoutInspectorTreeTest.kt

https://android-review.googlesource.com/1346442

Issue 158677863

Description

Issue summary

Comments

cl...@google.com <cl...@google.com> #2Jun 11, 2020 10:19AM

an...@google.com <an...@google.com> #3Jun 11, 2020 10:43AM

ka...@google.com <ka...@google.com> #4Jun 11, 2020 07:20PM

ap...@google.com <ap...@google.com> #5Jun 26, 2020 11:47AM

Add comment

Issue metadata