Fixed
Status Update
No update yet.
Comments
ch...@google.com
mi...@gmail.com
Hi Ed, Thank you so much for these suggestions. I've been reviewing them and merging them in. Hopefully it should be live. I've included a thank you note too in the article.
br...@gmail.com
Great! Thanks a lot, I'll look for the live updates soon!
an...@google.com
an...@google.com
an...@google.com
Thanks for filing the issue.
There is a Camera1/HAL1 issue on the Nexus 4. The preview will be stretched when configuring a JPEG that doesn't actually have the same aspect ratio(3:4) as the maximum supported JPEG resolution on Nexus 4.
The CameraXBasic set the target aspect ratio to 16:9 on Nexus 4 so that the preview is stretched.
We will workaround this Nexus 4 issue in the recent release.
There is a Camera1/HAL1 issue on the Nexus 4. The preview will be stretched when configuring a JPEG that doesn't actually have the same aspect ratio(3:4) as the maximum supported JPEG resolution on Nexus 4.
The CameraXBasic set the target aspect ratio to 16:9 on Nexus 4 so that the preview is stretched.
We will workaround this Nexus 4 issue in the recent release.
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit ee3c5d2dd752c5faf065efb04ed4251514184cfe
Author: Andrew Chiang <andrewchiang@google.com>
Date: Wed Oct 21 16:08:06 2020
Fix the preview is stretched on Nexus 4
There is a Camera1/HAL1 issue on the Nexus 4. The preview will be stretched when configuring a JPEG that doesn't actually have the same aspect ratio as the maximum JPEG resolution.
Workaround the issue by only configuring the size has the same aspect ratio as the maximum JPEG resolution to all the UseCases on Nexus 4.
Relnote:"Fixed an issue where the preview was stretched on Nexus 4 devices running Android L (API levels 21 and 22)."
Bug:
Test: run TargetAspectRatioTest
Change-Id: I4d407ee366c978de4e518995e97d5946fc19e29a
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/quirk/DeviceQuirksLoader.java
A camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/quirk/Nexus4AndroidLTargetAspectRatioQuirk.java
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/quirk/SamsungPreviewTargetAspectRatioQuirk.java
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/workaround/TargetAspectRatio.java
M camera/camera-camera2/src/test/java/androidx/camera/camera2/internal/compat/workaround/TargetAspectRatioTest.java
https://android-review.googlesource.com/1468884
Branch: androidx-master-dev
commit ee3c5d2dd752c5faf065efb04ed4251514184cfe
Author: Andrew Chiang <andrewchiang@google.com>
Date: Wed Oct 21 16:08:06 2020
Fix the preview is stretched on Nexus 4
There is a Camera1/HAL1 issue on the Nexus 4. The preview will be stretched when configuring a JPEG that doesn't actually have the same aspect ratio as the maximum JPEG resolution.
Workaround the issue by only configuring the size has the same aspect ratio as the maximum JPEG resolution to all the UseCases on Nexus 4.
Relnote:"Fixed an issue where the preview was stretched on Nexus 4 devices running Android L (API levels 21 and 22)."
Bug:
Test: run TargetAspectRatioTest
Change-Id: I4d407ee366c978de4e518995e97d5946fc19e29a
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/quirk/DeviceQuirksLoader.java
A camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/quirk/Nexus4AndroidLTargetAspectRatioQuirk.java
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/quirk/SamsungPreviewTargetAspectRatioQuirk.java
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/workaround/TargetAspectRatio.java
M camera/camera-camera2/src/test/java/androidx/camera/camera2/internal/compat/workaround/TargetAspectRatioTest.java
Description
CAMERAX VERSION (ex - 1.0.0-beta04)
CAMERA APPLICATION NAME AND VERSION: CameraXBasic (https://github.com/android/camera-samples/tree/master/CameraXBasic )
ANDROID OS BUILD NUMBER: LMY48T
DEVICE NAME: Nexus 4
DESCRIPTION: Nexus 4 Preview is stretched
LIST ANY EXPERIMENTAL FEATURES: None
STEPS TO REPRODUCE:
OBSERVED RESULTS: The preview is stretched
EXPECTED RESULTS: The preview respects aspect ratio
REPRODUCIBILITY: 5 of 5