Application get crashed when reached at end of List. [158892717]

Fixed

Bug

Status Update

No update yet.

Description

th...@gmail.com

created issue #1

Jun 14, 2020 08:05AM

Component used: Paging
Version used: 3.0.0-alpha01

I have followed codelabs paging 3 tutorial. I have implemented paging from network and database.
This is the repository provided by codelabs tutorial :-

https://github.com/googlecodelabs/android-paging

I have founded 2 issues in Paging 3.

1. Application get crashed when Recylerview reach at end(last page).
Inside GithubRemoteMediator.kt
I have set val endOfPaginationReached = page > 2 to allow maximum 2 pages for testing.
So, the problem is when I reach at the last page of list, application get crashed as remoteKeys.nextKey is null(as we have set nextKey=null for last page of list).

2. Offline cache broken
How to support caching when application is open without internet connection. currently it is showing retry button. How to show previously loaded data. I have tried to fix this by removing

// clear all tables in the database
if (loadType == LoadType.REFRESH) {
repoDatabase.remoteKeysDao().clearRemoteKeys()
repoDatabase.reposDao().clearRepos()
}

as this will now not gone delete data from database.
But still Pager does not load data available.

So how I can fix this problem?
Is there any way of detecting end of paging?
Why Pager is not returning data available in database.

Comments

du...@google.com <du...@google.com> #2Jun 15, 2020 04:16PM

Reassigned to du...@google.com.

Thank you for reporting this issue. For us to further investigate this issue, please provide the following additional information:

Steps to reproduce
What steps are needed to reproduce this issue?

If required, please provide sample project or apk to reproduce the issue. Also mention the steps to be followed for reproducing the issue with the given sample project or apk.

Expected output
What is the expected output?

Current output
What is the current output?

Android bug report capturing
After reproducing the issue, press the volume up, volume down, and power button simultaneously. This will capture a bug report on your device in the “bug reports” directory. Attach the bug report file to this issue.

Alternate method

After reproducing the issue, navigate to “developer settings”, ensure “USB debugging” is enabled, then enable “Bug report shortcut”. Capture bug report by holding the power button and selecting the “Take bug report” option.

Screen Record of the Issue
Please capture screen record or video of the issue using following steps:
adb shell screenrecord /sdcard/video.mp4
Subsequently use following command to pull the recorded file:
adb pull /sdcard/video.mp4
Attach the file to this issue.

th...@gmail.com <th...@gmail.com> #3Jun 17, 2020 09:21AM

Hi,

I think it's my mistake, I guess I should not invoke BiometricPrompt from onResume it will cause an infinite loop.

Running on Samsung A50 Android 9 or Emulator Nexus 5X API 27

Android Studio 3.5.1
compileSdkVersion 29
minSdkVersion 21
targetSdkVersion 29

def biometric_version = "1.0.0-rc01"
implementation "androidx.biometric:biometric:$biometric_version"

Scenario 1:
- No biometric or device credentials (PIN, pattern, password) configured
- Biometric prompt not showing
- Tap on Toast button
- Activity is not responding (can't tap on button)

Scenario 2:
- Device credential configured (Pattern)
- Biometric prompt showing pattern authentication
- Tap on Cancel
- Tap on Toast button
- Activity is not responding (can't tap on button)

Expected output : Toast showing when button tapped

ap...@google.com <ap...@google.com> #4Jun 17, 2020 08:08PM

But I do not have issue if I remove "setDeviceCredentialAllowed", that's what make me thing there is something wrong

Steps to reproduce:
- Fingerprint configured in settings
- Biometric prompt showing
- Tap on cancel
- Tap on Toast button
- Toast is showing

Scenario 2:
- Device credential configured (Pattern)
- Biometric prompt showing pattern authentication
- Tap on Cancel
- Tap on Toast button
- Activity is not responding (can't tap on button)

Behaviour is not the same between biometric and credentials authentication

du...@google.com <du...@google.com> #5Jun 17, 2020 08:16PM

Marked as fixed.

deleted

du...@google.com <du...@google.com> #6Jun 17, 2020 08:18PM

Assigning back to triage queue so it's not lost in mine, will take a look soon.

th...@gmail.com <th...@gmail.com> #7Jun 18, 2020 03:08AM

mathieumolette@gmail.com: You're right that this is likely caused by invoking BiometricPrompt in onResume, causing an authentication loop. But the specific side effect of having the transparent handling activity get stuck onscreen is definitely not intended and ideally shouldn't be this easy to run into. I'll look into making this more robust.

Issue 158892717