Multiple ProvideEmphasis layers user the outer value instead of the latest [159017896]

Fixed

Bug

Status Update

No update yet.

Description

ja...@google.com

created issue #1

Jun 15, 2020 03:34PM

Column {
ProvideEmphasis(emphasis = EmphasisAmbient.current.medium) {
Log.d("jalc", ContentColorAmbient.current.alpha.toString())
Text("This should be medium")

ProvideEmphasis(emphasis = EmphasisAmbient.current.high) {
Log.d("jalc", ContentColorAmbient.current.alpha.toString())
Text("This should be high")

ProvideEmphasis(emphasis = EmphasisAmbient.current.disabled) {
Log.d("jalc", "Disabled " + ContentColorAmbient.current.alpha.toString())
Text("This should be disabled")
}
}
}
}

They all print the same value, 0.6

Expected: receive the parent's value each time.

Comments

ja...@google.com <ja...@google.com> #2Jun 15, 2020 03:49PM

Project: platform/frameworks/support
Branch: androidx-main

commit 9082f62682f853ad5251a1c79dde9eccba7abdd9
Author: Max Alfonso-Ying <maxying@google.com>
Date: Thu Apr 18 00:34:40 2024

[M2 text field] Apply background to decoration box

...instead of to the BasicTextField, so changing the
backgroundColor will properly change the decoration
box's background color.

Fixes:

b/307694651

Test: added unit tests
Relnote: "Fix backgroundColor not applying to
TextFieldDecorationBox and OutlinedTextFieldDecorationBox.
Decoration boxes now accept a `shape` parameter."
Change-Id: I371c26718597cb36ac537e9412ce476532afb40d

M compose/material/material/api/current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/TextFieldDecorationBoxDemos.kt
M compose/material/material/src/androidInstrumentedTest/kotlin/androidx/compose/material/textfield/TextFieldDecorationBoxTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/OutlinedTextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextFieldDefaults.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextFieldImpl.kt

https://android-review.googlesource.com/3046833

cl...@google.com <cl...@google.com> Jun 15, 2020 04:26PM

Assigned to lp...@google.com.

ja...@google.com <ja...@google.com> #3Sep 24, 2020 10:07AM

Friendly ping as it looks like a common case

lp...@google.com <lp...@google.com> #4Sep 24, 2020 05:28PM

This happens because Emphasis currently does not get applied to non-opaque colors - but the use case is valid and is one of the problems with the current `Emphasis` implementation. This needs to change and I have some ideas, but it also requires a lot of changes to the layers below, such as content color, so I need to do a lot more thinking first unfortunately

ap...@google.com <ap...@google.com> #5Nov 4, 2020 11:38AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 3772ac5c0a5bcc10bbc7ba56893cf0540808a095
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Mon Nov 02 19:23:39 2020

Deprecates Emphasis and adds AmbientContentAlpha to represent alpha provided by components

Migrates existing usages of Emphasis to use AmbientContentAlpha.
Text and Icon now consume AmbientContentAlpha by default.

Bug:

b/150286239

Bug:

b/158060530

Bug:

b/159017896

Test: ContentAlphaTest
Relnote: "Emphasis has been deprecated and replaced with AmbientContentAlpha. AmbientContentAlpha is a simpler abstraction that represents the preferred content alpha for part of the hierarchy, similar to how AmbientContentColor represents the preferred content color. Text and Icon now consume the current value from AmbientContentAlpha by default, and you can manually do: color.copy(alpha = AmbientContentAlpha.current) to have the same effect in your components. Instead of using ProvideEmphasis, you can just directly provide a value through AmbientContentAlpha, and use the new default levels in ContentAlpha to replace the old EmphasisLevels."
Change-Id: Idf03e63a3082842e183535b5fdbf04947e3a671c

M compose/material/material/api/current.txt
M compose/material/material/api/public_plus_experimental_current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/MaterialDemos.kt
M compose/material/material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/MaterialTextField.kt
A compose/material/material/samples/src/main/java/androidx/compose/material/samples/ContentAlphaSamples.kt
D compose/material/material/samples/src/main/java/androidx/compose/material/samples/EmphasisSamples.kt
M compose/material/material/samples/src/main/java/androidx/compose/material/samples/TextFieldSamples.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/BottomNavigationScreenshotTest.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/ButtonTest.kt
A compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/ContentAlphaTest.kt
D compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/EmphasisTest.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/MenuTest.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/TabScreenshotTest.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/textfield/OutlinedTextFieldTest.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/textfield/TextFieldTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/AlertDialog.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/AppBar.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/BottomNavigation.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Button.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Checkbox.kt
A compose/material/material/src/commonMain/kotlin/androidx/compose/material/ContentAlpha.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Emphasis.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/FloatingActionButton.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Icon.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/ListItem.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/MaterialTheme.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Menu.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/RadioButton.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Snackbar.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Switch.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Tab.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Text.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextFieldImpl.kt

https://android-review.googlesource.com/1484478

lp...@google.com <lp...@google.com> Nov 4, 2020 11:39AM

Marked as fixed.

Issue 159017896