IssueTracker

Project: platform/frameworks/support
Branch: androidx-main

commit a330c0d3bcdd41326f37968a60e6084ad4a2e32c
Author: Chet Haase <chet@google.com>
Date:   Wed Jul 05 07:26:46 2023

    Convert APIs using PointF to use Float instead
   
    PointF is a convenient mechanism for passing around x.y values
    representing 2D points. But there are downsides, including:
    - Converting to PointF: You may not have the data in PointF form
    to begin with, so using an API which takes PointF requires converting
    the data  to that form (including allocating a PointF object every time)
    - Mutability: Point structures can be mutated internally, causing
    unpredictability in what that mutation means. Should the library
    react to those changes? Ignore them? Do defensive copies (requiring
    even more allocations)? Using primitive types like Float make the
    behavior more obvious (by making the data inherently immutable).
    - Allocations: Whenever we use object types, there are necessarily
    allocations on the Java heap for them. This puts pressure on the GC
    at both allocation and collection time. Given the amount of points
    being passed around (especially at morph creation time, when curves
    are being split and created), this causes a lot of PointF objects to
    be allocated (even temporarily). Using Float avoids that problem.
   
    Also fixed bug with unclosed paths causing discontinuity at the
    start/end point.
   
    Bug: 276466399
    Bug: 290254314
    Test: integration and unit tests pass
    Relnote: PointF parameters changed to Float pairs
    Change-Id: Id4705d27c7be31b26ade8186b99fffe2e2f8450e

M       graphics/graphics-shapes/api/current.txt
M       graphics/graphics-shapes/api/restricted_current.txt
M       graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/CubicShapeTest.kt
M       graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/CubicTest.kt
M       graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/PolygonMeasureTest.kt
M       graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/PolygonTest.kt
M       graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/RoundedPolygonTest.kt
M       graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/ShapesTest.kt
M       graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/TestUtils.kt
M       graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/Cubic.kt
M       graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/CubicShape.kt
M       graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/FeatureMapping.kt
M       graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/FloatMapping.kt
M       graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/Morph.kt
M       graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/PolygonMeasure.kt
M       graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/RoundedPolygon.kt
M       graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/Shapes.kt
M       graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/Utils.kt
M       graphics/integration-tests/testapp-compose/src/main/java/androidx/graphics/shapes/testcompose/DebugDraw.kt
M       graphics/integration-tests/testapp-compose/src/main/java/androidx/graphics/shapes/testcompose/ShapeEditor.kt
M       graphics/integration-tests/testapp/src/main/java/androidx/graphics/shapes/test/MaterialShapes.kt

https://android-review.googlesource.com/2649119

PointF was the main (possibly only) mutability issue, marking this as fixed

I will mark is as blocked by b/154920561 as we first need to make the following fix, and when this case is fixed I can recommend how to avoid clashes with the better messaging

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 5ec2ca9d0adff00297ca0a42a69307aa14341e80
Author: Andrey Kulikov <andreykulikov@google.com>
Date:   Fri Jul 31 17:40:46 2020

    Allow having multiple value providers for the same savedInstanceState() key
   
    Originally we were hoping to solve the unique keys issue fully on a compose compiler/runtime side, but it is not trivial and will make the runtime way less efficient still without 100 percent uniqueness guarantees.
   
    The simple case which is not currently working is
    list.forEach {
       savedInstanceState { 0 }
    }
    Runtime keys are the keys generated during the compilation for the hash of the function invocation location in the codebase. In the for loop we have two invocations with the same key and we can't do anything more clever than just allow multiple invocations with the same key and use the order in which they are executed to differentiate them. Which makes this code basically equivalent to
    list.forEachIndexed { index, item ->
       key(index) {
           savedInstanceState { 0 }
       }
    }
    But still allows to provide more reasonable keys if the user needs it
    list.forEach { item ->
       key(item.myUniqueKey) {
           savedInstanceState { 0 }
       }
    }
    To allow state to be "moved" together with the item if the items in a list was reordered.
   
    Given that we have to adjust how UiSavedStateRegistry works and replicate the runtime behavior. There are could be multiple providers registered for the same [key]. In this case the order in which they were registered matters.
   
    Say we registered two providers for the key. One provides "1", second provides "2".
    [performSave] in this case will have listOf("1", "2) as a value for the key in the map. And later, when the registry will be recreated with the previously saved values, the first execution of [consumeRestored] would consume "1" and the second one "2".
   
    In addition to this change I also refactored rememberSavedInstanceState() implementation to be more prepared for future possible cases when the compose transaction can fail (we can only save the values during composition in state objects) and should use onCommit like behaviour for registering/unregistering the providers.
    Also in light of deprecation of state { } composable in favour to remember { mutableStateOf() } I decided to add a more meaningful error message if the user will try to write rememberSavedInstanceState { mutableStateOf() } to guide people to use savedInstanceState() which provides a Saver implementation for MutableState
   
    Fixes: 160042650
    Fixes: 156853976
    Fixes: 159026663
    Fixes: 154920561
    Relnote: Crash when something which saves the state was used inside the for loop is fixed. Now having the same key in savedInstanceState() is allowed, api of UiSavedStateRegistry is now adjusted to this new requirement
    Test: new tests, manually
    Change-Id: I4ab7630120ffce145d1bf09d52a475d197030150

M       ui/ui-core/src/androidMain/kotlin/androidx/compose/ui/platform/DisposableUiSavedStateRegistry.kt
M       ui/ui-saved-instance-state/api/current.txt
M       ui/ui-saved-instance-state/api/public_plus_experimental_current.txt
M       ui/ui-saved-instance-state/api/restricted_current.txt
M       ui/ui-saved-instance-state/src/androidAndroidTest/kotlin/androidx/compose/runtime/savedinstancestate/RememberSavedInstanceStateTest.kt
A       ui/ui-saved-instance-state/src/androidAndroidTest/kotlin/androidx/compose/runtime/savedinstancestate/RestorationInVariousScenariosTest.kt
M       ui/ui-saved-instance-state/src/commonMain/kotlin/androidx/compose/runtime/savedinstancestate/RememberSavedInstanceState.kt
M       ui/ui-saved-instance-state/src/commonMain/kotlin/androidx/compose/runtime/savedinstancestate/Saver.kt
M       ui/ui-saved-instance-state/src/commonMain/kotlin/androidx/compose/runtime/savedinstancestate/UiSavedStateRegistry.kt
M       ui/ui-saved-instance-state/src/test/java/androidx/compose/runtime/savedinstancestate/AutoSaverTest.kt
M       ui/ui-saved-instance-state/src/test/java/androidx/compose/runtime/savedinstancestate/UiSavedStateRegistryTest.kt
M       ui/ui-test/src/androidMain/kotlin/androidx/ui/test/StateRestorationTester.kt

https://android-review.googlesource.com/1382560