Fixed
Status Update
Comments
al...@google.com <al...@google.com> #2
Hi Ed, Thank you so much for these suggestions. I've been reviewing them and merging them in. Hopefully it should be live. I've included a thank you note too in the article.
au...@google.com <au...@google.com> #3
Great! Thanks a lot, I'll look for the live updates soon!
ap...@google.com <ap...@google.com> #4
Project: platform/tools/metalava
Branch: master
commit 1c6970595670656331c9f9c0a4bbfe5ddf1d763a
Author: Aurimas Liutikas <aurimas@google.com>
Date: Tue Jun 30 10:11:28 2020
Do not emit @UseExperimenal annotations
These annotations act as a suppression/acknowledgement of the
use of @Experimental.
Bug: 159033688
Test: Added a new test
Change-Id: I06bf11e6ba2fca9f3b0345e284c7651b1f723287
M src/main/java/com/android/tools/metalava/model/AnnotationItem.kt
M src/test/java/com/android/tools/metalava/ApiFileTest.kt
https://android-review.googlesource.com/1353007
Branch: master
commit 1c6970595670656331c9f9c0a4bbfe5ddf1d763a
Author: Aurimas Liutikas <aurimas@google.com>
Date: Tue Jun 30 10:11:28 2020
Do not emit @UseExperimenal annotations
These annotations act as a suppression/acknowledgement of the
use of @Experimental.
Bug: 159033688
Test: Added a new test
Change-Id: I06bf11e6ba2fca9f3b0345e284c7651b1f723287
M src/main/java/com/android/tools/metalava/model/AnnotationItem.kt
M src/test/java/com/android/tools/metalava/ApiFileTest.kt
au...@google.com <au...@google.com>
ap...@google.com <ap...@google.com> #5
Project: platform/frameworks/support
Branch: androidx-main
commit 5fb04a4538a5ad4fe42221d7a70274b465351c03
Author: TY Chang <tonytychang@google.com>
Date: Wed Nov 25 16:53:06 2020
Remove the workaround for @UseExperimental.
Methods now can be marked @OptIn with multiple experimental classes.
So remove the workaround in CameraController and CameraXActivity.
Replace ExperimentalUseCaseGroupLifecycle with
ExperimentalUseCaseGroup.
RelNote: "Replaced ExperimentalUseCaseGroupLifecycle with
ExperimentalUseCaseGroup."
Bug: b/170599666 , b/159033688
Test: ./gradlew bOS
Change-Id: I3b2ef21251f3831245722d9cf46edc52d406ddcf
M camera/camera-lifecycle/api/public_plus_experimental_current.txt
M camera/camera-lifecycle/src/main/java/androidx/camera/lifecycle/ProcessCameraProvider.java
M camera/camera-view/src/main/java/androidx/camera/view/CameraController.java
M camera/camera-view/src/main/java/androidx/camera/view/LifecycleCameraController.java
M camera/integration-tests/coretestapp/src/main/java/androidx/camera/integration/core/CameraXActivity.java
M camera/integration-tests/viewtestapp/src/main/java/androidx/camera/integration/view/PreviewViewFragment.java
https://android-review.googlesource.com/1533054
Branch: androidx-main
commit 5fb04a4538a5ad4fe42221d7a70274b465351c03
Author: TY Chang <tonytychang@google.com>
Date: Wed Nov 25 16:53:06 2020
Remove the workaround for @UseExperimental.
Methods now can be marked @OptIn with multiple experimental classes.
So remove the workaround in CameraController and CameraXActivity.
Replace ExperimentalUseCaseGroupLifecycle with
ExperimentalUseCaseGroup.
RelNote: "Replaced ExperimentalUseCaseGroupLifecycle with
ExperimentalUseCaseGroup."
Bug:
Test: ./gradlew bOS
Change-Id: I3b2ef21251f3831245722d9cf46edc52d406ddcf
M camera/camera-lifecycle/api/public_plus_experimental_current.txt
M camera/camera-lifecycle/src/main/java/androidx/camera/lifecycle/ProcessCameraProvider.java
M camera/camera-view/src/main/java/androidx/camera/view/CameraController.java
M camera/camera-view/src/main/java/androidx/camera/view/LifecycleCameraController.java
M camera/integration-tests/coretestapp/src/main/java/androidx/camera/integration/core/CameraXActivity.java
M camera/integration-tests/viewtestapp/src/main/java/androidx/camera/integration/view/PreviewViewFragment.java
Description
When marking an API as experimental in artifact A, if the annotation is from another artifact B, the updateApi in artifact A does not generate the correct result.
checkApi fails and ask for version increment even if the new API is experimental.
When calling updateApi with -PForce, the experimental API is added to current.txt, and the experimental annotation is missing.
CL with the issue. aosp/1312020