IssueTracker

Component used: Navigation Version used: 2.3.0-beta01, 2.3.0-rc01 Devices/Android versions reproduced on: Emulator - SDK 29

If this is a bug in the library, we would appreciate if you could attach:

<deepLink app:uri="test.faithlife.com/messages/{conversation_id}?threadId={thread_id}"/>

Deep links like this one cause a crash if a link like (a) https://test.faithlife.com/messages/1?threadId are opened in the app. Navigation seems to attempt to parse the value associated with the threadId even though it isn't specified.

I'd expect, since the url spec for deep links indicates that there's an expected value associated with the query parameter, that links like (a) won't match deep link specifications that require a value.

Note: This crash is observed regardless of a default value being specified for thread_id in the argument spec or not.

     Caused by: android.view.InflateException: Binary XML file line #21 in com.faithlife.mobile.debug:layout/activity_home_content: Error inflating class androidx.fragment.app.FragmentContainerView
     Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'boolean java.lang.String.endsWith(java.lang.String)' on a null object reference
        at androidx.navigation.NavType$4.parseValue(NavType.java:388)
        at androidx.navigation.NavType$4.parseValue(NavType.java:372)
        at androidx.navigation.NavType.parseAndPut(NavType.java:96)
        at androidx.navigation.NavDeepLink.parseArgument(NavDeepLink.java:306)
        at androidx.navigation.NavDeepLink.getMatchingArguments(NavDeepLink.java:293)
        at androidx.navigation.NavDestination.matchDeepLink(NavDestination.java:474)
        at androidx.navigation.NavGraph.matchDeepLink(NavGraph.java:79)
        at androidx.navigation.NavGraph.matchDeepLink(NavGraph.java:79)
        at androidx.navigation.NavGraph.matchDeepLink(NavGraph.java:79)
        at androidx.navigation.NavController.handleDeepLink(NavController.java:674)
        at androidx.navigation.NavController.onGraphCreated(NavController.java:629)
        at androidx.navigation.NavController.setGraph(NavController.java:586)
        at androidx.navigation.NavController.setGraph(NavController.java:551)
        at androidx.navigation.NavController.setGraph(NavController.java:533)
        at androidx.navigation.fragment.NavHostFragment.onCreate(NavHostFragment.java:238)