Feature request: Document how to display an empty screen [159054196]

Fixed

Bug

Status Update

No update yet.

Description

ri...@soundcloud.com

created issue #1

Jun 16, 2020 09:13AM

The doc about how to load and display paged data with Paging 3.0 clearly explains how to show progress and error views but it doesn't cover how to handle the case of an empty result. Also the samples seem to not support that case.

I'm new to the Paging library and I find it non trivial to determine what is the right LoadingState to listen to. I assume it's the refresh state, but even there it's not clear how to determine whether the result is empty or not.

Maybe this suggestion should go to a separate issue but I think it would be nice to reuse the same LoadStateAdapter approach as that would allow to build nice reusable loading-empty-error page components.

Comments

le...@gmail.com <le...@gmail.com> #2Jun 16, 2020 01:29PM

Some things to work out before making the annotations type-use:

Determine guidelines for type nullability in public API
Determine rules for when type nullability can change in public API
Confirm that intellij nullability lint works as expected for type-use nullability annotations
Test what the impact would be on existing arrays (due to ambiguities of type-use annotations on arrays)
Confirm usage of type-use androidx.annotation.NonNull/Nullable in metalava won't break anything for platform

du...@google.com <du...@google.com> #3Jun 16, 2020 03:14PM

Plan for making the annotations type-use: https://docs.google.com/document/d/1tNqV9Dgtii6wvulm8emjs0bwgSL3Fwf3F4LFXfVeyTU/edit

cc...@google.com <cc...@google.com> #4Jun 16, 2020 04:06PM

Tracking sheet for which projects have been migrated.

du...@google.com <du...@google.com> #5Jun 16, 2020 04:30PM

Project: platform/frameworks/support
Branch: androidx-main

commit 558f17c6f9e237897fcc87fa556ca4af5c1808c6
Author: Julia McClellan <juliamcclellan@google.com>
Date: Thu Sep 19 14:50:25 2024

Add JSpecify to list of Dackka allowed nullness annotations

Test: Compared the output of `./gradlew docs-tip-of-tree:docs` with the current codebase and aosp/3190072, which switches all nullness annotations to jspecify. Only observed changes were updated nullness annotation links and additional copies of some inherited methods when a parent used a different nullness annotation (similar to

b/280845383

)
Bug: 326456246

Change-Id: I40ede9c84dbae3a1ac7d3d4e98f77a56e119caaa

M buildSrc/private/src/main/kotlin/androidx/build/docs/AndroidXDocsImplPlugin.kt

https://android-review.googlesource.com/3272873

ap...@google.com <ap...@google.com> #6Jun 16, 2020 04:48PM

Project: platform/frameworks/support
Branch: androidx-main

commit c8f5025ba9bf1deb5effbebb7e79683ee7ff9f50
Author: Julia McClellan <juliamcclellan@google.com>
Date: Fri Sep 20 12:31:45 2024

Add JSpecify package-list

Bug: 326456246
Test: checking links in output of `./gradlew docs-tip-of-tree:docs` with aosp/3190072 which switches annotations to jspecify
Change-Id: Ic52ecc37cfb84002ba830dfca6186db2dc5bae67

M buildSrc/private/src/main/kotlin/androidx/build/dackka/DackkaTask.kt
A docs-public/package-lists/jspecify/package-list

https://android-review.googlesource.com/3275171

cc...@google.com <cc...@google.com> Jun 16, 2020 05:11PM

Reassigned to du...@google.com.

ap...@google.com <ap...@google.com> #7Jun 17, 2020 11:33PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit b05578cabee04fdccd2f24c7e2d6a8b25b94a97a
Author: Julia McClellan <juliamcclellan@google.com>
Date: Mon Sep 23 11:21:48 2024

Add java format task

Will be used by the jspecify update script

Bug: 326456246
Test: `./gradlew core:core:javaFormat`, `./gradlew core:core:javaFormat --fix-imports-only` to check java diffs. `./gradlew paging:paging-guava:javaFormat` to check the task succeeds for a project with no java files

Change-Id: I6027419d4ad520a4bd82decd009d252b7077d8a6

M buildSrc/private/src/main/kotlin/androidx/build/AndroidXImplPlugin.kt
A buildSrc/private/src/main/kotlin/androidx/build/JavaFormat.kt
M gradle/libs.versions.toml

https://android-review.googlesource.com/3277031