Fixed
Status Update
No update yet.
Comments
mk...@google.com
Looks like the access flags passed in is null. Will try to see if I can reproduce the problem.
mk...@google.com
The class file seems correct. This could point to a concurrency issue because we are using a cache for the class initializer in the method backing, where the default value is a sentinel with no null as accessflag.
We are moving our internal builder bots and therefore I cannot point to an externally built R8 via a hash, so can I ask you to try and run with the attached R8.jar here or applying the diff from
buildscript {
dependencies {
classpath files($PATH_TO_R8_JAR) // Must be before the Gradle Plugin for Android.
classpath 'com.android.tools.build:gradle:X.Y.Z' // Your current AGP version.
}
}
zs...@salesforce.com
Will try this in our repo and keep you posted!
ap...@google.com
Project: r8
Branch: master
commit 27c5ce8febc7094630758fddcde572d886bbe4b4
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Fri Jul 10 12:37:04 2020
Move synchronization of class initializer from DexClass to MethodColl
Bug: 159194018
Change-Id: Ibd800bc484baaab0344b87d610d686df0d19e264
M src/main/java/com/android/tools/r8/graph/DexClass.java
M src/main/java/com/android/tools/r8/graph/DexEncodedMethod.java
M src/main/java/com/android/tools/r8/graph/MethodCollection.java
M src/test/java/com/android/tools/r8/ir/conversion/CallGraphTestBase.java
https://r8-review.googlesource.com/52544
Branch: master
commit 27c5ce8febc7094630758fddcde572d886bbe4b4
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Fri Jul 10 12:37:04 2020
Move synchronization of class initializer from DexClass to MethodColl
Bug: 159194018
Change-Id: Ibd800bc484baaab0344b87d610d686df0d19e264
M src/main/java/com/android/tools/r8/graph/DexClass.java
M src/main/java/com/android/tools/r8/graph/DexEncodedMethod.java
M src/main/java/com/android/tools/r8/graph/MethodCollection.java
M src/test/java/com/android/tools/r8/ir/conversion/CallGraphTestBase.java
ap...@google.com
Project: r8
Branch: 2.1
commit 457065d1a288b3fedcc032104587cd280dae7915
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Wed Aug 05 11:36:06 2020
Version 2.1.57
Cherry-pick: Close stream of input source when dumping
CL:https://r8-review.googlesource.com/52560
Cherry-pick: Move synchronization of class initializer from DexClass to MethodColl
CL:https://r8-review.googlesource.com/52544
Cherry-pick: Add reproduction of removed fields in kotlin.Metadata
CL:https://r8-review.googlesource.com/52666
Cherry-pick: Only emit kotlin metadata values for non-pruned
annotation members
CL:https://r8-review.googlesource.com/52667
Bug: 160901582
Bug: 159194018
Bug: 161230424
Bug: 162900580
Bug: 152476580
Change-Id: I3e506acaba9333ed6bd31d7229f5982bab215696
M src/main/java/com/android/tools/r8/Version.java
M src/main/java/com/android/tools/r8/graph/DexClass.java
M src/main/java/com/android/tools/r8/graph/DexEncodedMethod.java
M src/main/java/com/android/tools/r8/graph/MethodCollection.java
M src/main/java/com/android/tools/r8/kotlin/KotlinClassMetadataReader.java
M src/main/java/com/android/tools/r8/kotlin/KotlinMetadataRewriter.java
M src/main/java/com/android/tools/r8/utils/AndroidApp.java
M src/test/java/com/android/tools/r8/ir/conversion/CallGraphTestBase.java
A src/test/java/com/android/tools/r8/kotlin/metadata/MetadataPrunedFieldsTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteInRenamedTypeTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteKeepTest.java
A src/test/java/com/android/tools/r8/kotlin/metadata/metadata_pruned_fields/Main.java
A src/test/java/com/android/tools/r8/kotlin/metadata/metadata_pruned_fields/Methods.kt
https://r8-review.googlesource.com/52674
Branch: 2.1
commit 457065d1a288b3fedcc032104587cd280dae7915
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Wed Aug 05 11:36:06 2020
Version 2.1.57
Cherry-pick: Close stream of input source when dumping
CL:
Cherry-pick: Move synchronization of class initializer from DexClass to MethodColl
CL:
Cherry-pick: Add reproduction of removed fields in kotlin.Metadata
CL:
Cherry-pick: Only emit kotlin metadata values for non-pruned
annotation members
CL:
Bug: 160901582
Bug: 159194018
Bug: 161230424
Bug: 162900580
Bug: 152476580
Change-Id: I3e506acaba9333ed6bd31d7229f5982bab215696
M src/main/java/com/android/tools/r8/Version.java
M src/main/java/com/android/tools/r8/graph/DexClass.java
M src/main/java/com/android/tools/r8/graph/DexEncodedMethod.java
M src/main/java/com/android/tools/r8/graph/MethodCollection.java
M src/main/java/com/android/tools/r8/kotlin/KotlinClassMetadataReader.java
M src/main/java/com/android/tools/r8/kotlin/KotlinMetadataRewriter.java
M src/main/java/com/android/tools/r8/utils/AndroidApp.java
M src/test/java/com/android/tools/r8/ir/conversion/CallGraphTestBase.java
A src/test/java/com/android/tools/r8/kotlin/metadata/MetadataPrunedFieldsTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteInRenamedTypeTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteKeepTest.java
A src/test/java/com/android/tools/r8/kotlin/metadata/metadata_pruned_fields/Main.java
A src/test/java/com/android/tools/r8/kotlin/metadata/metadata_pruned_fields/Methods.kt
Description
This was reported in