Fixed
Status Update
Comments
nj...@google.com <nj...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 23a7d960caf43390a554700d3c56ada189a9d10e
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Mon Aug 10 15:11:36 2020
IconButton / IconToggleButton API scrub
Test: ./gradlew updateApi
Bug: b/161809385
Bug: b/161807956
Relnote: "Adds enabled parameter to IconButton, and reorders parameters in IconToggleButton"
Change-Id: I0a9419b1a631cadad451395302ad87b7f9214f96
M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/IconButton.kt
https://android-review.googlesource.com/1394868
Branch: androidx-master-dev
commit 23a7d960caf43390a554700d3c56ada189a9d10e
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Mon Aug 10 15:11:36 2020
IconButton / IconToggleButton API scrub
Test: ./gradlew updateApi
Bug:
Bug:
Relnote: "Adds enabled parameter to IconButton, and reorders parameters in IconToggleButton"
Change-Id: I0a9419b1a631cadad451395302ad87b7f9214f96
M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/IconButton.kt
nj...@google.com <nj...@google.com> #3
ap...@google.com <ap...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-master-dev
commit d895377af6c69dae07d571b9f103623ff8877d14
Author: Nader Jawad <njawad@google.com>
Date: Thu Jun 18 21:42:45 2020
Fixed issue where some Material components
were not rounded when they should have been
Fixed issue where configuration of internal
Paint objects within DrawScope would compare
the underlying value with itself instead of
comparing against the the newly provided
stroke parameters
Added tests to DrawScope to ensure drawing
identical drawing commands between DrawScope
and Canvas generate the same results to ensure
that stroke parameters are being configured
properly.
Added additional tests to Slider and Switch to
verify that contents are rounded when they should be.
Fixes: 159333137
Bug: 159331694
Test: Added tests to DrawScopeTest, SwitchUiTest
SliderTest
Change-Id: Ieb6c7529afef7f0d3abd9ce336d2857bdce5a210
M ui/ui-graphics/src/androidAndroidTest/kotlin/androidx/ui/graphics/drawscope/DrawScopeTest.kt
M ui/ui-graphics/src/commonMain/kotlin/androidx/ui/graphics/drawscope/DrawScope.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SliderTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SwitchUiTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/Slider.kt
M ui/ui-material/src/main/java/androidx/ui/material/Switch.kt
https://android-review.googlesource.com/1344285
Branch: androidx-master-dev
commit d895377af6c69dae07d571b9f103623ff8877d14
Author: Nader Jawad <njawad@google.com>
Date: Thu Jun 18 21:42:45 2020
Fixed issue where some Material components
were not rounded when they should have been
Fixed issue where configuration of internal
Paint objects within DrawScope would compare
the underlying value with itself instead of
comparing against the the newly provided
stroke parameters
Added tests to DrawScope to ensure drawing
identical drawing commands between DrawScope
and Canvas generate the same results to ensure
that stroke parameters are being configured
properly.
Added additional tests to Slider and Switch to
verify that contents are rounded when they should be.
Fixes: 159333137
Bug: 159331694
Test: Added tests to DrawScopeTest, SwitchUiTest
SliderTest
Change-Id: Ieb6c7529afef7f0d3abd9ce336d2857bdce5a210
M ui/ui-graphics/src/androidAndroidTest/kotlin/androidx/ui/graphics/drawscope/DrawScopeTest.kt
M ui/ui-graphics/src/commonMain/kotlin/androidx/ui/graphics/drawscope/DrawScope.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SliderTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SwitchUiTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/Slider.kt
M ui/ui-material/src/main/java/androidx/ui/material/Switch.kt
ap...@google.com <ap...@google.com> #5
Project: platform/frameworks/support
Branch: androidx-master-dev
commit f01d78990b9f0e8a41a06a7e41b76c37fbad601f
Author: Matvei Malkov <malkov@google.com>
Date: Fri Jun 05 14:52:06 2020
Switch rework 3
This CL reworks switch internals and API, to make it more customizable and support new features
In particular:
* Switch supports disabled state properly
* Proper indication when clicking or dragging
* dynamic elevation when pressed or dragged
Relnote: Switch now appears in a disabled state when `enabled` is set to false
Fixes: 155941869
Fixes: 144797838
Fixes: 158808522
Fixes: 159069619
Fixes: 159331694
Test: screenshot tests has been added
Change-Id: If46244d35274f24d3713422c8d28b5b870fb8c84
A ui/ui-material/src/androidTest/java/androidx/ui/material/SwitchScreenshotTest.kt
A ui/ui-material/src/androidTest/java/androidx/ui/material/SwitchTest.kt
D ui/ui-material/src/androidTest/java/androidx/ui/material/SwitchUiTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/Switch.kt
https://android-review.googlesource.com/1324521
Branch: androidx-master-dev
commit f01d78990b9f0e8a41a06a7e41b76c37fbad601f
Author: Matvei Malkov <malkov@google.com>
Date: Fri Jun 05 14:52:06 2020
Switch rework 3
This CL reworks switch internals and API, to make it more customizable and support new features
In particular:
* Switch supports disabled state properly
* Proper indication when clicking or dragging
* dynamic elevation when pressed or dragged
Relnote: Switch now appears in a disabled state when `enabled` is set to false
Fixes: 155941869
Fixes: 144797838
Fixes: 158808522
Fixes: 159069619
Fixes: 159331694
Test: screenshot tests has been added
Change-Id: If46244d35274f24d3713422c8d28b5b870fb8c84
A ui/ui-material/src/androidTest/java/androidx/ui/material/SwitchScreenshotTest.kt
A ui/ui-material/src/androidTest/java/androidx/ui/material/SwitchTest.kt
D ui/ui-material/src/androidTest/java/androidx/ui/material/SwitchUiTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/Switch.kt
Description
We need to add screenshot tests to Switch to prevent accidental changes down the line to break this component