Fixed
Status Update
No update yet.
Comments
nj...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit d895377af6c69dae07d571b9f103623ff8877d14
Author: Nader Jawad <njawad@google.com>
Date: Thu Jun 18 21:42:45 2020
Fixed issue where some Material components
were not rounded when they should have been
Fixed issue where configuration of internal
Paint objects within DrawScope would compare
the underlying value with itself instead of
comparing against the the newly provided
stroke parameters
Added tests to DrawScope to ensure drawing
identical drawing commands between DrawScope
and Canvas generate the same results to ensure
that stroke parameters are being configured
properly.
Added additional tests to Slider and Switch to
verify that contents are rounded when they should be.
Fixes: 159333137
Bug: 159331694
Test: Added tests to DrawScopeTest, SwitchUiTest
SliderTest
Change-Id: Ieb6c7529afef7f0d3abd9ce336d2857bdce5a210
M ui/ui-graphics/src/androidAndroidTest/kotlin/androidx/ui/graphics/drawscope/DrawScopeTest.kt
M ui/ui-graphics/src/commonMain/kotlin/androidx/ui/graphics/drawscope/DrawScope.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SliderTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SwitchUiTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/Slider.kt
M ui/ui-material/src/main/java/androidx/ui/material/Switch.kt
https://android-review.googlesource.com/1344285
Branch: androidx-master-dev
commit d895377af6c69dae07d571b9f103623ff8877d14
Author: Nader Jawad <njawad@google.com>
Date: Thu Jun 18 21:42:45 2020
Fixed issue where some Material components
were not rounded when they should have been
Fixed issue where configuration of internal
Paint objects within DrawScope would compare
the underlying value with itself instead of
comparing against the the newly provided
stroke parameters
Added tests to DrawScope to ensure drawing
identical drawing commands between DrawScope
and Canvas generate the same results to ensure
that stroke parameters are being configured
properly.
Added additional tests to Slider and Switch to
verify that contents are rounded when they should be.
Fixes: 159333137
Bug: 159331694
Test: Added tests to DrawScopeTest, SwitchUiTest
SliderTest
Change-Id: Ieb6c7529afef7f0d3abd9ce336d2857bdce5a210
M ui/ui-graphics/src/androidAndroidTest/kotlin/androidx/ui/graphics/drawscope/DrawScopeTest.kt
M ui/ui-graphics/src/commonMain/kotlin/androidx/ui/graphics/drawscope/DrawScope.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SliderTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SwitchUiTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/Slider.kt
M ui/ui-material/src/main/java/androidx/ui/material/Switch.kt
Description
After aosp/1332149 we don't respect StrokeCap anymore in DrawScope.drawLine method.
This resulted with Switch, Slider and LinearProgressIndication material components appear without rounded corners at the end of their tracks and appear as rectangles.
for visibility: This change was shipped as a part of dev14, so Switch will appear to be very broken in dev14 version.
Filed