Status Update
Comments
sc...@google.com <sc...@google.com> #2
This is a particularly hard device to come by - do you happen to have access to the device? If so could you provide us with the output of: adb shell dumpsys media.camera > info.txt
Thanks!
vi...@idenfy.com <vi...@idenfy.com> #3
Stacktrace:
Caused by: java.lang.IllegalArgumentException: Can not get supported output size under supported maximum for the format: 34
at androidx.camera.camera2.internal.SupportedSurfaceCombination.getSupportedOutputSizes(SupportedSurfaceCombination.java:355)
at androidx.camera.camera2.internal.SupportedSurfaceCombination.getSuggestedResolutions(SupportedSurfaceCombination.java:197)
at androidx.camera.camera2.internal.Camera2DeviceSurfaceManager.getSuggestedResolutions(Camera2DeviceSurfaceManager.java:198)
at androidx.camera.core.CameraX.calculateSuggestedResolutions(CameraX.java:943)
at androidx.camera.core.CameraX.bindToLifecycle(CameraX.java:293)
at androidx.camera.lifecycle.ProcessCameraProvider.bindToLifecycle(ProcessCameraProvider.java:227)
Below are some findings based on our debugging
When Dex is connected
previewConfig.getMaxResolution() is returning "731x411" as maxSize.
Inside Preview.Builder.build() -> Default_MAX_resolution is set to "CameraX.getSurfaceManager().getPreviewSize()" which is 731x411
this is being picked as maxSize.
While rendering maxSize is 731x411 and minSize is 640x480 and below are available outputSizes
0 = {Size@11860} "4032x3024"
1 = {Size@11861} "3984x2988"
2 = {Size@11862} "4032x2268"
3 = {Size@11863} "3024x3024"
4 = {Size@11864} "2976x2976"
5 = {Size@11865} "3840x2160"
6 = {Size@11866} "3264x2448"
7 = {Size@11867} "4032x1960"
8 = {Size@11868} "2880x2160"
9 = {Size@11869} "3264x1836"
10 = {Size@11870} "2160x2160"
11 = {Size@11871} "2560x1440"
12 = {Size@11872} "2224x1080"
13 = {Size@11873} "2048x1152"
14 = {Size@11874} "1920x1080"
15 = {Size@11875} "1440x1080"
16 = {Size@11876} "1088x1088"
17 = {Size@11877} "1280x720"
18 = {Size@11878} "1024x768"
19 = {Size@11879} "1056x704"
20 = {Size@11880} "960x720"
21 = {Size@11881} "960x540"
22 = {Size@11882} "720x720"
23 = {Size@11883} "800x450"
24 = {Size@11884} "720x480"
25 = {Size@11885} "640x480"
26 = {Size@11886} "352x288"
27 = {Size@11887} "320x240"
28 = {Size@11888} "256x144"
29 = {Size@11889} "176x144"
and couldn't find any size in this range.
When Dex not connected
minsize = 640x480
maxsize = 1920x1080
0 = {Size@11836} "4032x3024"
1 = {Size@11837} "3984x2988"
2 = {Size@11838} "4032x2268"
3 = {Size@11839} "3024x3024"
4 = {Size@11840} "2976x2976"
5 = {Size@11841} "3840x2160"
6 = {Size@11842} "3264x2448"
7 = {Size@11843} "4032x1960"
8 = {Size@11844} "2880x2160"
9 = {Size@11845} "3264x1836"
10 = {Size@11846} "2160x2160"
11 = {Size@11847} "2560x1440"
12 = {Size@11848} "2224x1080"
13 = {Size@11849} "2048x1152"
14 = {Size@11850} "1920x1080"
15 = {Size@11851} "1440x1080"
16 = {Size@11852} "1088x1088"
17 = {Size@11853} "1280x720"
18 = {Size@11854} "1024x768"
19 = {Size@11855} "1056x704"
20 = {Size@11856} "960x720"
21 = {Size@11857} "960x540"
22 = {Size@11858} "720x720"
23 = {Size@11859} "800x450"
24 = {Size@11860} "720x480"
25 = {Size@11861} "640x480"
26 = {Size@11862} "352x288"
27 = {Size@11863} "320x240"
28 = {Size@11864} "256x144"
29 = {Size@11865} "176x144"
and we have 12 available sizes in this range
Camera2DeviceSurfaceManager.java:: getPreviewSize()
mCameraSupportedSurfaceCombinationMap.get(cameraId).getSurfaceDefinition().getPreviewSize() = "1920x1080"
cameraId=0
sc...@google.com <sc...@google.com> #4
The issue root cause is that CameraX will default filter out sizes smaller than 640x480. For Preview, the max size will be limited to under display size. I checked the HW spec info for the issue related devices. Display size of FUJITSU F-04J/F-05J is 360x640. That will result int that no size exists in the conditions that is larger or equal to 640x480 and smaller or equal to 360x640.
A temporary workaround for this situation is to use Preview.Builder#setTargetResolution() to set a size smaller than 640x480 to bypass the problem.
For device FUJITSU arrowsM04, I checked its HW spec info and its display size I found is 1280x720. It seems that the problem should not exist in the device.
Could you confirm that the problem exist on arrowsM04 device? What will be the returned value when using Display#getRealSize to obtain the display size?
vi...@idenfy.com <vi...@idenfy.com> #5
> A temporary workaround for this situation is to use Preview.Builder#setTargetResolution() to set a size smaller than 640x480 to bypass the problem.
OK. I will try it.
> Could you confirm that the problem exist on arrowsM04 device?
We receive the crash report (Crashlytics) that this crash has occurred on arrowsM04.
We don't have this device so we can't confirm that the problem really exist on arrowsM04.
> What will be the returned value when using Display#getRealSize to obtain the display size?
We can't investigate it for the same reason.
Thank you.
sc...@google.com <sc...@google.com> #6
This issue happened on devices that the display size is smaller than 640x480. In original auto-resolution mechanism, supported sizes smaller than 640x480 will be default filter out.
The auto-resolution mechanism encodes the guaranteed configurations tables in CameraDevice#createCaptureSession(SessionConfiguration). It defines that the PREVIEW size is the small one of the device display size and 1080p. The PREVIEW size will be the maximal size limitation for Preview use case. The reason it limits the size to display size and 1080p is the stream output in display size or 1080p has been able to provide good enough preview quality. Therefore, auto-resolution mechanism will limit the selected size to be smaller than the small one of the device display size and 1080p.
With above two conditions, in this issue, all sizes smaller than 640x480 have been filter out, therefore, there is no size smaller than the display size 320x240 can be selected to use. And cause the exception.
Solution:
When the display size is smaller than 640x480, auto-resolution mechanism won't filter out those small sizes smaller than 640x480. This makes those small size be left and can be selected for the Preview use case on small display devices.
The solution has been merged and will be included in next CameraX release.
vi...@idenfy.com <vi...@idenfy.com> #7
Hello.
This crash still occurs.
- CAMERAX VERSION: 1.0.0-beta4
- ANDROID OS BUILD NUMBER: Android 7.1.1
- DEVICE NAME: FUJITSU F-02H
We receive following crash report from FUJITSU F-02H. So far We have received this crash report only from F-02H.
java.lang.IllegalArgumentException
Can not get supported output size under supported maximum for the format: 34
androidx.camera.camera2.internal.SupportedSurfaceCombination.getSupportedOutputSizes (SupportedSurfaceCombination.java:349)
androidx.camera.camera2.internal.SupportedSurfaceCombination.getSuggestedResolutions (SupportedSurfaceCombination.java:197)
androidx.camera.camera2.internal.Camera2DeviceSurfaceManager.getSuggestedResolutions (Camera2DeviceSurfaceManager.java:198)
androidx.camera.core.CameraX.calculateSuggestedResolutions (CameraX.java:949)
androidx.camera.core.CameraX.bindToLifecycle (CameraX.java:351)
androidx.camera.lifecycle.ProcessCameraProvider.bindToLifecycle (ProcessCameraProvider.java:230)
(our application's package name).CameraFragment.bindCameraUseCases (CameraFragment.java:174)
sc...@google.com <sc...@google.com> #8
Could you help to provide the following information to clarify the issue?
1. Is the full name of the device Fujitsu Arrows NX F-02H that has a 1440x2560 display?
2. Please help to provide the supported output sizes of ImageFormat.PRIVATE that is obtained by StreamConfigurationMap#getOutputSizes(int).
vi...@idenfy.com <vi...@idenfy.com> #9
- Is the full name of the device Fujitsu Arrows NX F-02H that has a 1440x2560 display?
Yes
- Please help to provide the supported output sizes of ImageFormat.PRIVATE that is obtained by StreamConfigurationMap#getOutputSizes(int).
Since we don't have this device, we'll try to collect this information in the next version of our app. The next version will be released later this month.
vi...@idenfy.com <vi...@idenfy.com> #10
Hello.
- Please help to provide the supported output sizes of ImageFormat.PRIVATE that is obtained by StreamConfigurationMap#getOutputSizes(int).
We have collected the output of the device where the crash occurs.
Device1
- Model : arrows Be F-05J
- Android Version : 7.1.1
- Supported output sizes of ImageFormat.PRIVATE
CameraId 0: 480x480
CameraId 1: 2048x1536 ,1920x1080 ,1280x720 ,960x720 ,640x480 ,320x240 ,176x144
Device2
- Model : Fujitsu arrows M04
- Android Version : 7.1.1
- Supported output sizes of ImageFormat.PRIVATE
CameraId 0: 480x480
CameraId 1: 2048x1536 ,1920x1080 ,1280x720 ,960x720 ,640x480 ,320x240 ,176x144
Additional Information
CameraX version : 1.0.0-beta04
We collect the supported output sizes by following code.
val errorString = buildString {
append("The supported output sizes of ImageFormat.PRIVATE: ")
(requireContext().getSystemService(Context.CAMERA_SERVICE) as CameraManager).apply {
cameraIdList.forEachIndexed { index, cameraId ->
val msg = if (VERSION.SDK_INT >= VERSION_CODES.M) {
val configurationMap =
getCameraCharacteristics(cameraId).get(CameraCharacteristics.SCALER_STREAM_CONFIGURATION_MAP)
val sizes = configurationMap?.getOutputSizes(ImageFormat.PRIVATE)
"CameraId $index: ${sizes?.joinToString(" ,")}"
} else {
"CameraId $index: This device version is under M."
}
append(msg)
}
}
}
sc...@google.com <sc...@google.com> #11
vi...@idenfy.com <vi...@idenfy.com> #12
I tried to find the device specs and both 720x1280
size display. For the camera id 0 device, it is a different case that the display size is larger than 640x480
but the device only supports a 480x480
size. The case also caused the same IllegalArgumentException and was also fixed by 1.0.0-beta04
release. Before 480x480
size would be filtered out and then caused the IllegalArgumentException. After it was merged, the 640x480
size threshold was removed and then the 480x480
size would be kept and selected to use.
It looks like 1.0.0-beta04
release had been used to collect the supported sizes information. But the issue should have been fixed by 1.0.0-beta04
release. Did you only check the device model name to collect the supported sizes information or collect the information when the IllegalArgumentException issue happens again?
CameraX's 1.0.0-beta04
version. Maybe you can also consider to upgrade to the latest 1.0.0-rc01
version for your application. Thanks.
vi...@idenfy.com <vi...@idenfy.com> #13
Did you only check the device model name to collect the supported sizes information or collect the information when the IllegalArgumentException issue happens again?
We collect informations only from the device on which IllegalArgumentException happened.
Our latest app uses CameraX version 1.0.0-beta10
and this issue still occurres.
However we don't receive crash report from Fujitsu arrows Be F-05J
or Fujitsu arrows M04
so far. (This doesn't mean this issue is fixed on these devices because our app is heavily rely on camera so these device's user wouldn't use our app anymore.)
Instead, we receive crash report from
- Model : Fujitsu F-03K
- Android Version : 7.1.2
- Supported output sizes of ImageFormat.PRIVATE
CameraId 0 : 480x480
CameraId 1 : 2048x1536 ,1920x1080 ,1280x720 ,960x720 ,640x480 ,320x240 ,176x144
sc...@google.com <sc...@google.com> #14
I missed some settings when I simulated the issue by robolectric test so that I was not able to reproduce it. Now, I can reproduce the issue if the device only supports one 480x480 resolution. I'm working on the solution and target to make it included in next release.
vi...@idenfy.com <vi...@idenfy.com> #15
Branch: androidx-main
commit 69d15dff7bb857ee33a0f643ff42a0f8bc475ab2
Author: charcoalchen <charcoalchen@google.com>
Date: Fri Jan 08 18:30:03 2021
Fixed IllegalArgumentException issue happened when all preview supported sizes are smaller than 640x480 and display size is larger than 640x480.
Do not filter out sizes smaller than 640x480 when all preview supported sizes are smaller than 640x480 and display size is larger than 640x480.
Relnote:"Fixed IllegalArgumentException issue happened when all preview supported sizes are smaller than 640x480 and display size is larger than 640x480."
Bug: 150506192
Test: SupportedSurfaceCombinationTest
Change-Id: I2a63ce8e2ad42a9cc060c8635ac3603bf440b1ec
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/SupportedSurfaceCombination.java
M camera/camera-camera2/src/test/java/androidx/camera/camera2/internal/SupportedSurfaceCombinationTest.java
sc...@google.com <sc...@google.com> #16
vi...@idenfy.com <vi...@idenfy.com> #17
Values of images are:
2020-06-30 15:56:10.979 7436-7669/com.idenfy.app.new D/CameraLog: imageProxyImmutableImageInfo{tag=null, timestamp=288133495824503, rotationDegrees=90}width:864 height: 480
2020-06-30 15:56:10.979 7436-7669/com.idenfy.app.new D/CameraLog: bitmap from preview.getBitmap() width:1080 height:1944
Resolution seems very small and this is the case. The width is 864(Image is rotated, so actual width is 480). While preview.getBitmap() returns much better resolution on this device.
If I set .setTargetAspectRatio(screenAspectRatio) instead of .setTargetResolution(resolution) (which is 1080x2016 on Xiaomi mi A2) I still get same value from analyzer.
I think that Xiaomi mi A2 is unique device, or perhaps camerax fails to get better resolution, if it is even possible for ImageAnalysis.
vi...@idenfy.com <vi...@idenfy.com> #18
sc...@google.com <sc...@google.com> #19
To be clear,
you set setTargetAspectRatio to RATIO_16_9 or or 4_3 on Xiaomi mi A2 , and still get the ImageAnalysis image size = 864 x480 ?
vi...@idenfy.com <vi...@idenfy.com> #20
sc...@google.com <sc...@google.com> #21
+ Charcoal,
This looks like a bug in CameraX. Can you help clarify it ?
vi...@idenfy.com <vi...@idenfy.com> #22
need?
On Mon, Jul 6, 2020, 18:05 <buganizer-system@google.com> wrote:
--
UAB "Identifikaciniai Projektai", iDenfyâ„¢ is compliant with the General
Data Protection Regulation. To learn more about how we collect, keep, and
process your private information in compliance with GDPR, please view our
privacy policy <
last updated on 2019-10-11.
Information contained in this email and any
attachments may be privileged or confidential and intended for the
exclusive use of the original recipient. If you have received this email by
mistake, please advise the sender immediately and delete the email,
including emptying your deleted email box.
ch...@google.com <ch...@google.com> #23
Could you help to provide the supported output sizes of YUV_420_888 format on the Xiaomi mi A2 device?
The info can be obtained by StreamConfigurationMap#getOutputSizes.
vi...@idenfy.com <vi...@idenfy.com> #24
camera = cameraProvider.bindToLifecycle(
this, cameraSelector, preview, imageAnalyzer, imageCapture)
val cameraId = Camera2CameraInfo.extractCameraId(camera!!.cameraInfo)
val cameraManager = context!!.getSystemService(Context.CAMERA_SERVICE) as CameraManager
val characteristics = cameraManager.getCameraCharacteristics(cameraId)
val streamConfigurationMap = characteristics.get(CameraCharacteristics.SCALER_STREAM_CONFIGURATION_MAP)
val outputSizes = streamConfigurationMap.getOutputSizes(ImageFormat.YUV_420_888)
for(size in outputSizes){
Log.d("CameraLog", "outPut size: ${size.toString()}")
}
By the way, this is how I set aspectRatio, which I use inImageAnalysis.Builder() perhaps there is issue there( I doubt it):
val metrics = DisplayMetrics().also { viewFinder!!.display.getMetrics(it) }
val screenAspectRatio = getCameraAspectRatio(metrics.widthPixels, metrics.heightPixels)
fun getCameraAspectRatio(width: Int, height: Int): Int{
val previewRatio = Math.max(width, height).toDouble() / Math.min(width, height)
if (Math.abs(previewRatio - 4.0 / 3.0) <= kotlin.math.abs(previewRatio - 16.0 / 9.0)) {
return AspectRatio.RATIO_4_3
}
return AspectRatio.RATIO_16_9
}
Now regarding output sizes results on Pixel XL3:
2020-07-07 11:29:57.498 12722-12722/com.idenfy.app.new D/CameraLog: outPut size: 1280x720
2020-07-07 11:29:57.498 12722-12722/com.idenfy.app.new D/CameraLog: outPut size: 640x480
2020-07-07 11:29:57.498 12722-12722/com.idenfy.app.new D/CameraLog: outPut size: 320x240
2020-07-07 11:29:57.499 12722-12722/com.idenfy.app.new D/CameraLog: outPut size: 176x144
2020-07-07 11:29:57.499 12722-12722/com.idenfy.app.new D/CameraLog: outPut size: 1920x1080
2020-07-07 11:30:05.669 12722-13019/com.idenfy.app.new D/CameraLog: imageProxy info: ImmutableImageInfo{tag=null, timestamp=17810298350440, rotationDegrees=90} width:1280 height:720
Now same code on Xiaomi mi A2:
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 2048x1536
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 1920x1440
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 2048x1080
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 1920x1080
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 2560x800
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 1440x1080
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 1280x960
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 1440x720
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 1280x720
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 1280x480
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 1280x400
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 864x480
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 640x640
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 800x480
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 720x480
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 768x432
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 640x480
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 480x640
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 576x432
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 640x360
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 480x360
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 480x320
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 384x288
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 352x288
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 320x240
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 240x320
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 240x160
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 176x144
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 144x176
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 160x120
2020-07-07 11:35:38.932 31102-31707/com.idenfy.app.new D/CameraLog: imageProxy info: ImmutableImageInfo{tag=null, timestamp=877300072296933, rotationDegrees=90} width:864 height:480
As you can see device has better resolution. For instance we currently use
ch...@google.com <ch...@google.com> #25
If your major requirement is to obtain a better quality result by converting ImageAnalysis's outputs, I'll suggest to directly set the target resolution to the maximal size that ImageAnalysis can support. The maximal supported size is 1920x1080. But please be noticed that the target resolution setting needs to match the target rotation. It means that it should be set as 1080x1920 when a phone device is in its natural portrait (ROTATION_0) orientation and should be set as 1920x1080 when the phone device is in landscape orientation.
vi...@idenfy.com <vi...@idenfy.com> #26
Regarding resolution, we only use camera on portrait mode, so it is even
user for us.
Now, not all phones have 1080x1920. Will it be a problem if I set the
highest resolution, but device does not support it? Will the camerax
fallback to other resolution automatically?
If not, perhaps I can update cameraX resolution at runtime, because I do
get output sizes after binding camera to lifecycle. However, I am not sure
how can I do the following in code.
On Wed, Jul 8, 2020, 05:46 <buganizer-system@google.com> wrote:
--
UAB "Identifikaciniai Projektai", iDenfyâ„¢ is compliant with the General
Data Protection Regulation. To learn more about how we collect, keep, and
process your private information in compliance with GDPR, please view our
privacy policy <
last updated on 2019-10-11.
Information contained in this email and any
attachments may be privileged or confidential and intended for the
exclusive use of the original recipient. If you have received this email by
mistake, please advise the sender immediately and delete the email,
including emptying your deleted email box.
ch...@google.com <ch...@google.com> #27
The difference between setting target aspect ratio as ApsectRatio.RATIO_16_9 and setting target resolution as 1080x1920 for ImageAnalysis is:
-> Setting target aspect ratio as ApsectRatio.RATIO_16_9 for ImageAnalysis will select the smallest 16:9 size that can box 640x480.
-> Setting target resolution as 1080x1920 for ImageAnalysis will select the biggest 16:9 available size that is under 1080x1920.
The difference is caused by CameraX has default 640x480 size setting for ImageAnalysis. For most analysis requirement, 640x480 size has been big enough. Analyzing larger image costs time. Therefore, developers need to set the target resolution explicitly to obtain larger ImageAnalysis output.
vi...@idenfy.com <vi...@idenfy.com> #28
swapped values? I tested with : *Size(width:1920, height:1080) *as
resolution and it did not work. As soon as I switched to *Size(width:1080,
height:1920)* for ROTATION_0 iamgeAnalyzer returned imageProxy with high
resolution even on Xioami mi A2.
On Wed, Jul 8, 2020 at 9:57 AM <buganizer-system@google.com> wrote:
--
UAB "Identifikaciniai Projektai", iDenfyâ„¢ is compliant with the General
Data Protection Regulation. To learn more about how we collect, keep, and
process your private information in compliance with GDPR, please view our
privacy policy <
last updated on 2019-10-11.
Information contained in this email and any
attachments may be privileged or confidential and intended for the
exclusive use of the original recipient. If you have received this email by
mistake, please advise the sender immediately and delete the email,
including emptying your deleted email box.
ch...@google.com <ch...@google.com> #29
=> The resolution Size should be expressed in the coordinate frame after rotating the supported sizes by the target rotation. For example, a device with portrait natural orientation in natural target rotation requesting a portrait image may specify 480x640, and the same device, rotated 90 degrees and targeting landscape orientation may specify 640x480.
Therefore, the target resolution setting should correspond to the target rotation setting. Just like what I mentioned in
=> it should be set as 1080x1920 when a phone device is in its natural portrait (ROTATION_0) orientation and should be set as 1920x1080 when the phone device is in landscape orientation.
vi...@idenfy.com <vi...@idenfy.com> #30
Sincerely, Viktor
ch...@google.com <ch...@google.com> #31
After clarifying, the root causes of why 864x480 is selected are listed as the following.
Case 1: When setting target aspect ratio as ApsectRatio.RATIO_16_9 for ImageAnalysis
Reason: For ImageAnalysis, a size closest to 640x480 with the target aspect ratio 16:9 will be selected. 864x480 is a mod16 alignment size that matches 16:9 aspect ratio. Therefore, 864x480 is selected when setting target aspect ratio as ApsectRatio.RATIO_16_9 for ImageAnalysis.
Case 2: When setting target resolution as 1080x2016 as mentioned in
Reason: 864x480 is considered to be a mod16 alignment size to match the aspect ratio of 2016x1080. But other 16:9 sizes do not match the aspect ratio of 2016x1080. CameraX will selected a size matches or its aspect ratio is nearest to the aspect ratio of the target resolution setting. Therefore, 864x480 is selected when setting target resolution as 1080x2016.
For the case 2, I think it should be a bug. The 864x480 size should be grouped into 16:9 aspect ratio sizes group but not to be a size matching the aspect ratio of 2016x1080. I'm working to have a solution for the case 2, then, you will be able to directly set the target resolution as the display's size after the solution is merged.
ap...@google.com <ap...@google.com> #32
Branch: androidx-master-dev
commit fd15f09dce5fb49a871e544ddbc812271883af81
Author: charcoalchen <charcoalchen@google.com>
Date: Mon Jul 13 13:55:04 2020
Fixed SupportedSurfaceCombination aspect ratio size grouping issue
Group all available sizes by aspect ratio first and then sort the groups by the distance to the target aspect ratio to find the best suitable size.
The developers may set the target resolution as any arbitrary size. Original logic directly used the aspect ratio of the target resolution setting to find the supported sizes that match the aspect ratio under mod16 mechanism. It made some supported sizes that should belong to other aspect ratio were incorrectly grouped under mod16 mechanism, and then considered to match the aspect ratio of the target resolution setting. For example, 864x480 should be a 16:9 size, but it was grouped to match the aspect ratio of 2016x1080 target resolution setting. To fix this issue, the all supported sizes will be grouped first. It can avoid a size to be grouped to match a strange aspect ratio. Then, the auto-resolution mechanism will sort all sizes by the aspect ratio difference distance of the groups to select the suitable supported size for the target resolution setting.
Relnote:"Fixed auto-resolution aspect ratio size grouping issue that a 16:9 mod16 size (864x480) is selected when the target resolution setting is 2016x1080 and there is another 1920x1080 16:9 size supported."
Bug: 159363774
Test: run SupportedSurfaceCombinationTest
Change-Id: I531671972a05bf01e2dea1f96da5bc3d6655c391
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/SupportedSurfaceCombination.java
M camera/camera-camera2/src/test/java/androidx/camera/camera2/internal/SupportedSurfaceCombinationTest.java
Description