Fixed
Status Update
No update yet.
Comments
sc...@google.com
A couple of questions:
1. Have you saw crash in real device or only in simulators?
2. Do you use dynamic feature for language ID?
1. Have you saw crash in real device or only in simulators?
2. Do you use dynamic feature for language ID?
vi...@idenfy.com
Tested on Android 12 Emulator with custom executor, but cannot repro this issue.
sc...@google.com
-
Second crash in the description is from a real device. Experienced it myself on two different Xiaomi phones, plus lots of crashes from users in the Google Play console.
-
Dynamic features are not used in the application.
As a wild guess, I have downgraded build tools from 31.0.0 to 30.0.3, compileSdk from 31 to 30, and moved all work with Language ID to the service in a separate process (just to be sure that crash can kill secondary process instead of main). This combination is in beta for 2 days by now and I don't see any SIGSEGV crashes.
vi...@idenfy.com
Hmm, I feel the crash might be something related to separate/secondary process.
I also changed compileSdk and targetSDK to 31 but still cannot repro this issue.
sc...@google.com
On the contrary, there was no separate process before, when crashes started.
In the new build (with the aforementioned changes) I can see SIGSEGV crash, but only one instead of dozens and it has a bit different backtrace:
signal 11 (SIGSEGV), code 1 (SEGV_MAPERR)
liblanguage_id_jni.so (offset 0x11e000)
backtrace:
#00 pc 000000000003c7c0 /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
#00 pc 000000000003b960 /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
#00 pc 000000000003bb48 /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
#00 pc 000000000003bafc /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
#00 pc 0000000000036c98 /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
#00 pc 0000000000032714 /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
#00 pc 0000000000031cac /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
#00 pc 0000000000057438 /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/oat/arm64/base.odex (offset 0x57000)
vi...@idenfy.com
FYI, ML Kit launched a new language ID SDK in the latest release, which uses a new language ID model.
Could you try the new SDK version(17.0.0) to check if you can still repro this native crash? Thanks!
sc...@google.com
Thank you, I'll try it and check.
vi...@idenfy.com
Hello. I have similar experience.
- I'm using mlkit-language 16.1.1
- I didnot meet this error until using AGP 4.2
- I can get this error since using AGP 7.0
- This error raised on Release build only(minimized by R8)
- This error raised without obfuscation.
sc...@google.com
I created reproducible project.
$ git clone https://github.com/ganadist/VersionCodeDemo -b mlkit_agp7 mlkit_agp7
$ cd mlkit_agp7
$ ./gradlew :app:pPRUA
$ adb install app/build/outputs/universal_apk/productionRelease/app-production-release-universal.apk
$ adb shell am start -n com.example.myapplication/.MainActivity
$ adb logcat -b crash -d
10-19 19:41:49.844 17810 17810 F libc : Fatal signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x7acf9d733c in tid 17810 (e.myapplication), pid 17810 (e.myapplication)
10-19 19:41:50.473 17849 17849 F DEBUG : *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
10-19 19:41:50.473 17849 17849 F DEBUG : Build fingerprint: 'google/crosshatch/crosshatch:12/SPB5.210812.002/7671067:user/release-keys'
10-19 19:41:50.473 17849 17849 F DEBUG : Revision: 'MP1.0'
10-19 19:41:50.473 17849 17849 F DEBUG : ABI: 'arm64'
10-19 19:41:50.473 17849 17849 F DEBUG : Timestamp: 2021-10-19 19:41:49.903736988+0900
10-19 19:41:50.473 17849 17849 F DEBUG : Process uptime: 0s
10-19 19:41:50.473 17849 17849 F DEBUG : Cmdline: com.example.myapplication
10-19 19:41:50.474 17849 17849 F DEBUG : pid: 17810, tid: 17810, name: e.myapplication >>> com.example.myapplication <<<
10-19 19:41:50.474 17849 17849 F DEBUG : uid: 10240
10-19 19:41:50.474 17849 17849 F DEBUG : signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x7acf9d733c
10-19 19:41:50.474 17849 17849 F DEBUG : x0 0000000000000000 x1 00000000000008fc x2 0000007a76760c71 x3 0000000000000000
10-19 19:41:50.474 17849 17849 F DEBUG : x4 0000000000000010 x5 0000007ba4db49d0 x6 0000007b34dc3680 x7 3de38e3900000608
10-19 19:41:50.474 17849 17849 F DEBUG : x8 0000007bb4dbedf0 x9 0000007acf9db2aa x10 0000000000000000 x11 0000007acf9d6640
10-19 19:41:50.474 17849 17849 F DEBUG : x12 0000000000000009 x13 0000000000000000 x14 0000000000000061 x15 00000000ebad6a89
10-19 19:41:50.474 17849 17849 F DEBUG : x16 0000007a767cfef8 x17 0000007d9a564b40 x18 0000007da3830000 x19 0000007feaf56a08
10-19 19:41:50.474 17849 17849 F DEBUG : x20 0000000000000000 x21 0000007ba4da50b0 x22 0000007bb4dbedf0 x23 0000007ba4da50b8
10-19 19:41:50.474 17849 17849 F DEBUG : x24 0000000000000009 x25 000000000000067e x26 0000000000000012 x27 0000000000000008
10-19 19:41:50.474 17849 17849 F DEBUG : x28 0000007b64dc8440 x29 0000000000000000
10-19 19:41:50.474 17849 17849 F DEBUG : lr 0000007a7678a964 sp 0000007feaf56810 pc 0000007a7678b7c0 pst 0000000060000000
10-19 19:41:50.474 17849 17849 F DEBUG : backtrace:
10-19 19:41:50.474 17849 17849 F DEBUG : #00 pc 000000000003c7c0 /data/app/~~mHaMq-e9ocbm9UfYnkCGkQ==/com.example.myapplication-HgG9vkluwDDO1K78-Vzr0A==/lib/arm64/liblanguage_id_jni.so (BuildId: 859ec0ec2000a39e6ae8ed42e1704f46)
10-19 19:41:50.474 17849 17849 F DEBUG : #01 pc 000000000003b960 /data/app/~~mHaMq-e9ocbm9UfYnkCGkQ==/com.example.myapplication-HgG9vkluwDDO1K78-Vzr0A==/lib/arm64/liblanguage_id_jni.so (BuildId: 859ec0ec2000a39e6ae8ed42e1704f46)
10-19 19:41:50.474 17849 17849 F DEBUG : #02 pc 000000000003bb48 /data/app/~~mHaMq-e9ocbm9UfYnkCGkQ==/com.example.myapplication-HgG9vkluwDDO1K78-Vzr0A==/lib/arm64/liblanguage_id_jni.so (BuildId: 859ec0ec2000a39e6ae8ed42e1704f46)
10-19 19:41:50.474 17849 17849 F DEBUG : #03 pc 000000000003bafc /data/app/~~mHaMq-e9ocbm9UfYnkCGkQ==/com.example.myapplication-HgG9vkluwDDO1K78-Vzr0A==/lib/arm64/liblanguage_id_jni.so (BuildId: 859ec0ec2000a39e6ae8ed42e1704f46)
10-19 19:41:50.474 17849 17849 F DEBUG : #04 pc 0000000000036c98 /data/app/~~mHaMq-e9ocbm9UfYnkCGkQ==/com.example.myapplication-HgG9vkluwDDO1K78-Vzr0A==/lib/arm64/liblanguage_id_jni.so (BuildId: 859ec0ec2000a39e6ae8ed42e1704f46)
10-19 19:41:50.474 17849 17849 F DEBUG : #05 pc 00000000000324a4 /data/app/~~mHaMq-e9ocbm9UfYnkCGkQ==/com.example.myapplication-HgG9vkluwDDO1K78-Vzr0A==/lib/arm64/liblanguage_id_jni.so (BuildId: 859ec0ec2000a39e6ae8ed42e1704f46)
10-19 19:41:50.474 17849 17849 F DEBUG : #06 pc 0000000000031b5c /data/app/~~mHaMq-e9ocbm9UfYnkCGkQ==/com.example.myapplication-HgG9vkluwDDO1K78-Vzr0A==/lib/arm64/liblanguage_id_jni.so (Java_com_google_mlkit_nl_languageid_internal_LanguageIdentificationJni_nativeIdentifyLanguage+100) (BuildId: 859ec0ec2000a39e6ae8ed42e1704f46)
But after downgrade to AGP 4.2, crash is not reproducible.
$ git clone https://github.com/ganadist/VersionCodeDemo -b mlkit_agp42 mlkit_agp42
$ cd mlkit_agp42
$ ./gradlew :app:pPRUA
$ adb install app/build/outputs/universal_apk/productionRelease/app-production-release-universal.apk
$ adb shell am start -n com.example.myapplication/.MainActivity
Also, I tried to disable
$ git clone https://github.com/ganadist/VersionCodeDemo -b mlkit_agp7_r8_disable_inline_optimizer mlkit_agp7_r8
$ cd mlkit_agp7_r8
$ ./gradlew :app:pPRUA
$ adb install app/build/outputs/universal_apk/productionRelease/app-production-release-universal.apk
$ adb shell am start -n com.example.myapplication/.MainActivity
vi...@idenfy.com
I tried the repro steps but got a NPE when I run ./gradlew :app:pPRUA
FAILURE: Build failed with an exception.
* What went wrong:
java.lang.NullPointerException
> java.lang.NullPointerException (no error message)
Could you also check if this is reproducible on 17.0.0 or 17.0.1? If yes, could you attach the full log that I can take a look? Thanks!
vi...@idenfy.com
Here are gradle build scan logs for each branches.
All builds were clean build, and disabled build cache.
- mlkit_agp7 :
https://scans.gradle.com/s/qrymdqfzwokbq - mlkit_agp42 :
https://scans.gradle.com/s/b6644hzfyfhaw - mlkit_agp7_r8_disable_inline_optimizer :
https://scans.gradle.com/s/c6h5hy2nxod4u
Also, I pushed to update MLKit Language Id version 17.0.1 on
And here is crash log after apply 17.0.1
You can see that BuildId of liblanguage_id_l2c_jni.so was changed from 859ec0ec2000a39e6ae8ed42e1704f46 to be6e59455cc10135330c93acdebfc121
10-20 03:07:24.522 24587 24628 F libc : Fatal signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x7acf995426 in tid 24628 (pool-3-thread-3), pid 24587 (e.myapplication)
10-20 03:07:25.190 24710 24710 F DEBUG : *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
10-20 03:07:25.190 24710 24710 F DEBUG : Build fingerprint: 'google/crosshatch/crosshatch:12/SPB5.210812.002/7671067:user/release-keys'
10-20 03:07:25.190 24710 24710 F DEBUG : Revision: 'MP1.0'
10-20 03:07:25.190 24710 24710 F DEBUG : ABI: 'arm64'
10-20 03:07:25.190 24710 24710 F DEBUG : Timestamp: 2021-10-20 03:07:24.583346246+0900
10-20 03:07:25.190 24710 24710 F DEBUG : Process uptime: 0s
10-20 03:07:25.190 24710 24710 F DEBUG : Cmdline: com.example.myapplication
10-20 03:07:25.190 24710 24710 F DEBUG : pid: 24587, tid: 24628, name: pool-3-thread-3 >>> com.example.myapplication <<<
10-20 03:07:25.190 24710 24710 F DEBUG : uid: 10240
10-20 03:07:25.190 24710 24710 F DEBUG : signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x7acf995426
10-20 03:07:25.190 24710 24710 F DEBUG : x0 0000007b54da9d30 x1 0000007d9a5fe7cc x2 0000000000000000 x3 0000000000000010
10-20 03:07:25.190 24710 24710 F DEBUG : x4 0000000000000000 x5 0000007c34dbc79c x6 0000002f0000083b x7 000003c300002dd5
10-20 03:07:25.190 24710 24710 F DEBUG : x8 0000000000000001 x9 0000000000000004 x10 0000000000000010 x11 0000000000000000
10-20 03:07:25.190 24710 24710 F DEBUG : x12 0000000000000000 x13 000000000000217e x14 0000007acf9932a8 x15 000000000000217e
10-20 03:07:25.190 24710 24710 F DEBUG : x16 0000000000000000 x17 0000007d9a564c78 x18 0000007a6ef18000 x19 0000007c34dbc580
10-20 03:07:25.190 24710 24710 F DEBUG : x20 0000007ca4dc7170 x21 0000007ca4dc7800 x22 0000007ca4dc71e0 x23 0000000000000000
10-20 03:07:25.190 24710 24710 F DEBUG : x24 0000000000000018 x25 0000000000000007 x26 0000000000000006 x27 0000000000000004
10-20 03:07:25.190 24710 24710 F DEBUG : x28 0000007ca4dc7090 x29 0000007cb4da9940
10-20 03:07:25.190 24710 24710 F DEBUG : lr 0000007a770a9624 sp 0000007a6f7de9c0 pc 0000007a770a96a8 pst 0000000020000000
10-20 03:07:25.190 24710 24710 F DEBUG : backtrace:
10-20 03:07:25.190 24710 24710 F DEBUG : #00 pc 00000000000386a8 /data/app/~~KjjULZV48O7KSOgOP1wYNQ==/com.example.myapplication-vFUidUPTjaGg4oo3SRAYJw==/lib/arm64/liblanguage_id_l2c_jni.so (BuildId: be6e59455cc10135330c93acdebfc121)
10-20 03:07:25.190 24710 24710 F DEBUG : #01 pc 00000000000388a0 /data/app/~~KjjULZV48O7KSOgOP1wYNQ==/com.example.myapplication-vFUidUPTjaGg4oo3SRAYJw==/lib/arm64/liblanguage_id_l2c_jni.so (BuildId: be6e59455cc10135330c93acdebfc121)
10-20 03:07:25.190 24710 24710 F DEBUG : #02 pc 00000000000844a0 /data/app/~~KjjULZV48O7KSOgOP1wYNQ==/com.example.myapplication-vFUidUPTjaGg4oo3SRAYJw==/lib/arm64/liblanguage_id_l2c_jni.so (BuildId: be6e59455cc10135330c93acdebfc121)
10-20 03:07:25.190 24710 24710 F DEBUG : #03 pc 000000000008783c /data/app/~~KjjULZV48O7KSOgOP1wYNQ==/com.example.myapplication-vFUidUPTjaGg4oo3SRAYJw==/lib/arm64/liblanguage_id_l2c_jni.so (BuildId: be6e59455cc10135330c93acdebfc121)
10-20 03:07:25.190 24710 24710 F DEBUG : #04 pc 0000000000035fc4 /data/app/~~KjjULZV48O7KSOgOP1wYNQ==/com.example.myapplication-vFUidUPTjaGg4oo3SRAYJw==/lib/arm64/liblanguage_id_l2c_jni.so (BuildId: be6e59455cc10135330c93acdebfc121)
10-20 03:07:25.190 24710 24710 F DEBUG : #05 pc 0000000000034954 /data/app/~~KjjULZV48O7KSOgOP1wYNQ==/com.example.myapplication-vFUidUPTjaGg4oo3SRAYJw==/lib/arm64/liblanguage_id_l2c_jni.so (BuildId: be6e59455cc10135330c93acdebfc121)
10-20 03:07:25.190 24710 24710 F DEBUG : #06 pc 00000000000340e8 /data/app/~~KjjULZV48O7KSOgOP1wYNQ==/com.example.myapplication-vFUidUPTjaGg4oo3SRAYJw==/lib/arm64/liblanguage_id_l2c_jni.so (Java_com_google_mlkit_nl_languageid_internal_ThickLanguageIdentifier_nativeIdentifyPossibleLanguages+108) (BuildId: be6e59455cc10135330c93acdebfc121)
10-20 03:07:25.191 24710 24710 F DEBUG : #07 pc 00000000002d9a44 /apex/com.android.art/lib64/libart.so (art_quick_generic_jni_trampoline+148) (BuildId: cdecb8dde1264c9871695c29854aa3b1)
10-20 03:07:25.191 24710 24710 F DEBUG : #08 pc 000000000020a700 /apex/com.android.art/lib64/libart.so (nterp_helper+5648) (BuildId: cdecb8dde1264c9871695c29854aa3b1)
10-20 03:07:25.191 24710 24710 F DEBUG : #09 pc 00000000000cd0dc /data/app/~~KjjULZV48O7KSOgOP1wYNQ==/com.example.myapplication-vFUidUPTjaGg4oo3SRAYJw==/oat/arm64/base.vdex
10-20 03:07:25.191 24710 24710 F DEBUG : #10 pc 000000000020a044 /apex/com.android.art/lib64/libart.so (nterp_helper+3924) (BuildId: cdecb8dde1264c9871695c29854aa3b1)
10-20 03:07:25.191 24710 24710 F DEBUG : #11 pc 00000000000ccfa8 /data/app/~~KjjULZV48O7KSOgOP1wYNQ==/com.example.myapplication-vFUidUPTjaGg4oo3SRAYJw==/oat/arm64/base.vdex
10-20 03:07:25.191 24710 24710 F DEBUG : #12 pc 0000000000557cb4 /system/framework/arm64/boot-framework.oat (android.os.Binder.transact+148) (BuildId: 43a571a0ad85d6451b47016336a541ecb0eb12bb)
10-20 03:07:25.191 24710 24710 F DEBUG : #13 pc 000000000020b53c /apex/com.android.art/lib64/libart.so (nterp_helper+9292) (BuildId: cdecb8dde1264c9871695c29854aa3b1)
10-20 03:07:25.191 24710 24710 F DEBUG : #14 pc 00000000000b7aba /data/app/~~KjjULZV48O7KSOgOP1wYNQ==/com.example.myapplication-vFUidUPTjaGg4oo3SRAYJw==/oat/arm64/base.vdex
10-20 03:07:25.191 24710 24710 F DEBUG : #15 pc 000000000020a044 /apex/com.android.art/lib64/libart.so (nterp_helper+3924) (BuildId: cdecb8dde1264c9871695c29854aa3b1)
10-20 03:07:25.191 24710 24710 F DEBUG : #16 pc 00000000000a7496 /data/app/~~KjjULZV48O7KSOgOP1wYNQ==/com.example.myapplication-vFUidUPTjaGg4oo3SRAYJw==/oat/arm64/base.vdex
10-20 03:07:25.191 24710 24710 F DEBUG : #17 pc 000000000020a044 /apex/com.android.art/lib64/libart.so (nterp_helper+3924) (BuildId: cdecb8dde1264c9871695c29854aa3b1)
10-20 03:07:25.191 24710 24710 F DEBUG : #18 pc 00000000000a7360 /data/app/~~KjjULZV48O7KSOgOP1wYNQ==/com.example.myapplication-vFUidUPTjaGg4oo3SRAYJw==/oat/arm64/base.vdex
10-20 03:07:25.191 24710 24710 F DEBUG : #19 pc 000000000020ae64 /apex/com.android.art/lib64/libart.so (nterp_helper+7540) (BuildId: cdecb8dde1264c9871695c29854aa3b1)
10-20 03:07:25.191 24710 24710 F DEBUG : #20 pc 000000000009e46c /data/app/~~KjjULZV48O7KSOgOP1wYNQ==/com.example.myapplication-vFUidUPTjaGg4oo3SRAYJw==/oat/arm64/base.vdex
10-20 03:07:25.191 24710 24710 F DEBUG : #21 pc 000000000020ae64 /apex/com.android.art/lib64/libart.so (nterp_helper+7540) (BuildId: cdecb8dde1264c9871695c29854aa3b1)
10-20 03:07:25.191 24710 24710 F DEBUG : #22 pc 00000000000d33d6 /data/app/~~KjjULZV48O7KSOgOP1wYNQ==/com.example.myapplication-vFUidUPTjaGg4oo3SRAYJw==/oat/arm64/base.vdex
10-20 03:07:25.191 24710 24710 F DEBUG : #23 pc 000000000020ae64 /apex/com.android.art/lib64/libart.so (nterp_helper+7540) (BuildId: cdecb8dde1264c9871695c29854aa3b1)
10-20 03:07:25.191 24710 24710 F DEBUG : #24 pc 000000000009df0a /data/app/~~KjjULZV48O7KSOgOP1wYNQ==/com.example.myapplication-vFUidUPTjaGg4oo3SRAYJw==/oat/arm64/base.vdex
10-20 03:07:25.191 24710 24710 F DEBUG : #25 pc 0000000000209124 /apex/com.android.art/lib64/libart.so (nterp_helper+52) (BuildId: cdecb8dde1264c9871695c29854aa3b1)
10-20 03:07:25.191 24710 24710 F DEBUG : #26 pc 000000000009e350 /data/app/~~KjjULZV48O7KSOgOP1wYNQ==/com.example.myapplication-vFUidUPTjaGg4oo3SRAYJw==/oat/arm64/base.vdex
10-20 03:07:25.191 24710 24710 F DEBUG : #27 pc 000000000037b9ac /apex/com.android.art/javalib/arm64/boot.oat (java.util.concurrent.ThreadPoolExecutor.runWorker+988) (BuildId: ab2bf4ec264efdb6c452a238be38fe624de826b8)
10-20 03:07:25.191 24710 24710 F DEBUG : #28 pc 00000000003751d4 /apex/com.android.art/javalib/arm64/boot.oat (java.util.concurrent.ThreadPoolExecutor$Worker.run+68) (BuildId: ab2bf4ec264efdb6c452a238be38fe624de826b8)
10-20 03:07:25.191 24710 24710 F DEBUG : #29 pc 000000000020aec4 /apex/com.android.art/lib64/libart.so (nterp_helper+7636) (BuildId: cdecb8dde1264c9871695c29854aa3b1)
10-20 03:07:25.191 24710 24710 F DEBUG : #30 pc 000000000009e370 /data/app/~~KjjULZV48O7KSOgOP1wYNQ==/com.example.myapplication-vFUidUPTjaGg4oo3SRAYJw==/oat/arm64/base.vdex
10-20 03:07:25.191 24710 24710 F DEBUG : #31 pc 00000000001bf35c /apex/com.android.art/javalib/arm64/boot.oat (java.lang.Thread.run+76) (BuildId: ab2bf4ec264efdb6c452a238be38fe624de826b8)
10-20 03:07:25.191 24710 24710 F DEBUG : #32 pc 00000000002d0164 /apex/com.android.art/lib64/libart.so (art_quick_invoke_stub+548) (BuildId: cdecb8dde1264c9871695c29854aa3b1)
10-20 03:07:25.191 24710 24710 F DEBUG : #33 pc 000000000031ccac /apex/com.android.art/lib64/libart.so (art::ArtMethod::Invoke(art::Thread*, unsigned int*, unsigned int, art::JValue*, char const*)+156) (BuildId: cdecb8dde1264c9871695c29854aa3b1)
10-20 03:07:25.191 24710 24710 F DEBUG : #34 pc 00000000003cf8a0 /apex/com.android.art/lib64/libart.so (art::JValue art::InvokeVirtualOrInterfaceWithJValues<art::ArtMethod*>(art::ScopedObjectAccessAlreadyRunnable const&, _jobject*, art::ArtMethod*, jvalue const*)+380) (BuildId: cdecb8dde1264c9871695c29854aa3b1)
10-20 03:07:25.191 24710 24710 F DEBUG : #35 pc 0000000000460894 /apex/com.android.art/lib64/libart.so (art::Thread::CreateCallback(void*)+992) (BuildId: cdecb8dde1264c9871695c29854aa3b1)
10-20 03:07:25.191 24710 24710 F DEBUG : #36 pc 00000000000b1910 /apex/com.android.runtime/lib64/bionic/libc.so (__pthread_start(void*)+264) (BuildId: ba489d4985c0cf173209da67405662f9)
10-20 03:07:25.191 24710 24710 F DEBUG : #37 pc 00000000000513f0 /apex/com.android.runtime/lib64/bionic/libc.so (__start_thread+64) (BuildId: ba489d4985c0cf173209da67405662f9)
sc...@google.com
Cross-posted on R8 issue tracker.
vi...@idenfy.com
Hi,
Looks like we figured out the root cause in
For temporary workarounds for the existing SDKs, you need to add this rule
-keep class com.google.mlkit.nl.languageid.internal.LanguageIdentificationJni { *; }
for language-id 16.1.1, and add this rule
-keep class com.google.mlkit.nl.languageid.internal.ThickLanguageIdentifier { *; }
for version language-id 17.0.0+ for the newer model.
We'll fix this issue in the upcoming release so that you'll not need these workarounds in the future release.
Thanks a lot for reporting this issue!
sc...@google.com
Added workarounds in
vi...@idenfy.com
vi...@idenfy.com
Hello, any news? :)
sc...@google.com
Hi Viktor,
To be clear,
you set setTargetAspectRatio to RATIO_16_9 or or 4_3 on Xiaomi mi A2 , and still get the ImageAnalysis image size = 864 x480 ?
To be clear,
you set setTargetAspectRatio to RATIO_16_9 or or 4_3 on Xiaomi mi A2 , and still get the ImageAnalysis image size = 864 x480 ?
vi...@idenfy.com
Yes, exactly :)
sc...@google.com
Thanks for the info.
+ Charcoal,
This looks like a bug in CameraX. Can you help clarify it ?
+ Charcoal,
This looks like a bug in CameraX. Can you help clarify it ?
vi...@idenfy.com
Yes, I can assist in any way you need. How can I help? What information you
need?
On Mon, Jul 6, 2020, 18:05 <buganizer-system@google.com> wrote:
need?
On Mon, Jul 6, 2020, 18:05 <buganizer-system@google.com> wrote:
--
UAB "Identifikaciniai Projektai", iDenfy™ is compliant with the General
Data Protection Regulation. To learn more about how we collect, keep, and
process your private information in compliance with GDPR, please view our
privacy policy <
last updated on 2019-10-11.
Information contained in this email and any
attachments may be privileged or confidential and intended for the
exclusive use of the original recipient. If you have received this email by
mistake, please advise the sender immediately and delete the email,
including emptying your deleted email box.
ch...@google.com
Hi Viktor,
Could you help to provide the supported output sizes of YUV_420_888 format on the Xiaomi mi A2 device?
The info can be obtained by StreamConfigurationMap#getOutputSizes.
Could you help to provide the supported output sizes of YUV_420_888 format on the Xiaomi mi A2 device?
The info can be obtained by StreamConfigurationMap#getOutputSizes.
vi...@idenfy.com
Ok, so this is how I did it on Pixel XL 3 and also Xiaomi mi A2.
camera = cameraProvider.bindToLifecycle(
this, cameraSelector, preview, imageAnalyzer, imageCapture)
val cameraId = Camera2CameraInfo.extractCameraId(camera!!.cameraInfo)
val cameraManager = context!!.getSystemService(Context.CAMERA_SERVICE) as CameraManager
val characteristics = cameraManager.getCameraCharacteristics(cameraId)
val streamConfigurationMap = characteristics.get(CameraCharacteristics.SCALER_STREAM_CONFIGURATION_MAP)
val outputSizes = streamConfigurationMap.getOutputSizes(ImageFormat.YUV_420_888)
for(size in outputSizes){
Log.d("CameraLog", "outPut size: ${size.toString()}")
}
By the way, this is how I set aspectRatio, which I use inImageAnalysis.Builder() perhaps there is issue there( I doubt it):
val metrics = DisplayMetrics().also { viewFinder!!.display.getMetrics(it) }
val screenAspectRatio = getCameraAspectRatio(metrics.widthPixels, metrics.heightPixels)
fun getCameraAspectRatio(width: Int, height: Int): Int{
val previewRatio = Math.max(width, height).toDouble() / Math.min(width, height)
if (Math.abs(previewRatio - 4.0 / 3.0) <= kotlin.math.abs(previewRatio - 16.0 / 9.0)) {
return AspectRatio.RATIO_4_3
}
return AspectRatio.RATIO_16_9
}
Now regarding output sizes results on Pixel XL3:
2020-07-07 11:29:57.498 12722-12722/com.idenfy.app.new D/CameraLog: outPut size: 1280x720
2020-07-07 11:29:57.498 12722-12722/com.idenfy.app.new D/CameraLog: outPut size: 640x480
2020-07-07 11:29:57.498 12722-12722/com.idenfy.app.new D/CameraLog: outPut size: 320x240
2020-07-07 11:29:57.499 12722-12722/com.idenfy.app.new D/CameraLog: outPut size: 176x144
2020-07-07 11:29:57.499 12722-12722/com.idenfy.app.new D/CameraLog: outPut size: 1920x1080
2020-07-07 11:30:05.669 12722-13019/com.idenfy.app.new D/CameraLog: imageProxy info: ImmutableImageInfo{tag=null, timestamp=17810298350440, rotationDegrees=90} width:1280 height:720
Now same code on Xiaomi mi A2:
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 2048x1536
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 1920x1440
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 2048x1080
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 1920x1080
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 2560x800
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 1440x1080
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 1280x960
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 1440x720
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 1280x720
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 1280x480
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 1280x400
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 864x480
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 640x640
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 800x480
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 720x480
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 768x432
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 640x480
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 480x640
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 576x432
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 640x360
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 480x360
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 480x320
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 384x288
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 352x288
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 320x240
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 240x320
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 240x160
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 176x144
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 144x176
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 160x120
2020-07-07 11:35:38.932 31102-31707/com.idenfy.app.new D/CameraLog: imageProxy info: ImmutableImageInfo{tag=null, timestamp=877300072296933, rotationDegrees=90} width:864 height:480
As you can see device has better resolution. For instance we currently usehttps://github.com/RedApparat/Fotoapparat camera library and it produces much better images using frames.
camera = cameraProvider.bindToLifecycle(
this, cameraSelector, preview, imageAnalyzer, imageCapture)
val cameraId = Camera2CameraInfo.extractCameraId(camera!!.cameraInfo)
val cameraManager = context!!.getSystemService(Context.CAMERA_SERVICE) as CameraManager
val characteristics = cameraManager.getCameraCharacteristics(cameraId)
val streamConfigurationMap = characteristics.get(CameraCharacteristics.SCALER_STREAM_CONFIGURATION_MAP)
val outputSizes = streamConfigurationMap.getOutputSizes(ImageFormat.YUV_420_888)
for(size in outputSizes){
Log.d("CameraLog", "outPut size: ${size.toString()}")
}
By the way, this is how I set aspectRatio, which I use inImageAnalysis.Builder() perhaps there is issue there( I doubt it):
val metrics = DisplayMetrics().also { viewFinder!!.display.getMetrics(it) }
val screenAspectRatio = getCameraAspectRatio(metrics.widthPixels, metrics.heightPixels)
fun getCameraAspectRatio(width: Int, height: Int): Int{
val previewRatio = Math.max(width, height).toDouble() / Math.min(width, height)
if (Math.abs(previewRatio - 4.0 / 3.0) <= kotlin.math.abs(previewRatio - 16.0 / 9.0)) {
return AspectRatio.RATIO_4_3
}
return AspectRatio.RATIO_16_9
}
Now regarding output sizes results on Pixel XL3:
2020-07-07 11:29:57.498 12722-12722/com.idenfy.app.new D/CameraLog: outPut size: 1280x720
2020-07-07 11:29:57.498 12722-12722/com.idenfy.app.new D/CameraLog: outPut size: 640x480
2020-07-07 11:29:57.498 12722-12722/com.idenfy.app.new D/CameraLog: outPut size: 320x240
2020-07-07 11:29:57.499 12722-12722/com.idenfy.app.new D/CameraLog: outPut size: 176x144
2020-07-07 11:29:57.499 12722-12722/com.idenfy.app.new D/CameraLog: outPut size: 1920x1080
2020-07-07 11:30:05.669 12722-13019/com.idenfy.app.new D/CameraLog: imageProxy info: ImmutableImageInfo{tag=null, timestamp=17810298350440, rotationDegrees=90} width:1280 height:720
Now same code on Xiaomi mi A2:
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 2048x1536
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 1920x1440
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 2048x1080
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 1920x1080
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 2560x800
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 1440x1080
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 1280x960
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 1440x720
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 1280x720
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 1280x480
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 1280x400
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 864x480
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 640x640
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 800x480
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 720x480
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 768x432
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 640x480
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 480x640
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 576x432
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 640x360
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 480x360
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 480x320
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 384x288
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 352x288
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 320x240
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 240x320
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 240x160
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 176x144
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 144x176
2020-07-07 11:35:27.512 31102-31102/com.idenfy.app.new D/CameraLog: outPut size: 160x120
2020-07-07 11:35:38.932 31102-31707/com.idenfy.app.new D/CameraLog: imageProxy info: ImmutableImageInfo{tag=null, timestamp=877300072296933, rotationDegrees=90} width:864 height:480
As you can see device has better resolution. For instance we currently use
ch...@google.com
Thanks for providing the info. I can reproduce the issue by robolectric test. I still need more time to clarify and fix the issue.
If your major requirement is to obtain a better quality result by converting ImageAnalysis's outputs, I'll suggest to directly set the target resolution to the maximal size that ImageAnalysis can support. The maximal supported size is 1920x1080. But please be noticed that the target resolution setting needs to match the target rotation. It means that it should be set as 1080x1920 when a phone device is in its natural portrait (ROTATION_0) orientation and should be set as 1920x1080 when the phone device is in landscape orientation.
If your major requirement is to obtain a better quality result by converting ImageAnalysis's outputs, I'll suggest to directly set the target resolution to the maximal size that ImageAnalysis can support. The maximal supported size is 1920x1080. But please be noticed that the target resolution setting needs to match the target rotation. It means that it should be set as 1080x1920 when a phone device is in its natural portrait (ROTATION_0) orientation and should be set as 1920x1080 when the phone device is in landscape orientation.
vi...@idenfy.com
It is great that you can reproduce issue!
Regarding resolution, we only use camera on portrait mode, so it is even
user for us.
Now, not all phones have 1080x1920. Will it be a problem if I set the
highest resolution, but device does not support it? Will the camerax
fallback to other resolution automatically?
If not, perhaps I can update cameraX resolution at runtime, because I do
get output sizes after binding camera to lifecycle. However, I am not sure
how can I do the following in code.
On Wed, Jul 8, 2020, 05:46 <buganizer-system@google.com> wrote:
Regarding resolution, we only use camera on portrait mode, so it is even
user for us.
Now, not all phones have 1080x1920. Will it be a problem if I set the
highest resolution, but device does not support it? Will the camerax
fallback to other resolution automatically?
If not, perhaps I can update cameraX resolution at runtime, because I do
get output sizes after binding camera to lifecycle. However, I am not sure
how can I do the following in code.
On Wed, Jul 8, 2020, 05:46 <buganizer-system@google.com> wrote:
--
UAB "Identifikaciniai Projektai", iDenfy™ is compliant with the General
Data Protection Regulation. To learn more about how we collect, keep, and
process your private information in compliance with GDPR, please view our
privacy policy <
last updated on 2019-10-11.
Information contained in this email and any
attachments may be privileged or confidential and intended for the
exclusive use of the original recipient. If you have received this email by
mistake, please advise the sender immediately and delete the email,
including emptying your deleted email box.
ch...@google.com
When setting the target resolution as 1080x1920, if the size is not supported for the device, the next smaller size with the same aspect ratio will be selected to use. If the device does not support 16:9 sizes, the other sizes with aspect ratio that is nearest to the target resolution will still be selected to use. Therefore, I think you can adopt the 1080x1920 target resolution setting approach.
The difference between setting target aspect ratio as ApsectRatio.RATIO_16_9 and setting target resolution as 1080x1920 for ImageAnalysis is:
-> Setting target aspect ratio as ApsectRatio.RATIO_16_9 for ImageAnalysis will select the smallest 16:9 size that can box 640x480.
-> Setting target resolution as 1080x1920 for ImageAnalysis will select the biggest 16:9 available size that is under 1080x1920.
The difference is caused by CameraX has default 640x480 size setting for ImageAnalysis. For most analysis requirement, 640x480 size has been big enough. Analyzing larger image costs time. Therefore, developers need to set the target resolution explicitly to obtain larger ImageAnalysis output.
The difference between setting target aspect ratio as ApsectRatio.RATIO_16_9 and setting target resolution as 1080x1920 for ImageAnalysis is:
-> Setting target aspect ratio as ApsectRatio.RATIO_16_9 for ImageAnalysis will select the smallest 16:9 size that can box 640x480.
-> Setting target resolution as 1080x1920 for ImageAnalysis will select the biggest 16:9 available size that is under 1080x1920.
The difference is caused by CameraX has default 640x480 size setting for ImageAnalysis. For most analysis requirement, 640x480 size has been big enough. Analyzing larger image costs time. Therefore, developers need to set the target resolution explicitly to obtain larger ImageAnalysis output.
vi...@idenfy.com
Hello, I tested with resolution. Perhaps you made a mistake with size and
swapped values? I tested with : *Size(width:1920, height:1080) *as
resolution and it did not work. As soon as I switched to *Size(width:1080,
height:1920)* for ROTATION_0 iamgeAnalyzer returned imageProxy with high
resolution even on Xioami mi A2.
On Wed, Jul 8, 2020 at 9:57 AM <buganizer-system@google.com> wrote:
swapped values? I tested with : *Size(width:1920, height:1080) *as
resolution and it did not work. As soon as I switched to *Size(width:1080,
height:1920)* for ROTATION_0 iamgeAnalyzer returned imageProxy with high
resolution even on Xioami mi A2.
On Wed, Jul 8, 2020 at 9:57 AM <buganizer-system@google.com> wrote:
--
UAB "Identifikaciniai Projektai", iDenfy™ is compliant with the General
Data Protection Regulation. To learn more about how we collect, keep, and
process your private information in compliance with GDPR, please view our
privacy policy <
last updated on 2019-10-11.
Information contained in this email and any
attachments may be privileged or confidential and intended for the
exclusive use of the original recipient. If you have received this email by
mistake, please advise the sender immediately and delete the email,
including emptying your deleted email box.
ch...@google.com
Please refer to https://developer.android.com/reference/androidx/camera/core/ImageAnalysis.Builder#setTargetResolution(android.util.Size) .
=> The resolution Size should be expressed in the coordinate frame after rotating the supported sizes by the target rotation. For example, a device with portrait natural orientation in natural target rotation requesting a portrait image may specify 480x640, and the same device, rotated 90 degrees and targeting landscape orientation may specify 640x480.
Therefore, the target resolution setting should correspond to the target rotation setting. Just like what I mentioned in
=> it should be set as 1080x1920 when a phone device is in its natural portrait (ROTATION_0) orientation and should be set as 1920x1080 when the phone device is in landscape orientation.
=> The resolution Size should be expressed in the coordinate frame after rotating the supported sizes by the target rotation. For example, a device with portrait natural orientation in natural target rotation requesting a portrait image may specify 480x640, and the same device, rotated 90 degrees and targeting landscape orientation may specify 640x480.
Therefore, the target resolution setting should correspond to the target rotation setting. Just like what I mentioned in
=> it should be set as 1080x1920 when a phone device is in its natural portrait (ROTATION_0) orientation and should be set as 1920x1080 when the phone device is in landscape orientation.
vi...@idenfy.com
Hello, perhaps there are some updates regarding this issue? Or should we rather use (width:1920, height:1080) for our case, because it does work correctly? :)
Sincerely, Viktor
Sincerely, Viktor
ch...@google.com
Hi Viktor,
After clarifying, the root causes of why 864x480 is selected are listed as the following.
Case 1: When setting target aspect ratio as ApsectRatio.RATIO_16_9 for ImageAnalysis
Reason: For ImageAnalysis, a size closest to 640x480 with the target aspect ratio 16:9 will be selected. 864x480 is a mod16 alignment size that matches 16:9 aspect ratio. Therefore, 864x480 is selected when setting target aspect ratio as ApsectRatio.RATIO_16_9 for ImageAnalysis.
Case 2: When setting target resolution as 1080x2016 as mentioned in
Reason: 864x480 is considered to be a mod16 alignment size to match the aspect ratio of 2016x1080. But other 16:9 sizes do not match the aspect ratio of 2016x1080. CameraX will selected a size matches or its aspect ratio is nearest to the aspect ratio of the target resolution setting. Therefore, 864x480 is selected when setting target resolution as 1080x2016.
For the case 2, I think it should be a bug. The 864x480 size should be grouped into 16:9 aspect ratio sizes group but not to be a size matching the aspect ratio of 2016x1080. I'm working to have a solution for the case 2, then, you will be able to directly set the target resolution as the display's size after the solution is merged.
After clarifying, the root causes of why 864x480 is selected are listed as the following.
Case 1: When setting target aspect ratio as ApsectRatio.RATIO_16_9 for ImageAnalysis
Reason: For ImageAnalysis, a size closest to 640x480 with the target aspect ratio 16:9 will be selected. 864x480 is a mod16 alignment size that matches 16:9 aspect ratio. Therefore, 864x480 is selected when setting target aspect ratio as ApsectRatio.RATIO_16_9 for ImageAnalysis.
Case 2: When setting target resolution as 1080x2016 as mentioned in
Reason: 864x480 is considered to be a mod16 alignment size to match the aspect ratio of 2016x1080. But other 16:9 sizes do not match the aspect ratio of 2016x1080. CameraX will selected a size matches or its aspect ratio is nearest to the aspect ratio of the target resolution setting. Therefore, 864x480 is selected when setting target resolution as 1080x2016.
For the case 2, I think it should be a bug. The 864x480 size should be grouped into 16:9 aspect ratio sizes group but not to be a size matching the aspect ratio of 2016x1080. I'm working to have a solution for the case 2, then, you will be able to directly set the target resolution as the display's size after the solution is merged.
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit fd15f09dce5fb49a871e544ddbc812271883af81
Author: charcoalchen <charcoalchen@google.com>
Date: Mon Jul 13 13:55:04 2020
Fixed SupportedSurfaceCombination aspect ratio size grouping issue
Group all available sizes by aspect ratio first and then sort the groups by the distance to the target aspect ratio to find the best suitable size.
The developers may set the target resolution as any arbitrary size. Original logic directly used the aspect ratio of the target resolution setting to find the supported sizes that match the aspect ratio under mod16 mechanism. It made some supported sizes that should belong to other aspect ratio were incorrectly grouped under mod16 mechanism, and then considered to match the aspect ratio of the target resolution setting. For example, 864x480 should be a 16:9 size, but it was grouped to match the aspect ratio of 2016x1080 target resolution setting. To fix this issue, the all supported sizes will be grouped first. It can avoid a size to be grouped to match a strange aspect ratio. Then, the auto-resolution mechanism will sort all sizes by the aspect ratio difference distance of the groups to select the suitable supported size for the target resolution setting.
Relnote:"Fixed auto-resolution aspect ratio size grouping issue that a 16:9 mod16 size (864x480) is selected when the target resolution setting is 2016x1080 and there is another 1920x1080 16:9 size supported."
Bug: 159363774
Test: run SupportedSurfaceCombinationTest
Change-Id: I531671972a05bf01e2dea1f96da5bc3d6655c391
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/SupportedSurfaceCombination.java
M camera/camera-camera2/src/test/java/androidx/camera/camera2/internal/SupportedSurfaceCombinationTest.java
https://android-review.googlesource.com/1360358
Branch: androidx-master-dev
commit fd15f09dce5fb49a871e544ddbc812271883af81
Author: charcoalchen <charcoalchen@google.com>
Date: Mon Jul 13 13:55:04 2020
Fixed SupportedSurfaceCombination aspect ratio size grouping issue
Group all available sizes by aspect ratio first and then sort the groups by the distance to the target aspect ratio to find the best suitable size.
The developers may set the target resolution as any arbitrary size. Original logic directly used the aspect ratio of the target resolution setting to find the supported sizes that match the aspect ratio under mod16 mechanism. It made some supported sizes that should belong to other aspect ratio were incorrectly grouped under mod16 mechanism, and then considered to match the aspect ratio of the target resolution setting. For example, 864x480 should be a 16:9 size, but it was grouped to match the aspect ratio of 2016x1080 target resolution setting. To fix this issue, the all supported sizes will be grouped first. It can avoid a size to be grouped to match a strange aspect ratio. Then, the auto-resolution mechanism will sort all sizes by the aspect ratio difference distance of the groups to select the suitable supported size for the target resolution setting.
Relnote:"Fixed auto-resolution aspect ratio size grouping issue that a 16:9 mod16 size (864x480) is selected when the target resolution setting is 2016x1080 and there is another 1920x1080 16:9 size supported."
Bug: 159363774
Test: run SupportedSurfaceCombinationTest
Change-Id: I531671972a05bf01e2dea1f96da5bc3d6655c391
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/SupportedSurfaceCombination.java
M camera/camera-camera2/src/test/java/androidx/camera/camera2/internal/SupportedSurfaceCombinationTest.java
ch...@google.com
A solution has been merged to make 1920x1080 can be selected when the target resolution is set as 1080x2016. Please wait for CameraX's next release.
vi...@idenfy.com
Amazing, thank you for your work!
Description