Status Update
Comments
vi...@google.com <vi...@google.com>
tg...@google.com <tg...@google.com> #2
Hi Jomo, can you take a look at this one?
tg...@google.com <tg...@google.com> #3
Currently we are filtering the flags. Maybe we should just allow -C
as well?
mi...@gmail.com <mi...@gmail.com> #4
It would be great if -C
can be allowed.
CMake is evolving. Recently support for log levels was introduced. With filtering cannot pass --log-level=VERBOSE
into CMake.
Isn't blacklisting -G
, -S
, -B
and a few others a better approach?
Plugin can emit a warning/error if user try to override one of them. Message will help developers to correct script files and prevent half-baked builds from happening.
As for scope of this issue, I'm totally fine with -C
being allowed.
mi...@gmail.com <mi...@gmail.com> #5
I would love to move forward and you're able to help me with that.
Any chance for this to be solved in near future?
mi...@gmail.com <mi...@gmail.com> #6
Like in school. The best way to get a silence is to ask a question. :D
jo...@google.com <jo...@google.com> #7
It looks like a bug to me. I think it's related to the fact that we don't append arguments to the result here:
jo...@google.com <jo...@google.com> #8
All flags should be passable now, even ones like -G or -N that are likely to result in an unstable or unusable project. So, it's caveat emptor for now and I'll disallow some flags if that turns out to be too problematic.
(internal reference ag/a5f1a02d3faa4e41bacf1885efc3581c36c5c9fe)
mi...@gmail.com <mi...@gmail.com> #9
I will test it on my machine and wait for full release to bump on build agents.
Thank you very much!
mi...@gmail.com <mi...@gmail.com> #10
Hello. I would like to get you know than in Gradle plugin 4.2.1 -C
is still removed from CMake command line.
jo...@google.com <jo...@google.com>
jo...@google.com <jo...@google.com>
jo...@google.com <jo...@google.com> #11
mi...@gmail.com <mi...@gmail.com> #12
Thank you!
Description
Build: AI-193.6911.18.40.6514223, 202005201507,
AI-193.6911.18.40.6514223, JRE 1.8.0_242-release-1644-b01x64 JetBrains s.r.o, OS Windows 10(amd64) v10.0 , screens 2160x1280
AS: 4.0; Kotlin plugin: 1.3.72-release-Studio4.0-1; Android Gradle Plugin: 4.0.0; Gradle: 6.5; NDK: from local.properties: 19.1.5304403, latest from SDK: 19.1.5304403; LLDB: LLDB 3.1 (revision: 3.1.4508709); CMake: from local.properties: (not specified), latest from SDK: 3.10.2, from PATH: (not found)
Android Gradle Plugin 4.0.0 (3.6.0+ may be affected too) ignore all cmake arguments which does not start with '-D' prefix. This break existing builds as '-C' is used to populate CMake cache with initial values.
Repro:
Minimal example:
Android Gradle Plugin 4.0.0: all arguments not which does not start with '-D' are ignored
Android Gradle Plugin 3.5.3 correctly passes all arguments to CMake