Non-public initializers are shrunk by proguard/R8 (#159561780 follow-up) [159595260]

Fixed

Bug

Status Update

No update yet.

Description

ka...@droidsonroids.pl

created issue #1

Jun 22, 2020 11:15PM

Component used: Startup

Version used: 1.0.0-alpha1

Devices/Android versions reproduced on: Does not matter

This is a follow-up of closed issue #159561780. Indeed the last comment seems to be true - internal class causes lint error while public does not. However, core of the issue still occurs and the same workaround works. Despite that initializers classes are public they are shrunk by R8.

Maybe some optimization is causing that? AGP: 4.2.0-alpha02 proguard full mode enabled proguard-android-optimize.txt used

Using the following Initializer class (located in library module, listed in its manifest, not added as dependency of any other initializer):

class ReportingInitializer : Initializer<Unit> {

    override fun create(context: Context) {
        //some code
    }

    override fun dependencies() = emptyList<Class<out Initializer<*>>>()
}

If the following proguard/R8 rule is applied then it works:

-keep class * extends androidx.startup.Initializer {
   <init>();
}

Comments

ra...@google.com <ra...@google.com> #2Jun 22, 2020 11:25PM

A couple of questions:

1. Have you saw crash in real device or only in simulators?
2. Do you use dynamic feature for language ID?

ka...@droidsonroids.pl <ka...@droidsonroids.pl> #3Jun 23, 2020 12:07PM

Tested on Android 12 Emulator with custom executor, but cannot repro this issue.

le...@gmail.com <le...@gmail.com> #4Jun 23, 2020 04:04PM

Second crash in the description is from a real device. Experienced it myself on two different Xiaomi phones, plus lots of crashes from users in the Google Play console.
Dynamic features are not used in the application.

As a wild guess, I have downgraded build tools from 31.0.0 to 30.0.3, compileSdk from 31 to 30, and moved all work with Language ID to the service in a separate process (just to be sure that crash can kill secondary process instead of main). This combination is in beta for 2 days by now and I don't see any SIGSEGV crashes.

Message last modified on Jun 23, 2020 04:17PM

ra...@google.com <ra...@google.com> #5Jun 23, 2020 04:24PM

Hmm, I feel the crash might be something related to separate/secondary process.

I also changed compileSdk and targetSDK to 31 but still cannot repro this issue.

ap...@google.com <ap...@google.com> #6Jun 23, 2020 05:34PM

Marked as fixed.

On the contrary, there was no separate process before, when crashes started.

In the new build (with the aforementioned changes) I can see SIGSEGV crash, but only one instead of dozens and it has a bit different backtrace:

signal 11 (SIGSEGV), code 1 (SEGV_MAPERR)
liblanguage_id_jni.so (offset 0x11e000)

backtrace:
  #00  pc 000000000003c7c0  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003b960  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003bb48  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003bafc  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000036c98  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000032714  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000031cac  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000057438  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/oat/arm64/base.odex (offset 0x57000)

sm...@gmail.com <sm...@gmail.com> #7Feb 1, 2022 05:12PM

FYI, ML Kit launched a new language ID SDK in the latest release, which uses a new language ID model. https://developers.google.com/ml-kit/release-notes#august_11_2021

Could you try the new SDK version(17.0.0) to check if you can still repro this native crash? Thanks!

ap...@google.com <ap...@google.com> #8Sep 10, 2023 04:17AM

Thank you, I'll try it and check.