Fixed
Status Update
No update yet.
Comments
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 4c42c5589076ec3b104d47955da3fe1275d4fa4b
Author: Dustin Lam <dustinlam@google.com>
Date: Wed Sep 16 15:32:47 2020
Set defaultConfig.testInstrumentation args directly from BenchmarkPlugin
Since we don't actually use the configuration object it shouldn't be
necessary to set defaultConfig params in a configureEach block, which
interferes with configuration caching because it requires the lambda to
be serialized.
Bug: 159804788
Test: ./gradlew benchmark:benchmark-gradle-plugin:test (Run from IDE as well)
Change-Id: I14812b9dcbdf51d0ee658077a9820d3ddddcdfa4
M benchmark/gradle-plugin/src/main/kotlin/androidx/benchmark/gradle/BenchmarkPlugin.kt
https://android-review.googlesource.com/1429118
Branch: androidx-master-dev
commit 4c42c5589076ec3b104d47955da3fe1275d4fa4b
Author: Dustin Lam <dustinlam@google.com>
Date: Wed Sep 16 15:32:47 2020
Set defaultConfig.testInstrumentation args directly from BenchmarkPlugin
Since we don't actually use the configuration object it shouldn't be
necessary to set defaultConfig params in a configureEach block, which
interferes with configuration caching because it requires the lambda to
be serialized.
Bug: 159804788
Test: ./gradlew benchmark:benchmark-gradle-plugin:test (Run from IDE as well)
Change-Id: I14812b9dcbdf51d0ee658077a9820d3ddddcdfa4
M benchmark/gradle-plugin/src/main/kotlin/androidx/benchmark/gradle/BenchmarkPlugin.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 6be1c120b8c4cbf64c0ae7865780ebe39c1ba2be
Author: Dustin Lam <dustinlam@google.com>
Date: Thu Sep 17 14:23:19 2020
Support configuration caching in BenchmarkPlugin
Cannot use Task.getProject() in a doLast {} block anymore to support
configuration caching, so instead, read the buildDir path into a
separate variable first, since we don't expect that to change.
Bug: 159804788
Test: ./gradlew benchmark:benchmark-gradle-plugin:test
Change-Id: I8860cd9b9d70f31909910062d044609b055657f0
M benchmark/gradle-plugin/src/main/kotlin/androidx/benchmark/gradle/BenchmarkPlugin.kt
https://android-review.googlesource.com/1431330
Branch: androidx-master-dev
commit 6be1c120b8c4cbf64c0ae7865780ebe39c1ba2be
Author: Dustin Lam <dustinlam@google.com>
Date: Thu Sep 17 14:23:19 2020
Support configuration caching in BenchmarkPlugin
Cannot use Task.getProject() in a doLast {} block anymore to support
configuration caching, so instead, read the buildDir path into a
separate variable first, since we don't expect that to change.
Bug: 159804788
Test: ./gradlew benchmark:benchmark-gradle-plugin:test
Change-Id: I8860cd9b9d70f31909910062d044609b055657f0
M benchmark/gradle-plugin/src/main/kotlin/androidx/benchmark/gradle/BenchmarkPlugin.kt
du...@google.com
ga...@google.com
Dustin, which version of the BenchmarkPlugin should contain these fixes?
cc...@google.com
We haven't shipped this publicly yet, as we haven't scheduled a release in a while. Going through the process for that now with
Description
AndroidX Benchmark plugin should support configuration caching. We should also add regression integration tests.
Gradle docs:https://docs.gradle.org/current/userguide/configuration_cache.html