Add MailTo class [159827506]

Fixed

Feature Request

Status Update

No update yet.

Description

ck...@gmail.com

created issue #1

Jun 24, 2020 08:19PM

android.net.MailTo contains a couple of bugs that prevents it from properly parsing some mailto: URIs that are found in the wild. My blog post contains more details: https://cketti.de/2020/06/22/android-net-mailto-is-broken/

I also fixed the bugs and published the class as a small library that can be used to replace usages of android.net.MailTo: https://github.com/cketti/MailToCompat

It has been suggested to me that the fixed up class could also be part of AndroidX Core. I'm happy to reformat the class to match the AOSP code style and create a CL if this is something you'd be fine with including in the library. Ian Lake volunteered to help with reviewing ❤️

Please let me know if such a contribution would be welcome.

Comments

il...@google.com <il...@google.com> Jun 24, 2020 08:20PM

Reassigned to al...@google.com.

al...@google.com <al...@google.com> #2Jun 24, 2020 09:17PM

Reassigned to ck...@gmail.com.

Yes, of course, that sounds great. Let us know if you run into any issues with the checkout. Instructions are on AOSP here.

al...@google.com <al...@google.com> #3Jun 24, 2020 09:18PM

Or any issues with the bug tracker. I'm honestly not sure whether non-Google accounts can Accept bugs.

ap...@google.com <ap...@google.com> #4Jul 8, 2020 11:24PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 6e961e5c179c9a616962d0fa16d7dcfe7e725e76
Author: cketti <cketti@gmail.com>
Date: Thu Jun 25 01:13:13 2020

Add MailTo class to parse mailto: URIs (RFC 6068)

The MailTo class is meant as a drop-in replacement for
android.net.MailTo. The API is retained, but a couple of bugs present
in the platform version have been fixed.

See also:

https://cketti.de/2020/06/22/android-net-mailto-is-broken/

Relnote: "Added `MailTo` API which provides consistent behavior and bug fixes for all API levels"
Test: ./gradlew :core:core:connectedCheck
Bug: 159827506
Change-Id: Ie93956270775e1214d778a890711105dd4b1db19

M core/core/api/1.5.0-alpha01.txt
M core/core/api/current.txt
M core/core/api/public_plus_experimental_1.5.0-alpha01.txt
M core/core/api/public_plus_experimental_current.txt
M core/core/api/restricted_1.5.0-alpha01.txt
M core/core/api/restricted_current.txt
A core/core/src/androidTest/java/androidx/core/net/MailToTest.kt
A core/core/src/main/java/androidx/core/net/MailTo.java
A core/core/src/main/java/androidx/core/net/ParseException.java

https://android-review.googlesource.com/1349602

il...@google.com <il...@google.com> #5Jul 8, 2020 11:27PM

Marked as fixed.

This has been fixed and will be available in Core 1.5.0-alpha02. Thanks for your contribution!

Issue 159827506