Status Update
Comments
fu...@google.com <fu...@google.com> #2
This is a particularly hard device to come by - do you happen to have access to the device? If so could you provide us with the output of: adb shell dumpsys media.camera > info.txt
Thanks!
sc...@gmail.com <sc...@gmail.com> #3
Stacktrace:
Caused by: java.lang.IllegalArgumentException: Can not get supported output size under supported maximum for the format: 34
at androidx.camera.camera2.internal.SupportedSurfaceCombination.getSupportedOutputSizes(SupportedSurfaceCombination.java:355)
at androidx.camera.camera2.internal.SupportedSurfaceCombination.getSuggestedResolutions(SupportedSurfaceCombination.java:197)
at androidx.camera.camera2.internal.Camera2DeviceSurfaceManager.getSuggestedResolutions(Camera2DeviceSurfaceManager.java:198)
at androidx.camera.core.CameraX.calculateSuggestedResolutions(CameraX.java:943)
at androidx.camera.core.CameraX.bindToLifecycle(CameraX.java:293)
at androidx.camera.lifecycle.ProcessCameraProvider.bindToLifecycle(ProcessCameraProvider.java:227)
Below are some findings based on our debugging
When Dex is connected
previewConfig.getMaxResolution() is returning "731x411" as maxSize.
Inside Preview.Builder.build() -> Default_MAX_resolution is set to "CameraX.getSurfaceManager().getPreviewSize()" which is 731x411
this is being picked as maxSize.
While rendering maxSize is 731x411 and minSize is 640x480 and below are available outputSizes
0 = {Size@11860} "4032x3024"
1 = {Size@11861} "3984x2988"
2 = {Size@11862} "4032x2268"
3 = {Size@11863} "3024x3024"
4 = {Size@11864} "2976x2976"
5 = {Size@11865} "3840x2160"
6 = {Size@11866} "3264x2448"
7 = {Size@11867} "4032x1960"
8 = {Size@11868} "2880x2160"
9 = {Size@11869} "3264x1836"
10 = {Size@11870} "2160x2160"
11 = {Size@11871} "2560x1440"
12 = {Size@11872} "2224x1080"
13 = {Size@11873} "2048x1152"
14 = {Size@11874} "1920x1080"
15 = {Size@11875} "1440x1080"
16 = {Size@11876} "1088x1088"
17 = {Size@11877} "1280x720"
18 = {Size@11878} "1024x768"
19 = {Size@11879} "1056x704"
20 = {Size@11880} "960x720"
21 = {Size@11881} "960x540"
22 = {Size@11882} "720x720"
23 = {Size@11883} "800x450"
24 = {Size@11884} "720x480"
25 = {Size@11885} "640x480"
26 = {Size@11886} "352x288"
27 = {Size@11887} "320x240"
28 = {Size@11888} "256x144"
29 = {Size@11889} "176x144"
and couldn't find any size in this range.
When Dex not connected
minsize = 640x480
maxsize = 1920x1080
0 = {Size@11836} "4032x3024"
1 = {Size@11837} "3984x2988"
2 = {Size@11838} "4032x2268"
3 = {Size@11839} "3024x3024"
4 = {Size@11840} "2976x2976"
5 = {Size@11841} "3840x2160"
6 = {Size@11842} "3264x2448"
7 = {Size@11843} "4032x1960"
8 = {Size@11844} "2880x2160"
9 = {Size@11845} "3264x1836"
10 = {Size@11846} "2160x2160"
11 = {Size@11847} "2560x1440"
12 = {Size@11848} "2224x1080"
13 = {Size@11849} "2048x1152"
14 = {Size@11850} "1920x1080"
15 = {Size@11851} "1440x1080"
16 = {Size@11852} "1088x1088"
17 = {Size@11853} "1280x720"
18 = {Size@11854} "1024x768"
19 = {Size@11855} "1056x704"
20 = {Size@11856} "960x720"
21 = {Size@11857} "960x540"
22 = {Size@11858} "720x720"
23 = {Size@11859} "800x450"
24 = {Size@11860} "720x480"
25 = {Size@11861} "640x480"
26 = {Size@11862} "352x288"
27 = {Size@11863} "320x240"
28 = {Size@11864} "256x144"
29 = {Size@11865} "176x144"
and we have 12 available sizes in this range
Camera2DeviceSurfaceManager.java:: getPreviewSize()
mCameraSupportedSurfaceCombinationMap.get(cameraId).getSurfaceDefinition().getPreviewSize() = "1920x1080"
cameraId=0
fu...@google.com <fu...@google.com> #4
The issue root cause is that CameraX will default filter out sizes smaller than 640x480. For Preview, the max size will be limited to under display size. I checked the HW spec info for the issue related devices. Display size of FUJITSU F-04J/F-05J is 360x640. That will result int that no size exists in the conditions that is larger or equal to 640x480 and smaller or equal to 360x640.
A temporary workaround for this situation is to use Preview.Builder#setTargetResolution() to set a size smaller than 640x480 to bypass the problem.
For device FUJITSU arrowsM04, I checked its HW spec info and its display size I found is 1280x720. It seems that the problem should not exist in the device.
Could you confirm that the problem exist on arrowsM04 device? What will be the returned value when using Display#getRealSize to obtain the display size?
sc...@gmail.com <sc...@gmail.com> #5
> A temporary workaround for this situation is to use Preview.Builder#setTargetResolution() to set a size smaller than 640x480 to bypass the problem.
OK. I will try it.
> Could you confirm that the problem exist on arrowsM04 device?
We receive the crash report (Crashlytics) that this crash has occurred on arrowsM04.
We don't have this device so we can't confirm that the problem really exist on arrowsM04.
> What will be the returned value when using Display#getRealSize to obtain the display size?
We can't investigate it for the same reason.
Thank you.
sc...@gmail.com <sc...@gmail.com> #6
This issue happened on devices that the display size is smaller than 640x480. In original auto-resolution mechanism, supported sizes smaller than 640x480 will be default filter out.
The auto-resolution mechanism encodes the guaranteed configurations tables in CameraDevice#createCaptureSession(SessionConfiguration). It defines that the PREVIEW size is the small one of the device display size and 1080p. The PREVIEW size will be the maximal size limitation for Preview use case. The reason it limits the size to display size and 1080p is the stream output in display size or 1080p has been able to provide good enough preview quality. Therefore, auto-resolution mechanism will limit the selected size to be smaller than the small one of the device display size and 1080p.
With above two conditions, in this issue, all sizes smaller than 640x480 have been filter out, therefore, there is no size smaller than the display size 320x240 can be selected to use. And cause the exception.
Solution:
When the display size is smaller than 640x480, auto-resolution mechanism won't filter out those small sizes smaller than 640x480. This makes those small size be left and can be selected for the Preview use case on small display devices.
The solution has been merged and will be included in next CameraX release.
fu...@google.com <fu...@google.com> #7
Hello.
This crash still occurs.
- CAMERAX VERSION: 1.0.0-beta4
- ANDROID OS BUILD NUMBER: Android 7.1.1
- DEVICE NAME: FUJITSU F-02H
We receive following crash report from FUJITSU F-02H. So far We have received this crash report only from F-02H.
java.lang.IllegalArgumentException
Can not get supported output size under supported maximum for the format: 34
androidx.camera.camera2.internal.SupportedSurfaceCombination.getSupportedOutputSizes (SupportedSurfaceCombination.java:349)
androidx.camera.camera2.internal.SupportedSurfaceCombination.getSuggestedResolutions (SupportedSurfaceCombination.java:197)
androidx.camera.camera2.internal.Camera2DeviceSurfaceManager.getSuggestedResolutions (Camera2DeviceSurfaceManager.java:198)
androidx.camera.core.CameraX.calculateSuggestedResolutions (CameraX.java:949)
androidx.camera.core.CameraX.bindToLifecycle (CameraX.java:351)
androidx.camera.lifecycle.ProcessCameraProvider.bindToLifecycle (ProcessCameraProvider.java:230)
(our application's package name).CameraFragment.bindCameraUseCases (CameraFragment.java:174)
sc...@gmail.com <sc...@gmail.com> #8
Could you help to provide the following information to clarify the issue?
1. Is the full name of the device Fujitsu Arrows NX F-02H that has a 1440x2560 display?
2. Please help to provide the supported output sizes of ImageFormat.PRIVATE that is obtained by StreamConfigurationMap#getOutputSizes(int).
fu...@google.com <fu...@google.com> #9
- Is the full name of the device Fujitsu Arrows NX F-02H that has a 1440x2560 display?
Yes
- Please help to provide the supported output sizes of ImageFormat.PRIVATE that is obtained by StreamConfigurationMap#getOutputSizes(int).
Since we don't have this device, we'll try to collect this information in the next version of our app. The next version will be released later this month.
sc...@gmail.com <sc...@gmail.com> #10
Hello.
- Please help to provide the supported output sizes of ImageFormat.PRIVATE that is obtained by StreamConfigurationMap#getOutputSizes(int).
We have collected the output of the device where the crash occurs.
Device1
- Model : arrows Be F-05J
- Android Version : 7.1.1
- Supported output sizes of ImageFormat.PRIVATE
CameraId 0: 480x480
CameraId 1: 2048x1536 ,1920x1080 ,1280x720 ,960x720 ,640x480 ,320x240 ,176x144
Device2
- Model : Fujitsu arrows M04
- Android Version : 7.1.1
- Supported output sizes of ImageFormat.PRIVATE
CameraId 0: 480x480
CameraId 1: 2048x1536 ,1920x1080 ,1280x720 ,960x720 ,640x480 ,320x240 ,176x144
Additional Information
CameraX version : 1.0.0-beta04
We collect the supported output sizes by following code.
val errorString = buildString {
append("The supported output sizes of ImageFormat.PRIVATE: ")
(requireContext().getSystemService(Context.CAMERA_SERVICE) as CameraManager).apply {
cameraIdList.forEachIndexed { index, cameraId ->
val msg = if (VERSION.SDK_INT >= VERSION_CODES.M) {
val configurationMap =
getCameraCharacteristics(cameraId).get(CameraCharacteristics.SCALER_STREAM_CONFIGURATION_MAP)
val sizes = configurationMap?.getOutputSizes(ImageFormat.PRIVATE)
"CameraId $index: ${sizes?.joinToString(" ,")}"
} else {
"CameraId $index: This device version is under M."
}
append(msg)
}
}
}
sc...@gmail.com <sc...@gmail.com> #11
sm...@gmail.com <sm...@gmail.com> #12
I tried to find the device specs and both 720x1280
size display. For the camera id 0 device, it is a different case that the display size is larger than 640x480
but the device only supports a 480x480
size. The case also caused the same IllegalArgumentException and was also fixed by 1.0.0-beta04
release. Before 480x480
size would be filtered out and then caused the IllegalArgumentException. After it was merged, the 640x480
size threshold was removed and then the 480x480
size would be kept and selected to use.
It looks like 1.0.0-beta04
release had been used to collect the supported sizes information. But the issue should have been fixed by 1.0.0-beta04
release. Did you only check the device model name to collect the supported sizes information or collect the information when the IllegalArgumentException issue happens again?
CameraX's 1.0.0-beta04
version. Maybe you can also consider to upgrade to the latest 1.0.0-rc01
version for your application. Thanks.
tr...@google.com <tr...@google.com> #13
Did you only check the device model name to collect the supported sizes information or collect the information when the IllegalArgumentException issue happens again?
We collect informations only from the device on which IllegalArgumentException happened.
Our latest app uses CameraX version 1.0.0-beta10
and this issue still occurres.
However we don't receive crash report from Fujitsu arrows Be F-05J
or Fujitsu arrows M04
so far. (This doesn't mean this issue is fixed on these devices because our app is heavily rely on camera so these device's user wouldn't use our app anymore.)
Instead, we receive crash report from
- Model : Fujitsu F-03K
- Android Version : 7.1.2
- Supported output sizes of ImageFormat.PRIVATE
CameraId 0 : 480x480
CameraId 1 : 2048x1536 ,1920x1080 ,1280x720 ,960x720 ,640x480 ,320x240 ,176x144
sm...@gmail.com <sm...@gmail.com> #14
I missed some settings when I simulated the issue by robolectric test so that I was not able to reproduce it. Now, I can reproduce the issue if the device only supports one 480x480 resolution. I'm working on the solution and target to make it included in next release.
sm...@gmail.com <sm...@gmail.com> #15
Branch: androidx-main
commit 69d15dff7bb857ee33a0f643ff42a0f8bc475ab2
Author: charcoalchen <charcoalchen@google.com>
Date: Fri Jan 08 18:30:03 2021
Fixed IllegalArgumentException issue happened when all preview supported sizes are smaller than 640x480 and display size is larger than 640x480.
Do not filter out sizes smaller than 640x480 when all preview supported sizes are smaller than 640x480 and display size is larger than 640x480.
Relnote:"Fixed IllegalArgumentException issue happened when all preview supported sizes are smaller than 640x480 and display size is larger than 640x480."
Bug: 150506192
Test: SupportedSurfaceCombinationTest
Change-Id: I2a63ce8e2ad42a9cc060c8635ac3603bf440b1ec
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/SupportedSurfaceCombination.java
M camera/camera-camera2/src/test/java/androidx/camera/camera2/internal/SupportedSurfaceCombinationTest.java
cd...@gmail.com <cd...@gmail.com> #16
cd...@gmail.com <cd...@gmail.com> #17
sc...@gmail.com <sc...@gmail.com> #18
I've recorded a video of it happening and attached. How can we triage this issue further to assist fixing it?
sc...@gmail.com <sc...@gmail.com> #19
tr...@google.com <tr...@google.com> #20
Thanks I'll give this a shot on the Galaxy S7. So far I have only been able to reproduce this issue once on the Galaxy S7 and never again, so if this method can reproduce the issue that should be sufficient to track down what's going on.
To double check with the original reporter, have you been able to reproduce this issue on any other device besides the Galaxy S7?
sc...@gmail.com <sc...@gmail.com> #21
sc...@gmail.com <sc...@gmail.com> #22
#20, Have you been able to reproduce it?
ap...@google.com <ap...@google.com> #23
Branch: androidx-master-dev
commit d28fa62279c51229945faf83faa421510e59a813
Author: Trevor McGuire <trevormcguire@google.com>
Date: Mon Dec 07 00:21:38 2020
Add CameraInfoInternal to UseCase#mergeConfigs()
This allows the CameraInfo to be used by the UseCase's onMergeConfig()
to make determinations about conflict resolutions.
This will be used to check for the existance of a quirk in ImageCapture
which will use a software encoding pipeline to create JPEGs.
Bug: 159831206
Test: UseCaseTest
Change-Id: I3bcf8b72a959b3d37364217a921c06b99776fe69
M camera/camera-camera2/src/test/java/androidx/camera/camera2/internal/Camera2DeviceSurfaceManagerTest.java
M camera/camera-camera2/src/test/java/androidx/camera/camera2/internal/SupportedSurfaceCombinationTest.java
M camera/camera-core/src/androidTest/java/androidx/camera/core/UseCaseTest.java
M camera/camera-core/src/main/java/androidx/camera/core/ImageCapture.java
M camera/camera-core/src/main/java/androidx/camera/core/Preview.java
M camera/camera-core/src/main/java/androidx/camera/core/UseCase.java
M camera/camera-core/src/main/java/androidx/camera/core/internal/CameraUseCaseAdapter.java
M camera/camera-testing/src/main/java/androidx/camera/testing/Configs.java
ap...@google.com <ap...@google.com> #24
Branch: androidx-master-dev
commit 11ef032d526d35e0b53e8dc7697c9d862616ecde
Author: Trevor McGuire <trevormcguire@google.com>
Date: Mon Dec 07 00:46:49 2020
Quirks#contains() for checking existence of quirks
Adds a contains() method to the Quirks class which checks for the
existance of a quirk in the Quirks container.
This will also allow checking for the existance of a quirk by its
superclass or superinterface, as long as the superclass or
superinterface is a quirk itself.
Bug: 159831206
Test: QuirksTest
Change-Id: I41fd9955916897a7af0438a0cc1c2f72df387c4a
M camera/camera-core/src/main/java/androidx/camera/core/impl/Quirks.java
M camera/camera-core/src/test/java/androidx/camera/core/impl/QuirksTest.java
ap...@google.com <ap...@google.com> #25
Branch: androidx-master-dev
commit 9e2c61d9df3d8962a133f386f0dbce97f95f3ff8
Author: Trevor McGuire <trevormcguire@google.com>
Date: Mon Dec 07 01:53:26 2020
Move CameraQuirks from Camera to CameraInfo
This allows quirks to be retrieved from CameraInfoInternal.
Since CameraInfoInternal is retrievable from CameraInternal, it can
still be retrieved from CameraInternal
Bug: 159831206
Test: N/A, simple move
Change-Id: Ib4457d14b0dbde26fcf7d4fd09df21624d7e9113
M camera/camera-camera2-pipe-integration/src/main/java/androidx/camera/camera2/pipe/integration/adapter/CameraInfoAdapter.kt
M camera/camera-camera2-pipe-integration/src/main/java/androidx/camera/camera2/pipe/integration/adapter/CameraInternalAdapter.kt
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/Camera2CameraImpl.java
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/Camera2CameraInfoImpl.java
M camera/camera-core/src/main/java/androidx/camera/core/impl/CameraInfoInternal.java
M camera/camera-core/src/main/java/androidx/camera/core/impl/CameraInternal.java
M camera/camera-testing/src/main/java/androidx/camera/testing/fakes/FakeCamera.java
M camera/camera-testing/src/main/java/androidx/camera/testing/fakes/FakeCameraInfoInternal.java
ap...@google.com <ap...@google.com> #26
Branch: androidx-master-dev
commit e2b6eece39593fc1952838048ba5e7349e48081f
Author: Trevor McGuire <trevormcguire@google.com>
Date: Mon Dec 07 00:28:41 2020
Utility in-memory EXIF writer class
Introduces ExifData and ExifOutputStream classes which are adapted from
ExifInterface in order to write EXIF in-memory. This was not possible
with ExifInterface as it requires a File or FileDescriptor to modify
EXIF values.
These new classes only support writing a subset of EXIF tags from
ExifInterface. Some other functionality removed includes writing
thumbnails/strips, support for XMP, and support for other formats
besides JPEG.
ExifOutputStream wraps another output stream to write ExifData directly
into the JPEG data. It is suitable as an output for
YuvImage.compressToJpeg() and Bitmap.compress().
This will be used by ImageCapture to write EXIF when encoding JPEGs
using a software JPEG encoder, but may be expanded/adapted later to
replace less efficient uses of ExifInterface which make use of temp
files.
Bug: 159831206
Test: ExifDataTest, ExifOutputStreamTest
Change-Id: Ided3d716348fa4871940524df40d35a93823ca1a
M camera/camera-core/build.gradle
A camera/camera-core/src/androidTest/java/androidx/camera/core/impl/utils/ExifOutputStreamTest.kt
A camera/camera-core/src/main/java/androidx/camera/core/impl/utils/ByteOrderedDataInputStream.java
A camera/camera-core/src/main/java/androidx/camera/core/impl/utils/ByteOrderedDataOutputStream.java
A camera/camera-core/src/main/java/androidx/camera/core/impl/utils/ExifAttribute.java
A camera/camera-core/src/main/java/androidx/camera/core/impl/utils/ExifData.java
A camera/camera-core/src/main/java/androidx/camera/core/impl/utils/ExifOutputStream.java
A camera/camera-core/src/main/java/androidx/camera/core/impl/utils/ExifTag.java
A camera/camera-core/src/main/java/androidx/camera/core/impl/utils/LongRational.java
A camera/camera-core/src/test/java/androidx/camera/core/impl/utils/ExifDataTest.kt
ap...@google.com <ap...@google.com> #27
Branch: androidx-master-dev
commit 1cc6a3d965b303a58dd1ebe99842c352afe8b34f
Author: Trevor McGuire <trevormcguire@google.com>
Date: Mon Dec 07 00:36:00 2020
ImageWriterCompat for specifying format
Adds ImageWriterCompat class which can be used to create an ImageWriter
with the ability to specify the format on API 26+. This functionality
could previously only be accessed on API 29.
This allows using an ImageWriter to write JPEGs to a JPEG ImageReader.
Bug: 159831206
Test: ImageWriterCompatTest
Change-Id: I02c4f6a3a5ceebe66e16e65b0abc526eef2bbd94
A camera/camera-core/src/main/java/androidx/camera/core/internal/compat/ImageWriterCompat.java
A camera/camera-core/src/main/java/androidx/camera/core/internal/compat/ImageWriterCompatApi26Impl.java
A camera/camera-core/src/main/java/androidx/camera/core/internal/compat/ImageWriterCompatApi29Impl.java
A camera/camera-core/src/main/java/androidx/camera/core/internal/compat/package-info.java
A camera/camera-core/src/test/java/androidx/camera/core/internal/compat/ImageWriterCompatTest.java
ap...@google.com <ap...@google.com> #28
Branch: androidx-master-dev
commit 3db0961cf57164c28f710934c8f86059a83b2d21
Author: Trevor McGuire <trevormcguire@google.com>
Date: Mon Dec 07 01:18:55 2020
Extract ExifData from ImageInfo
Adds ability to retrieve exif information from ImageInfo and put it
into an ExifData.Builder.
This will be used to generate software encoded JPEGs in ImageCapture
Bug: 159831206
Test: ./gradlew connectedCheck on 'heroqltevzw' (device affected by bug)
Change-Id: I8401816812103701260675c5aaa28b5b6c34722a
M camera/camera-camera2/build.gradle
M camera/camera-camera2/src/androidTest/java/androidx/camera/camera2/internal/Camera2CameraCaptureResultTest.java
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/Camera2CameraCaptureResult.java
M camera/camera-core/src/main/java/androidx/camera/core/ImageInfo.java
M camera/camera-core/src/main/java/androidx/camera/core/ImmutableImageInfo.java
M camera/camera-core/src/main/java/androidx/camera/core/impl/CameraCaptureResult.java
M camera/camera-core/src/main/java/androidx/camera/core/internal/CameraCaptureResultImageInfo.java
M camera/camera-testing/src/main/java/androidx/camera/testing/fakes/FakeImageInfo.java
ap...@google.com <ap...@google.com> #29
Branch: androidx-master-dev
commit 8e6500ea49a0c8b0ee9061c3f169326367308f2e
Author: Trevor McGuire <trevormcguire@google.com>
Date: Mon Dec 07 12:57:11 2020
Add output ImageFormat to ProcessingImageReader
Allows ProcessingImageReader to have differring input and output
formats.
This allows ProcessingImageReader to do image format conversion, such
as converting YUV to JPEG or RGB.
Bug: 159831206
Test: ./gradlew camera:camera-core:connectedCheck
Change-Id: Ib93c2727e1935cac324492578fb984a2e1a15769
M camera/camera-core/src/main/java/androidx/camera/core/ProcessingImageReader.java
M camera/camera-core/src/test/java/androidx/camera/core/ProcessingImageReaderTest.java
ap...@google.com <ap...@google.com> #30
Branch: androidx-master-dev
commit 6aa34a2b3faad8227b3311a8e372e4ccf7eaf462
Author: Trevor McGuire <trevormcguire@google.com>
Date: Mon Dec 07 23:32:41 2020
Add JpegHalCorruptImageQuirk and superinterface
Adds device quirk to workaround issue where HAL sometimes produces
corrupt JPEGs on SM-G930V back camera.
This is accomplished by adding a quirk interface called
SoftwareJpegEncodingPreferredQuirk, which is defined in camera-core and
can be subclassed in the camera implementation library.
JpegHalCorruptImageQuirk subclasses SoftwareJpegEncodingPreferredQuirk
in camera-camera2.
JpegHalCorruptImageQuirk is added to the CameraQuirks, and the
existence of the superinterface is checked in ImageCapture to
automatically enable software JPEG encoding on the device.
Relnote: "Workaround included for intermittent corrupt image data in
JPEGs on SM-G930V back-facing camera."
Bug: 159831206
Test: Manual reproduction steps on local SM-G930V no longer produce
issue.
Change-Id: I5aca54ce3ce8a5a50bc7b84175b2f0dbb7e706e2
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/quirk/CameraQuirks.java
A camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/quirk/JpegHalCorruptImageQuirk.java
M camera/camera-core/src/main/java/androidx/camera/core/ImageCapture.java
A camera/camera-core/src/main/java/androidx/camera/core/internal/compat/quirk/SoftwareJpegEncodingPreferredQuirk.java
ap...@google.com <ap...@google.com> #31
Branch: androidx-master-dev
commit 4be48010e316fe42a0acab3055f5ef4d93f5f4cf
Author: Trevor McGuire <trevormcguire@google.com>
Date: Mon Dec 07 22:46:56 2020
Software JPEG pipeline in ImageCapture
Adds a software JPEG pipeline to ImageCapture which can be used instead
of receiving JPEGs directly from the HAL. This can be used in
compatibility cases where problems may exist with JPEGs from the HAL
such as corrupted images. This could also be used in cases where
encoding JPEGs in software may be faster than using a HW JPEG encoder.
This pipeline will produce android.media.Image with type JPEG, but can
only be used on API 26+.
This feature can be enabled by using the hidden ImageCapture.Builder
option setSoftwareJpegEncoderRequested().
Bug: 159831206
Test: ./gradlew camera:camera-camera2:connectedCheck
Change-Id: I253fc0ffa285c3cd60681d396b68e08286dc6c95
M camera/camera-core/src/main/java/androidx/camera/core/ImageCapture.java
M camera/camera-core/src/main/java/androidx/camera/core/ProcessingImageReader.java
M camera/camera-core/src/main/java/androidx/camera/core/impl/ImageCaptureConfig.java
A camera/camera-core/src/main/java/androidx/camera/core/internal/YuvToJpegProcessor.java
M camera/camera-core/src/main/java/androidx/camera/core/internal/utils/ImageUtil.java
M camera/camera-testing/src/main/java/androidx/camera/testing/CameraUtil.java
sc...@gmail.com <sc...@gmail.com> #32
tr...@google.com <tr...@google.com> #33
This will be part of our mid-month December release next week.
Just a note on this bug for later reference:
The bug isn't exclusive to CameraX, but can be reproduced with Camera2. I've attached a version of Camera2Basic
(CameraXBasic
. The bug can be reliably reproduced with the following steps on an SM-G930V:
- Install attached
Camera2Basic
and (optionally) add to the home screen so it can be easily opened. - Restart the phone.
- Immediately launch
Camera2Basic
as soon as the phone starts. - As soon as the preview is displayed, rapidly press the shutter button for ~30 shots.
- Wait for all shots to finish (thumbnails should stop updating), you may see some green thumbnails while capturing.
- View the shots that were taken in the phone's gallery app. Some of the shots near the beginning of the burst of captures may exhibit the bug. If not, repeat all steps.
ap...@google.com <ap...@google.com> #34
Branch: androidx-main
commit 8768eb76402e8c3f4bed01d6c39a9548e7575726
Author: leo huang <leohuang@google.com>
Date: Sat Jan 09 06:26:06 2021
Add SM-G930T to JpegHalCorruptImageQuirk
The green image issue can also be observed on SM-G930T back camera.
Relnote: "Workaround included for intermittent corrupt image data in JPEGs on SM-G930T back-facing camera."
Bug: 159831206
Test: Manual test
Change-Id: I52001b98b8124fc9a3ee6b8c343225bb21881d12
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/quirk/JpegHalCorruptImageQuirk.java
er...@google.com <er...@google.com> #35
Closing this out. Thanks!
ap...@google.com <ap...@google.com> #36
Branch: androidx-main
commit a7c4eab91156e6d1e54a81c5cebdeb37348a1abe
Author: Tahsin Masrur <tahsinm@google.com>
Date: Wed Mar 01 15:24:57 2023
[CameraPipe] Add JpegHalCorruptImageQuirk
Quirk to workaround issue where HAL sometimes produces corrupt JPEGs. Ref:
Bug: 267558909
Test: JpegHalCorruptImageQuirkTest
Change-Id: I2f0c62d8db76306a689f4576fd5c5ef6c8573f02
M camera/camera-camera2-pipe-integration/src/main/java/androidx/camera/camera2/pipe/integration/compat/quirk/CameraQuirks.kt
A camera/camera-camera2-pipe-integration/src/main/java/androidx/camera/camera2/pipe/integration/compat/quirk/JpegHalCorruptImageQuirk.kt
A camera/camera-camera2-pipe-integration/src/test/java/androidx/camera/camera2/pipe/integration/compat/quirk/JpegHalCorruptImageQuirkTest.kt
Description
androidx.camera:camera-camera2:1.0.0-beta05
androidx.camera:camera-lifecycle:1.0.0-beta05
androidx.camera:camera-view:1.0.0-alpha12
CAMERA APPLICATION NAME AND VERSION: (Settings > Apps > (app name) > version)
1.0
ANDROID OS BUILD NUMBER: (Settings > About > Build number)
R16NW.G930VVRU8CRJ3
DEVICE NAME: (Nexus 5X, Samsung S6, etc)
Samsung Galaxy S7 (SM-G930V)
DESCRIPTION:
For some camera sessions CameraX will produce completely green images. In those sessions I see 20-30% of photos taken being completely green. In other sessions I see no issues.
LIST ANY EXPERIMENTAL FEATURES: (As an example - @ExperimentalCamera2Interop)
Unaware of any.
STEPS TO REPRODUCE:
1. Take photos in rapid succession
2. Save photos to media store
3. View photos
OBSERVED RESULTS:
Some photos appear completely green, others appear normal.
EXPECTED RESULTS:
All photos should appear normal
REPRODUCIBILITY: (5 of 5, 1 of 100, etc)
10 of 100
ADDITIONAL INFORMATION:
This issue is critical to my team, as users can't immediately review all photos and when taking several photos they may easily miss the green photos. This leads to critical loss of data.
I've attached a logcat grab for a session with 7 photos, 2 of which turned out green.
Please ignore the ADB logcat error "camera is closed" at the end of the capture, as I closed the camera too quick while it was still processing. I believe this is my own fault.
CODE FRAGMENTS (this will help us troubleshoot your issues):
// capture code - outputPath is null in all tests, which leads to saving to MediaStore:
// Create output options object which contains file + metadata
val contentValues = ContentValues().apply {
put(MediaStore.MediaColumns.DISPLAY_NAME, "Untitled")
put(MediaStore.MediaColumns.MIME_TYPE, "image/jpg")
}
// Create the output file option to store the captured image in MediaStore
val outputOptions = when (outputPath) {
null -> ImageCapture.OutputFileOptions
.Builder(
context.contentResolver,
MediaStore.Images.Media.EXTERNAL_CONTENT_URI,
contentValues
)
.build()
else -> ImageCapture.OutputFileOptions
.Builder(File(outputPath))
.build()
}
flashViewFinder()
val audio = getActivity().getSystemService(Context.AUDIO_SERVICE) as AudioManager
if (audio.ringerMode == AudioManager.RINGER_MODE_NORMAL) {
MediaActionSound().play(MediaActionSound.SHUTTER_CLICK);
}
// Setup image capture listener which is triggered after photo has
// been taken
imageCapture?.takePicture(
outputOptions, ContextCompat.getMainExecutor(getActivity()), object : ImageCapture.OnImageSavedCallback {
override fun onError(ex: ImageCaptureException) {
Log.e(TAG, "CameraView: Photo capture failed: ${ex.message}", ex)
promise.reject("E_CAPTURE_FAILED", "takePicture failed: ${ex.message}")
}
override fun onImageSaved(output: ImageCapture.OutputFileResults) {
try {
val savedUri = output.savedUri.toString()
onPictureTaken(savedUri)
Log.d(TAG, "CameraView: Photo capture succeeded: $savedUri")
val imageInfo = Arguments.createMap()
imageInfo.putString("uri", savedUri)
imageInfo.putString("id", output.savedUri?.path)
imageInfo.putString("name", output.savedUri?.lastPathSegment)
// imageInfo.putInt("size", null)
imageInfo.putInt("width", width)
imageInfo.putInt("height", height)
imageInfo.putString("path", output.savedUri?.path)
promise.resolve(imageInfo)
} catch(ex: Exception) {
Log.e(TAG, "Error while saving or decoding saved photo: ${ex.message}", ex)
promise.reject("E_ON_IMG_SAVED", "Error while reading saved photo: ${ex.message}")
}
}
})