Green images in ~20% of photos taken [159831206]

Fixed

Bug

Status Update

No update yet.

Description

sc...@gmail.com

created issue #1

Jun 25, 2020 12:22AM

CAMERAX VERSION (ex - 1.0.0-alpha07)
androidx.camera:camera-camera2:1.0.0-beta05
androidx.camera:camera-lifecycle:1.0.0-beta05
androidx.camera:camera-view:1.0.0-alpha12

CAMERA APPLICATION NAME AND VERSION: (Settings > Apps > (app name) > version)
1.0

ANDROID OS BUILD NUMBER: (Settings > About > Build number)
R16NW.G930VVRU8CRJ3

DEVICE NAME: (Nexus 5X, Samsung S6, etc)
Samsung Galaxy S7 (SM-G930V)

DESCRIPTION:
For some camera sessions CameraX will produce completely green images. In those sessions I see 20-30% of photos taken being completely green. In other sessions I see no issues.

LIST ANY EXPERIMENTAL FEATURES: (As an example - @ExperimentalCamera2Interop)
Unaware of any.

STEPS TO REPRODUCE:
1. Take photos in rapid succession
2. Save photos to media store
3. View photos

OBSERVED RESULTS:
Some photos appear completely green, others appear normal.

EXPECTED RESULTS:
All photos should appear normal

REPRODUCIBILITY: (5 of 5, 1 of 100, etc)
10 of 100

ADDITIONAL INFORMATION:
This issue is critical to my team, as users can't immediately review all photos and when taking several photos they may easily miss the green photos. This leads to critical loss of data.
I've attached a logcat grab for a session with 7 photos, 2 of which turned out green.
Please ignore the ADB logcat error "camera is closed" at the end of the capture, as I closed the camera too quick while it was still processing. I believe this is my own fault.

CODE FRAGMENTS (this will help us troubleshoot your issues):
// capture code - outputPath is null in all tests, which leads to saving to MediaStore:
// Create output options object which contains file + metadata
val contentValues = ContentValues().apply {
put(MediaStore.MediaColumns.DISPLAY_NAME, "Untitled")
put(MediaStore.MediaColumns.MIME_TYPE, "image/jpg")
}

// Create the output file option to store the captured image in MediaStore
val outputOptions = when (outputPath) {
null -> ImageCapture.OutputFileOptions
.Builder(
context.contentResolver,
MediaStore.Images.Media.EXTERNAL_CONTENT_URI,
contentValues
)
.build()
else -> ImageCapture.OutputFileOptions
.Builder(File(outputPath))
.build()
}

flashViewFinder()

val audio = getActivity().getSystemService(Context.AUDIO_SERVICE) as AudioManager
if (audio.ringerMode == AudioManager.RINGER_MODE_NORMAL) {
MediaActionSound().play(MediaActionSound.SHUTTER_CLICK);
}

// Setup image capture listener which is triggered after photo has
// been taken
imageCapture?.takePicture(
outputOptions, ContextCompat.getMainExecutor(getActivity()), object : ImageCapture.OnImageSavedCallback {
override fun onError(ex: ImageCaptureException) {
Log.e(TAG, "CameraView: Photo capture failed: ${ex.message}", ex)
promise.reject("E_CAPTURE_FAILED", "takePicture failed: ${ex.message}")
}

override fun onImageSaved(output: ImageCapture.OutputFileResults) {
try {
val savedUri = output.savedUri.toString()
onPictureTaken(savedUri)
Log.d(TAG, "CameraView: Photo capture succeeded: $savedUri")

val imageInfo = Arguments.createMap()
imageInfo.putString("uri", savedUri)
imageInfo.putString("id", output.savedUri?.path)
imageInfo.putString("name", output.savedUri?.lastPathSegment)
// imageInfo.putInt("size", null)
imageInfo.putInt("width", width)
imageInfo.putInt("height", height)
imageInfo.putString("path", output.savedUri?.path)

promise.resolve(imageInfo)
} catch(ex: Exception) {
Log.e(TAG, "Error while saving or decoding saved photo: ${ex.message}", ex)
promise.reject("E_ON_IMG_SAVED", "Error while reading saved photo: ${ex.message}")
}
}
})

log.txt.zip

124 KB

Download

Comments

fu...@google.com <fu...@google.com> #2Jun 25, 2020 01:23AM

Hi Ed, Thank you so much for these suggestions. I've been reviewing them and merging them in. Hopefully it should be live. I've included a thank you note too in the article.

sc...@gmail.com <sc...@gmail.com> #3Jun 25, 2020 02:35AM

Great! Thanks a lot, I'll look for the live updates soon!

fu...@google.com <fu...@google.com> #4Jun 26, 2020 02:29AM

From the logs, was it the last photo taken that had the green image issue? What may be happening is a lifecycle transition is shutting down the camera while the image is being prepared/saved. The green cast could be due to missing data (possibly UV data) from an incomplete file.

The following logs show the lifecycle shutting down at the end (after what looks like 7 or so valid captures?):

06-24 17:03:18.239 17748 18064 D UseCaseAttachState: All use case: [androidx.camera.core.Preview-eedde991-5d98-43b3-b0e3-2eda0560e774] for camera: 0

06-24 17:03:18.253 17748 18064 D UseCaseAttachState: All use case: [] for camera: 0

Then an error occurs: 06-24 17:03:18.335 17748 17748 E ReactNative: CameraView: Photo capture failed: Camera is closed. 06-24 17:03:18.335 17748 17748 E ReactNative: androidx.camera.core.ImageCaptureException: Camera is closed.

We're currently working on a fix that will ensure images are fully written before a shutdown happens. A potential app workaround is to delay a lifecycle change until image callbacks are received, however we'll be fixing this in CameraX.

sc...@gmail.com <sc...@gmail.com> #5Jun 26, 2020 02:49AM

Unfortunately that's not the issue.
Several photos were green. Of 7 photos I think it was about 2 green.
Neither first or last. I was trying to take them in rapid succession so
maybe there is a bug related to parallel processing / closing file handles
prematurely?

Thanks

On Thu, Jun 25, 2020 at 19:29 <buganizer-system@google.com> wrote:

- Show quoted text -

sc...@gmail.com <sc...@gmail.com> #6Jul 10, 2020 05:21PM

Hey, is there anything we can provide you guys to investigate further? We have abandoned usage of the library because of this issue. We'd really love to get it going again.

fu...@google.com <fu...@google.com> #7Jul 14, 2020 11:56PM

Since the upcoming fix generally ensures images are written fully, and perhaps other conditions beyond start/stop cycles were causing this issue, it might be possible the fix addresses this.

The fix is merged now and will be available in the next version of the library. When it becomes available, could you check the new version and see if it addresses the issue?

sc...@gmail.com <sc...@gmail.com> #8Jul 15, 2020 02:07AM

Yes, we’d be happy to test it. Thank you.
Can we sign up for release notifications somehow? Otherwise I’ll check back in whenever I think of it

fu...@google.com <fu...@google.com> #9Jul 16, 2020 09:32PM

Reassigned to tr...@google.com.

Also, is the same issue observed using CameraXBasic on that device? And if you are comfortable, sharing one of the green images would help.

We don't have release notifications, however we will try and post on the Google Group when a new release becomes available.

sc...@gmail.com <sc...@gmail.com> #10Jul 17, 2020 01:09AM

Attached is a series of 5 photos of which 2 were green.

green-photos.zip

7.7 MB

Download

sc...@gmail.com <sc...@gmail.com> #11Jul 17, 2020 01:12AM

Sorry, forgot to reply: I used CameraX very briefly. I was not able to reproduce. I didn't test very much. To reproduce the issue it usually requires a lot of use / switching apps / back and forward and spamming the shutter. At some point it gets into a "bad state" where it'll start producing the green images once in a while.

sm...@gmail.com <sm...@gmail.com> #12Jul 20, 2020 07:20PM

Will this fix also potentially cover green "frames" in the preview view? I just got a bug report in today from QA where they saw some green flickers intermixed with normal images when they first opened the camera to scan a QR code. Per the report after a second or two it stabilized to show a normal preview and they were able to scan the QR code successfully.

It was a Samsung Galaxy A8(2018) running Android 9. The device bought in Europe.

tr...@google.com <tr...@google.com> #13Jul 21, 2020 04:57AM

This is the first we're hearing of green frames in preview, but it is certainly possible. Were you using PreviewView from the camera-view artifact?

There are multiple potential causes of green images, including faulty hardware, bugs in the HAL camera implementation, bugs in the framework, or bugs in CameraX. If it isn't caused by a bug in CameraX, the best we can do is work around the issue. But that is only possible if we can identify the source.

The reason these images appear as green (rather than say, black) is usually because the underlying buffer is in the YUV color space. Green images correspond to chroma components (U/V) that are all zero. For ImageCapture, images use the JPEG format, which usually uses YUV as the compressed image format. For Preview, the buffers are often NV21 or NV12 format, which are also YUV formats.

I'll be receiving the device mentioned in this bug later this week, so I'll try to reproduce and see what I can find.

It would be useful if you have any more information about how you have configured the use case. Are you using the defaults from the IamgeCapture.Builder/Preview.Builder or are you using something like a custom resolution/aspect ratio?

sm...@gmail.com <sm...@gmail.com> #14Jul 22, 2020 12:08AM

Yes I'm using the PreviewView from alpha13.

The aspect ratio should be 16:9 as this preview is nearly full screen (Ie
image under status bar, but not the navbar). The only other possibility is
4:3 but I don't know many phones that will resolve that ratio. I'm using
the value from AspectRatio. Both use cases use the same aspect ratio value.

The only other value I set in the use cases is the targetRotation.

Note: this is not consistent. However our QA tester did happen to be screen
recording it so it is clear that it is during the initialization phase of
the camera.

On Mon, Jul 20, 2020 at 9:57 PM <buganizer-system@google.com> wrote:

- Show quoted text -

sm...@gmail.com <sm...@gmail.com> #15Aug 8, 2020 12:55AM

FYI this is very infrequent with respect to preview. Just had the 2nd incidence during the startup reported by my tester. After a second or two the green flashes go away and the camera worked as expected otherwise.

implementation "androidx.camera:camera-camera2:1.0.0-beta07"
implementation "androidx.camera:camera-lifecycle:1.0.0-beta07"
implementation "androidx.camera:camera-view:1.0.0-alpha14"

I added some logging related to this ticket:

https://issuetracker.google.com/issues/159733086 for the same device to try and capture any device errors. I see the camera device open/close as expected with no other issues logged.

cd...@gmail.com <cd...@gmail.com> #16Aug 8, 2020 09:39AM

I have also experience green tint when using CameraX on larger than normal screens. Attached is a screenshot of using [MLKit Vision-Quickstart : CameraXLivePreviewActivity option](

https://github.com/googlesamples/mlkit/tree/master/android/vision-quickstart).

As you can see, the preview is green tinted and flipped.

CameraX Version:
implementation "androidx.camera:camera-camera2:1.0.0-beta07"
implementation "androidx.camera:camera-lifecycle:1.0.0-beta07"
implementation "androidx.camera:camera-view:1.0.0-alpha14"

Device:
[LG Verizon Tablet VK700] (

https://www.gsmarena.com/lg_g_pad_10_1_lte-7289.php)

===========
NB: This problem was also shared in another issue: (

https://issuetracker.google.com/issues/162811631)

cd...@gmail.com <cd...@gmail.com> #17Aug 8, 2020 09:41AM

Attaching image for my previous comment, as I mistakenly omitted it.

Screenshot_2020-08-08-03-57-45.png

353 KB

View

Download

sc...@gmail.com <sc...@gmail.com> #18Aug 22, 2020 10:48PM

I was just able to reproduce using the standard CameraX Basic example project multiple times. I can still reproduce the issue in my main app on version beta08 (camera-view on alpha15), so the issue still seems to be around.

I've recorded a video of it happening and attached. How can we triage this issue further to assist fixing it?

IMG_6101 2020-08-22 22_41_41.2020-08-22 15_46_25.mp4

8.1 MB

Download

sc...@gmail.com <sc...@gmail.com> #19Aug 23, 2020 12:10AM

I should add that I also have a full length video showing how a freshly cleared version of the app goes from 0 photos to generating a green photo. The video is rather large at 46 MB. I am consistently able to reproduce this by resetting the app and clearing cache (equivalent to reinstalling), opening the app, giving permissions, spamming the capture button 20 times, then switching to the native camera app, snap a few photos, then back to the app again and snap more photos. This will produce the issue.

tr...@google.com <tr...@google.com> #20Aug 24, 2020 07:22PM

Thanks I'll give this a shot on the Galaxy S7. So far I have only been able to reproduce this issue once on the Galaxy S7 and never again, so if this method can reproduce the issue that should be sufficient to track down what's going on.

To double check with the original reporter, have you been able to reproduce this issue on any other device besides the Galaxy S7?

sc...@gmail.com <sc...@gmail.com> #21Aug 25, 2020 02:16AM

I'm the original author of the issue. I have only tested Samsung Galaxy S7. I tried rebooting the device, I tried updating to the latest available software (Samsung doesn't update it much anymore) but nothing has helped unfortunately.

sc...@gmail.com <sc...@gmail.com> #22Sep 29, 2020 09:28PM

This is the number 1 blocker for us to start using this library. We can't put it into production, but otherwise it's been great.

#20, Have you been able to reproduce it?

ap...@google.com <ap...@google.com> #23Dec 8, 2020 07:00PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit d28fa62279c51229945faf83faa421510e59a813
Author: Trevor McGuire <trevormcguire@google.com>
Date: Mon Dec 07 00:21:38 2020

Add CameraInfoInternal to UseCase#mergeConfigs()

This allows the CameraInfo to be used by the UseCase's onMergeConfig()
to make determinations about conflict resolutions.

This will be used to check for the existance of a quirk in ImageCapture
which will use a software encoding pipeline to create JPEGs.

Bug: 159831206
Test: UseCaseTest
Change-Id: I3bcf8b72a959b3d37364217a921c06b99776fe69

M camera/camera-camera2/src/test/java/androidx/camera/camera2/internal/Camera2DeviceSurfaceManagerTest.java
M camera/camera-camera2/src/test/java/androidx/camera/camera2/internal/SupportedSurfaceCombinationTest.java
M camera/camera-core/src/androidTest/java/androidx/camera/core/UseCaseTest.java
M camera/camera-core/src/main/java/androidx/camera/core/ImageCapture.java
M camera/camera-core/src/main/java/androidx/camera/core/Preview.java
M camera/camera-core/src/main/java/androidx/camera/core/UseCase.java
M camera/camera-core/src/main/java/androidx/camera/core/internal/CameraUseCaseAdapter.java
M camera/camera-testing/src/main/java/androidx/camera/testing/Configs.java

https://android-review.googlesource.com/1518430

ap...@google.com <ap...@google.com> #24Dec 8, 2020 07:15PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 11ef032d526d35e0b53e8dc7697c9d862616ecde
Author: Trevor McGuire <trevormcguire@google.com>
Date: Mon Dec 07 00:46:49 2020

Quirks#contains() for checking existence of quirks

Adds a contains() method to the Quirks class which checks for the
existance of a quirk in the Quirks container.

This will also allow checking for the existance of a quirk by its
superclass or superinterface, as long as the superclass or
superinterface is a quirk itself.

Bug: 159831206
Test: QuirksTest
Change-Id: I41fd9955916897a7af0438a0cc1c2f72df387c4a

M camera/camera-core/src/main/java/androidx/camera/core/impl/Quirks.java
M camera/camera-core/src/test/java/androidx/camera/core/impl/QuirksTest.java

https://android-review.googlesource.com/1520100

ap...@google.com <ap...@google.com> #25Dec 8, 2020 07:15PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 9e2c61d9df3d8962a133f386f0dbce97f95f3ff8
Author: Trevor McGuire <trevormcguire@google.com>
Date: Mon Dec 07 01:53:26 2020

Move CameraQuirks from Camera to CameraInfo

This allows quirks to be retrieved from CameraInfoInternal.
Since CameraInfoInternal is retrievable from CameraInternal, it can
still be retrieved from CameraInternal

Bug: 159831206
Test: N/A, simple move
Change-Id: Ib4457d14b0dbde26fcf7d4fd09df21624d7e9113

M camera/camera-camera2-pipe-integration/src/main/java/androidx/camera/camera2/pipe/integration/adapter/CameraInfoAdapter.kt
M camera/camera-camera2-pipe-integration/src/main/java/androidx/camera/camera2/pipe/integration/adapter/CameraInternalAdapter.kt
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/Camera2CameraImpl.java
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/Camera2CameraInfoImpl.java
M camera/camera-core/src/main/java/androidx/camera/core/impl/CameraInfoInternal.java
M camera/camera-core/src/main/java/androidx/camera/core/impl/CameraInternal.java
M camera/camera-testing/src/main/java/androidx/camera/testing/fakes/FakeCamera.java
M camera/camera-testing/src/main/java/androidx/camera/testing/fakes/FakeCameraInfoInternal.java

https://android-review.googlesource.com/1520099

ap...@google.com <ap...@google.com> #26Dec 9, 2020 02:22AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit e2b6eece39593fc1952838048ba5e7349e48081f
Author: Trevor McGuire <trevormcguire@google.com>
Date: Mon Dec 07 00:28:41 2020

Utility in-memory EXIF writer class

Introduces ExifData and ExifOutputStream classes which are adapted from
ExifInterface in order to write EXIF in-memory. This was not possible
with ExifInterface as it requires a File or FileDescriptor to modify
EXIF values.

These new classes only support writing a subset of EXIF tags from
ExifInterface. Some other functionality removed includes writing
thumbnails/strips, support for XMP, and support for other formats
besides JPEG.

ExifOutputStream wraps another output stream to write ExifData directly
into the JPEG data. It is suitable as an output for
YuvImage.compressToJpeg() and Bitmap.compress().

This will be used by ImageCapture to write EXIF when encoding JPEGs
using a software JPEG encoder, but may be expanded/adapted later to
replace less efficient uses of ExifInterface which make use of temp
files.

Bug: 159831206
Test: ExifDataTest, ExifOutputStreamTest
Change-Id: Ided3d716348fa4871940524df40d35a93823ca1a

M camera/camera-core/build.gradle
A camera/camera-core/src/androidTest/java/androidx/camera/core/impl/utils/ExifOutputStreamTest.kt
A camera/camera-core/src/main/java/androidx/camera/core/impl/utils/ByteOrderedDataInputStream.java
A camera/camera-core/src/main/java/androidx/camera/core/impl/utils/ByteOrderedDataOutputStream.java
A camera/camera-core/src/main/java/androidx/camera/core/impl/utils/ExifAttribute.java
A camera/camera-core/src/main/java/androidx/camera/core/impl/utils/ExifData.java
A camera/camera-core/src/main/java/androidx/camera/core/impl/utils/ExifOutputStream.java
A camera/camera-core/src/main/java/androidx/camera/core/impl/utils/ExifTag.java
A camera/camera-core/src/main/java/androidx/camera/core/impl/utils/LongRational.java
A camera/camera-core/src/test/java/androidx/camera/core/impl/utils/ExifDataTest.kt

https://android-review.googlesource.com/1519733

ap...@google.com <ap...@google.com> #27Dec 9, 2020 02:48AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 1cc6a3d965b303a58dd1ebe99842c352afe8b34f
Author: Trevor McGuire <trevormcguire@google.com>
Date: Mon Dec 07 00:36:00 2020

ImageWriterCompat for specifying format

Adds ImageWriterCompat class which can be used to create an ImageWriter
with the ability to specify the format on API 26+. This functionality
could previously only be accessed on API 29.

This allows using an ImageWriter to write JPEGs to a JPEG ImageReader.

Bug: 159831206
Test: ImageWriterCompatTest
Change-Id: I02c4f6a3a5ceebe66e16e65b0abc526eef2bbd94

A camera/camera-core/src/main/java/androidx/camera/core/internal/compat/ImageWriterCompat.java
A camera/camera-core/src/main/java/androidx/camera/core/internal/compat/ImageWriterCompatApi26Impl.java
A camera/camera-core/src/main/java/androidx/camera/core/internal/compat/ImageWriterCompatApi29Impl.java
A camera/camera-core/src/main/java/androidx/camera/core/internal/compat/package-info.java
A camera/camera-core/src/test/java/androidx/camera/core/internal/compat/ImageWriterCompatTest.java

https://android-review.googlesource.com/1519736

ap...@google.com <ap...@google.com> #28Dec 9, 2020 08:24AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 3db0961cf57164c28f710934c8f86059a83b2d21
Author: Trevor McGuire <trevormcguire@google.com>
Date: Mon Dec 07 01:18:55 2020

Extract ExifData from ImageInfo

Adds ability to retrieve exif information from ImageInfo and put it
into an ExifData.Builder.

This will be used to generate software encoded JPEGs in ImageCapture

Bug: 159831206
Test: ./gradlew connectedCheck on 'heroqltevzw' (device affected by bug)
Change-Id: I8401816812103701260675c5aaa28b5b6c34722a

M camera/camera-camera2/build.gradle
M camera/camera-camera2/src/androidTest/java/androidx/camera/camera2/internal/Camera2CameraCaptureResultTest.java
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/Camera2CameraCaptureResult.java
M camera/camera-core/src/main/java/androidx/camera/core/ImageInfo.java
M camera/camera-core/src/main/java/androidx/camera/core/ImmutableImageInfo.java
M camera/camera-core/src/main/java/androidx/camera/core/impl/CameraCaptureResult.java
M camera/camera-core/src/main/java/androidx/camera/core/internal/CameraCaptureResultImageInfo.java
M camera/camera-testing/src/main/java/androidx/camera/testing/fakes/FakeImageInfo.java

https://android-review.googlesource.com/1519734

ap...@google.com <ap...@google.com> #29Dec 10, 2020 07:55AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 8e6500ea49a0c8b0ee9061c3f169326367308f2e
Author: Trevor McGuire <trevormcguire@google.com>
Date: Mon Dec 07 12:57:11 2020

Add output ImageFormat to ProcessingImageReader

Allows ProcessingImageReader to have differring input and output
formats.

This allows ProcessingImageReader to do image format conversion, such
as converting YUV to JPEG or RGB.

Bug: 159831206
Test: ./gradlew camera:camera-core:connectedCheck
Change-Id: Ib93c2727e1935cac324492578fb984a2e1a15769

M camera/camera-core/src/main/java/androidx/camera/core/ProcessingImageReader.java
M camera/camera-core/src/test/java/androidx/camera/core/ProcessingImageReaderTest.java

https://android-review.googlesource.com/1518429

ap...@google.com <ap...@google.com> #30Dec 10, 2020 08:49AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 6aa34a2b3faad8227b3311a8e372e4ccf7eaf462
Author: Trevor McGuire <trevormcguire@google.com>
Date: Mon Dec 07 23:32:41 2020

Add JpegHalCorruptImageQuirk and superinterface

Adds device quirk to workaround issue where HAL sometimes produces
corrupt JPEGs on SM-G930V back camera.

This is accomplished by adding a quirk interface called
SoftwareJpegEncodingPreferredQuirk, which is defined in camera-core and
can be subclassed in the camera implementation library.
JpegHalCorruptImageQuirk subclasses SoftwareJpegEncodingPreferredQuirk
in camera-camera2.

JpegHalCorruptImageQuirk is added to the CameraQuirks, and the
existence of the superinterface is checked in ImageCapture to
automatically enable software JPEG encoding on the device.

Relnote: "Workaround included for intermittent corrupt image data in
JPEGs on SM-G930V back-facing camera."

Bug: 159831206
Test: Manual reproduction steps on local SM-G930V no longer produce
issue.

Change-Id: I5aca54ce3ce8a5a50bc7b84175b2f0dbb7e706e2

M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/quirk/CameraQuirks.java
A camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/quirk/JpegHalCorruptImageQuirk.java
M camera/camera-core/src/main/java/androidx/camera/core/ImageCapture.java
A camera/camera-core/src/main/java/androidx/camera/core/internal/compat/quirk/SoftwareJpegEncodingPreferredQuirk.java

https://android-review.googlesource.com/1520799

ap...@google.com <ap...@google.com> #31Dec 10, 2020 08:49AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 4be48010e316fe42a0acab3055f5ef4d93f5f4cf
Author: Trevor McGuire <trevormcguire@google.com>
Date: Mon Dec 07 22:46:56 2020

Software JPEG pipeline in ImageCapture

Adds a software JPEG pipeline to ImageCapture which can be used instead
of receiving JPEGs directly from the HAL. This can be used in
compatibility cases where problems may exist with JPEGs from the HAL
such as corrupted images. This could also be used in cases where
encoding JPEGs in software may be faster than using a HW JPEG encoder.

This pipeline will produce android.media.Image with type JPEG, but can
only be used on API 26+.

This feature can be enabled by using the hidden ImageCapture.Builder
option setSoftwareJpegEncoderRequested().

Bug: 159831206
Test: ./gradlew camera:camera-camera2:connectedCheck
Change-Id: I253fc0ffa285c3cd60681d396b68e08286dc6c95

M camera/camera-core/src/main/java/androidx/camera/core/ImageCapture.java
M camera/camera-core/src/main/java/androidx/camera/core/ProcessingImageReader.java
M camera/camera-core/src/main/java/androidx/camera/core/impl/ImageCaptureConfig.java
A camera/camera-core/src/main/java/androidx/camera/core/internal/YuvToJpegProcessor.java
M camera/camera-core/src/main/java/androidx/camera/core/internal/utils/ImageUtil.java
M camera/camera-testing/src/main/java/androidx/camera/testing/CameraUtil.java

https://android-review.googlesource.com/1520798

sc...@gmail.com <sc...@gmail.com> #32Dec 11, 2020 04:20AM

Amazing work! When will this be released, if we know?

tr...@google.com <tr...@google.com> #33Dec 12, 2020 05:41AM

This will be part of our mid-month December release next week.

Just a note on this bug for later reference:

The bug isn't exclusive to CameraX, but can be reproduced with Camera2. I've attached a version of Camera2Basic (https://github.com/android/camera-samples/tree/master/Camera2Basic) which has been modified to allow capturing many shots successively, similar to CameraXBasic. The bug can be reliably reproduced with the following steps on an SM-G930V:

Install attached Camera2Basic and (optionally) add to the home screen so it can be easily opened.
Restart the phone.
Immediately launch Camera2Basic as soon as the phone starts.
As soon as the preview is displayed, rapidly press the shutter button for ~30 shots.
Wait for all shots to finish (thumbnails should stop updating), you may see some green thumbnails while capturing.
View the shots that were taken in the phone's gallery app. Some of the shots near the beginning of the burst of captures may exhibit the bug. If not, repeat all steps.

Camera2Basic.zip

1.2 MB

Download

ap...@google.com <ap...@google.com> #34Jan 13, 2021 12:34AM

Project: platform/frameworks/support
Branch: androidx-main

commit 8768eb76402e8c3f4bed01d6c39a9548e7575726
Author: leo huang <leohuang@google.com>
Date: Sat Jan 09 06:26:06 2021

Add SM-G930T to JpegHalCorruptImageQuirk

The green image issue can also be observed on SM-G930T back camera.

Relnote: "Workaround included for intermittent corrupt image data in JPEGs on SM-G930T back-facing camera."

Bug: 159831206
Test: Manual test
Change-Id: I52001b98b8124fc9a3ee6b8c343225bb21881d12

M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/quirk/JpegHalCorruptImageQuirk.java

https://android-review.googlesource.com/1545625

er...@google.com <er...@google.com> #35Mar 9, 2021 10:20PM

Marked as fixed.

Hello. The changes marked here have been cherrypicked into our last RC03 release and address the green images in the back camera. This does not address the front camera. If you'd like to keep apprised on the front camera please cc yourself on

http://issuetracker.google.com/182304572

Closing this out. Thanks!

ap...@google.com <ap...@google.com> #36Mar 7, 2023 03:46AM

Project: platform/frameworks/support
Branch: androidx-main

commit a7c4eab91156e6d1e54a81c5cebdeb37348a1abe
Author: Tahsin Masrur <tahsinm@google.com>
Date: Wed Mar 01 15:24:57 2023

[CameraPipe] Add JpegHalCorruptImageQuirk

Quirk to workaround issue where HAL sometimes produces corrupt JPEGs. Ref:

b/159831206

Bug: 267558909
Test: JpegHalCorruptImageQuirkTest
Change-Id: I2f0c62d8db76306a689f4576fd5c5ef6c8573f02

M camera/camera-camera2-pipe-integration/src/main/java/androidx/camera/camera2/pipe/integration/compat/quirk/CameraQuirks.kt
A camera/camera-camera2-pipe-integration/src/main/java/androidx/camera/camera2/pipe/integration/compat/quirk/JpegHalCorruptImageQuirk.kt
A camera/camera-camera2-pipe-integration/src/test/java/androidx/camera/camera2/pipe/integration/compat/quirk/JpegHalCorruptImageQuirkTest.kt

https://android-review.googlesource.com/2462638

Issue 159831206

Description

Issue summary

Comments

fu...@google.com <fu...@google.com> #2Jun 25, 2020 01:23AM

sc...@gmail.com <sc...@gmail.com> #3Jun 25, 2020 02:35AM

fu...@google.com <fu...@google.com> #4Jun 26, 2020 02:29AM

sc...@gmail.com <sc...@gmail.com> #5Jun 26, 2020 02:49AM

sc...@gmail.com <sc...@gmail.com> #6Jul 10, 2020 05:21PM

fu...@google.com <fu...@google.com> #7Jul 14, 2020 11:56PM

sc...@gmail.com <sc...@gmail.com> #8Jul 15, 2020 02:07AM

fu...@google.com <fu...@google.com> #9Jul 16, 2020 09:32PM

sc...@gmail.com <sc...@gmail.com> #10Jul 17, 2020 01:09AM

sc...@gmail.com <sc...@gmail.com> #11Jul 17, 2020 01:12AM

sm...@gmail.com <sm...@gmail.com> #12Jul 20, 2020 07:20PM

tr...@google.com <tr...@google.com> #13Jul 21, 2020 04:57AM

sm...@gmail.com <sm...@gmail.com> #14Jul 22, 2020 12:08AM

sm...@gmail.com <sm...@gmail.com> #15Aug 8, 2020 12:55AM

cd...@gmail.com <cd...@gmail.com> #16Aug 8, 2020 09:39AM

cd...@gmail.com <cd...@gmail.com> #17Aug 8, 2020 09:41AM

sc...@gmail.com <sc...@gmail.com> #18Aug 22, 2020 10:48PM

sc...@gmail.com <sc...@gmail.com> #19Aug 23, 2020 12:10AM

tr...@google.com <tr...@google.com> #20Aug 24, 2020 07:22PM

sc...@gmail.com <sc...@gmail.com> #21Aug 25, 2020 02:16AM

sc...@gmail.com <sc...@gmail.com> #22Sep 29, 2020 09:28PM

ap...@google.com <ap...@google.com> #23Dec 8, 2020 07:00PM

ap...@google.com <ap...@google.com> #24Dec 8, 2020 07:15PM

ap...@google.com <ap...@google.com> #25Dec 8, 2020 07:15PM

ap...@google.com <ap...@google.com> #26Dec 9, 2020 02:22AM

ap...@google.com <ap...@google.com> #27Dec 9, 2020 02:48AM

ap...@google.com <ap...@google.com> #28Dec 9, 2020 08:24AM

ap...@google.com <ap...@google.com> #29Dec 10, 2020 07:55AM

ap...@google.com <ap...@google.com> #30Dec 10, 2020 08:49AM

ap...@google.com <ap...@google.com> #31Dec 10, 2020 08:49AM

sc...@gmail.com <sc...@gmail.com> #32Dec 11, 2020 04:20AM

tr...@google.com <tr...@google.com> #33Dec 12, 2020 05:41AM

ap...@google.com <ap...@google.com> #34Jan 13, 2021 12:34AM

er...@google.com <er...@google.com> #35Mar 9, 2021 10:20PM

ap...@google.com <ap...@google.com> #36Mar 7, 2023 03:46AM

Add comment

Issue metadata