Status Update
Comments
fu...@google.com <fu...@google.com> #2
1. Have you saw crash in real device or only in simulators?
2. Do you use dynamic feature for language ID?
sc...@gmail.com <sc...@gmail.com> #3
Tested on Android 12 Emulator with custom executor, but cannot repro this issue.
fu...@google.com <fu...@google.com> #4
-
Second crash in the description is from a real device. Experienced it myself on two different Xiaomi phones, plus lots of crashes from users in the Google Play console.
-
Dynamic features are not used in the application.
As a wild guess, I have downgraded build tools from 31.0.0 to 30.0.3, compileSdk from 31 to 30, and moved all work with Language ID to the service in a separate process (just to be sure that crash can kill secondary process instead of main). This combination is in beta for 2 days by now and I don't see any SIGSEGV crashes.
sc...@gmail.com <sc...@gmail.com> #5
Hmm, I feel the crash might be something related to separate/secondary process.
I also changed compileSdk and targetSDK to 31 but still cannot repro this issue.
sc...@gmail.com <sc...@gmail.com> #6
On the contrary, there was no separate process before, when crashes started.
In the new build (with the aforementioned changes) I can see SIGSEGV crash, but only one instead of dozens and it has a bit different backtrace:
signal 11 (SIGSEGV), code 1 (SEGV_MAPERR)
liblanguage_id_jni.so (offset 0x11e000)
backtrace:
#00 pc 000000000003c7c0 /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
#00 pc 000000000003b960 /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
#00 pc 000000000003bb48 /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
#00 pc 000000000003bafc /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
#00 pc 0000000000036c98 /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
#00 pc 0000000000032714 /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
#00 pc 0000000000031cac /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
#00 pc 0000000000057438 /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/oat/arm64/base.odex (offset 0x57000)
fu...@google.com <fu...@google.com> #7
FYI, ML Kit launched a new language ID SDK in the latest release, which uses a new language ID model.
Could you try the new SDK version(17.0.0) to check if you can still repro this native crash? Thanks!
sc...@gmail.com <sc...@gmail.com> #8
Thank you, I'll try it and check.
fu...@google.com <fu...@google.com> #9
Hello. I have similar experience.
- I'm using mlkit-language 16.1.1
- I didnot meet this error until using AGP 4.2
- I can get this error since using AGP 7.0
- This error raised on Release build only(minimized by R8)
- This error raised without obfuscation.
sc...@gmail.com <sc...@gmail.com> #11
I created reproducible project.
$ git clone https://github.com/ganadist/VersionCodeDemo -b mlkit_agp7 mlkit_agp7
$ cd mlkit_agp7
$ ./gradlew :app:pPRUA
$ adb install app/build/outputs/universal_apk/productionRelease/app-production-release-universal.apk
$ adb shell am start -n com.example.myapplication/.MainActivity
$ adb logcat -b crash -d
10-19 19:41:49.844 17810 17810 F libc : Fatal signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x7acf9d733c in tid 17810 (e.myapplication), pid 17810 (e.myapplication)
10-19 19:41:50.473 17849 17849 F DEBUG : *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
10-19 19:41:50.473 17849 17849 F DEBUG : Build fingerprint: 'google/crosshatch/crosshatch:12/SPB5.210812.002/7671067:user/release-keys'
10-19 19:41:50.473 17849 17849 F DEBUG : Revision: 'MP1.0'
10-19 19:41:50.473 17849 17849 F DEBUG : ABI: 'arm64'
10-19 19:41:50.473 17849 17849 F DEBUG : Timestamp: 2021-10-19 19:41:49.903736988+0900
10-19 19:41:50.473 17849 17849 F DEBUG : Process uptime: 0s
10-19 19:41:50.473 17849 17849 F DEBUG : Cmdline: com.example.myapplication
10-19 19:41:50.474 17849 17849 F DEBUG : pid: 17810, tid: 17810, name: e.myapplication >>> com.example.myapplication <<<
10-19 19:41:50.474 17849 17849 F DEBUG : uid: 10240
10-19 19:41:50.474 17849 17849 F DEBUG : signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x7acf9d733c
10-19 19:41:50.474 17849 17849 F DEBUG : x0 0000000000000000 x1 00000000000008fc x2 0000007a76760c71 x3 0000000000000000
10-19 19:41:50.474 17849 17849 F DEBUG : x4 0000000000000010 x5 0000007ba4db49d0 x6 0000007b34dc3680 x7 3de38e3900000608
10-19 19:41:50.474 17849 17849 F DEBUG : x8 0000007bb4dbedf0 x9 0000007acf9db2aa x10 0000000000000000 x11 0000007acf9d6640
10-19 19:41:50.474 17849 17849 F DEBUG : x12 0000000000000009 x13 0000000000000000 x14 0000000000000061 x15 00000000ebad6a89
10-19 19:41:50.474 17849 17849 F DEBUG : x16 0000007a767cfef8 x17 0000007d9a564b40 x18 0000007da3830000 x19 0000007feaf56a08
10-19 19:41:50.474 17849 17849 F DEBUG : x20 0000000000000000 x21 0000007ba4da50b0 x22 0000007bb4dbedf0 x23 0000007ba4da50b8
10-19 19:41:50.474 17849 17849 F DEBUG : x24 0000000000000009 x25 000000000000067e x26 0000000000000012 x27 0000000000000008
10-19 19:41:50.474 17849 17849 F DEBUG : x28 0000007b64dc8440 x29 0000000000000000
10-19 19:41:50.474 17849 17849 F DEBUG : lr 0000007a7678a964 sp 0000007feaf56810 pc 0000007a7678b7c0 pst 0000000060000000
10-19 19:41:50.474 17849 17849 F DEBUG : backtrace:
10-19 19:41:50.474 17849 17849 F DEBUG : #00 pc 000000000003c7c0 /data/app/~~mHaMq-e9ocbm9UfYnkCGkQ==/com.example.myapplication-HgG9vkluwDDO1K78-Vzr0A==/lib/arm64/liblanguage_id_jni.so (BuildId: 859ec0ec2000a39e6ae8ed42e1704f46)
10-19 19:41:50.474 17849 17849 F DEBUG : #01 pc 000000000003b960 /data/app/~~mHaMq-e9ocbm9UfYnkCGkQ==/com.example.myapplication-HgG9vkluwDDO1K78-Vzr0A==/lib/arm64/liblanguage_id_jni.so (BuildId: 859ec0ec2000a39e6ae8ed42e1704f46)
10-19 19:41:50.474 17849 17849 F DEBUG : #02 pc 000000000003bb48 /data/app/~~mHaMq-e9ocbm9UfYnkCGkQ==/com.example.myapplication-HgG9vkluwDDO1K78-Vzr0A==/lib/arm64/liblanguage_id_jni.so (BuildId: 859ec0ec2000a39e6ae8ed42e1704f46)
10-19 19:41:50.474 17849 17849 F DEBUG : #03 pc 000000000003bafc /data/app/~~mHaMq-e9ocbm9UfYnkCGkQ==/com.example.myapplication-HgG9vkluwDDO1K78-Vzr0A==/lib/arm64/liblanguage_id_jni.so (BuildId: 859ec0ec2000a39e6ae8ed42e1704f46)
10-19 19:41:50.474 17849 17849 F DEBUG : #04 pc 0000000000036c98 /data/app/~~mHaMq-e9ocbm9UfYnkCGkQ==/com.example.myapplication-HgG9vkluwDDO1K78-Vzr0A==/lib/arm64/liblanguage_id_jni.so (BuildId: 859ec0ec2000a39e6ae8ed42e1704f46)
10-19 19:41:50.474 17849 17849 F DEBUG : #05 pc 00000000000324a4 /data/app/~~mHaMq-e9ocbm9UfYnkCGkQ==/com.example.myapplication-HgG9vkluwDDO1K78-Vzr0A==/lib/arm64/liblanguage_id_jni.so (BuildId: 859ec0ec2000a39e6ae8ed42e1704f46)
10-19 19:41:50.474 17849 17849 F DEBUG : #06 pc 0000000000031b5c /data/app/~~mHaMq-e9ocbm9UfYnkCGkQ==/com.example.myapplication-HgG9vkluwDDO1K78-Vzr0A==/lib/arm64/liblanguage_id_jni.so (Java_com_google_mlkit_nl_languageid_internal_LanguageIdentificationJni_nativeIdentifyLanguage+100) (BuildId: 859ec0ec2000a39e6ae8ed42e1704f46)
But after downgrade to AGP 4.2, crash is not reproducible.
$ git clone https://github.com/ganadist/VersionCodeDemo -b mlkit_agp42 mlkit_agp42
$ cd mlkit_agp42
$ ./gradlew :app:pPRUA
$ adb install app/build/outputs/universal_apk/productionRelease/app-production-release-universal.apk
$ adb shell am start -n com.example.myapplication/.MainActivity
Also, I tried to disable
$ git clone https://github.com/ganadist/VersionCodeDemo -b mlkit_agp7_r8_disable_inline_optimizer mlkit_agp7_r8
$ cd mlkit_agp7_r8
$ ./gradlew :app:pPRUA
$ adb install app/build/outputs/universal_apk/productionRelease/app-production-release-universal.apk
$ adb shell am start -n com.example.myapplication/.MainActivity
sm...@gmail.com <sm...@gmail.com> #12
I tried the repro steps but got a NPE when I run ./gradlew :app:pPRUA
FAILURE: Build failed with an exception.
* What went wrong:
java.lang.NullPointerException
> java.lang.NullPointerException (no error message)
Could you also check if this is reproducible on 17.0.0
or 17.0.1
? If yes, could you attach the full log that I can take a look? Thanks!
tr...@google.com <tr...@google.com> #13
Here are gradle build scan logs for each branches.
All builds were clean build, and disabled build cache.
- mlkit_agp7 :
https://scans.gradle.com/s/qrymdqfzwokbq - mlkit_agp42 :
https://scans.gradle.com/s/b6644hzfyfhaw - mlkit_agp7_r8_disable_inline_optimizer :
https://scans.gradle.com/s/c6h5hy2nxod4u
Also, I pushed to update MLKit Language Id version 17.0.1 on
And here is crash log after apply 17.0.1
You can see that BuildId
of liblanguage_id_l2c_jni.so
was changed from 859ec0ec2000a39e6ae8ed42e1704f46
to be6e59455cc10135330c93acdebfc121
10-20 03:07:24.522 24587 24628 F libc : Fatal signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x7acf995426 in tid 24628 (pool-3-thread-3), pid 24587 (e.myapplication)
10-20 03:07:25.190 24710 24710 F DEBUG : *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
10-20 03:07:25.190 24710 24710 F DEBUG : Build fingerprint: 'google/crosshatch/crosshatch:12/SPB5.210812.002/7671067:user/release-keys'
10-20 03:07:25.190 24710 24710 F DEBUG : Revision: 'MP1.0'
10-20 03:07:25.190 24710 24710 F DEBUG : ABI: 'arm64'
10-20 03:07:25.190 24710 24710 F DEBUG : Timestamp: 2021-10-20 03:07:24.583346246+0900
10-20 03:07:25.190 24710 24710 F DEBUG : Process uptime: 0s
10-20 03:07:25.190 24710 24710 F DEBUG : Cmdline: com.example.myapplication
10-20 03:07:25.190 24710 24710 F DEBUG : pid: 24587, tid: 24628, name: pool-3-thread-3 >>> com.example.myapplication <<<
10-20 03:07:25.190 24710 24710 F DEBUG : uid: 10240
10-20 03:07:25.190 24710 24710 F DEBUG : signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x7acf995426
10-20 03:07:25.190 24710 24710 F DEBUG : x0 0000007b54da9d30 x1 0000007d9a5fe7cc x2 0000000000000000 x3 0000000000000010
10-20 03:07:25.190 24710 24710 F DEBUG : x4 0000000000000000 x5 0000007c34dbc79c x6 0000002f0000083b x7 000003c300002dd5
10-20 03:07:25.190 24710 24710 F DEBUG : x8 0000000000000001 x9 0000000000000004 x10 0000000000000010 x11 0000000000000000
10-20 03:07:25.190 24710 24710 F DEBUG : x12 0000000000000000 x13 000000000000217e x14 0000007acf9932a8 x15 000000000000217e
10-20 03:07:25.190 24710 24710 F DEBUG : x16 0000000000000000 x17 0000007d9a564c78 x18 0000007a6ef18000 x19 0000007c34dbc580
10-20 03:07:25.190 24710 24710 F DEBUG : x20 0000007ca4dc7170 x21 0000007ca4dc7800 x22 0000007ca4dc71e0 x23 0000000000000000
10-20 03:07:25.190 24710 24710 F DEBUG : x24 0000000000000018 x25 0000000000000007 x26 0000000000000006 x27 0000000000000004
10-20 03:07:25.190 24710 24710 F DEBUG : x28 0000007ca4dc7090 x29 0000007cb4da9940
10-20 03:07:25.190 24710 24710 F DEBUG : lr 0000007a770a9624 sp 0000007a6f7de9c0 pc 0000007a770a96a8 pst 0000000020000000
10-20 03:07:25.190 24710 24710 F DEBUG : backtrace:
10-20 03:07:25.190 24710 24710 F DEBUG : #00 pc 00000000000386a8 /data/app/~~KjjULZV48O7KSOgOP1wYNQ==/com.example.myapplication-vFUidUPTjaGg4oo3SRAYJw==/lib/arm64/liblanguage_id_l2c_jni.so (BuildId: be6e59455cc10135330c93acdebfc121)
10-20 03:07:25.190 24710 24710 F DEBUG : #01 pc 00000000000388a0 /data/app/~~KjjULZV48O7KSOgOP1wYNQ==/com.example.myapplication-vFUidUPTjaGg4oo3SRAYJw==/lib/arm64/liblanguage_id_l2c_jni.so (BuildId: be6e59455cc10135330c93acdebfc121)
10-20 03:07:25.190 24710 24710 F DEBUG : #02 pc 00000000000844a0 /data/app/~~KjjULZV48O7KSOgOP1wYNQ==/com.example.myapplication-vFUidUPTjaGg4oo3SRAYJw==/lib/arm64/liblanguage_id_l2c_jni.so (BuildId: be6e59455cc10135330c93acdebfc121)
10-20 03:07:25.190 24710 24710 F DEBUG : #03 pc 000000000008783c /data/app/~~KjjULZV48O7KSOgOP1wYNQ==/com.example.myapplication-vFUidUPTjaGg4oo3SRAYJw==/lib/arm64/liblanguage_id_l2c_jni.so (BuildId: be6e59455cc10135330c93acdebfc121)
10-20 03:07:25.190 24710 24710 F DEBUG : #04 pc 0000000000035fc4 /data/app/~~KjjULZV48O7KSOgOP1wYNQ==/com.example.myapplication-vFUidUPTjaGg4oo3SRAYJw==/lib/arm64/liblanguage_id_l2c_jni.so (BuildId: be6e59455cc10135330c93acdebfc121)
10-20 03:07:25.190 24710 24710 F DEBUG : #05 pc 0000000000034954 /data/app/~~KjjULZV48O7KSOgOP1wYNQ==/com.example.myapplication-vFUidUPTjaGg4oo3SRAYJw==/lib/arm64/liblanguage_id_l2c_jni.so (BuildId: be6e59455cc10135330c93acdebfc121)
10-20 03:07:25.190 24710 24710 F DEBUG : #06 pc 00000000000340e8 /data/app/~~KjjULZV48O7KSOgOP1wYNQ==/com.example.myapplication-vFUidUPTjaGg4oo3SRAYJw==/lib/arm64/liblanguage_id_l2c_jni.so (Java_com_google_mlkit_nl_languageid_internal_ThickLanguageIdentifier_nativeIdentifyPossibleLanguages+108) (BuildId: be6e59455cc10135330c93acdebfc121)
10-20 03:07:25.191 24710 24710 F DEBUG : #07 pc 00000000002d9a44 /apex/com.android.art/lib64/libart.so (art_quick_generic_jni_trampoline+148) (BuildId: cdecb8dde1264c9871695c29854aa3b1)
10-20 03:07:25.191 24710 24710 F DEBUG : #08 pc 000000000020a700 /apex/com.android.art/lib64/libart.so (nterp_helper+5648) (BuildId: cdecb8dde1264c9871695c29854aa3b1)
10-20 03:07:25.191 24710 24710 F DEBUG : #09 pc 00000000000cd0dc /data/app/~~KjjULZV48O7KSOgOP1wYNQ==/com.example.myapplication-vFUidUPTjaGg4oo3SRAYJw==/oat/arm64/base.vdex
10-20 03:07:25.191 24710 24710 F DEBUG : #10 pc 000000000020a044 /apex/com.android.art/lib64/libart.so (nterp_helper+3924) (BuildId: cdecb8dde1264c9871695c29854aa3b1)
10-20 03:07:25.191 24710 24710 F DEBUG : #11 pc 00000000000ccfa8 /data/app/~~KjjULZV48O7KSOgOP1wYNQ==/com.example.myapplication-vFUidUPTjaGg4oo3SRAYJw==/oat/arm64/base.vdex
10-20 03:07:25.191 24710 24710 F DEBUG : #12 pc 0000000000557cb4 /system/framework/arm64/boot-framework.oat (android.os.Binder.transact+148) (BuildId: 43a571a0ad85d6451b47016336a541ecb0eb12bb)
10-20 03:07:25.191 24710 24710 F DEBUG : #13 pc 000000000020b53c /apex/com.android.art/lib64/libart.so (nterp_helper+9292) (BuildId: cdecb8dde1264c9871695c29854aa3b1)
10-20 03:07:25.191 24710 24710 F DEBUG : #14 pc 00000000000b7aba /data/app/~~KjjULZV48O7KSOgOP1wYNQ==/com.example.myapplication-vFUidUPTjaGg4oo3SRAYJw==/oat/arm64/base.vdex
10-20 03:07:25.191 24710 24710 F DEBUG : #15 pc 000000000020a044 /apex/com.android.art/lib64/libart.so (nterp_helper+3924) (BuildId: cdecb8dde1264c9871695c29854aa3b1)
10-20 03:07:25.191 24710 24710 F DEBUG : #16 pc 00000000000a7496 /data/app/~~KjjULZV48O7KSOgOP1wYNQ==/com.example.myapplication-vFUidUPTjaGg4oo3SRAYJw==/oat/arm64/base.vdex
10-20 03:07:25.191 24710 24710 F DEBUG : #17 pc 000000000020a044 /apex/com.android.art/lib64/libart.so (nterp_helper+3924) (BuildId: cdecb8dde1264c9871695c29854aa3b1)
10-20 03:07:25.191 24710 24710 F DEBUG : #18 pc 00000000000a7360 /data/app/~~KjjULZV48O7KSOgOP1wYNQ==/com.example.myapplication-vFUidUPTjaGg4oo3SRAYJw==/oat/arm64/base.vdex
10-20 03:07:25.191 24710 24710 F DEBUG : #19 pc 000000000020ae64 /apex/com.android.art/lib64/libart.so (nterp_helper+7540) (BuildId: cdecb8dde1264c9871695c29854aa3b1)
10-20 03:07:25.191 24710 24710 F DEBUG : #20 pc 000000000009e46c /data/app/~~KjjULZV48O7KSOgOP1wYNQ==/com.example.myapplication-vFUidUPTjaGg4oo3SRAYJw==/oat/arm64/base.vdex
10-20 03:07:25.191 24710 24710 F DEBUG : #21 pc 000000000020ae64 /apex/com.android.art/lib64/libart.so (nterp_helper+7540) (BuildId: cdecb8dde1264c9871695c29854aa3b1)
10-20 03:07:25.191 24710 24710 F DEBUG : #22 pc 00000000000d33d6 /data/app/~~KjjULZV48O7KSOgOP1wYNQ==/com.example.myapplication-vFUidUPTjaGg4oo3SRAYJw==/oat/arm64/base.vdex
10-20 03:07:25.191 24710 24710 F DEBUG : #23 pc 000000000020ae64 /apex/com.android.art/lib64/libart.so (nterp_helper+7540) (BuildId: cdecb8dde1264c9871695c29854aa3b1)
10-20 03:07:25.191 24710 24710 F DEBUG : #24 pc 000000000009df0a /data/app/~~KjjULZV48O7KSOgOP1wYNQ==/com.example.myapplication-vFUidUPTjaGg4oo3SRAYJw==/oat/arm64/base.vdex
10-20 03:07:25.191 24710 24710 F DEBUG : #25 pc 0000000000209124 /apex/com.android.art/lib64/libart.so (nterp_helper+52) (BuildId: cdecb8dde1264c9871695c29854aa3b1)
10-20 03:07:25.191 24710 24710 F DEBUG : #26 pc 000000000009e350 /data/app/~~KjjULZV48O7KSOgOP1wYNQ==/com.example.myapplication-vFUidUPTjaGg4oo3SRAYJw==/oat/arm64/base.vdex
10-20 03:07:25.191 24710 24710 F DEBUG : #27 pc 000000000037b9ac /apex/com.android.art/javalib/arm64/boot.oat (java.util.concurrent.ThreadPoolExecutor.runWorker+988) (BuildId: ab2bf4ec264efdb6c452a238be38fe624de826b8)
10-20 03:07:25.191 24710 24710 F DEBUG : #28 pc 00000000003751d4 /apex/com.android.art/javalib/arm64/boot.oat (java.util.concurrent.ThreadPoolExecutor$Worker.run+68) (BuildId: ab2bf4ec264efdb6c452a238be38fe624de826b8)
10-20 03:07:25.191 24710 24710 F DEBUG : #29 pc 000000000020aec4 /apex/com.android.art/lib64/libart.so (nterp_helper+7636) (BuildId: cdecb8dde1264c9871695c29854aa3b1)
10-20 03:07:25.191 24710 24710 F DEBUG : #30 pc 000000000009e370 /data/app/~~KjjULZV48O7KSOgOP1wYNQ==/com.example.myapplication-vFUidUPTjaGg4oo3SRAYJw==/oat/arm64/base.vdex
10-20 03:07:25.191 24710 24710 F DEBUG : #31 pc 00000000001bf35c /apex/com.android.art/javalib/arm64/boot.oat (java.lang.Thread.run+76) (BuildId: ab2bf4ec264efdb6c452a238be38fe624de826b8)
10-20 03:07:25.191 24710 24710 F DEBUG : #32 pc 00000000002d0164 /apex/com.android.art/lib64/libart.so (art_quick_invoke_stub+548) (BuildId: cdecb8dde1264c9871695c29854aa3b1)
10-20 03:07:25.191 24710 24710 F DEBUG : #33 pc 000000000031ccac /apex/com.android.art/lib64/libart.so (art::ArtMethod::Invoke(art::Thread*, unsigned int*, unsigned int, art::JValue*, char const*)+156) (BuildId: cdecb8dde1264c9871695c29854aa3b1)
10-20 03:07:25.191 24710 24710 F DEBUG : #34 pc 00000000003cf8a0 /apex/com.android.art/lib64/libart.so (art::JValue art::InvokeVirtualOrInterfaceWithJValues<art::ArtMethod*>(art::ScopedObjectAccessAlreadyRunnable const&, _jobject*, art::ArtMethod*, jvalue const*)+380) (BuildId: cdecb8dde1264c9871695c29854aa3b1)
10-20 03:07:25.191 24710 24710 F DEBUG : #35 pc 0000000000460894 /apex/com.android.art/lib64/libart.so (art::Thread::CreateCallback(void*)+992) (BuildId: cdecb8dde1264c9871695c29854aa3b1)
10-20 03:07:25.191 24710 24710 F DEBUG : #36 pc 00000000000b1910 /apex/com.android.runtime/lib64/bionic/libc.so (__pthread_start(void*)+264) (BuildId: ba489d4985c0cf173209da67405662f9)
10-20 03:07:25.191 24710 24710 F DEBUG : #37 pc 00000000000513f0 /apex/com.android.runtime/lib64/bionic/libc.so (__start_thread+64) (BuildId: ba489d4985c0cf173209da67405662f9)
sm...@gmail.com <sm...@gmail.com> #14
Cross-posted on R8 issue tracker.
sm...@gmail.com <sm...@gmail.com> #15
Hi,
Looks like we figured out the root cause in
For temporary workarounds for the existing SDKs, you need to add this rule
-keep class com.google.mlkit.nl.languageid.internal.LanguageIdentificationJni { *; }
for language-id 16.1.1
, and add this rule
-keep class com.google.mlkit.nl.languageid.internal.ThickLanguageIdentifier { *; }
for version language-id 17.0.0+
for the newer model.
We'll fix this issue in the upcoming release so that you'll not need these workarounds in the future release.
Thanks a lot for reporting this issue!
cd...@gmail.com <cd...@gmail.com> #16
Added workarounds in
cd...@gmail.com <cd...@gmail.com> #17
sc...@gmail.com <sc...@gmail.com> #18
I've recorded a video of it happening and attached. How can we triage this issue further to assist fixing it?
sc...@gmail.com <sc...@gmail.com> #19
tr...@google.com <tr...@google.com> #20
Thanks I'll give this a shot on the Galaxy S7. So far I have only been able to reproduce this issue once on the Galaxy S7 and never again, so if this method can reproduce the issue that should be sufficient to track down what's going on.
To double check with the original reporter, have you been able to reproduce this issue on any other device besides the Galaxy S7?
sc...@gmail.com <sc...@gmail.com> #21
sc...@gmail.com <sc...@gmail.com> #22
#20, Have you been able to reproduce it?
ap...@google.com <ap...@google.com> #23
Branch: androidx-master-dev
commit d28fa62279c51229945faf83faa421510e59a813
Author: Trevor McGuire <trevormcguire@google.com>
Date: Mon Dec 07 00:21:38 2020
Add CameraInfoInternal to UseCase#mergeConfigs()
This allows the CameraInfo to be used by the UseCase's onMergeConfig()
to make determinations about conflict resolutions.
This will be used to check for the existance of a quirk in ImageCapture
which will use a software encoding pipeline to create JPEGs.
Bug: 159831206
Test: UseCaseTest
Change-Id: I3bcf8b72a959b3d37364217a921c06b99776fe69
M camera/camera-camera2/src/test/java/androidx/camera/camera2/internal/Camera2DeviceSurfaceManagerTest.java
M camera/camera-camera2/src/test/java/androidx/camera/camera2/internal/SupportedSurfaceCombinationTest.java
M camera/camera-core/src/androidTest/java/androidx/camera/core/UseCaseTest.java
M camera/camera-core/src/main/java/androidx/camera/core/ImageCapture.java
M camera/camera-core/src/main/java/androidx/camera/core/Preview.java
M camera/camera-core/src/main/java/androidx/camera/core/UseCase.java
M camera/camera-core/src/main/java/androidx/camera/core/internal/CameraUseCaseAdapter.java
M camera/camera-testing/src/main/java/androidx/camera/testing/Configs.java
ap...@google.com <ap...@google.com> #24
Branch: androidx-master-dev
commit 11ef032d526d35e0b53e8dc7697c9d862616ecde
Author: Trevor McGuire <trevormcguire@google.com>
Date: Mon Dec 07 00:46:49 2020
Quirks#contains() for checking existence of quirks
Adds a contains() method to the Quirks class which checks for the
existance of a quirk in the Quirks container.
This will also allow checking for the existance of a quirk by its
superclass or superinterface, as long as the superclass or
superinterface is a quirk itself.
Bug: 159831206
Test: QuirksTest
Change-Id: I41fd9955916897a7af0438a0cc1c2f72df387c4a
M camera/camera-core/src/main/java/androidx/camera/core/impl/Quirks.java
M camera/camera-core/src/test/java/androidx/camera/core/impl/QuirksTest.java
ap...@google.com <ap...@google.com> #25
Branch: androidx-master-dev
commit 9e2c61d9df3d8962a133f386f0dbce97f95f3ff8
Author: Trevor McGuire <trevormcguire@google.com>
Date: Mon Dec 07 01:53:26 2020
Move CameraQuirks from Camera to CameraInfo
This allows quirks to be retrieved from CameraInfoInternal.
Since CameraInfoInternal is retrievable from CameraInternal, it can
still be retrieved from CameraInternal
Bug: 159831206
Test: N/A, simple move
Change-Id: Ib4457d14b0dbde26fcf7d4fd09df21624d7e9113
M camera/camera-camera2-pipe-integration/src/main/java/androidx/camera/camera2/pipe/integration/adapter/CameraInfoAdapter.kt
M camera/camera-camera2-pipe-integration/src/main/java/androidx/camera/camera2/pipe/integration/adapter/CameraInternalAdapter.kt
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/Camera2CameraImpl.java
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/Camera2CameraInfoImpl.java
M camera/camera-core/src/main/java/androidx/camera/core/impl/CameraInfoInternal.java
M camera/camera-core/src/main/java/androidx/camera/core/impl/CameraInternal.java
M camera/camera-testing/src/main/java/androidx/camera/testing/fakes/FakeCamera.java
M camera/camera-testing/src/main/java/androidx/camera/testing/fakes/FakeCameraInfoInternal.java
ap...@google.com <ap...@google.com> #26
Branch: androidx-master-dev
commit e2b6eece39593fc1952838048ba5e7349e48081f
Author: Trevor McGuire <trevormcguire@google.com>
Date: Mon Dec 07 00:28:41 2020
Utility in-memory EXIF writer class
Introduces ExifData and ExifOutputStream classes which are adapted from
ExifInterface in order to write EXIF in-memory. This was not possible
with ExifInterface as it requires a File or FileDescriptor to modify
EXIF values.
These new classes only support writing a subset of EXIF tags from
ExifInterface. Some other functionality removed includes writing
thumbnails/strips, support for XMP, and support for other formats
besides JPEG.
ExifOutputStream wraps another output stream to write ExifData directly
into the JPEG data. It is suitable as an output for
YuvImage.compressToJpeg() and Bitmap.compress().
This will be used by ImageCapture to write EXIF when encoding JPEGs
using a software JPEG encoder, but may be expanded/adapted later to
replace less efficient uses of ExifInterface which make use of temp
files.
Bug: 159831206
Test: ExifDataTest, ExifOutputStreamTest
Change-Id: Ided3d716348fa4871940524df40d35a93823ca1a
M camera/camera-core/build.gradle
A camera/camera-core/src/androidTest/java/androidx/camera/core/impl/utils/ExifOutputStreamTest.kt
A camera/camera-core/src/main/java/androidx/camera/core/impl/utils/ByteOrderedDataInputStream.java
A camera/camera-core/src/main/java/androidx/camera/core/impl/utils/ByteOrderedDataOutputStream.java
A camera/camera-core/src/main/java/androidx/camera/core/impl/utils/ExifAttribute.java
A camera/camera-core/src/main/java/androidx/camera/core/impl/utils/ExifData.java
A camera/camera-core/src/main/java/androidx/camera/core/impl/utils/ExifOutputStream.java
A camera/camera-core/src/main/java/androidx/camera/core/impl/utils/ExifTag.java
A camera/camera-core/src/main/java/androidx/camera/core/impl/utils/LongRational.java
A camera/camera-core/src/test/java/androidx/camera/core/impl/utils/ExifDataTest.kt
ap...@google.com <ap...@google.com> #27
Branch: androidx-master-dev
commit 1cc6a3d965b303a58dd1ebe99842c352afe8b34f
Author: Trevor McGuire <trevormcguire@google.com>
Date: Mon Dec 07 00:36:00 2020
ImageWriterCompat for specifying format
Adds ImageWriterCompat class which can be used to create an ImageWriter
with the ability to specify the format on API 26+. This functionality
could previously only be accessed on API 29.
This allows using an ImageWriter to write JPEGs to a JPEG ImageReader.
Bug: 159831206
Test: ImageWriterCompatTest
Change-Id: I02c4f6a3a5ceebe66e16e65b0abc526eef2bbd94
A camera/camera-core/src/main/java/androidx/camera/core/internal/compat/ImageWriterCompat.java
A camera/camera-core/src/main/java/androidx/camera/core/internal/compat/ImageWriterCompatApi26Impl.java
A camera/camera-core/src/main/java/androidx/camera/core/internal/compat/ImageWriterCompatApi29Impl.java
A camera/camera-core/src/main/java/androidx/camera/core/internal/compat/package-info.java
A camera/camera-core/src/test/java/androidx/camera/core/internal/compat/ImageWriterCompatTest.java
ap...@google.com <ap...@google.com> #28
Branch: androidx-master-dev
commit 3db0961cf57164c28f710934c8f86059a83b2d21
Author: Trevor McGuire <trevormcguire@google.com>
Date: Mon Dec 07 01:18:55 2020
Extract ExifData from ImageInfo
Adds ability to retrieve exif information from ImageInfo and put it
into an ExifData.Builder.
This will be used to generate software encoded JPEGs in ImageCapture
Bug: 159831206
Test: ./gradlew connectedCheck on 'heroqltevzw' (device affected by bug)
Change-Id: I8401816812103701260675c5aaa28b5b6c34722a
M camera/camera-camera2/build.gradle
M camera/camera-camera2/src/androidTest/java/androidx/camera/camera2/internal/Camera2CameraCaptureResultTest.java
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/Camera2CameraCaptureResult.java
M camera/camera-core/src/main/java/androidx/camera/core/ImageInfo.java
M camera/camera-core/src/main/java/androidx/camera/core/ImmutableImageInfo.java
M camera/camera-core/src/main/java/androidx/camera/core/impl/CameraCaptureResult.java
M camera/camera-core/src/main/java/androidx/camera/core/internal/CameraCaptureResultImageInfo.java
M camera/camera-testing/src/main/java/androidx/camera/testing/fakes/FakeImageInfo.java
ap...@google.com <ap...@google.com> #29
Branch: androidx-master-dev
commit 8e6500ea49a0c8b0ee9061c3f169326367308f2e
Author: Trevor McGuire <trevormcguire@google.com>
Date: Mon Dec 07 12:57:11 2020
Add output ImageFormat to ProcessingImageReader
Allows ProcessingImageReader to have differring input and output
formats.
This allows ProcessingImageReader to do image format conversion, such
as converting YUV to JPEG or RGB.
Bug: 159831206
Test: ./gradlew camera:camera-core:connectedCheck
Change-Id: Ib93c2727e1935cac324492578fb984a2e1a15769
M camera/camera-core/src/main/java/androidx/camera/core/ProcessingImageReader.java
M camera/camera-core/src/test/java/androidx/camera/core/ProcessingImageReaderTest.java
ap...@google.com <ap...@google.com> #30
Branch: androidx-master-dev
commit 6aa34a2b3faad8227b3311a8e372e4ccf7eaf462
Author: Trevor McGuire <trevormcguire@google.com>
Date: Mon Dec 07 23:32:41 2020
Add JpegHalCorruptImageQuirk and superinterface
Adds device quirk to workaround issue where HAL sometimes produces
corrupt JPEGs on SM-G930V back camera.
This is accomplished by adding a quirk interface called
SoftwareJpegEncodingPreferredQuirk, which is defined in camera-core and
can be subclassed in the camera implementation library.
JpegHalCorruptImageQuirk subclasses SoftwareJpegEncodingPreferredQuirk
in camera-camera2.
JpegHalCorruptImageQuirk is added to the CameraQuirks, and the
existence of the superinterface is checked in ImageCapture to
automatically enable software JPEG encoding on the device.
Relnote: "Workaround included for intermittent corrupt image data in
JPEGs on SM-G930V back-facing camera."
Bug: 159831206
Test: Manual reproduction steps on local SM-G930V no longer produce
issue.
Change-Id: I5aca54ce3ce8a5a50bc7b84175b2f0dbb7e706e2
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/quirk/CameraQuirks.java
A camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/quirk/JpegHalCorruptImageQuirk.java
M camera/camera-core/src/main/java/androidx/camera/core/ImageCapture.java
A camera/camera-core/src/main/java/androidx/camera/core/internal/compat/quirk/SoftwareJpegEncodingPreferredQuirk.java
ap...@google.com <ap...@google.com> #31
Branch: androidx-master-dev
commit 4be48010e316fe42a0acab3055f5ef4d93f5f4cf
Author: Trevor McGuire <trevormcguire@google.com>
Date: Mon Dec 07 22:46:56 2020
Software JPEG pipeline in ImageCapture
Adds a software JPEG pipeline to ImageCapture which can be used instead
of receiving JPEGs directly from the HAL. This can be used in
compatibility cases where problems may exist with JPEGs from the HAL
such as corrupted images. This could also be used in cases where
encoding JPEGs in software may be faster than using a HW JPEG encoder.
This pipeline will produce android.media.Image with type JPEG, but can
only be used on API 26+.
This feature can be enabled by using the hidden ImageCapture.Builder
option setSoftwareJpegEncoderRequested().
Bug: 159831206
Test: ./gradlew camera:camera-camera2:connectedCheck
Change-Id: I253fc0ffa285c3cd60681d396b68e08286dc6c95
M camera/camera-core/src/main/java/androidx/camera/core/ImageCapture.java
M camera/camera-core/src/main/java/androidx/camera/core/ProcessingImageReader.java
M camera/camera-core/src/main/java/androidx/camera/core/impl/ImageCaptureConfig.java
A camera/camera-core/src/main/java/androidx/camera/core/internal/YuvToJpegProcessor.java
M camera/camera-core/src/main/java/androidx/camera/core/internal/utils/ImageUtil.java
M camera/camera-testing/src/main/java/androidx/camera/testing/CameraUtil.java
sc...@gmail.com <sc...@gmail.com> #32
tr...@google.com <tr...@google.com> #33
This will be part of our mid-month December release next week.
Just a note on this bug for later reference:
The bug isn't exclusive to CameraX, but can be reproduced with Camera2. I've attached a version of Camera2Basic
(CameraXBasic
. The bug can be reliably reproduced with the following steps on an SM-G930V:
- Install attached
Camera2Basic
and (optionally) add to the home screen so it can be easily opened. - Restart the phone.
- Immediately launch
Camera2Basic
as soon as the phone starts. - As soon as the preview is displayed, rapidly press the shutter button for ~30 shots.
- Wait for all shots to finish (thumbnails should stop updating), you may see some green thumbnails while capturing.
- View the shots that were taken in the phone's gallery app. Some of the shots near the beginning of the burst of captures may exhibit the bug. If not, repeat all steps.
ap...@google.com <ap...@google.com> #34
Branch: androidx-main
commit 8768eb76402e8c3f4bed01d6c39a9548e7575726
Author: leo huang <leohuang@google.com>
Date: Sat Jan 09 06:26:06 2021
Add SM-G930T to JpegHalCorruptImageQuirk
The green image issue can also be observed on SM-G930T back camera.
Relnote: "Workaround included for intermittent corrupt image data in JPEGs on SM-G930T back-facing camera."
Bug: 159831206
Test: Manual test
Change-Id: I52001b98b8124fc9a3ee6b8c343225bb21881d12
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/quirk/JpegHalCorruptImageQuirk.java
er...@google.com <er...@google.com> #35
Closing this out. Thanks!
ap...@google.com <ap...@google.com> #36
Branch: androidx-main
commit a7c4eab91156e6d1e54a81c5cebdeb37348a1abe
Author: Tahsin Masrur <tahsinm@google.com>
Date: Wed Mar 01 15:24:57 2023
[CameraPipe] Add JpegHalCorruptImageQuirk
Quirk to workaround issue where HAL sometimes produces corrupt JPEGs. Ref:
Bug: 267558909
Test: JpegHalCorruptImageQuirkTest
Change-Id: I2f0c62d8db76306a689f4576fd5c5ef6c8573f02
M camera/camera-camera2-pipe-integration/src/main/java/androidx/camera/camera2/pipe/integration/compat/quirk/CameraQuirks.kt
A camera/camera-camera2-pipe-integration/src/main/java/androidx/camera/camera2/pipe/integration/compat/quirk/JpegHalCorruptImageQuirk.kt
A camera/camera-camera2-pipe-integration/src/test/java/androidx/camera/camera2/pipe/integration/compat/quirk/JpegHalCorruptImageQuirkTest.kt
Description
androidx.camera:camera-camera2:1.0.0-beta05
androidx.camera:camera-lifecycle:1.0.0-beta05
androidx.camera:camera-view:1.0.0-alpha12
CAMERA APPLICATION NAME AND VERSION: (Settings > Apps > (app name) > version)
1.0
ANDROID OS BUILD NUMBER: (Settings > About > Build number)
R16NW.G930VVRU8CRJ3
DEVICE NAME: (Nexus 5X, Samsung S6, etc)
Samsung Galaxy S7 (SM-G930V)
DESCRIPTION:
For some camera sessions CameraX will produce completely green images. In those sessions I see 20-30% of photos taken being completely green. In other sessions I see no issues.
LIST ANY EXPERIMENTAL FEATURES: (As an example - @ExperimentalCamera2Interop)
Unaware of any.
STEPS TO REPRODUCE:
1. Take photos in rapid succession
2. Save photos to media store
3. View photos
OBSERVED RESULTS:
Some photos appear completely green, others appear normal.
EXPECTED RESULTS:
All photos should appear normal
REPRODUCIBILITY: (5 of 5, 1 of 100, etc)
10 of 100
ADDITIONAL INFORMATION:
This issue is critical to my team, as users can't immediately review all photos and when taking several photos they may easily miss the green photos. This leads to critical loss of data.
I've attached a logcat grab for a session with 7 photos, 2 of which turned out green.
Please ignore the ADB logcat error "camera is closed" at the end of the capture, as I closed the camera too quick while it was still processing. I believe this is my own fault.
CODE FRAGMENTS (this will help us troubleshoot your issues):
// capture code - outputPath is null in all tests, which leads to saving to MediaStore:
// Create output options object which contains file + metadata
val contentValues = ContentValues().apply {
put(MediaStore.MediaColumns.DISPLAY_NAME, "Untitled")
put(MediaStore.MediaColumns.MIME_TYPE, "image/jpg")
}
// Create the output file option to store the captured image in MediaStore
val outputOptions = when (outputPath) {
null -> ImageCapture.OutputFileOptions
.Builder(
context.contentResolver,
MediaStore.Images.Media.EXTERNAL_CONTENT_URI,
contentValues
)
.build()
else -> ImageCapture.OutputFileOptions
.Builder(File(outputPath))
.build()
}
flashViewFinder()
val audio = getActivity().getSystemService(Context.AUDIO_SERVICE) as AudioManager
if (audio.ringerMode == AudioManager.RINGER_MODE_NORMAL) {
MediaActionSound().play(MediaActionSound.SHUTTER_CLICK);
}
// Setup image capture listener which is triggered after photo has
// been taken
imageCapture?.takePicture(
outputOptions, ContextCompat.getMainExecutor(getActivity()), object : ImageCapture.OnImageSavedCallback {
override fun onError(ex: ImageCaptureException) {
Log.e(TAG, "CameraView: Photo capture failed: ${ex.message}", ex)
promise.reject("E_CAPTURE_FAILED", "takePicture failed: ${ex.message}")
}
override fun onImageSaved(output: ImageCapture.OutputFileResults) {
try {
val savedUri = output.savedUri.toString()
onPictureTaken(savedUri)
Log.d(TAG, "CameraView: Photo capture succeeded: $savedUri")
val imageInfo = Arguments.createMap()
imageInfo.putString("uri", savedUri)
imageInfo.putString("id", output.savedUri?.path)
imageInfo.putString("name", output.savedUri?.lastPathSegment)
// imageInfo.putInt("size", null)
imageInfo.putInt("width", width)
imageInfo.putInt("height", height)
imageInfo.putString("path", output.savedUri?.path)
promise.resolve(imageInfo)
} catch(ex: Exception) {
Log.e(TAG, "Error while saving or decoding saved photo: ${ex.message}", ex)
promise.reject("E_ON_IMG_SAVED", "Error while reading saved photo: ${ex.message}")
}
}
})