Status Update
Comments
js...@google.com <js...@google.com> #2
I don't feel strongly, but intuitively I think maybe I'm with Clara and Matvei here - Default tells me it is used as a default parameter in a function. Presumably not all constants are defaults and default
tells me how the content is intended to be used, but it's also true that almost everything which is a constant is just a configurable default so ¯_(ツ)_/¯.
If we're going to get rid of the default
prefix, I'd be inclined to suggest that FooConstants
should be renamed to FooDefaults
for all Foo
where we want to get rid of the prefix. IIRC part of the reason FooConstants
was chose over FooDefaults
at API Council was specifically in consideration of the possibility that not all constants are defaults, and the desire to remain consistent with our naming for the Constants container across widgets, but happy to re-evaluate if people feel differently.
But again, I don't feel strongly, so happy with whatever you all decide.
lp...@google.com <lp...@google.com> #3
Latest thoughts are that we should move back to FooDefaults
since the values inside these objects are not constants (factory functions with default values, etc), and remove any default / constant prefix as it is redundant here.
ap...@google.com <ap...@google.com> #4
Branch: androidx-master-dev
commit bfdc10fdf728b1344934d2e193e16cf6700698ad
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Thu Dec 03 16:27:34 2020
Renames *Constants objects to *Defaults
These objects do not just hold constants, but can also hold values used in default values for parameters, such as ButtonDefaults.colors(). Naming these as default and removing the unecessary `default` prefix makes it more consistent with their use.
Fixes:
Test: updateApi
Relnote: "Renamed *Constants objects such as ButtonConstants to end with Defaults instead, such as ButtonDefaults. Also removes unecessary `default` prefix from properties in these new objects."
Change-Id: Ibb915f0fd06a9c99ae6791e85634d5aea49374f6
M compose/androidview/androidview/integration-tests/androidview-demos/src/main/java/androidx/compose/androidview/demos/ComplexInteractions.kt
M compose/desktop/desktop/samples/src/jvmMain/kotlin/androidx/compose/desktop/examples/example1/Main.kt
M compose/desktop/desktop/samples/src/jvmMain/kotlin/androidx/compose/desktop/examples/popupexample/AppContent.kt
M compose/integration-tests/docs-snippets/src/main/java/androidx/compose/integration/docs/preview/LayoutPreview.kt
M compose/integration-tests/docs-snippets/src/main/java/androidx/compose/integration/docs/theming/Theming.kt
M compose/material/material/api/current.txt
M compose/material/material/api/public_plus_experimental_current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/ButtonDemo.kt
M compose/material/material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/TabDemo.kt
M compose/material/material/samples/src/main/java/androidx/compose/material/samples/ButtonSamples.kt
M compose/material/material/samples/src/main/java/androidx/compose/material/samples/ProgressIndicatorSamples.kt
M compose/material/material/samples/src/main/java/androidx/compose/material/samples/SelectionControlsSamples.kt
M compose/material/material/samples/src/main/java/androidx/compose/material/samples/TabSamples.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/ButtonTest.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/FloatingActionButtonTest.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/SwitchScreenshotTest.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/TabTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/BackdropScaffold.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/BottomSheetScaffold.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Button.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Checkbox.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Drawer.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Elevation.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/FloatingActionButton.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/ListItem.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Menu.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/ModalBottomSheet.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/ProgressIndicator.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/RadioButton.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Scaffold.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Slider.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Snackbar.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/SwipeToDismiss.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Swipeable.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Switch.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Tab.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TabRow.kt
M navigation/navigation-compose/integration-tests/navigation-demos/src/main/java/androidx/navigation/compose/demos/NavByDeepLinkDemo.kt
M navigation/navigation-compose/integration-tests/navigation-demos/src/main/java/androidx/navigation/compose/demos/NavPopUpToDemo.kt
M navigation/navigation-compose/samples/src/main/java/androidx/navigation/compose/samples/NavigationSamples.kt
Description