Fixed
Status Update
Comments
an...@google.com <an...@google.com>
mo...@google.com <mo...@google.com> #2
Oh sorry, this should be marked as a feature request.
mo...@google.com <mo...@google.com>
ap...@google.com <ap...@google.com> #3
This is really easy to implement, and I've made a patch just by adapting the code for FabPosition.End
. The only thing is that I can't produce the screenshots for the testing code to use.
Could someone please have a look at this and try to merge it? The changes to actual Compose (not test) code are literally like this, it's so simple:
# androidx-main/compose/material/material/src/commonMain/kotlin/androidx/compose/material/BottomSheetScaffold.kt
401a402
> FabPosition.Start -> FabStartSpacing.roundToPx()
416a418
> private val FabStartSpacing = 16.dp
# androidx-main/compose/material/material/src/commonMain/kotlin/androidx/compose/material/Scaffold.kt
79a80,85
> * Position FAB at the bottom of the screen at the start, above the [BottomAppBar] (if it
> * exists)
> */
> Start,
>
> /**
265a272,277
> }
> else if (fabPosition == FabPosition.Start) {
> if (layoutDirection == LayoutDirection.Ltr) {
> FabSpacing.roundToPx()
> } else {
> layoutWidth - FabSpacing.roundToPx() - fabWidth
Thank you very much.
ap...@google.com <ap...@google.com> #4
Resetting assignee to `None` in preparation of the triage bash on Thursday June 17th. Please reach out to nickanthony@ if you have any questions.
mo...@google.com <mo...@google.com>
ap...@google.com <ap...@google.com> #5
Assigning to Max, it might be a good task to start rumping up on APIs
Description
Places where android.graphics.Matrix and android.graphics.RectF are used better be switched to using Compose's own portable abstractions.