crash by android.support.v7.widget.StaggeredGridLayoutManager$LazySpanLookup.invalidateAfter(StaggeredGridLayoutManager.java:2878) [160193663]

Fixed

Bug

NeedsInfo

Status Update

No update yet.

Description

gy...@gmail.com

created issue #1

Jun 30, 2020 07:12AM

android version:8.1.0
recyclerView- support.v7-28.0.0
Describe:
I try to update item count in RecyclerView (use StaggeredGridLayoutManager),which step is change the dataSet and invoke Adapter.notifyItemRangeInserted(int ,int) (notifyDataSetChanged will no crash but i can't use is because the staggere layout may be dislocated).This step can be invoked many times depends on http response(a http response will insert some items ,we invoke many times http request).Sometimes the application will crash but we have no idea why it is crash. The crash stack like this(full stack to see the file)

java.lang.ArrayIndexOutOfBoundsException: Array index out of range: 46
        at java.util.Arrays.rangeCheck(Arrays.java:123)
        at java.util.Arrays.fill(Arrays.java:2831)
        at android.support.v7.widget.StaggeredGridLayoutManager$LazySpanLookup.invalidateAfter(StaggeredGridLayoutManager.java:2878)
        at android.support.v7.widget.StaggeredGridLayoutManager.handleUpdate(StaggeredGridLayoutManager.java:1550)
        at android.support.v7.widget.StaggeredGridLayoutManager.onItemsAdded(StaggeredGridLayoutManager.java:1509)
        at android.support.v7.widget.RecyclerView$6.dispatchUpdate(RecyclerView.java:1010)
        at android.support.v7.widget.RecyclerView$6.onDispatchSecondPass(RecyclerView.java:1027)
        at android.support.v7.widget.AdapterHelper.consumeUpdatesInOnePass(AdapterHelper.java:563)
        at android.support.v7.widget.RecyclerView.processAdapterUpdatesAndSetAnimationFlags(RecyclerView.java:3585)
        at android.support.v7.widget.RecyclerView.dispatchLayoutStep1(RecyclerView.java:3829)
        at android.support.v7.widget.RecyclerView.dispatchLayout(RecyclerView.java:3639)
......
......

please tell me the solution to solve this problem and what is the LazySpanLookup,thanks very much.

deleted

Restricted

0 B

Comments

vi...@google.com <vi...@google.com> Jun 30, 2020 07:29AM

Assigned to vi...@google.com.

vi...@google.com <vi...@google.com> #2Jun 30, 2020 08:42AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019

Change the way to detect mismatch between POJO and query

This fixes cursor mismatch warnings with expandProjection.

Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258

https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

gy...@gmail.com <gy...@gmail.com> #3Jul 1, 2020 08:53AM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
Created: 2019-10-14 17:23:42.610596+00:00
Changes: aosp/1123258

gy...@gmail.com <gy...@gmail.com> #4Jul 2, 2020 10:06AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020

Re-factor how errors are dismissed when query is re-written

This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (

b/140759491

).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.

This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.

Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

deleted

Restricted

0 B

vi...@google.com <vi...@google.com> #5Jul 8, 2020 01:17PM

Sample project throws an error: "Installation failed due to 'null' " . Please check and share the sample project again.

vi...@google.com <vi...@google.com> #6Jul 17, 2020 07:20AM

We are still waiting for the sample project requested above. Kindly share with us.

sh...@google.com <sh...@google.com> #7Jul 21, 2020 09:01PM

Marked as fixed.

Fixed via https://android.googlesource.com/platform/frameworks/support/+/49b601979ebccb8fcc6b8d670b79ae1c5f818dbf