crash by android.support.v7.widget.StaggeredGridLayoutManager$LazySpanLookup.invalidateAfter(StaggeredGridLayoutManager.java:2878) [160193663]

Fixed

Bug

NeedsInfo

Status Update

No update yet.

Description

gy...@gmail.com

created issue #1

Jun 30, 2020 07:12AM

android version:8.1.0
recyclerView- support.v7-28.0.0
Describe:
I try to update item count in RecyclerView (use StaggeredGridLayoutManager),which step is change the dataSet and invoke Adapter.notifyItemRangeInserted(int ,int) (notifyDataSetChanged will no crash but i can't use is because the staggere layout may be dislocated).This step can be invoked many times depends on http response(a http response will insert some items ,we invoke many times http request).Sometimes the application will crash but we have no idea why it is crash. The crash stack like this(full stack to see the file)

java.lang.ArrayIndexOutOfBoundsException: Array index out of range: 46
        at java.util.Arrays.rangeCheck(Arrays.java:123)
        at java.util.Arrays.fill(Arrays.java:2831)
        at android.support.v7.widget.StaggeredGridLayoutManager$LazySpanLookup.invalidateAfter(StaggeredGridLayoutManager.java:2878)
        at android.support.v7.widget.StaggeredGridLayoutManager.handleUpdate(StaggeredGridLayoutManager.java:1550)
        at android.support.v7.widget.StaggeredGridLayoutManager.onItemsAdded(StaggeredGridLayoutManager.java:1509)
        at android.support.v7.widget.RecyclerView$6.dispatchUpdate(RecyclerView.java:1010)
        at android.support.v7.widget.RecyclerView$6.onDispatchSecondPass(RecyclerView.java:1027)
        at android.support.v7.widget.AdapterHelper.consumeUpdatesInOnePass(AdapterHelper.java:563)
        at android.support.v7.widget.RecyclerView.processAdapterUpdatesAndSetAnimationFlags(RecyclerView.java:3585)
        at android.support.v7.widget.RecyclerView.dispatchLayoutStep1(RecyclerView.java:3829)
        at android.support.v7.widget.RecyclerView.dispatchLayout(RecyclerView.java:3639)
......
......

please tell me the solution to solve this problem and what is the LazySpanLookup,thanks very much.

deleted

Restricted

0 B

Comments

vi...@google.com <vi...@google.com> Jun 30, 2020 07:29AM

Assigned to vi...@google.com.

vi...@google.com <vi...@google.com> #2Jun 30, 2020 08:42AM

My guess is an AutoValue extension is what's needed here:

http://ryanharter.com/blog/2016/05/16/autovalue-extensions/

We accept pull requests! :)

gy...@gmail.com <gy...@gmail.com> #3Jul 1, 2020 08:53AM

> We accept pull requests! :)

Is there a public repo somewhere? I don't see any obvious repo for it in

https://android.googlesource.com, and it doesn't seem to be inside

https://android.googlesource.com/platform/frameworks/support.

Room supports final fields (yay!), which probably will suffice for many people with respect to this feature request.

gy...@gmail.com <gy...@gmail.com> #4Jul 2, 2020 10:06AM

Room supports immutability (it can use arg constructors) but does not directly support AutoValue. It is in the schedule but not high priority :/. Idk much about its internals at this stage so I'm not sure how we would implement it but should be totally doable.

Sorry we don't have the source release yet :/.

deleted

Restricted

0 B

vi...@google.com <vi...@google.com> #5Jul 8, 2020 01:17PM

"It is in the schedule but not high priority" -- completely understandable.

"Sorry we don't have the source release yet :/." -- ah, OK, I thought perhaps with the pull request comment, that meant that there was a repo somewhere that I had overlooked.

Thanks!

vi...@google.com <vi...@google.com> #6Jul 17, 2020 07:20AM

Add autovalue support also means you can easily achieve parcelable by

https://github.com/rharter/auto-value-parcel. Please consider support this.

sh...@google.com <sh...@google.com> #7Jul 21, 2020 09:01PM

Marked as fixed.

AutoValue is really a handy way to ensure data integrity.