Fixed
Status Update
Comments
du...@google.com <du...@google.com> #2
Thanks for reporting this!
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 39c3760790bfce0cd067811061baf8fae804b90e
Author: Dustin Lam <dustinlam@google.com>
Date: Tue Jun 30 14:15:23 2020
Give retried hints priority over prefetchDistance
RelNote: "Fix for a bug where sometimes scrolling after
PagingSource returns an error could prevent PagingDataAdapter.retry()
from retrying."
Fixes: 160194384
Test: ./gradlew paging:paging-common:test
Change-Id: I1084fdc5d66254bbbcaa87e154ccab1dbffd54db
M paging/common/src/main/kotlin/androidx/paging/PageFetcherSnapshot.kt
M paging/common/src/test/kotlin/androidx/paging/PageFetcherSnapshotTest.kt
https://android-review.googlesource.com/1353451
Branch: androidx-master-dev
commit 39c3760790bfce0cd067811061baf8fae804b90e
Author: Dustin Lam <dustinlam@google.com>
Date: Tue Jun 30 14:15:23 2020
Give retried hints priority over prefetchDistance
RelNote: "Fix for a bug where sometimes scrolling after
PagingSource returns an error could prevent PagingDataAdapter.retry()
from retrying."
Fixes: 160194384
Test: ./gradlew paging:paging-common:test
Change-Id: I1084fdc5d66254bbbcaa87e154ccab1dbffd54db
M paging/common/src/main/kotlin/androidx/paging/PageFetcherSnapshot.kt
M paging/common/src/test/kotlin/androidx/paging/PageFetcherSnapshotTest.kt
ma...@justpinch.com <ma...@justpinch.com> #4
Great! I can confirm the issue no longer persists with this change. Superb turnaround time!
Description
Component used: Paging 3.0.0
Version used: alpha02
Devices/Android versions reproduced on: Nokia 7.1/Android 10
Steps to reproduce:
step11_loading_state
:alpha02
IOException
, use airplane mode etc)Sample project illustrating the problem attached for convenience.
I've confirmed the retry call makes it all the way up to
PageFetcherSnapshot
and is collected fromretryChannel
. From there I got lost in the world of suspend functions and breakpoints without any useful context...Further observations:
alpha01
.FAIL
toON_INITIAL_LOAD
inGithubPagingSource
to confirm)