Retry does not work after initial load [160194384]

Fixed

Bug

Status Update

No update yet.

Description

ma...@justpinch.com

created issue #1

Jun 30, 2020 04:17PM

Component used: Paging 3.0.0
Version used: alpha02
Devices/Android versions reproduced on: Nokia 7.1/Android 10

Steps to reproduce:

Clone the paging codelab on branch step11_loading_state: https://github.com/googlecodelabs/android-paging/tree/step11_loading_state
Update to the paging version to alpha02
Compile & launch sample app
Make the data load that fetches the 2nd page of Github repos fail (e.g. throw an IOException, use airplane mode etc)
Scroll all the way down to the "Retry" button
Observe nothing appears to happen when tapping the retry button

Sample project illustrating the problem attached for convenience.

I've confirmed the retry call makes it all the way up to PageFetcherSnapshot and is collected from retryChannel. From there I got lost in the world of suspend functions and breakpoints without any useful context...

Further observations:

Could not reproduce this issue with version alpha01.
Retry works as expected when the initial data load fails (set FAIL to ON_INITIAL_LOAD in GithubPagingSource to confirm)

android-paging-sample-retry-broken-on-alpha02.zip

166 KB

Download

Comments

du...@google.com <du...@google.com> #2Jun 30, 2020 09:17PM

Some things to work out before making the annotations type-use:

Determine guidelines for type nullability in public API
Determine rules for when type nullability can change in public API
Confirm that intellij nullability lint works as expected for type-use nullability annotations
Test what the impact would be on existing arrays (due to ambiguities of type-use annotations on arrays)
Confirm usage of type-use androidx.annotation.NonNull/Nullable in metalava won't break anything for platform

ap...@google.com <ap...@google.com> #3Jul 1, 2020 06:31PM

Marked as fixed.

Plan for making the annotations type-use: https://docs.google.com/document/d/1tNqV9Dgtii6wvulm8emjs0bwgSL3Fwf3F4LFXfVeyTU/edit

ma...@justpinch.com <ma...@justpinch.com> #4Jul 2, 2020 06:13AM

Tracking sheet for which projects have been migrated.

Issue 160194384

Description

Issue summary

Comments

du...@google.com <du...@google.com> #2Jun 30, 2020 09:17PM

ap...@google.com <ap...@google.com> #3Jul 1, 2020 06:31PM

ma...@justpinch.com <ma...@justpinch.com> #4Jul 2, 2020 06:13AM

Add comment

Issue metadata