Fixed
Status Update
No update yet.
Comments
po...@google.com
I've been working these days on supporting Compose inside ViewGroups which is what we need to remove setViewContent. I will reassign this to me if you don't mind!
po...@google.com
Actually removing setViewContent was not blocked on this, sorry for the confusion. Happy to take care of this nonetheless, let me know :)
po...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit b469c2ff83c9b67999ca63bbf73e542736b41534
Author: Mihai Popa <popam@google.com>
Date: Wed Jul 29 12:38:51 2020
Deprecate setViewContent
Relnote: setViewContent was deprecated. setContent should be used instead.
Bug: 160335130
Test: ./gradlew buildOnServer
Change-Id: I7e49740d26f42e9326cb5582a4522d74957b90fe
M compose/compose-runtime/src/androidAndroidTest/kotlin/androidx/compose/runtime/BaseComposeTest.kt
M ui/ui-android-view/integration-tests/android-view-demos/src/main/java/androidx/ui/androidview/demos/WebComponentActivity.kt
M ui/ui-android-view/src/main/java/androidx/ui/androidview/adapters/ArrayAdapter.kt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidMain/kotlin/androidx/compose/ui/platform/Wrapper.kt
https://android-review.googlesource.com/1374984
Branch: androidx-master-dev
commit b469c2ff83c9b67999ca63bbf73e542736b41534
Author: Mihai Popa <popam@google.com>
Date: Wed Jul 29 12:38:51 2020
Deprecate setViewContent
Relnote: setViewContent was deprecated. setContent should be used instead.
Bug: 160335130
Test: ./gradlew buildOnServer
Change-Id: I7e49740d26f42e9326cb5582a4522d74957b90fe
M compose/compose-runtime/src/androidAndroidTest/kotlin/androidx/compose/runtime/BaseComposeTest.kt
M ui/ui-android-view/integration-tests/android-view-demos/src/main/java/androidx/ui/androidview/demos/WebComponentActivity.kt
M ui/ui-android-view/src/main/java/androidx/ui/androidview/adapters/ArrayAdapter.kt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidMain/kotlin/androidx/compose/ui/platform/Wrapper.kt
po...@google.com
I will close this as fixed, will handle the removal of the API separately and Adam is working on the ViewGroup.setContent refactoring.
Description
Version used:
Devices/Android versions reproduced on:
If this is a bug in the library, we would appreciate if you could attach:
- Sample project to trigger the issue.
- A screenrecord or screenshots showing the issue (if UI related).