Remove setViewContent APIs and refactor ViewGroup.setContent to be more consistent [160335130]

Fixed

Bug

Status Update

No update yet.

Description

le...@google.com

created issue #1

Jul 1, 2020 06:48PM

Component used:
Version used:
Devices/Android versions reproduced on:

If this is a bug in the library, we would appreciate if you could attach:
- Sample project to trigger the issue.
- A screenrecord or screenshots showing the issue (if UI related).

Comments

po...@google.com <po...@google.com> #2Jul 3, 2020 01:59PM

Reassigned to po...@google.com.

Project: platform/frameworks/support
Branch: androidx-main

commit 5534f4a73789b7cf56b5219efab704cb7fd056e0
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Thu Feb 04 14:03:00 2021

Deletes deprecated Material, Foundation, and Ambient* related APIs

Also renames Ambients.kt and AndroidAmbients.kt to CompositionLocals.kt and AndroidCompositionLocals.kt

Fixes:

b/178633932

Test: updateApi
Relnote: "Deleted some previously deprecated APIs"
Change-Id: Ice5dae36591015a9d905b84b26cc02662385d831

M compose/foundation/foundation-layout/api/current.txt
M compose/foundation/foundation-layout/api/public_plus_experimental_current.txt
M compose/foundation/foundation-layout/api/restricted_current.txt
D compose/foundation/foundation-layout/integration-tests/layout-demos/src/main/java/androidx/compose/foundation/layout/demos/ConstraintLayoutDemo.kt
M compose/foundation/foundation-layout/integration-tests/layout-demos/src/main/java/androidx/compose/foundation/layout/demos/LayoutDemos.kt
D compose/foundation/foundation-layout/samples/src/main/java/androidx/compose/foundation/layout/samples/ConstraintLayoutSample.kt
D compose/foundation/foundation-layout/src/androidAndroidTest/kotlin/androidx/compose/foundation/layout/ConstraintLayoutTest.kt
D compose/foundation/foundation-layout/src/androidMain/kotlin/androidx/compose/foundation/layout/ConstraintLayout.kt
M compose/foundation/foundation-layout/src/commonMain/kotlin/androidx/compose/foundation/layout/AlignmentLine.kt
M compose/foundation/foundation-layout/src/commonMain/kotlin/androidx/compose/foundation/layout/Column.kt
D compose/foundation/foundation-layout/src/commonMain/kotlin/androidx/compose/foundation/layout/Flow.kt
M compose/foundation/foundation-layout/src/commonMain/kotlin/androidx/compose/foundation/layout/Offset.kt
M compose/foundation/foundation-layout/src/commonMain/kotlin/androidx/compose/foundation/layout/Row.kt
M compose/foundation/foundation-layout/src/commonMain/kotlin/androidx/compose/foundation/layout/RowColumnImpl.kt
M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/public_plus_experimental_current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/ListDemos.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/selection/SelectionContainerFocusTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Indication.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Scroll.kt
D compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/LazyFor.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/BasicTextField.kt
M compose/foundation/foundation/src/desktopMain/kotlin/androidx/compose/foundation/animation/AndroidFlingCalculator.kt
M compose/integration-tests/docs-snippets/src/main/java/androidx/compose/integration/docs/kotlin/Kotlin.kt
M compose/integration-tests/docs-snippets/src/main/java/androidx/compose/integration/docs/layout/Layout.kt
M compose/material/material-ripple/api/current.txt
M compose/material/material-ripple/api/public_plus_experimental_current.txt
M compose/material/material-ripple/api/restricted_current.txt
M compose/material/material-ripple/src/commonMain/kotlin/androidx/compose/material/ripple/RippleTheme.kt
M compose/material/material/api/current.txt
M compose/material/material/api/public_plus_experimental_current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/src/androidMain/kotlin/androidx/compose/material/AlertDialog.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/ContentAlpha.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/ContentColor.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Elevation.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/ElevationOverlay.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/OutlinedTextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Tab.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Text.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextField.kt
M compose/runtime/runtime-saveable/api/current.txt
M compose/runtime/runtime-saveable/api/public_plus_experimental_current.txt
M compose/runtime/runtime-saveable/api/restricted_current.txt
D compose/runtime/runtime-saveable/src/commonMain/kotlin/androidx/compose/runtime/savedinstancestate/Deprecated.kt
M compose/runtime/runtime/api/current.txt
M compose/runtime/runtime/api/public_plus_experimental_current.txt
M compose/runtime/runtime/api/restricted_current.txt
M compose/runtime/runtime/src/commonMain/kotlin/androidx/compose/runtime/CompositionLocal.kt
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/public_plus_experimental_current.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidCompositionLocals.kt
D compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/platform/Ambients.kt
A compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/platform/CompositionLocals.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/platform/InspectionMode.kt
M compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/window/DesktopPopup.kt

https://android-review.googlesource.com/1575163

po...@google.com <po...@google.com> #3Jul 3, 2020 03:30PM

Reassigned to le...@google.com.

Actually removing setViewContent was not blocked on this, sorry for the confusion. Happy to take care of this nonetheless, let me know :)

po...@google.com <po...@google.com> Jul 9, 2020 03:51PM

Reassigned to po...@google.com.

ap...@google.com <ap...@google.com> #4Jul 30, 2020 03:09AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b469c2ff83c9b67999ca63bbf73e542736b41534
Author: Mihai Popa <popam@google.com>
Date: Wed Jul 29 12:38:51 2020

Deprecate setViewContent

Relnote: setViewContent was deprecated. setContent should be used instead.
Bug: 160335130
Test: ./gradlew buildOnServer
Change-Id: I7e49740d26f42e9326cb5582a4522d74957b90fe

M compose/compose-runtime/src/androidAndroidTest/kotlin/androidx/compose/runtime/BaseComposeTest.kt
M ui/ui-android-view/integration-tests/android-view-demos/src/main/java/androidx/ui/androidview/demos/WebComponentActivity.kt
M ui/ui-android-view/src/main/java/androidx/ui/androidview/adapters/ArrayAdapter.kt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidMain/kotlin/androidx/compose/ui/platform/Wrapper.kt

https://android-review.googlesource.com/1374984

po...@google.com <po...@google.com> #5Jul 31, 2020 10:09AM

Marked as fixed.

I will close this as fixed, will handle the removal of the API separately and Adam is working on the ViewGroup.setContent refactoring.

Issue 160335130