Fixed
Status Update
Comments
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 682f397abe72d5217d17fe6f24b8d3836915e75e
Author: Mihai Popa <popam@google.com>
Date: Fri Jul 03 14:38:04 2020
Support Compose in ViewGroups during composition
The CL adds support for composing LayoutNodes inside ViewGroup parents
during the same composition, without requiring a new composition.
Also, to make the new tests pass, the CL fixes the handling of
View#forceLayout() for Views inside Compose.
Relnote: Compose UI can now be composed inside ViewGroups without requiring a new composition. See ViewInteropDemo for an example.
Bug: 160455080
Change-Id: I9ab0b3ff5febce27c34e81dd55e3dce6ea1aa742
M ui/ui-core/integration-tests/ui-core-demos/src/main/java/androidx/ui/core/demos/CoreDemos.kt
M ui/ui-core/integration-tests/ui-core-demos/src/main/java/androidx/ui/core/demos/viewinterop/ViewInterop.kt
M ui/ui-core/integration-tests/ui-core-demos/src/main/java/androidx/ui/core/demos/viewinterop/ViewRef.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/core/test/AndroidViewCompatTest.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidViewsHandler.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/node/UiApplier.kt
https://android-review.googlesource.com/1355262
Branch: androidx-master-dev
commit 682f397abe72d5217d17fe6f24b8d3836915e75e
Author: Mihai Popa <popam@google.com>
Date: Fri Jul 03 14:38:04 2020
Support Compose in ViewGroups during composition
The CL adds support for composing LayoutNodes inside ViewGroup parents
during the same composition, without requiring a new composition.
Also, to make the new tests pass, the CL fixes the handling of
View#forceLayout() for Views inside Compose.
Relnote: Compose UI can now be composed inside ViewGroups without requiring a new composition. See ViewInteropDemo for an example.
Bug: 160455080
Change-Id: I9ab0b3ff5febce27c34e81dd55e3dce6ea1aa742
M ui/ui-core/integration-tests/ui-core-demos/src/main/java/androidx/ui/core/demos/CoreDemos.kt
M ui/ui-core/integration-tests/ui-core-demos/src/main/java/androidx/ui/core/demos/viewinterop/ViewInterop.kt
M ui/ui-core/integration-tests/ui-core-demos/src/main/java/androidx/ui/core/demos/viewinterop/ViewRef.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/core/test/AndroidViewCompatTest.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidViewsHandler.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/node/UiApplier.kt
Description
Currently this is crashing: Box { emitView(::FrameLayout, {}) { Box() } }