Support for ThreadLocal.withInitial(java.util.function.Supplier) [160484830]

Verified

Feature Request

Status Update

No update yet.

Description

ja...@jamesonwilliams.com

created issue #1

Jul 4, 2020 07:38PM

What I'm Doing

I am trying to use core library desugaring with Android Studio 4.0.0. I use AGP 4.0.0, Gradle 6.5.1.

I am using an Android 5 (API 21) device.

I have:

dependencies {
    coreLibraryDesugaring 'com.android.tools:desugar_jdk_libs:1.0.9'
    implementation 'software.amazon.awssdk:iot:2.13.50'
    implementation 'software.amazon.awssdk:url-connection-client:2.13.50'
}

And:

android {
    compileOptions {
        coreLibraryDesugaringEnabled true
        sourceCompatibility JavaVersion.VERSION_1_8
        targetCompatibility JavaVersion.VERSION_1_8
    }
}

I include some simple code:

IotClient iot = IotClient.builder()
    .region(Region.US_EAST_1)
    .httpClient(UrlConnectionHttpClient.create())
    .credentialsProvider(StaticCredentialsProvider.create(myCredentials))
    .build();

What Goes Wrong

This will build, and install. But, at runtime, on the API 21 device, the application crashes:

     Caused by: java.lang.NoClassDefFoundError: $r8$wrapper$java$util$function$Supplier$-WRP
        at software.amazon.awssdk.auth.signer.internal.AbstractAwsSigner.<clinit>(AbstractAwsSigner.java:58)
        at software.amazon.awssdk.services.iot.DefaultIotBaseClientBuilder.defaultSigner(DefaultIotBaseClientBuilder.java:61)
        at software.amazon.awssdk.services.iot.DefaultIotBaseClientBuilder.lambda$mergeServiceDefaults$0$DefaultIotBaseClientBuilder(DefaultIotBaseClientBuilder.java:47)
        at software.amazon.awssdk.services.iot.-$$Lambda$DefaultIotBaseClientBuilder$RuCpp-IDGbLR4J35FYb1MSqjp84.accept(lambda)
        at software.amazon.awssdk.utils.builder.SdkBuilder$-CC.$default$applyMutation(SdkBuilder.java:61)
        at software.amazon.awssdk.core.client.config.SdkClientConfiguration$Builder.applyMutation(SdkClientConfiguration.java)
        at software.amazon.awssdk.core.client.config.SdkClientConfiguration.merge(SdkClientConfiguration.java:66)
        at software.amazon.awssdk.services.iot.DefaultIotBaseClientBuilder.mergeServiceDefaults(DefaultIotBaseClientBuilder.java:47)
        at software.amazon.awssdk.awscore.client.builder.AwsDefaultClientBuilder.mergeChildDefaults(AwsDefaultClientBuilder.java:114)
        at software.amazon.awssdk.core.client.builder.SdkDefaultClientBuilder.syncClientConfiguration(SdkDefaultClientBuilder.java:148)
        at software.amazon.awssdk.services.iot.DefaultIotClientBuilder.buildClient(DefaultIotClientBuilder.java:27)
        at software.amazon.awssdk.services.iot.DefaultIotClientBuilder.buildClient(DefaultIotClientBuilder.java:22)
        at software.amazon.awssdk.core.client.builder.SdkDefaultClientBuilder.build(SdkDefaultClientBuilder.java:124)

Why It Goes Wrong (Maybe)

The line it is unhappy about is in ThreadLocal's withInitial static method, which takes a java.util.function.Supplier.

ThreadLocal is NOT listed in the Java 8 language support table, here.

Additional Information

The build did include copious warnings.


> Transform artifact desugar_jdk_libs_configuration-0.11.1.jar (com.android.tools:desugar_jdk_libs_configuration:0.11.1) with L8DexDesugarLibTransform
Warning: Type `j$.util.Optional` was not found, it is required for default or static interface methods desugaring of `j$.util.Optional j$.util.OptionalConversions.convert(java.util.Optional)`
Warning: Type `j$.util.OptionalDouble` was not found, it is required for default or static interface methods desugaring of `j$.util.OptionalDouble j$.util.OptionalConversions.convert(java.util.OptionalDouble)`
Warning: Type `j$.util.OptionalLong` was not found, it is required for default or static interface methods desugaring of `j$.util.OptionalLong j$.util.OptionalConversions.convert(java.util.OptionalLong)`
Warning: Type `j$.util.OptionalInt` was not found, it is required for default or static interface methods desugaring of `j$.util.OptionalInt j$.util.OptionalConversions.convert(java.util.OptionalInt)`
Warning: Type `j$.time.ZonedDateTime` was not found, it is required for default or static interface methods desugaring of `j$.time.ZonedDateTime j$.time.TimeConversions.convert(java.time.ZonedDateTime)`
Warning: Type `j$.time.ZoneId` was not found, it is required for default or static interface methods desugaring of `j$.time.ZoneId j$.time.TimeConversions.convert(java.time.ZoneId)`
Warning: Type `j$.time.MonthDay` was not found, it is required for default or static interface methods desugaring of `j$.time.MonthDay j$.time.TimeConversions.convert(java.time.MonthDay)`
Warning: Type `j$.time.Instant` was not found, it is required for default or static interface methods desugaring of `j$.time.Instant j$.time.TimeConversions.convert(java.time.Instant)`
Warning: Type `j$.time.LocalDate` was not found, it is required for default or static interface methods desugaring of `j$.time.LocalDate j$.time.TimeConversions.convert(java.time.LocalDate)`
Warning: Type `j$.time.Duration` was not found, it is required for default or static interface methods desugaring of `j$.time.Duration j$.time.TimeConversions.convert(java.time.Duration)`
Warning: Type `j$.util.DesugarGregorianCalendar` was not found, it is required for default or static interface methods desugaring of `j$.time.ZonedDateTime j$.$r8$backportedMethods$utility$GregorianCalendar$toZonedDateTime$dispatchHolder.toZonedDateTime(java.util.GregorianCalendar)`
Warning: Type `j$.util.DesugarDate` was not found, it is required for default or static interface methods desugaring of `j$.time.Instant j$.$r8$backportedMethods$utility$Date$toInstant$dispatchHolder.toInstant(java.util.Date)`

> Transform artifact desugar_jdk_libs-1.0.5.jar (com.android.tools:desugar_jdk_libs:1.0.5) with L8DexDesugarLibTransform
Warning in /Users/jhwill/.gradle/caches/modules-2/files-2.1/com.android.tools/desugar_jdk_libs/1.0.5/359e5e4f4784f23beb30ba454b41f6f992e58481/desugar_jdk_libs-1.0.5.jar:java/util/stream/SpinedBuffer$OfPrimitive.class:
  Type `j$.$r8$wrapper$java$util$Spliterator$-WRP` was not found, it is required for default or static interface methods desugaring of `$-vivified-$.java.util.Spliterator java.util.stream.SpinedBuffer$OfPrimitive.spliterator()`
Warning in /Users/jhwill/.gradle/caches/modules-2/files-2.1/com.android.tools/desugar_jdk_libs/1.0.5/359e5e4f4784f23beb30ba454b41f6f992e58481/desugar_jdk_libs-1.0.5.jar:java/util/concurrent/ConcurrentHashMap.class:
  Type `j$.$r8$wrapper$java$util$function$BiFunction$-V-WRP` was not found, it is required for default or static interface methods desugaring of `java.lang.Object java.util.concurrent.ConcurrentHashMap.compute(java.lang.Object, $-vivified-$.java.util.function.BiFunction)`
Warning in /Users/jhwill/.gradle/caches/modules-2/files-2.1/com.android.tools/desugar_jdk_libs/1.0.5/359e5e4f4784f23beb30ba454b41f6f992e58481/desugar_jdk_libs-1.0.5.jar:java/util/concurrent/ConcurrentHashMap.class:
  Type `j$.$r8$wrapper$java$util$function$BiConsumer$-V-WRP` was not found, it is required for default or static interface methods desugaring of `void java.util.concurrent.ConcurrentHashMap.forEach($-vivified-$.java.util.function.BiConsumer)`
Warning in /Users/jhwill/.gradle/caches/modules-2/files-2.1/com.android.tools/desugar_jdk_libs/1.0.5/359e5e4f4784f23beb30ba454b41f6f992e58481/desugar_jdk_libs-1.0.5.jar:java/util/concurrent/ConcurrentHashMap.class:
  Type `j$.$r8$wrapper$java$util$function$Function$-V-WRP` was not found, it is required for default or static interface methods desugaring of `java.lang.Object java.util.concurrent.ConcurrentHashMap.computeIfAbsent(java.lang.Object, $-vivified-$.java.util.function.Function)`
Warning in synthesized for lambda desugaring:
  Type `j$.$r8$wrapper$java$util$function$ToDoubleFunction$-V-WRP` was not found, it is required for default or static interface methods desugaring of `java.util.Comparator java.time.chrono.-$$Lambda$AbstractChronology$5b0W7uLeaWkn0HLPDKwPXzJ7HPo.thenComparingDouble($-vivified-$.java.util.function.ToDoubleFunction)`
Warning in synthesized for lambda desugaring:
  Type `j$.$r8$wrapper$java$util$function$ToIntFunction$-V-WRP` was not found, it is required for default or static interface methods desugaring of `java.util.Comparator java.time.chrono.-$$Lambda$AbstractChronology$5b0W7uLeaWkn0HLPDKwPXzJ7HPo.thenComparingInt($-vivified-$.java.util.function.ToIntFunction)`
Warning in synthesized for lambda desugaring:
  Type `j$.$r8$wrapper$java$util$function$ToLongFunction$-V-WRP` was not found, it is required for default or static interface methods desugaring of `java.util.Comparator java.time.chrono.-$$Lambda$AbstractChronology$5b0W7uLeaWkn0HLPDKwPXzJ7HPo.thenComparingLong($-vivified-$.java.util.function.ToLongFunction)`
Warning in /Users/jhwill/.gradle/caches/modules-2/files-2.1/com.android.tools/desugar_jdk_libs/1.0.5/359e5e4f4784f23beb30ba454b41f6f992e58481/desugar_jdk_libs-1.0.5.jar:java/util/concurrent/ConcurrentHashMap$CollectionView.class:
  Type `j$.$r8$wrapper$java$util$stream$Stream$-WRP` was not found, it is required for default or static interface methods desugaring of `$-vivified-$.java.util.stream.Stream java.util.concurrent.ConcurrentHashMap$CollectionView.parallelStream()`
Warning in /Users/jhwill/.gradle/caches/modules-2/files-2.1/com.android.tools/desugar_jdk_libs/1.0.5/359e5e4f4784f23beb30ba454b41f6f992e58481/desugar_jdk_libs-1.0.5.jar:java/util/concurrent/ConcurrentHashMap$CollectionView.class:
  Type `j$.$r8$wrapper$java$util$function$Consumer$-V-WRP` was not found, it is required for default or static interface methods desugaring of `void java.util.concurrent.ConcurrentHashMap$CollectionView.forEach($-vivified-$.java.util.function.Consumer)`
Warning in /Users/jhwill/.gradle/caches/modules-2/files-2.1/com.android.tools/desugar_jdk_libs/1.0.5/359e5e4f4784f23beb30ba454b41f6f992e58481/desugar_jdk_libs-1.0.5.jar:java/util/concurrent/ConcurrentHashMap$CollectionView.class:
  Type `j$.$r8$wrapper$java$util$function$Predicate$-V-WRP` was not found, it is required for default or static interface methods desugaring of `boolean java.util.concurrent.ConcurrentHashMap$CollectionView.removeIf($-vivified-$.java.util.function.Predicate)`
Warning in /Users/jhwill/.gradle/caches/modules-2/files-2.1/com.android.tools/desugar_jdk_libs/1.0.5/359e5e4f4784f23beb30ba454b41f6f992e58481/desugar_jdk_libs-1.0.5.jar:java/util/concurrent/ThreadLocalRandom.class:
  Type `j$.$r8$wrapper$java$util$stream$IntStream$-WRP` was not found, it is required for default or static interface methods desugaring of `$-vivified-$.java.util.stream.IntStream java.util.concurrent.ThreadLocalRandom.ints()`
Warning in /Users/jhwill/.gradle/caches/modules-2/files-2.1/com.android.tools/desugar_jdk_libs/1.0.5/359e5e4f4784f23beb30ba454b41f6f992e58481/desugar_jdk_libs-1.0.5.jar:java/util/concurrent/ThreadLocalRandom.class:
  Type `j$.$r8$wrapper$java$util$stream$LongStream$-WRP` was not found, it is required for default or static interface methods desugaring of `$-vivified-$.java.util.stream.LongStream java.util.concurrent.ThreadLocalRandom.longs()`
Warning in /Users/jhwill/.gradle/caches/modules-2/files-2.1/com.android.tools/desugar_jdk_libs/1.0.5/359e5e4f4784f23beb30ba454b41f6f992e58481/desugar_jdk_libs-1.0.5.jar:java/util/concurrent/ThreadLocalRandom.class:
  Type `j$.$r8$wrapper$java$util$stream$DoubleStream$-WRP` was not found, it is required for default or static interface methods desugaring of `$-vivified-$.java.util.stream.DoubleStream java.util.concurrent.ThreadLocalRandom.doubles(long)`
Warning: Type `j$.util.OptionalConversions` was not found, it is required for default or static interface methods desugaring of `java.util.OptionalLong j$.$r8$wrapper$java$util$stream$LongStream$-WRP.reduce(java.util.function.LongBinaryOperator)`
Warning: Type `j$.util.LongSummaryStatisticsConversions` was not found, it is required for default or static interface methods desugaring of `java.util.LongSummaryStatistics j$.$r8$wrapper$java$util$stream$LongStream$-WRP.summaryStatistics()`
Warning: Type `j$.util.DoubleSummaryStatisticsConversions` was not found, it is required for default or static interface methods desugaring of `java.util.DoubleSummaryStatistics j$.$r8$wrapper$java$util$stream$DoubleStream$-WRP.summaryStatistics()`
Warning: Type `j$.util.IntSummaryStatisticsConversions` was not found, it is required for default or static interface methods desugaring of `java.util.IntSummaryStatistics j$.$r8$wrapper$java$util$stream$IntStream$-WRP.summaryStatistics()`

> Task :app:l8DexDesugarLibRelease
Warning in synthesized for lambda desugaring:
  Type `j$.$r8$wrapper$java$util$function$Function$-V-WRP` was not found, it is required for default or static interface methods desugaring of `java.util.Comparator java.time.chrono.-$$Lambda$AbstractChronology$onW9aZyLFliH5Gg1qLodD_GoPfA.thenComparing($-vivified-$.java.util.function.Function)`
Warning in synthesized for lambda desugaring:
  Type `j$.$r8$wrapper$java$util$function$ToDoubleFunction$-V-WRP` was not found, it is required for default or static interface methods desugaring of `java.util.Comparator java.time.chrono.-$$Lambda$AbstractChronology$onW9aZyLFliH5Gg1qLodD_GoPfA.thenComparingDouble($-vivified-$.java.util.function.ToDoubleFunction)`
Warning in synthesized for lambda desugaring:
  Type `j$.$r8$wrapper$java$util$function$ToIntFunction$-V-WRP` was not found, it is required for default or static interface methods desugaring of `java.util.Comparator java.time.chrono.-$$Lambda$AbstractChronology$onW9aZyLFliH5Gg1qLodD_GoPfA.thenComparingInt($-vivified-$.java.util.function.ToIntFunction)`
Warning in synthesized for lambda desugaring:
  Type `j$.$r8$wrapper$java$util$function$ToLongFunction$-V-WRP` was not found, it is required for default or static interface methods desugaring of `java.util.Comparator java.time.chrono.-$$Lambda$AbstractChronology$onW9aZyLFliH5Gg1qLodD_GoPfA.thenComparingLong($-vivified-$.java.util.function.ToLongFunction)`
Warning in /Users/jhwill/.gradle/caches/modules-2/files-2.1/com.android.tools/desugar_jdk_libs/1.0.5/359e5e4f4784f23beb30ba454b41f6f992e58481/desugar_jdk_libs-1.0.5.jar:java/util/concurrent/ConcurrentHashMap$KeyIterator.class:
  Type `j$.$r8$wrapper$java$util$function$Consumer$-V-WRP` was not found, it is required for default or static interface methods desugaring of `void java.util.concurrent.ConcurrentHashMap$KeyIterator.forEachRemaining($-vivified-$.java.util.function.Consumer)`
Warning in /Users/jhwill/.gradle/caches/modules-2/files-2.1/com.android.tools/desugar_jdk_libs/1.0.5/359e5e4f4784f23beb30ba454b41f6f992e58481/desugar_jdk_libs-1.0.5.jar:java/util/concurrent/ThreadLocalRandom.class:
  Type `j$.$r8$wrapper$java$util$stream$IntStream$-WRP` was not found, it is required for default or static interface methods desugaring of `$-vivified-$.java.util.stream.IntStream java.util.concurrent.ThreadLocalRandom.ints()`
Warning in /Users/jhwill/.gradle/caches/modules-2/files-2.1/com.android.tools/desugar_jdk_libs/1.0.5/359e5e4f4784f23beb30ba454b41f6f992e58481/desugar_jdk_libs-1.0.5.jar:java/util/concurrent/ThreadLocalRandom.class:
  Type `j$.$r8$wrapper$java$util$stream$LongStream$-WRP` was not found, it is required for default or static interface methods desugaring of `$-vivified-$.java.util.stream.LongStream java.util.concurrent.ThreadLocalRandom.longs()`
Warning in /Users/jhwill/.gradle/caches/modules-2/files-2.1/com.android.tools/desugar_jdk_libs/1.0.5/359e5e4f4784f23beb30ba454b41f6f992e58481/desugar_jdk_libs-1.0.5.jar:java/util/concurrent/ThreadLocalRandom.class:
  Type `j$.$r8$wrapper$java$util$stream$DoubleStream$-WRP` was not found, it is required for default or static interface methods desugaring of `$-vivified-$.java.util.stream.DoubleStream java.util.concurrent.ThreadLocalRandom.doubles(long)`
Warning in /Users/jhwill/.gradle/caches/modules-2/files-2.1/com.android.tools/desugar_jdk_libs/1.0.5/359e5e4f4784f23beb30ba454b41f6f992e58481/desugar_jdk_libs-1.0.5.jar:java/util/concurrent/ConcurrentHashMap$ValuesView.class:
  Type `j$.$r8$wrapper$java$util$Spliterator$-WRP` was not found, it is required for default or static interface methods desugaring of `$-vivified-$.java.util.Spliterator java.util.concurrent.ConcurrentHashMap$ValuesView.spliterator()`
Warning in /Users/jhwill/.gradle/caches/modules-2/files-2.1/com.android.tools/desugar_jdk_libs/1.0.5/359e5e4f4784f23beb30ba454b41f6f992e58481/desugar_jdk_libs-1.0.5.jar:java/util/stream/Collectors$Partition.class:
  Type `j$.$r8$wrapper$java$util$function$BiFunction$-V-WRP` was not found, it is required for default or static interface methods desugaring of `java.lang.Object java.util.stream.Collectors$Partition.computeIfPresent(java.lang.Object, $-vivified-$.java.util.function.BiFunction)`
Warning in /Users/jhwill/.gradle/caches/modules-2/files-2.1/com.android.tools/desugar_jdk_libs/1.0.5/359e5e4f4784f23beb30ba454b41f6f992e58481/desugar_jdk_libs-1.0.5.jar:java/util/stream/Collectors$Partition.class:
  Type `j$.$r8$wrapper$java$util$function$BiConsumer$-V-WRP` was not found, it is required for default or static interface methods desugaring of `void java.util.stream.Collectors$Partition.forEach($-vivified-$.java.util.function.BiConsumer)`
Warning in /Users/jhwill/.gradle/caches/modules-2/files-2.1/com.android.tools/desugar_jdk_libs/1.0.5/359e5e4f4784f23beb30ba454b41f6f992e58481/desugar_jdk_libs-1.0.5.jar:java/util/stream/Collectors$Partition$1.class:
  Type `j$.$r8$wrapper$java$util$stream$Stream$-WRP` was not found, it is required for default or static interface methods desugaring of `$-vivified-$.java.util.stream.Stream java.util.stream.Collectors$Partition$1.parallelStream()`
Warning in /Users/jhwill/.gradle/caches/modules-2/files-2.1/com.android.tools/desugar_jdk_libs/1.0.5/359e5e4f4784f23beb30ba454b41f6f992e58481/desugar_jdk_libs-1.0.5.jar:java/util/stream/Collectors$Partition$1.class:
  Type `j$.$r8$wrapper$java$util$function$Predicate$-V-WRP` was not found, it is required for default or static interface methods desugaring of `boolean java.util.stream.Collectors$Partition$1.removeIf($-vivified-$.java.util.function.Predicate)`

Expected Behavior

Desugaring tools produce working implementation for ThreadLocal.withInitial(Supplier). The code functions on an Android 5 / API 21 device.

Comments

ze...@google.com <ze...@google.com> #2Jul 6, 2020 04:40AM

Reassigned to cl...@google.com.

We're seeing a similar error in our code. Appears to be a combination of AGP 8.6.0 and Kotlin 2 needed to hit it.

private fun Intent.stripUnwantedFlags() {
    // Explicitly remove the new task and clear task flags (Our browser activity is a single
    // task activity and we never want to start a second task here).
    flags = flags and Intent.FLAG_ACTIVITY_NEW_TASK.inv()
    flags = flags and Intent.FLAG_ACTIVITY_CLEAR_TASK.inv()

    // IntentReceiverActivity is started with the "excludeFromRecents" flag (set in manifest). We
    // do not want to propagate this flag from the intent receiver activity to the browser.
    flags = flags and Intent.FLAG_ACTIVITY_EXCLUDE_FROM_RECENTS.inv()
}

All 3 lines then hit:

Must be one or more of: Intent.FLAG_GRANT_READ_URI_PERMISSION, Intent.FLAG_GRANT_WRITE_URI_PERMISSION, Intent.FLAG_FROM_BACKGROUND, Intent.FLAG_DEBUG_LOG_RESOLUTION, Intent.FLAG_EXCLUDE_STOPPED_PACKAGES, Intent.FLAG_INCLUDE_STOPPED_PACKAGES, Intent.FLAG_GRANT_PERSISTABLE_URI_PERMISSION, Intent.FLAG_GRANT_PREFIX_URI_PERMISSION, Intent.FLAG_ACTIVITY_MATCH_EXTERNAL, Intent.FLAG_ACTIVITY_NO_HISTORY, Intent.FLAG_ACTIVITY_SINGLE_TOP, Intent.FLAG_ACTIVITY_NEW_TASK, Intent.FLAG_ACTIVITY_MULTIPLE_TASK, Intent.FLAG_ACTIVITY_CLEAR_TOP, Intent.FLAG_ACTIVITY_FORWARD_RESULT, Intent.FLAG_ACTIVITY_PREVIOUS_IS_TOP, Intent.FLAG_ACTIVITY_EXCLUDE_FROM_RECENTS, Intent.FLAG_ACTIVITY_BROUGHT_TO_FRONT, Intent.FLAG_ACTIVITY_RESET_TASK_IF_NEEDED, Intent.FLAG_ACTIVITY_LAUNCHED_FROM_HISTORY, Intent.FLAG_ACTIVITY_CLEAR_WHEN_TASK_RESET, Intent.FLAG_ACTIVITY_NEW_DOCUMENT, Intent.FLAG_ACTIVITY_CLEAR_WHEN_TASK_RESET, Intent.FLAG_ACTIVITY_NO_USER_ACTION, Intent.FLAG_ACTIVITY_REORDER_TO_FRONT, Intent.FLAG_ACTIVITY_NO_ANIMATION, Intent.FLAG_ACTIVITY_CLEAR_TASK, Intent.FLAG_ACTIVITY_TASK_ON_HOME, Intent.FLAG_ACTIVITY_RETAIN_IN_RECENTS, Intent.FLAG_ACTIVITY_LAUNCH_ADJACENT, Intent.FLAG_ACTIVITY_REQUIRE_NON_BROWSER, Intent.FLAG_ACTIVITY_REQUIRE_DEFAULT, Intent.FLAG_RECEIVER_REGISTERED_ONLY, Intent.FLAG_RECEIVER_REPLACE_PENDING, Intent.FLAG_RECEIVER_FOREGROUND, Intent.FLAG_RECEIVER_NO_ABORT, Intent.FLAG_RECEIVER_VISIBLE_TO_INSTANT_APPS

ja...@jamesonwilliams.com <ja...@jamesonwilliams.com> #3Jul 6, 2020 05:59AM

The initial report (comment#1) seems like a dup of b/352609562 (internal link), and fixed at https://cs.android.com/android-studio/platform/tools/base/+/f88d11033727f891bcc2a7a1cbbeb109c7d5dd0f I believe it's available in AGP 8.7.0-alpha02+

However, comment#2 indicates that there are more kinds of conversions we may miss... Let me double-check that.

Message last modified on Jul 6, 2020 06:00AM

ze...@google.com <ze...@google.com> #4Jul 6, 2020 06:46AM

Thanks for fixing! What release should we be able to verify the fix in? And is there any chance of a backport for 8.6.1?

ja...@jamesonwilliams.com <ja...@jamesonwilliams.com> #5Jul 6, 2020 07:38AM

The caveat is that the fix for comment#1 is in 8.7.0-alpha02 and the fix for comment#2 will be in 8.8.0-alpha02. I'm asking internally how we can handle this case.

Message last modified on Jul 6, 2020 07:39AM

app-debug.apk

6.7 MB

Download

ze...@google.com <ze...@google.com> #6Jul 6, 2020 08:38AM

the fix for comment#2 will be in 8.8.0-alpha02

It is cherry-picked to 8.7

the fix for comment#1 is in 8.7.0-alpha02

This one and the above one are cherry-picked to 8.6.1

cl...@google.com <cl...@google.com> #7Jul 6, 2020 12:28PM

Thanks for the update!

ja...@jamesonwilliams.com <ja...@jamesonwilliams.com> #8Jul 6, 2020 03:22PM

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Studio Ladybug Feature Drop | 2024.2.2 Canary 2
Android Gradle Plugin 8.8.0-alpha02

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!

Message last modified on Jul 6, 2020 03:24PM

v2sdk.tar.gz

2.7 MB

Download

cl...@google.com <cl...@google.com> #9Jul 6, 2020 05:40PM

The fixes for this issue are now also available in:

Android Studio Ladybug | 2024.2.1 RC 1
Android Gradle Plugin 8.7.0-rc01

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

ja...@jamesonwilliams.com <ja...@jamesonwilliams.com> #10Jul 6, 2020 05:56PM

Thanks! I agree the error message could be improved.

Per the title, my original report here is really a feature request: "Can you add support for ThreadLocal#withInitial(...) into the desugaring library?"

I have also asked the AWS Java SDK V2 team to stop using this construct, from their side.

Message last modified on Jul 6, 2020 10:27PM

cl...@google.com <cl...@google.com> #11Jul 7, 2020 06:35AM

Accepted by cl...@google.com.

I will add ThreadLocal#withInitial to the desugared library wanted features hotlist, we'll see what we can do. It's not going to happen anytime soon though (at the very least not this quarter), so it's probably better if you build a work-around for now.

sg...@google.com <sg...@google.com> #12Jul 27, 2020 02:15PM

Given a supplier

Supplier<T> supplier = ...

Could

ThreadLocal<T> threadLocal = ThreadLocal.withInitial(supplier)

be desugared to


class SynthesizedThreadLocalSubClass extends ThreadLocal<T> {
  private Supplier<T> supplier;

  SynthesizedThreadLocalSubClass(Supplier<T> supplier) {
    this.supplier = supplier;
  }

  protected T initialValue() {
    return supplier.get();
  }
}

ThreadLocal<T> threadLocal = new SynthesizedThreadLocalSubClass(supplier);

That could allow this to be handled using backporting if backporting is extended to synthesize the subclass SynthesizedThreadLocalSubClass of ThreadLocal if required (that is if ThreadLocal.withInitial is used in the app).

mi...@gmail.com <mi...@gmail.com> #13Aug 23, 2021 10:24AM

Any update on this?

cl...@google.com <cl...@google.com> #14Aug 23, 2021 10:30AM

We've not worked on implementing a work-around for ThreadLocal.withInitial() so far.

@sgjesse should we try this quarter/next quarter?

sg...@google.com <sg...@google.com> Sep 9, 2022 10:29AM

Accepted by sg...@google.com.

ap...@google.com <ap...@google.com> #15Sep 9, 2022 10:30AM

Project: r8
Branch: main

commit a6f2739d4969ce085b93529c7cd20cc4cfee176b
Author: Søren Gjesse <sgjesse@google.com>
Date: Thu Sep 08 16:10:10 2022

Backport ThreadLocal.withInitial when Supplier is present

This will backport ThreadLocal.withInitial(java.util.function.Supplier)
when java.util.function.Supplier is present at runtime.

Without desugared library this makes the method usable from API level
24 (when Supplier was introduced) instead of from API level 26 (when
withInitial was introduced).

With desugared library the method is always usable as Supplier is
included in all desugared library versions.

Bug:

b/160484830

Change-Id: I536879372d903d15b182a2ef071adf01361c8f01

M src/main/java/com/android/tools/r8/graph/DexItemFactory.java
M src/main/java/com/android/tools/r8/ir/desugar/BackportedMethodRewriter.java
M src/main/java/com/android/tools/r8/ir/desugar/backports/BackportedMethodDesugaringEventConsumer.java
M src/main/java/com/android/tools/r8/ir/desugar/CfInstructionDesugaringEventConsumer.java
A src/test/java/com/android/tools/r8/desugar/backports/ThreadLocalBackportWithDesugaredLibraryTest.java
M src/main/java/com/android/tools/r8/synthesis/SyntheticNaming.java
A src/test/java/com/android/tools/r8/desugar/backports/ThreadLocalBackportTest.java

https://r8-review.googlesource.com/71303

ap...@google.com <ap...@google.com> #16Sep 13, 2022 03:08PM

Project: r8
Branch: main

commit b595f9b29de6e925a1a8e82f02a74a6d0da4db2c
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Sep 13 12:49:15 2022

Fix stack height for rewrite or ThreadLocal.withInitial

Bug:

b/160484830

Change-Id: I89d10b9d45357b57d32db47737035f38a5cb27f8

M src/main/java/com/android/tools/r8/ir/desugar/BackportedMethodRewriter.java
M src/test/java/com/android/tools/r8/desugar/backports/ThreadLocalBackportTest.java

https://r8-review.googlesource.com/71406

ap...@google.com <ap...@google.com> #17Sep 14, 2022 09:15AM

Project: r8
Branch: 3.2

commit 65092faa0276ccb00a37b8d35a10038cbbdec5fb
Author: Søren Gjesse <sgjesse@google.com>
Date: Wed Sep 14 11:08:57 2022

Version 3.2.81

Contains changes to resolve cherry-pick issues.

Bug:

b/160484830

Change-Id: I95cf2b7ef6dd6a7eafbff2a4735c7cd6d60f35de

M src/main/java/com/android/tools/r8/ir/desugar/BackportedMethodRewriter.java
M src/test/java/com/android/tools/r8/desugar/backports/ThreadLocalBackportWithDesugaredLibraryTest.java
M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/71411

ap...@google.com <ap...@google.com> #18Sep 14, 2022 09:15AM

Project: r8
Branch: 3.2

commit 703819c5fa4cff78373dee829761f807574ec2b9
Author: Søren Gjesse <sgjesse@google.com>
Date: Wed Sep 14 11:07:00 2022

Fix stack height for rewrite or ThreadLocal.withInitial

Bug:

b/160484830

https://r8-review.googlesource.com/71410

ap...@google.com <ap...@google.com> #19Sep 14, 2022 09:15AM

Project: r8
Branch: 3.2

commit 3931c5a1299bf1c2df1bfae06a9b954d2dc87b52
Author: Søren Gjesse <sgjesse@google.com>
Date: Wed Sep 14 11:06:28 2022

Backport ThreadLocal.withInitial when Supplier is present

This will backport ThreadLocal.withInitial(java.util.function.Supplier)
when java.util.function.Supplier is present at runtime.

Without desugared library this makes the method usable from API level
24 (when Supplier was introduced) instead of from API level 26 (when
withInitial was introduced).

With desugared library the method is always usable as Supplier is
included in all desugared library versions.

Bug:

b/160484830

https://r8-review.googlesource.com/71409

sg...@google.com <sg...@google.com> Sep 14, 2022 11:45AM

Marked as fixed.

sg...@google.com <sg...@google.com> Sep 14, 2022 02:06PM

Verified by sg...@google.com.

ap...@google.com <ap...@google.com> #20Sep 15, 2022 07:09AM

Project: r8
Branch: 4.0

commit 3b4722724a1460a5f0a245089210bf4e42cada23
Author: Søren Gjesse <sgjesse@google.com>
Date: Wed Sep 14 13:02:41 2022

Version 4.0.29

Bug:

b/160484830

Change-Id: I66dd4552b850077b8abfa87fb2760d7b17cdde62

M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/71425

ap...@google.com <ap...@google.com> #21Sep 15, 2022 07:09AM

Project: r8
Branch: 4.0

commit 654dcebcc75dbfa59b40ded2f5b1e87195af94a2
Author: Søren Gjesse <sgjesse@google.com>
Date: Wed Sep 14 13:02:32 2022

Fix stack height for rewrite or ThreadLocal.withInitial

Bug:

b/160484830

https://r8-review.googlesource.com/71424

ap...@google.com <ap...@google.com> #22Sep 15, 2022 07:09AM

Project: r8
Branch: 4.0

commit edf6432389f51e54f165a04fe32b0522e92306ad
Author: Søren Gjesse <sgjesse@google.com>
Date: Wed Sep 14 12:57:52 2022

Backport ThreadLocal.withInitial when Supplier is present

This will backport ThreadLocal.withInitial(java.util.function.Supplier)
when java.util.function.Supplier is present at runtime.

Without desugared library this makes the method usable from API level
24 (when Supplier was introduced) instead of from API level 26 (when
withInitial was introduced).

With desugared library the method is always usable as Supplier is
included in all desugared library versions.

Bug:

b/160484830

Change-Id: I536879372d903d15b182a2ef071adf01361c8f01

M src/main/java/com/android/tools/r8/graph/DexItemFactory.java
M src/main/java/com/android/tools/r8/ir/desugar/backports/BackportedMethodDesugaringEventConsumer.java
M src/main/java/com/android/tools/r8/ir/desugar/BackportedMethodRewriter.java
M src/main/java/com/android/tools/r8/ir/desugar/CfInstructionDesugaringEventConsumer.java
A src/test/java/com/android/tools/r8/desugar/backports/ThreadLocalBackportWithDesugaredLibraryTest.java
M src/main/java/com/android/tools/r8/synthesis/SyntheticNaming.java
A src/test/java/com/android/tools/r8/desugar/backports/ThreadLocalBackportTest.java

https://r8-review.googlesource.com/71423

ap...@google.com <ap...@google.com> #23Sep 15, 2022 07:09AM

Project: r8
Branch: 3.3

commit d6e7e48c4ae98e002e962c070f5dd310c85a59e0
Author: Søren Gjesse <sgjesse@google.com>
Date: Wed Sep 14 12:36:52 2022

Version 3.3.79

Contains changes to resolve cherry-pick issues.

Bug:

b/160484830

Change-Id: I65e2242cdf294aabc03dd728e63c68cea653c92a

M src/test/java/com/android/tools/r8/desugar/backports/ThreadLocalBackportWithDesugaredLibraryTest.java
M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/71422

ap...@google.com <ap...@google.com> #24Sep 15, 2022 07:09AM

Project: r8
Branch: 3.3

commit a9d35293e7c3e9bd7544dadc1aa3afac6829ec23
Author: Søren Gjesse <sgjesse@google.com>
Date: Wed Sep 14 12:36:33 2022

Fix stack height for rewrite or ThreadLocal.withInitial

Bug:

b/160484830

https://r8-review.googlesource.com/71421

ap...@google.com <ap...@google.com> #25Sep 15, 2022 07:09AM

Project: r8
Branch: 3.3

commit c460eb8a5ba603d8833d02d78b92321416ae78ae
Author: Søren Gjesse <sgjesse@google.com>
Date: Wed Sep 14 12:35:53 2022

Backport ThreadLocal.withInitial when Supplier is present

This will backport ThreadLocal.withInitial(java.util.function.Supplier)
when java.util.function.Supplier is present at runtime.

Without desugared library this makes the method usable from API level
24 (when Supplier was introduced) instead of from API level 26 (when
withInitial was introduced).

With desugared library the method is always usable as Supplier is
included in all desugared library versions.

Bug:

b/160484830

Change-Id: I536879372d903d15b182a2ef071adf01361c8f01

M src/main/java/com/android/tools/r8/graph/DexItemFactory.java
M src/main/java/com/android/tools/r8/ir/desugar/BackportedMethodRewriter.java
M src/main/java/com/android/tools/r8/ir/desugar/backports/BackportedMethodDesugaringEventConsumer.java
M src/main/java/com/android/tools/r8/ir/desugar/CfInstructionDesugaringEventConsumer.java
A src/test/java/com/android/tools/r8/desugar/backports/ThreadLocalBackportWithDesugaredLibraryTest.java
A src/test/java/com/android/tools/r8/desugar/backports/ThreadLocalBackportTest.java
M src/main/java/com/android/tools/r8/synthesis/SyntheticNaming.java

https://r8-review.googlesource.com/71420

ap...@google.com <ap...@google.com> #26Sep 15, 2022 07:10AM

b/160484830

https://r8-review.googlesource.com/71424

ap...@google.com <ap...@google.com> #27Sep 15, 2022 07:10AM

b/160484830

https://r8-review.googlesource.com/71423

Issue 160484830

Description

What I'm Doing

What Goes Wrong

Why It Goes Wrong (Maybe)

Additional Information

Expected Behavior

Issue summary

Comments

ze...@google.com <ze...@google.com> #2Jul 6, 2020 04:40AM

ja...@jamesonwilliams.com <ja...@jamesonwilliams.com> #3Jul 6, 2020 05:59AM

ze...@google.com <ze...@google.com> #4Jul 6, 2020 06:46AM

ja...@jamesonwilliams.com <ja...@jamesonwilliams.com> #5Jul 6, 2020 07:38AM

ze...@google.com <ze...@google.com> #6Jul 6, 2020 08:38AM

cl...@google.com <cl...@google.com> #7Jul 6, 2020 12:28PM

ja...@jamesonwilliams.com <ja...@jamesonwilliams.com> #8Jul 6, 2020 03:22PM

cl...@google.com <cl...@google.com> #9Jul 6, 2020 05:40PM

ja...@jamesonwilliams.com <ja...@jamesonwilliams.com> #10Jul 6, 2020 05:56PM

cl...@google.com <cl...@google.com> #11Jul 7, 2020 06:35AM

sg...@google.com <sg...@google.com> #12Jul 27, 2020 02:15PM

mi...@gmail.com <mi...@gmail.com> #13Aug 23, 2021 10:24AM

cl...@google.com <cl...@google.com> #14Aug 23, 2021 10:30AM

sg...@google.com <sg...@google.com> Sep 9, 2022 10:29AM

ap...@google.com <ap...@google.com> #15Sep 9, 2022 10:30AM

ap...@google.com <ap...@google.com> #16Sep 13, 2022 03:08PM

ap...@google.com <ap...@google.com> #17Sep 14, 2022 09:15AM

ap...@google.com <ap...@google.com> #18Sep 14, 2022 09:15AM

ap...@google.com <ap...@google.com> #19Sep 14, 2022 09:15AM

sg...@google.com <sg...@google.com> Sep 14, 2022 11:45AM

sg...@google.com <sg...@google.com> Sep 14, 2022 02:06PM

ap...@google.com <ap...@google.com> #20Sep 15, 2022 07:09AM

ap...@google.com <ap...@google.com> #21Sep 15, 2022 07:09AM

ap...@google.com <ap...@google.com> #22Sep 15, 2022 07:09AM

ap...@google.com <ap...@google.com> #23Sep 15, 2022 07:09AM

ap...@google.com <ap...@google.com> #24Sep 15, 2022 07:09AM

ap...@google.com <ap...@google.com> #25Sep 15, 2022 07:09AM

ap...@google.com <ap...@google.com> #26Sep 15, 2022 07:10AM

ap...@google.com <ap...@google.com> #27Sep 15, 2022 07:10AM

Add comment

Issue metadata