Navigation artifacts should be rewritten in Kotlin [160642814]

Fixed

Feature Request

Status Update

No update yet.

Description

il...@google.com

created issue #1

Jul 6, 2020 11:54PM

Component used: Navigation Version used: 2.3.0

While the Navigation Dynamic artifacts are written in Kotlin, the core navigation-common, navigation-runtime, navigation-fragment, and navigation-ui artifacts are still written in Java.

This leads to issues such as many, many overloads of navigate() as part of the core API (where 2-3 methods with default values would be more appropriate).

As a first step, Navigation should be converted over to Kotlin, keeping both binary and source compatibility with existing APIs.

This would also open up the ability to support future Kotlin first APIs as part of the core API surface.

Comments

il...@google.com <il...@google.com> Nov 9, 2020 11:43PM

Reassigned to jb...@google.com.

ap...@google.com <ap...@google.com> #2Jan 19, 2021 07:47PM

Project: platform/frameworks/support
Branch: androidx-main

commit c2365dcfeb9064814282304f30f3eb86be71fdc7
Author: Dan Nizri <dniz@google.com>
Date: Wed Dec 20 16:33:08 2023

Fix Popup back handling on Android T/13+ when android:enableOnBackInvokedCallback="true"

Bug: 313702338
Bug: 318537200
Test: tested with android:enableOnBackInvokedCallback="true"
Change-Id: I7c7cef686ed9fbfd2d144c90040b13528f1675ed

M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/window/AndroidPopup.android.kt

https://android-review.googlesource.com/2886766

ap...@google.com <ap...@google.com> #3Jan 19, 2021 07:47PM

Is there remaining work for this feature request. Support for predictive back in Dialogs would allow Material3 to remove some Dialog forks and would be very helpful!

ap...@google.com <ap...@google.com> #4Jan 26, 2021 11:51PM

Yeah, we probably want to investigate new API shapes here to take advantage of predictive back. No work ongoing yet though, needs prioritization

ap...@google.com <ap...@google.com> #5Jan 27, 2021 01:17AM

Pinging here, as we're facing a similar issue on Wear OS, PB support on Dialogs would allow us to simplify/remove some components that handle swipe to dismiss behaviour and consolidate the back gesture throughout the system.

ap...@google.com <ap...@google.com> #6Jan 27, 2021 01:52AM

(recapping my chat with Ian)

The tricky part is that the onDismissRequest is really the final signal and a chance for the app to just say 'nope, I don't want the dialog to dismiss' (since they own the state of 'should the dialog be shown or not' simply by either adding the Dialog to composition or leaving out of composition) - that's the just-in-time problem that the comment talks about. It would be very odd to have any kind of progress animation that doesn't actually lead to the dialog being dismissed when it is committed"

so really it needs to be a more holistic look at how to do dialogs and swap from a binary state (shown/not shown) to something that actually has something in between for cases like predictive back

ap...@google.com <ap...@google.com> #7Jan 27, 2021 01:56AM

Project: platform/frameworks/support
Branch: androidx-main

commit 6a08f85cd7de8ac139a423d0e2a59e56043c1b73
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Jan 21 17:38:46 2021

Convert NavBackStackEntryState to Kotlin

Converted the NavBackStackEntryState class to Kotlin and added the
Kotlin std lib dependency to navigation runtime.

RelNote: N/A
Test: ./gradlew checkApi
Bug: 160642814
Change-Id: I84168e943ce53e0f9205eec516656e4a24852c4e

M navigation/navigation-runtime/build.gradle
D navigation/navigation-runtime/src/main/java/androidx/navigation/NavBackStackEntryState.java
A navigation/navigation-runtime/src/main/java/androidx/navigation/NavBackStackEntryState.kt
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.java

https://android-review.googlesource.com/1557314

ap...@google.com <ap...@google.com> #8Jan 27, 2021 05:35PM

Project: platform/frameworks/support
Branch: androidx-main

commit dfc3f38cc48574d1f1ce0bc9833da7b67abfbad9
Author: Jeremy Woods <jbwoods@google.com>
Date: Mon Jan 25 17:16:35 2021

Convert NavControllerViewModel to Kotlin

Converted NavControllerViewModel to Kotlin.

RelNote: N/A
Test: ./gradlew checkApi
Bug: 160642814
Change-Id: If43de33cfe6dee4f4e6d1806f10a7eaaaafc7dfc

D navigation/navigation-runtime/src/main/java/androidx/navigation/NavControllerViewModel.java
A navigation/navigation-runtime/src/main/java/androidx/navigation/NavControllerViewModel.kt

https://android-review.googlesource.com/1559794

ap...@google.com <ap...@google.com> #9Jan 27, 2021 05:46PM

Project: platform/frameworks/support
Branch: androidx-main

commit 5b19fddb91b129168429b3cbf77323414d638b03
Author: Jeremy Woods <jbwoods@google.com>
Date: Mon Jan 25 19:38:23 2021

Convert ActionBarOnDestinationChangedListener to Kotlin

Converted the ActionBarOnDestinationChangedListener class to Kotlin.

RelNote: N/A
Test: ./gradlew checkApi
Bug: 160642814
Change-Id: I0a7b41ab48fbc2dbd3503907a7f3737d0a1f76a0

D navigation/navigation-ui/src/main/java/androidx/navigation/ui/ActionBarOnDestinationChangedListener.java
A navigation/navigation-ui/src/main/java/androidx/navigation/ui/ActionBarOnDestinationChangedListener.kt

https://android-review.googlesource.com/1560094

ap...@google.com <ap...@google.com> #10Jan 27, 2021 11:31PM

Project: platform/frameworks/support
Branch: androidx-main

commit d5f4ba078465516da538bcf96042a33e0cb6edd8
Author: Jeremy Woods <jbwoods@google.com>
Date: Mon Jan 25 19:31:24 2021

Convert AbstractAppBarOnDestinationChangedListener to Kotlin

Converted the AbstractAppBarOnDestinationChangedListener class to Kotlin.

RelNote: N/A
Test: ./gradlew checkApi
Bug: 160642814
Change-Id: I4414e3e5dcd1dbfd369bfc2b405519c51d163051

D navigation/navigation-ui/src/main/java/androidx/navigation/ui/AbstractAppBarOnDestinationChangedListener.java
A navigation/navigation-ui/src/main/java/androidx/navigation/ui/AbstractAppBarOnDestinationChangedListener.kt
M navigation/navigation-ui/src/main/java/androidx/navigation/ui/ActionBarOnDestinationChangedListener.kt
M navigation/navigation-ui/src/main/java/androidx/navigation/ui/CollapsingToolbarOnDestinationChangedListener.kt
M navigation/navigation-ui/src/main/java/androidx/navigation/ui/ToolbarOnDestinationChangedListener.kt

https://android-review.googlesource.com/1560093

ap...@google.com <ap...@google.com> #11Jan 28, 2021 12:11AM

Project: platform/frameworks/support
Branch: androidx-main

commit b1db65c1782f1dc7cc7f74980933632917ca0f23
Author: Jeremy Woods <jbwoods@google.com>
Date: Mon Jan 25 20:31:18 2021

Convert NavigationUI to Kotlin

Converted the NavigationUI class to Kotlin.

RelNote: N/A
Test: ./gradlew checkApi
Bug: 160642814
Change-Id: Idca423569bb9a57a7b154105faf0e773cba2945f

M navigation/navigation-ui/api/current.txt
M navigation/navigation-ui/api/public_plus_experimental_current.txt
M navigation/navigation-ui/api/restricted_current.txt
D navigation/navigation-ui/src/main/java/androidx/navigation/ui/NavigationUI.java
A navigation/navigation-ui/src/main/java/androidx/navigation/ui/NavigationUI.kt

https://android-review.googlesource.com/1560103

ap...@google.com <ap...@google.com> #12Jan 28, 2021 12:11AM

Project: platform/frameworks/support
Branch: androidx-main

commit 0a1ca65903f46c145127f0d3f6b93917d660f31a
Author: Jeremy Woods <jbwoods@google.com>
Date: Mon Jan 25 20:05:52 2021

Convert AppBarConfiguration to Kotlin

Converted the AppBarConfiguration class to Kotlin.

RelNote: N/A
Test: ./gradlew checkApi
Bug: 160642814
Change-Id: Idfc12584509cfaa9873fce13f1ecba20c39c45e3

A navigation/navigation-ui/api/current.ignore
M navigation/navigation-ui/api/current.txt
M navigation/navigation-ui/api/public_plus_experimental_current.txt
A navigation/navigation-ui/api/restricted_current.ignore
M navigation/navigation-ui/api/restricted_current.txt
D navigation/navigation-ui/src/main/java/androidx/navigation/ui/AppBarConfiguration.java
A navigation/navigation-ui/src/main/java/androidx/navigation/ui/AppBarConfiguration.kt

https://android-review.googlesource.com/1560100

ap...@google.com <ap...@google.com> #13Feb 19, 2021 12:10AM

Project: platform/frameworks/support
Branch: androidx-main

commit 86ed994afcfabc43a8cbe50cb537130bd88f01eb
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Jan 21 16:19:08 2021

Convert NavHostFragment to Kotlin

Converted NavHostFragment to Kotlin.

RelNote: N/A
Test: ./gradlew checkApi
Bug: 160642814
Change-Id: Iff631bf755ae7c3cb948ba32ce8bbb4f0b02842a

M navigation/navigation-dynamic-features-fragment/src/main/java/androidx/navigation/dynamicfeatures/fragment/DynamicNavHostFragment.kt
M navigation/navigation-fragment/api/current.txt
M navigation/navigation-fragment/api/public_plus_experimental_current.txt
M navigation/navigation-fragment/api/restricted_current.txt
D navigation/navigation-fragment/src/main/java/androidx/navigation/fragment/NavHostFragment.java
A navigation/navigation-fragment/src/main/java/androidx/navigation/fragment/NavHostFragment.kt

https://android-review.googlesource.com/1557309

ap...@google.com <ap...@google.com> #14Feb 19, 2021 12:10AM

Project: platform/frameworks/support
Branch: androidx-main

commit 941510470a88cdddacc7b583e6011e9a142909b5
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Jan 21 15:46:58 2021

Convert FragmentNavigator to Kotlin

Converted FragmentNavigator to Kotlin.

RelNote: N/A
Test: ./gradlew checkApi
Bug: 160642814
Change-Id: I10eb6b3d7ea47549ebf91dd1b6e3f201da950802

M navigation/navigation-dynamic-features-fragment/src/main/java/androidx/navigation/dynamicfeatures/fragment/DynamicFragmentNavigatorDestinationBuilder.kt
M navigation/navigation-dynamic-features-fragment/src/main/java/androidx/navigation/dynamicfeatures/fragment/DynamicNavHostFragment.kt
M navigation/navigation-fragment-ktx/src/main/java/androidx/navigation/fragment/FragmentNavigatorDestinationBuilder.kt
A navigation/navigation-fragment/api/current.ignore
M navigation/navigation-fragment/api/current.txt
M navigation/navigation-fragment/api/public_plus_experimental_current.txt
A navigation/navigation-fragment/api/restricted_current.ignore
M navigation/navigation-fragment/api/restricted_current.txt
M navigation/navigation-fragment/src/androidTest/java/androidx/navigation/fragment/FragmentNavigatorTest.kt
D navigation/navigation-fragment/src/main/java/androidx/navigation/fragment/FragmentNavigator.java
A navigation/navigation-fragment/src/main/java/androidx/navigation/fragment/FragmentNavigator.kt

https://android-review.googlesource.com/1557040

ap...@google.com <ap...@google.com> #15Feb 19, 2021 12:10AM

Project: platform/frameworks/support
Branch: androidx-main

commit 15726ce6361a51c24a2863f2c8a9eb7ed3df2f5e
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Jan 21 15:11:54 2021

Convert DialogFragmentNavigator to Kotlin

Converted DialogFragmentNavigator to Kotlin.

RelNote: N/A
Test: ./gradlew checkApi
Bug: 160642814
Change-Id: I8e329c8ae8e67b1ac3f2867faea9eb62088b14a1

M navigation/navigation-fragment-ktx/src/main/java/androidx/navigation/fragment/DialogFragmentNavigatorDestinationBuilder.kt
M navigation/navigation-fragment/api/current.txt
M navigation/navigation-fragment/api/public_plus_experimental_current.txt
M navigation/navigation-fragment/api/restricted_current.txt
M navigation/navigation-fragment/build.gradle
M navigation/navigation-fragment/src/androidTest/java/androidx/navigation/fragment/DialogFragmentNavigatorTest.kt
D navigation/navigation-fragment/src/main/java/androidx/navigation/fragment/DialogFragmentNavigator.java
A navigation/navigation-fragment/src/main/java/androidx/navigation/fragment/DialogFragmentNavigator.kt

https://android-review.googlesource.com/1556663

ap...@google.com <ap...@google.com> #16Feb 27, 2021 02:27AM

Project: platform/frameworks/support
Branch: androidx-main

commit a2c678aaeb5e6cde2b8c61205705a9d4fafd6ec7
Author: Jeremy Woods <jbwoods@google.com>
Date: Fri Feb 26 14:33:48 2021

Remove OnDestinationChangedListener mocks from NavControllerTest

Using a real OnDestinationChangedListener for the deep link
NavControllerTest instead of mock.

RelNote: N/A
Test: all tests pass
Bug: 160642814
Change-Id: I4242fb8c1dfca830bee5a168160d19f5ad579262

M navigation/navigation-runtime/build.gradle
M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerTest.kt

https://android-review.googlesource.com/1610914

ap...@google.com <ap...@google.com> #17Mar 2, 2021 04:27PM

Project: platform/frameworks/support
Branch: androidx-main

commit a83eff828baec31ab2a0fc89416514af45b88d35
Author: Jeremy Woods <jbwoods@google.com>
Date: Mon Jan 25 18:40:19 2021

Convert NavInflater to Kotlin

Converted the NavInflater class to Kotlin.

RelNote: N/A
Test: ./gradlew checkApi
Bug: 160642814
Change-Id: If4970f100f5e4310f8c05e4541e2509884b724df

M navigation/navigation-dynamic-features-runtime/src/main/java/androidx/navigation/dynamicfeatures/DynamicIncludeGraphNavigator.kt
M navigation/navigation-runtime/api/current.txt
M navigation/navigation-runtime/api/public_plus_experimental_current.txt
M navigation/navigation-runtime/api/restricted_current.txt
D navigation/navigation-runtime/src/main/java/androidx/navigation/NavInflater.java
A navigation/navigation-runtime/src/main/java/androidx/navigation/NavInflater.kt

https://android-review.googlesource.com/1560092

ap...@google.com <ap...@google.com> #18Mar 2, 2021 04:27PM

Project: platform/frameworks/support
Branch: androidx-main

commit d53adaa5482523d705e457222923585cd5c9978c
Author: Jeremy Woods <jbwoods@google.com>
Date: Mon Jan 25 18:19:47 2021

Convert Navigation class to Kotlin

Converted Navigation class to Kotlin.

RelNote: N/A
Test: ./gradlew checkApi
Bug: 160642814
Change-Id: Ia2ff940e61583fa5cdd79b311e8fdc6e2fde8e69

M navigation/navigation-runtime/api/current.txt
M navigation/navigation-runtime/api/public_plus_experimental_current.txt
M navigation/navigation-runtime/api/restricted_current.txt
D navigation/navigation-runtime/src/main/java/androidx/navigation/Navigation.java
A navigation/navigation-runtime/src/main/java/androidx/navigation/Navigation.kt

https://android-review.googlesource.com/1560089

ap...@google.com <ap...@google.com> #19Mar 2, 2021 04:27PM

Project: platform/frameworks/support
Branch: androidx-main

commit e78cce30b51e573b4f665f3eb0c3ab7494f07cf4
Author: Jeremy Woods <jbwoods@google.com>
Date: Mon Jan 25 18:01:26 2021

Convert NavHostController to Kotlin

Converted NavHostController to Kotlin.

RelNote: N/A
Test: ./gradlew checkApi
Bug: 160642814
Change-Id: Ib7975b78c86882df3f11971404e1560fb74078c7

M navigation/navigation-runtime/api/current.txt
M navigation/navigation-runtime/api/public_plus_experimental_current.txt
M navigation/navigation-runtime/api/restricted_current.txt
D navigation/navigation-runtime/src/main/java/androidx/navigation/NavHostController.java
A navigation/navigation-runtime/src/main/java/androidx/navigation/NavHostController.kt

https://android-review.googlesource.com/1559806

ap...@google.com <ap...@google.com> #20Mar 2, 2021 04:27PM

Project: platform/frameworks/support
Branch: androidx-main

commit c0bb465e0f854c088dbd3ed0545b176ccceb5415
Author: Jeremy Woods <jbwoods@google.com>
Date: Mon Jan 25 17:55:18 2021

Convert NavDeepLinkBuilder to Kotlin

Converted NavDeepLinkBuilder to Kotlin.

RelNote: N/A
Test: ./gradlew checkApi
Bug: 160642814
Change-Id: I67f58e8d7d861660afa2c5bcdb1ad9950a934f57

M navigation/navigation-runtime/api/current.txt
M navigation/navigation-runtime/api/public_plus_experimental_current.txt
M navigation/navigation-runtime/api/restricted_current.txt
D navigation/navigation-runtime/src/main/java/androidx/navigation/NavDeepLinkBuilder.java
A navigation/navigation-runtime/src/main/java/androidx/navigation/NavDeepLinkBuilder.kt

https://android-review.googlesource.com/1559805

ap...@google.com <ap...@google.com> #21Mar 2, 2021 04:27PM

Project: platform/frameworks/support
Branch: androidx-main

commit f79e6ec0c72edd3e8b00c34ad11ac86c5a118e7a
Author: Jeremy Woods <jbwoods@google.com>
Date: Fri Jan 22 12:31:03 2021

Convert NavController to Kotlin

Converted NavController to Kotlin.

RelNote: N/A
Test: ./gradlew checkApi
Bug: 160642814
Change-Id: Ice4ffe5b4682d6db8deb8644541f568fc961fd38

M navigation/navigation-runtime/api/current.txt
M navigation/navigation-runtime/api/public_plus_experimental_current.txt
M navigation/navigation-runtime/api/restricted_current.txt
D navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.java
A navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.kt
M navigation/navigation-testing/src/main/java/androidx/navigation/testing/TestNavHostController.kt

https://android-review.googlesource.com/1558717

ap...@google.com <ap...@google.com> #22Mar 2, 2021 04:27PM

Project: platform/frameworks/support
Branch: androidx-main

commit 67dc2c8665772580597d17b2aa78f22ee88bfcc1
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Jan 21 17:21:34 2021

Convert NavBackStackEntry to Kotlin

Converted the NavBackStackEntry class to Kotlin.

RelNote: N/A
Test: ./gradlew checkApi
Bug: 160642814
Change-Id: I4f7e5756b411708fa60ffeb00ae3b76aa1dedf66

M navigation/navigation-runtime/api/current.txt
M navigation/navigation-runtime/api/public_plus_experimental_current.txt
M navigation/navigation-runtime/api/restricted_current.txt
D navigation/navigation-runtime/src/main/java/androidx/navigation/NavBackStackEntry.java
A navigation/navigation-runtime/src/main/java/androidx/navigation/NavBackStackEntry.kt
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavBackStackEntryState.kt
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.java

https://android-review.googlesource.com/1557313

ap...@google.com <ap...@google.com> #23Mar 2, 2021 04:27PM

Project: platform/frameworks/support
Branch: androidx-main

commit 3d360389e67c04f76b16002be3de8615286a0874
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Jan 21 13:26:47 2021

Convert NavGraphNavigator to Kotlin

Converted NavGraphNavigator to Kotlin.

RelNote: N/A
Test: ./gradlew checkApi
Bug: 160642814
Change-Id: Ie58f94ad169d26406e9d2f57bf7f706fb089200f

M navigation/navigation-common/api/current.txt
M navigation/navigation-common/api/public_plus_experimental_current.txt
M navigation/navigation-common/api/restricted_current.txt
D navigation/navigation-common/src/main/java/androidx/navigation/NavGraphNavigator.java
A navigation/navigation-common/src/main/java/androidx/navigation/NavGraphNavigator.kt

https://android-review.googlesource.com/1556785

ap...@google.com <ap...@google.com> #24Mar 2, 2021 04:27PM

Project: platform/frameworks/support
Branch: androidx-main

commit 9098881304271b04abcaebe5d64483a5a10f150a
Author: Jeremy Woods <jbwoods@google.com>
Date: Sat Feb 27 01:55:41 2021

Convert NavGraph to Kotlin

Converted NavGraph to Kotlin.

RelNote: N/A
Test: ./gradlew checkApi
Bug: 160642814
Change-Id: I79af9549ef1f30354af0f785254b359d2fc353d4

M navigation/navigation-common/api/current.ignore
M navigation/navigation-common/api/current.txt
M navigation/navigation-common/api/public_plus_experimental_current.txt
M navigation/navigation-common/api/restricted_current.ignore
M navigation/navigation-common/api/restricted_current.txt
D navigation/navigation-common/src/main/java/androidx/navigation/NavGraph.java
A navigation/navigation-common/src/main/java/androidx/navigation/NavGraph.kt
M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavInflaterTest.kt

https://android-review.googlesource.com/1556782

ap...@google.com <ap...@google.com> #25Mar 2, 2021 04:27PM

Project: platform/frameworks/support
Branch: androidx-main

commit 0660bae4ddf99deb63ec078fc054f78e2e52252b
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Jan 21 13:40:09 2021

Convert Navigator to Kotlin

Converted Navigator to Kotlin.

RelNote: N/A
Test: ./gradlew checkApi
Bug: 160642814
Change-Id: I68fae73595665e4ec17f95f1edfd1e2a26cc93c1

M navigation/navigation-common/api/current.txt
M navigation/navigation-common/api/public_plus_experimental_current.txt
M navigation/navigation-common/api/restricted_current.txt
D navigation/navigation-common/src/main/java/androidx/navigation/Navigator.java
A navigation/navigation-common/src/main/java/androidx/navigation/Navigator.kt
M navigation/navigation-fragment/src/main/java/androidx/navigation/fragment/DialogFragmentNavigator.kt
M navigation/navigation-fragment/src/main/java/androidx/navigation/fragment/NavHostFragment.kt

https://android-review.googlesource.com/1556739

ap...@google.com <ap...@google.com> #26Mar 2, 2021 04:27PM

Project: platform/frameworks/support
Branch: androidx-main

commit 3f75946cee97486813087b534867fe33642abc8e
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Jan 21 14:28:05 2021

Convert NavOptions to Kotlin

Converted NavOptions to Kotlin.

RelNote: N/A
Test: ./gradlew checkApi
Bug: 160642814
Change-Id: I3bf4491e22ad6510860f16b0a2c32eeb38e5d79b

M navigation/navigation-common-ktx/src/androidTest/java/androidx/navigation/NavOptionsBuilderTest.kt
M navigation/navigation-common/api/current.txt
M navigation/navigation-common/api/public_plus_experimental_current.txt
M navigation/navigation-common/api/restricted_current.txt
D navigation/navigation-common/src/main/java/androidx/navigation/NavOptions.java
A navigation/navigation-common/src/main/java/androidx/navigation/NavOptions.kt

https://android-review.googlesource.com/1556713

ap...@google.com <ap...@google.com> #27Mar 2, 2021 04:27PM

Project: platform/frameworks/support
Branch: androidx-main

commit 6eef082144cd95e27fa42f031e7fee61d73f4716
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Jan 21 14:17:34 2021

Convert NavProvider to Kotlin

Converted NavProvider to Kotlin.

RelNote: N/A
Test: ./gradlew checkApi
Bug: 160642814
Change-Id: I31d69791e2a9e85ff1771dde44456f6e8953e7bf

M navigation/navigation-common/api/current.txt
M navigation/navigation-common/api/public_plus_experimental_current.txt
M navigation/navigation-common/api/restricted_current.txt
D navigation/navigation-common/src/main/java/androidx/navigation/NavigatorProvider.java
A navigation/navigation-common/src/main/java/androidx/navigation/NavigatorProvider.kt

https://android-review.googlesource.com/1556711

ap...@google.com <ap...@google.com> #28Mar 2, 2021 04:27PM

Project: platform/frameworks/support
Branch: androidx-main

commit 71e5fe591012ea9d748e17b9e1db95dae26d2297
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Jan 21 12:15:01 2021

Convert NavAction to Kotlin

Converted the NavAction class to Kotlin.

RelNote: N/A
Test: ./gradlew checkApi
Bug: 160642814
Change-Id: If373257e2999e57cdbc4e929cb2d8f3bc6ee1bf3

M navigation/navigation-common/api/current.txt
M navigation/navigation-common/api/public_plus_experimental_current.txt
M navigation/navigation-common/api/restricted_current.txt
D navigation/navigation-common/src/main/java/androidx/navigation/NavAction.java
A navigation/navigation-common/src/main/java/androidx/navigation/NavAction.kt

https://android-review.googlesource.com/1556512

ap...@google.com <ap...@google.com> #29Mar 2, 2021 04:27PM

Project: platform/frameworks/support
Branch: androidx-main

commit 468f4f8ae9bcdacf993c8ec0dfd2f9d0b81f5a38
Author: Jeremy Woods <jbwoods@google.com>
Date: Sat Feb 27 01:47:53 2021

Convert NavDestination to Kotlin

Converted the NavDestination class to Kotlin.

RelNote: N/A
Test: ./gradlew checkApi
Bug: 160642814
Change-Id: I59bce050a425180badeaffba9a0cbcceee45ba3a

M navigation/navigation-common/api/current.ignore
M navigation/navigation-common/api/current.txt
M navigation/navigation-common/api/public_plus_experimental_current.txt
M navigation/navigation-common/api/restricted_current.ignore
M navigation/navigation-common/api/restricted_current.txt
D navigation/navigation-common/src/main/java/androidx/navigation/NavDestination.java
A navigation/navigation-common/src/main/java/androidx/navigation/NavDestination.kt
M navigation/navigation-common/src/test/java/androidx/navigation/NavDestinationTest.kt

https://android-review.googlesource.com/1556511

ap...@google.com <ap...@google.com> #30Mar 2, 2021 04:27PM

Project: platform/frameworks/support
Branch: androidx-main

commit 444c6cf0f6522f7c975abfaa5a30a46fa2faa8a7
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Jan 07 22:38:44 2021

Convert NavDeepLinkRequest to Kotlin

Converted NavDeepLinkRequest to Kotlin.

RelNote: N/A
Test: ./gradlew checkApi
Bug: 160642814
Change-Id: I14807479fb99eab8c23a84d1f5a0cfa002cb53b1

M navigation/navigation-common/api/current.txt
M navigation/navigation-common/api/public_plus_experimental_current.txt
M navigation/navigation-common/api/restricted_current.txt
D navigation/navigation-common/src/main/java/androidx/navigation/NavDeepLinkRequest.java
A navigation/navigation-common/src/main/java/androidx/navigation/NavDeepLinkRequest.kt

https://android-review.googlesource.com/1544029

ap...@google.com <ap...@google.com> #31Mar 2, 2021 04:27PM

Project: platform/frameworks/support
Branch: androidx-main

commit 125c6fc59db3325e61b71f0bdc75f95da9d6a6bb
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Jan 07 18:38:12 2021

Convert NavDeepLink to Kotlin

Converted NavDeepLink to Kotlin.

RelNote: N/A
Test: ./gradlew checkApi
Bug: 160642814
Change-Id: I225b1d9edb6fb708829c4d410612c252ab090c11

M navigation/navigation-common/api/current.txt
M navigation/navigation-common/api/public_plus_experimental_current.txt
M navigation/navigation-common/api/restricted_current.txt
D navigation/navigation-common/src/main/java/androidx/navigation/NavDeepLink.java
A navigation/navigation-common/src/main/java/androidx/navigation/NavDeepLink.kt

https://android-review.googlesource.com/1544028

ap...@google.com <ap...@google.com> #32Mar 2, 2021 04:28PM

Project: platform/frameworks/support
Branch: androidx-main

commit c96f086025475e67f9eb82757369fbb52c43fad7
Author: Jeremy Woods <jbwoods@google.com>
Date: Sat Feb 27 01:40:50 2021

Convert NavArgument to Kotlin

Converted the NavArgument class to Kotlin.

RelNote: N/A
Test: ./gradlew checkApi
Bug: 160642814
Change-Id: I86a1b325911ad129d69adcfd644c3b3fb8918a7b

M navigation/navigation-common/api/current.ignore
M navigation/navigation-common/api/current.txt
M navigation/navigation-common/api/public_plus_experimental_current.txt
M navigation/navigation-common/api/restricted_current.ignore
M navigation/navigation-common/api/restricted_current.txt
M navigation/navigation-common/src/androidTest/java/androidx/navigation/test/NavArgument.kt
D navigation/navigation-common/src/main/java/androidx/navigation/NavArgument.java
A navigation/navigation-common/src/main/java/androidx/navigation/NavArgument.kt

https://android-review.googlesource.com/1543711

ap...@google.com <ap...@google.com> #33Mar 2, 2021 04:28PM

Project: platform/frameworks/support
Branch: androidx-main

commit 8f57617761e2923bd90bc97a3e1a28b1a697ab8f
Author: Jeremy Woods <jbwoods@google.com>
Date: Mon Jan 11 09:19:27 2021

Convert NavType to Kotlin

Converted the NavType class to Kotlin.

RelNote: N/A
Test: ./gradlew checkApi
Bug: 160642814
Change-Id: Ife16eb2aea7dc8e414610e0213d8c56fc082bc22

M navigation/navigation-common/api/api_lint.ignore
A navigation/navigation-common/api/current.ignore
M navigation/navigation-common/api/current.txt
M navigation/navigation-common/api/public_plus_experimental_current.txt
A navigation/navigation-common/api/restricted_current.ignore
M navigation/navigation-common/api/restricted_current.txt
D navigation/navigation-common/src/main/java/androidx/navigation/NavType.java
A navigation/navigation-common/src/main/java/androidx/navigation/NavType.kt

https://android-review.googlesource.com/1543624

ap...@google.com <ap...@google.com> #34Mar 2, 2021 04:28PM

Project: platform/frameworks/support
Branch: androidx-main

commit db06a28ece3cf182beda404961ec62e0a3e779a5
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Jan 21 16:38:30 2021

Convert ActivityNavigator to Kotlin

Converted the ActivityNavigator class to Kotlin.

RelNote: N/A
Test: ./gradlew checkApi
Bug: 160642814
Change-Id: I561646fbb8902acb0b73a7a95fa056a4b1930af1

M navigation/navigation-dynamic-features-runtime/src/androidTest/java/androidx/navigation/dynamicfeatures/DynamicActivityNavigatorTest.kt
M navigation/navigation-dynamic-features-runtime/src/main/java/androidx/navigation/dynamicfeatures/DynamicActivityNavigatorDestinationBuilder.kt
M navigation/navigation-runtime-ktx/src/main/java/androidx/navigation/ActivityNavigatorDestinationBuilder.kt
M navigation/navigation-runtime/api/current.txt
M navigation/navigation-runtime/api/public_plus_experimental_current.txt
M navigation/navigation-runtime/api/restricted_current.txt
M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/ActivityNavigatorTest.kt
D navigation/navigation-runtime/src/main/java/androidx/navigation/ActivityNavigator.java
A navigation/navigation-runtime/src/main/java/androidx/navigation/ActivityNavigator.kt

https://android-review.googlesource.com/1532573

ap...@google.com <ap...@google.com> #35Mar 2, 2021 04:28PM

Project: platform/frameworks/support
Branch: androidx-main

commit 0e6e21df0e44369df9faf1ced8794b9bd5f875a1
Author: Jeremy Woods <jbwoods@google.com>
Date: Mon Nov 09 13:29:07 2020

Convert NavHost interface to Kotlin

Converted the NavHost interface to Kotlin and added a dependency on the
Kotlin StdLib.

RelNote: N/A
Test: ./gradlew checkApi
Bug: 160642814

Change-Id: I70d2ff9e8cfa001c66fc07f4148e219d0d02543f

M navigation/navigation-fragment/api/current.txt
M navigation/navigation-fragment/api/public_plus_experimental_current.txt
M navigation/navigation-fragment/api/restricted_current.txt
M navigation/navigation-fragment/src/main/java/androidx/navigation/fragment/NavHostFragment.kt
M navigation/navigation-runtime-ktx/src/androidTest/java/androidx/navigation/NavHostTest.kt
M navigation/navigation-runtime/api/current.txt
M navigation/navigation-runtime/api/public_plus_experimental_current.txt
M navigation/navigation-runtime/api/restricted_current.txt
D navigation/navigation-runtime/src/main/java/androidx/navigation/NavHost.java
A navigation/navigation-runtime/src/main/java/androidx/navigation/NavHost.kt

https://android-review.googlesource.com/1532132

ap...@google.com <ap...@google.com> #36Mar 2, 2021 04:28PM

Project: platform/frameworks/support
Branch: androidx-main

commit 9b91a84d94fad51d5c11b7390e59ae185870eb73
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Dec 17 12:58:47 2020

Convert ActionOnlyNavDirections class to Kotlin

Converted the ActionOnlyNavDirections class to Kotlin.

RelNote: N/A
Test: ./gradlew checkApi
Bug: 160642814
Change-Id: I04dec9618922746591fcca6f6eddaee9abbb3194

M navigation/navigation-common/api/current.txt
M navigation/navigation-common/api/public_plus_experimental_current.txt
M navigation/navigation-common/api/restricted_current.txt
D navigation/navigation-common/src/main/java/androidx/navigation/ActionOnlyNavDirections.java
A navigation/navigation-common/src/main/java/androidx/navigation/ActionOnlyNavDirections.kt

https://android-review.googlesource.com/1532052

ap...@google.com <ap...@google.com> #37Mar 2, 2021 04:28PM

Project: platform/frameworks/support
Branch: androidx-main

commit d87afe7bd6dde2299603313bc1c843337e0af308
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Dec 17 12:36:35 2020

Convert NavDirections interface to Kotlin

Converted the NavDirections interface to Kotlin.

RelNote: N/A
Test: ./gradlew checkApi
Bug: 160642814
Change-Id: I3d464ef695216cb1a37f2b46e6049615c68f0f71

M navigation/navigation-common/api/current.txt
M navigation/navigation-common/api/public_plus_experimental_current.txt
M navigation/navigation-common/api/restricted_current.txt
M navigation/navigation-common/src/main/java/androidx/navigation/NavDirections.kt

https://android-review.googlesource.com/1532050

jb...@google.com <jb...@google.com> #38Mar 30, 2021 05:43PM

Marked as fixed.

This has been fixed internally and will be available in the Navigation 2.4.0-alpha01 release.