ConcurrentModificationException: TreeMap$PrivateEntryIterator.nextEntry [160769273]

Fixed

Bug

Status Update

No update yet.

Description

yo...@gmail.com

created issue #1

Jul 9, 2020 12:45AM

AGP 4.0.0 JDK 11.0.7 Gradle 6.5

Not reproducible...

> Task :app:minifyReleaseWithR8
R8: Missing class: java.lang.instrument.ClassFileTransformer
R8: Missing class: sun.misc.SignalHandler
R8: Missing class: org.conscrypt.ConscryptHostnameVerifier
R8: Library class android.content.res.XmlResourceParser implements program class org.xmlpull.v1.XmlPullParser
~/.gradle/caches/transforms-2/files-2.1/99a06b4b028d9265de10c97aa4597a8e/jetified-kotlin-reflect-1.3.72.jar: R8: com.android.tools.r8.errors.a
	at com.android.tools.r8.ir.conversion.O.b(:57)
	at com.android.tools.r8.ir.conversion.O.a(:390)
	at com.android.tools.r8.ir.conversion.O.a(:336)
	at com.android.tools.r8.utils.S0.a(:10)
	at java.base/java.util.concurrent.ForkJoinTask$AdaptedCallable.exec(ForkJoinTask.java:1448)
	at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:290)
	at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1020)
	at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1656)
	at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1594)
	at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:177)
	Suppressed: java.util.concurrent.ExecutionException: com.android.tools.r8.errors.a
		at java.base/java.util.concurrent.ForkJoinTask.get(ForkJoinTask.java:1006)
		at com.android.tools.r8.utils.S0.a(:14)
		at com.android.tools.r8.utils.S0.a(:9)
		at com.android.tools.r8.ir.conversion.a0.a(:49)
		at com.android.tools.r8.ir.conversion.O.a(:160)
		at com.android.tools.r8.R8.a(:354)
		at com.android.tools.r8.R8.c(:1)
		at com.android.tools.r8.R8.b(:1)
		at com.android.tools.r8.utils.W.a(:30)
		at com.android.tools.r8.R8.a(:28)
		at com.android.tools.r8.R8.run(:3)
		at com.android.builder.dexing.R8Tool.runR8(r8Tool.kt:247)
		at com.android.build.gradle.internal.tasks.R8Task$Companion.shrink(R8Task.kt:472)
		at com.android.build.gradle.internal.tasks.R8Task.doTaskAction(R8Task.kt:334)
		at com.android.build.gradle.internal.tasks.NonIncrementalTask$taskAction$$inlined$recordTaskAction$1.invoke(AndroidVariantTask.kt:74)
		at com.android.build.gradle.internal.tasks.NonIncrementalTask$taskAction$$inlined$recordTaskAction$1.invoke(AndroidVariantTask.kt:34)
		at com.android.build.gradle.internal.tasks.Blocks.recordSpan(Blocks.java:91)
		at com.android.build.gradle.internal.tasks.NonIncrementalTask.taskAction(NonIncrementalTask.kt:57)
		at jdk.internal.reflect.GeneratedMethodAccessor942.invoke(Unknown Source)
		at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
		at java.base/java.lang.reflect.Method.invoke(Method.java:566)
		at org.gradle.internal.reflect.JavaMethod.invoke(JavaMethod.java:104)
		at org.gradle.api.internal.project.taskfactory.StandardTaskAction.doExecute(StandardTaskAction.java:49)
		at org.gradle.api.internal.project.taskfactory.StandardTaskAction.execute(StandardTaskAction.java:42)
		at org.gradle.api.internal.project.taskfactory.StandardTaskAction.execute(StandardTaskAction.java:28)
		at org.gradle.api.internal.AbstractTask$TaskActionWrapper.execute(AbstractTask.java:726)
		at org.gradle.api.internal.AbstractTask$TaskActionWrapper.execute(AbstractTask.java:693)
		at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter$3.run(ExecuteActionsTaskExecuter.java:569)
		at org.gradle.internal.operations.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:395)
		at org.gradle.internal.operations.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:387)
		at org.gradle.internal.operations.DefaultBuildOperationExecutor$1.execute(DefaultBuildOperationExecutor.java:157)
		at org.gradle.internal.operations.DefaultBuildOperationExecutor.execute(DefaultBuildOperationExecutor.java:242)
		at org.gradle.internal.operations.DefaultBuildOperationExecutor.execute(DefaultBuildOperationExecutor.java:150)
		at org.gradle.internal.operations.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:84)
		at org.gradle.internal.operations.DelegatingBuildOperationExecutor.run(DelegatingBuildOperationExecutor.java:31)
		at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeAction(ExecuteActionsTaskExecuter.java:554)
		at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:537)
		at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.access$300(ExecuteActionsTaskExecuter.java:108)
		at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter$TaskExecution.executeWithPreviousOutputFiles(ExecuteActionsTaskExecuter.java:278)
		at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter$TaskExecution.execute(ExecuteActionsTaskExecuter.java:267)
		at org.gradle.internal.execution.steps.ExecuteStep.lambda$execute$1(ExecuteStep.java:33)
		at java.base/java.util.Optional.orElseGet(Optional.java:369)
		at org.gradle.internal.execution.steps.ExecuteStep.execute(ExecuteStep.java:33)
		at org.gradle.internal.execution.steps.ExecuteStep.execute(ExecuteStep.java:26)
		at org.gradle.internal.execution.steps.CleanupOutputsStep.execute(CleanupOutputsStep.java:67)
		at org.gradle.internal.execution.steps.CleanupOutputsStep.execute(CleanupOutputsStep.java:36)
		at org.gradle.internal.execution.steps.ResolveInputChangesStep.execute(ResolveInputChangesStep.java:49)
		at org.gradle.internal.execution.steps.ResolveInputChangesStep.execute(ResolveInputChangesStep.java:34)
		at org.gradle.internal.execution.steps.CancelExecutionStep.execute(CancelExecutionStep.java:43)
		at org.gradle.internal.execution.steps.TimeoutStep.executeWithoutTimeout(TimeoutStep.java:73)
		at org.gradle.internal.execution.steps.TimeoutStep.execute(TimeoutStep.java:54)
		at org.gradle.internal.execution.steps.CatchExceptionStep.execute(CatchExceptionStep.java:34)
		at org.gradle.internal.execution.steps.CreateOutputsStep.execute(CreateOutputsStep.java:44)
		at org.gradle.internal.execution.steps.SnapshotOutputsStep.execute(SnapshotOutputsStep.java:54)
		at org.gradle.internal.execution.steps.SnapshotOutputsStep.execute(SnapshotOutputsStep.java:38)
		at org.gradle.internal.execution.steps.BroadcastChangingOutputsStep.execute(BroadcastChangingOutputsStep.java:49)
		at org.gradle.internal.execution.steps.CacheStep.executeWithoutCache(CacheStep.java:159)
		at org.gradle.internal.execution.steps.CacheStep.executeAndStoreInCache(CacheStep.java:135)
		at org.gradle.internal.execution.steps.CacheStep.lambda$executeWithCache$2(CacheStep.java:112)
		at java.base/java.util.Optional.orElseGet(Optional.java:369)
		at org.gradle.internal.execution.steps.CacheStep.lambda$executeWithCache$3(CacheStep.java:112)
		at org.gradle.internal.Try$Success.map(Try.java:162)
		at org.gradle.internal.execution.steps.CacheStep.executeWithCache(CacheStep.java:81)
		at org.gradle.internal.execution.steps.CacheStep.execute(CacheStep.java:71)
		at org.gradle.internal.execution.steps.CacheStep.execute(CacheStep.java:43)
		at org.gradle.internal.execution.steps.StoreExecutionStateStep.execute(StoreExecutionStateStep.java:44)
		at org.gradle.internal.execution.steps.StoreExecutionStateStep.execute(StoreExecutionStateStep.java:33)
		at org.gradle.internal.execution.steps.RecordOutputsStep.execute(RecordOutputsStep.java:38)
		at org.gradle.internal.execution.steps.RecordOutputsStep.execute(RecordOutputsStep.java:24)
		at org.gradle.internal.execution.steps.SkipUpToDateStep.executeBecause(SkipUpToDateStep.java:92)
		at org.gradle.internal.execution.steps.SkipUpToDateStep.lambda$execute$0(SkipUpToDateStep.java:85)
		at java.base/java.util.Optional.map(Optional.java:265)
		at org.gradle.internal.execution.steps.SkipUpToDateStep.execute(SkipUpToDateStep.java:55)
		at org.gradle.internal.execution.steps.SkipUpToDateStep.execute(SkipUpToDateStep.java:39)
		at org.gradle.internal.execution.steps.ResolveChangesStep.execute(ResolveChangesStep.java:76)
		at org.gradle.internal.execution.steps.ResolveChangesStep.execute(ResolveChangesStep.java:37)
		at org.gradle.internal.execution.steps.legacy.MarkSnapshottingInputsFinishedStep.execute(MarkSnapshottingInputsFinishedStep.java:36)
		at org.gradle.internal.execution.steps.legacy.MarkSnapshottingInputsFinishedStep.execute(MarkSnapshottingInputsFinishedStep.java:26)
		at org.gradle.internal.execution.steps.ResolveCachingStateStep.execute(ResolveCachingStateStep.java:94)
		at org.gradle.internal.execution.steps.ResolveCachingStateStep.execute(ResolveCachingStateStep.java:49)
		at org.gradle.internal.execution.steps.CaptureStateBeforeExecutionStep.execute(CaptureStateBeforeExecutionStep.java:79)
		at org.gradle.internal.execution.steps.CaptureStateBeforeExecutionStep.execute(CaptureStateBeforeExecutionStep.java:53)
		at org.gradle.internal.execution.steps.ValidateStep.execute(ValidateStep.java:74)
		at org.gradle.internal.execution.steps.SkipEmptyWorkStep.lambda$execute$2(SkipEmptyWorkStep.java:78)
		at java.base/java.util.Optional.orElseGet(Optional.java:369)
		at org.gradle.internal.execution.steps.SkipEmptyWorkStep.execute(SkipEmptyWorkStep.java:78)
		at org.gradle.internal.execution.steps.SkipEmptyWorkStep.execute(SkipEmptyWorkStep.java:34)
		at org.gradle.internal.execution.steps.legacy.MarkSnapshottingInputsStartedStep.execute(MarkSnapshottingInputsStartedStep.java:39)
		at org.gradle.internal.execution.steps.LoadExecutionStateStep.execute(LoadExecutionStateStep.java:40)
		at org.gradle.internal.execution.steps.LoadExecutionStateStep.execute(LoadExecutionStateStep.java:28)
		at org.gradle.internal.execution.impl.DefaultWorkExecutor.execute(DefaultWorkExecutor.java:33)
		at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeIfValid(ExecuteActionsTaskExecuter.java:194)
		at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:186)
		at org.gradle.api.internal.tasks.execution.CleanupStaleOutputsExecuter.execute(CleanupStaleOutputsExecuter.java:114)
		at org.gradle.api.internal.tasks.execution.FinalizePropertiesTaskExecuter.execute(FinalizePropertiesTaskExecuter.java:46)
		at org.gradle.api.internal.tasks.execution.ResolveTaskExecutionModeExecuter.execute(ResolveTaskExecutionModeExecuter.java:62)
		at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:57)
		at org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:56)
		at org.gradle.api.internal.tasks.execution.CatchExceptionTaskExecuter.execute(CatchExceptionTaskExecuter.java:36)
		at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.executeTask(EventFiringTaskExecuter.java:77)
		at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.call(EventFiringTaskExecuter.java:55)
		at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.call(EventFiringTaskExecuter.java:52)
		at org.gradle.internal.operations.DefaultBuildOperationExecutor$CallableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:409)
		at org.gradle.internal.operations.DefaultBuildOperationExecutor$CallableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:399)
		at org.gradle.internal.operations.DefaultBuildOperationExecutor$1.execute(DefaultBuildOperationExecutor.java:157)
		at org.gradle.internal.operations.DefaultBuildOperationExecutor.execute(DefaultBuildOperationExecutor.java:242)
		at org.gradle.internal.operations.DefaultBuildOperationExecutor.execute(DefaultBuildOperationExecutor.java:150)
		at org.gradle.internal.operations.DefaultBuildOperationExecutor.call(DefaultBuildOperationExecutor.java:94)
		at org.gradle.internal.operations.DelegatingBuildOperationExecutor.call(DelegatingBuildOperationExecutor.java:36)
		at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter.execute(EventFiringTaskExecuter.java:52)
		at org.gradle.execution.plan.LocalTaskNodeExecutor.execute(LocalTaskNodeExecutor.java:41)
		at org.gradle.execution.taskgraph.DefaultTaskExecutionGraph$InvokeNodeExecutorsAction.execute(DefaultTaskExecutionGraph.java:356)
		at org.gradle.execution.taskgraph.DefaultTaskExecutionGraph$InvokeNodeExecutorsAction.execute(DefaultTaskExecutionGraph.java:343)
		at org.gradle.execution.taskgraph.DefaultTaskExecutionGraph$BuildOperationAwareExecutionAction.execute(DefaultTaskExecutionGraph.java:336)
		at org.gradle.execution.taskgraph.DefaultTaskExecutionGraph$BuildOperationAwareExecutionAction.execute(DefaultTaskExecutionGraph.java:322)
		at org.gradle.execution.plan.DefaultPlanExecutor$ExecutorWorker.lambda$run$0(DefaultPlanExecutor.java:127)
		at org.gradle.execution.plan.DefaultPlanExecutor$ExecutorWorker.execute(DefaultPlanExecutor.java:191)
		at org.gradle.execution.plan.DefaultPlanExecutor$ExecutorWorker.executeNextNode(DefaultPlanExecutor.java:182)
		at org.gradle.execution.plan.DefaultPlanExecutor$ExecutorWorker.run(DefaultPlanExecutor.java:124)
		at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:64)
		at org.gradle.internal.concurrent.ManagedExecutorImpl$1.run(ManagedExecutorImpl.java:48)
		at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
		at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
		at org.gradle.internal.concurrent.ThreadFactoryImpl$ManagedThreadRunnable.run(ThreadFactoryImpl.java:56)
		at java.base/java.lang.Thread.run(Thread.java:834)
	[CIRCULAR REFERENCE:com.android.tools.r8.errors.a]
Caused by: java.util.ConcurrentModificationException
	at java.base/java.util.TreeMap$PrivateEntryIterator.nextEntry(TreeMap.java:1208)
	at java.base/java.util.TreeMap$KeyIterator.next(TreeMap.java:1262)
	at com.android.tools.r8.graph.d.a(:146)
	at com.android.tools.r8.graph.d.mayHaveFinalizeMethodDirectlyOrIndirectly(:10)
	at com.android.tools.r8.u.b.S.a(:26)
	at com.android.tools.r8.u.b.g0.c(:11)
	at com.android.tools.r8.u.b.g0.a(:62)
	at com.android.tools.r8.ir.optimize.o.b(:19)
	at com.android.tools.r8.ir.conversion.O.a(:609)
	at com.android.tools.r8.ir.conversion.O.a(:417)
	at com.android.tools.r8.ir.conversion.O.b(:53)
	... 9 more

Comments

ze...@google.com <ze...@google.com> #2Jul 9, 2020 04:21AM

Reassigned to ze...@google.com.

I gather that by not reproducible, you can't reliably get the same error again?

retraced at 2.0.74:
~/.gradle/caches/transforms-2/files-2.1/99a06b4b028d9265de10c97aa4597a8e/jetified-kotlin-reflect-1.3.72.jar: R8: com.android.tools.r8.errors.CompilationError
at com.android.tools.r8.utils.ExceptionUtils.withOriginAttachmentHandler(ExceptionUtils.java:145)
at com.android.tools.r8.ir.conversion.IRConverter.rewriteCode(IRConverter.java:1068)
at com.android.tools.r8.ir.conversion.IRConverter.processMethod(IRConverter.java:1050)
at com.android.tools.r8.ir.conversion.IRConverter.lambda$optimize$4(IRConverter.java:672)
at com.android.tools.r8.utils.ThreadUtils.lambda$processItems$0(ThreadUtils.java:25)
at java.base/java.util.concurrent.ForkJoinTask$AdaptedCallable.exec(ForkJoinTask.java:1448)
at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:290)
at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1020)
at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1656)
at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1594)
at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:177)
Suppressed: java.util.concurrent.ExecutionException: com.android.tools.r8.errors.CompilationError
at java.base/java.util.concurrent.ForkJoinTask.get(ForkJoinTask.java:1006)
at com.android.tools.r8.utils.ThreadUtils.awaitFutures(ThreadUtils.java:37)
at com.android.tools.r8.utils.ThreadUtils.processItems(ThreadUtils.java:29)
at com.android.tools.r8.ir.conversion.PrimaryMethodProcessor.forEachMethod(PrimaryMethodProcessor.java:147)
at com.android.tools.r8.ir.conversion.IRConverter.optimize(IRConverter.java:671)
at com.android.tools.r8.R8.run(R8.java:514)
at com.android.tools.r8.R8.run(R8.java:242)
at com.android.tools.r8.R8.lambda$runForTesting$1(R8.java:233)
at com.android.tools.r8.utils.ExceptionUtils.withCompilationHandler(ExceptionUtils.java:69)
at com.android.tools.r8.utils.ExceptionUtils.withR8CompilationHandler(ExceptionUtils.java:57)
at com.android.tools.r8.R8.runForTesting(R8.java:229)
at com.android.tools.r8.R8.run(R8.java:164)
at com.android.builder.dexing.R8Tool.runR8(r8Tool.kt:247)
<snip>
[CIRCULAR REFERENCE:com.android.tools.r8.errors.a]
Caused by: java.util.ConcurrentModificationException
at java.base/java.util.TreeMap$PrivateEntryIterator.nextEntry(TreeMap.java:1208)
at java.base/java.util.TreeMap$KeyIterator.next(TreeMap.java:1262)
at com.android.tools.r8.graph.AppInfoWithSubtyping.computeMayHaveFinalizeMethodDirectlyOrIndirectlyIfAbsent(AppInfoWithSubtyping.java:765)
at com.android.tools.r8.graph.AppInfoWithSubtyping.mayHaveFinalizeMethodDirectlyOrIndirectly(AppInfoWithSubtyping.java:733)
at com.android.tools.r8.ir.code.FieldInstruction.isStoringObjectWithFinalizer(FieldInstruction.java:202)
at com.android.tools.r8.ir.code.InstancePut.instructionMayHaveSideEffects(InstancePut.java:114)
at com.android.tools.r8.ir.code.InstancePut.canBeDeadCode(InstancePut.java:129)
at com.android.tools.r8.ir.optimize.DeadCodeRemover.removeDeadInstructions(DeadCodeRemover.java:102)
at com.android.tools.r8.ir.optimize.DeadCodeRemover.run(DeadCodeRemover.java:47)
at com.android.tools.r8.ir.conversion.IRConverter.optimize(IRConverter.java:1291)
at com.android.tools.r8.ir.conversion.IRConverter.rewriteCodeInternal(IRConverter.java:1100)
at com.android.tools.r8.ir.conversion.IRConverter.lambda$rewriteCode$12(IRConverter.java:1072)
at com.android.tools.r8.utils.ExceptionUtils.withOriginAttachmentHandler(ExceptionUtils.java:141)
at com.android.tools.r8.ir.conversion.IRConverter.rewriteCode(IRConverter.java:1068)
... 9 more

yo...@gmail.com <yo...@gmail.com> #3Jul 9, 2020 05:35AM

Yeah, happened once on a CI build, but passed the next time

ri...@google.com <ri...@google.com> Jul 9, 2020 05:45AM

Reassigned to ri...@google.com.

ap...@google.com <ap...@google.com> #4Jul 9, 2020 06:56AM

Project: r8
Branch: 2.0

commit 8f22291dc66be5e8a603fde5343df520bc638f18
Author: Rico Wind <ricow@google.com>
Date: Thu Jul 09 08:34:34 2020

Version 2.0.95

This is not a cherry pick since this class is no longer available on
master.

Make iteration of directSubtypes thread safe

If we are synthesizing a class and adding it while iterating
the directSubtypes collection we might mutate the collection
concurrently.

Bug: 160769273
Change-Id: I97f1021747b7466df979ad624e38684c3d949aa2

M src/main/java/com/android/tools/r8/Version.java
M src/main/java/com/android/tools/r8/graph/AppInfoWithSubtyping.java

https://r8-review.googlesource.com/52520

ri...@google.com <ri...@google.com> #5Jul 9, 2020 06:58AM

Marked as fixed.

This is a problem that only exists on the R8 2.0 branch (and earlier) which is what is used for AGP 4.0
I landed a fix on our branch, but this might not make it into any 4.0 release before 4.1 goes stable.
4.1 has a different version of R8 that does not have this issue.

Issue 160769273