Fixed
Status Update
Comments
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 480bb79cbeca04ad5d07dd7364dc825086942a8b
Author: Ralston Da Silva <ralu@google.com>
Date: Mon Jul 20 12:56:09 2020
Use new Focus API for KeyInput
Update the KeyInputModifier and related code so that it uses the new focus modifiers
Bug: 157593719
Bug: 161296854
Bug: 160821157
Fixes: 161296854
Fixes: 157593719
Test: Updated related tests
Change-Id: I5468f4969cdebbffa1e7e12e8ecbb7e73f2f181a
M ui/ui-core/integration-tests/ui-core-demos/src/main/java/androidx/ui/core/demos/keyinput/KeyInputDemo.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/core/keyinput/AndroidProcessKeyInputTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/core/keyinput/ProcessKeyInputTest.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/keyinput/KeyInputModifier.kt
https://android-review.googlesource.com/1367297
Branch: androidx-master-dev
commit 480bb79cbeca04ad5d07dd7364dc825086942a8b
Author: Ralston Da Silva <ralu@google.com>
Date: Mon Jul 20 12:56:09 2020
Use new Focus API for KeyInput
Update the KeyInputModifier and related code so that it uses the new focus modifiers
Bug: 157593719
Bug: 161296854
Bug: 160821157
Fixes: 161296854
Fixes: 157593719
Test: Updated related tests
Change-Id: I5468f4969cdebbffa1e7e12e8ecbb7e73f2f181a
M ui/ui-core/integration-tests/ui-core-demos/src/main/java/androidx/ui/core/demos/keyinput/KeyInputDemo.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/core/keyinput/AndroidProcessKeyInputTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/core/keyinput/ProcessKeyInputTest.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/keyinput/KeyInputModifier.kt
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-master-dev
commit ad70d26a642fb5bfcfd44c27ace9f00ef75de06e
Author: Ralston Da Silva <ralu@google.com>
Date: Fri Jul 24 12:40:16 2020
Tests for the New Focus Modifier API
Migrate FocusModifier tests to test the new focus API.
ie. Test Modifier.focus() Modifier.focusRequester() and Modifier.focusObserver
While writing tests, I found a small bug in clearFocus(). Included a fix.
Bug: 161299807
Bug: 160821157
Fixes: 161299807
Test: This CL consists of tests
Change-Id: I6724f19d15f99b4a6edf1edcb369cc5aff15595c
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/core/focus/CaptureFocusTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/core/focus/ClearFocusTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/core/focus/FindFocusableChildrenTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/core/focus/FindParentFocusNodeTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/core/focus/FocusTestUtils.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/core/focus/FreeFocusTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/core/focus/OwnerFocusTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/core/focus/RequestFocusTest.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/focus/ModifiedFocusNode2.kt
https://android-review.googlesource.com/1372657
Branch: androidx-master-dev
commit ad70d26a642fb5bfcfd44c27ace9f00ef75de06e
Author: Ralston Da Silva <ralu@google.com>
Date: Fri Jul 24 12:40:16 2020
Tests for the New Focus Modifier API
Migrate FocusModifier tests to test the new focus API.
ie. Test Modifier.focus() Modifier.focusRequester() and Modifier.focusObserver
While writing tests, I found a small bug in clearFocus(). Included a fix.
Bug: 161299807
Bug: 160821157
Fixes: 161299807
Test: This CL consists of tests
Change-Id: I6724f19d15f99b4a6edf1edcb369cc5aff15595c
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/core/focus/CaptureFocusTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/core/focus/ClearFocusTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/core/focus/FindFocusableChildrenTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/core/focus/FindParentFocusNodeTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/core/focus/FocusTestUtils.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/core/focus/FreeFocusTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/core/focus/OwnerFocusTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/core/focus/RequestFocusTest.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/focus/ModifiedFocusNode2.kt
ra...@google.com <ra...@google.com>
ap...@google.com <ap...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 228085e8d5f891a40d855254db35abd10d71d3e2
Author: Ralston Da Silva <ralu@google.com>
Date: Wed Aug 12 03:34:16 2020
Deleting deprecated focus code which was replaced by the new focus API
Bug: 160922116
Bug: 160821157
Bug: 162441435
Bug: 160822875
Bug: 160921940
Test: N/A removing unused code
Relnote: Removed deprecated FocusModifier
Change-Id: I0b4ba5c6f28b683787848042af76ac9ec20c7caf
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeView.kt
D ui/ui-core/src/commonMain/kotlin/androidx/compose/ui/FocusModifier.kt
D ui/ui-core/src/commonMain/kotlin/androidx/compose/ui/focus/FocusModifierImpl.kt
M ui/ui-core/src/commonMain/kotlin/androidx/compose/ui/focus/FocusNodeUtils.kt
M ui/ui-core/src/commonMain/kotlin/androidx/compose/ui/focus/FocusState.kt
M ui/ui-core/src/commonMain/kotlin/androidx/compose/ui/node/DelegatingLayoutNodeWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/compose/ui/node/InnerPlaceable.kt
M ui/ui-core/src/commonMain/kotlin/androidx/compose/ui/node/LayoutNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/compose/ui/node/LayoutNodeWrapper.kt
D ui/ui-core/src/commonMain/kotlin/androidx/compose/ui/node/ModifiedFocusNode.kt
M ui/ui-core/src/desktopMain/kotlin/androidx/compose/ui/platform/DesktopOwner.kt
https://android-review.googlesource.com/1397868
Branch: androidx-master-dev
commit 228085e8d5f891a40d855254db35abd10d71d3e2
Author: Ralston Da Silva <ralu@google.com>
Date: Wed Aug 12 03:34:16 2020
Deleting deprecated focus code which was replaced by the new focus API
Bug: 160922116
Bug: 160821157
Bug: 162441435
Bug: 160822875
Bug: 160921940
Test: N/A removing unused code
Relnote: Removed deprecated FocusModifier
Change-Id: I0b4ba5c6f28b683787848042af76ac9ec20c7caf
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeView.kt
D ui/ui-core/src/commonMain/kotlin/androidx/compose/ui/FocusModifier.kt
D ui/ui-core/src/commonMain/kotlin/androidx/compose/ui/focus/FocusModifierImpl.kt
M ui/ui-core/src/commonMain/kotlin/androidx/compose/ui/focus/FocusNodeUtils.kt
M ui/ui-core/src/commonMain/kotlin/androidx/compose/ui/focus/FocusState.kt
M ui/ui-core/src/commonMain/kotlin/androidx/compose/ui/node/DelegatingLayoutNodeWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/compose/ui/node/InnerPlaceable.kt
M ui/ui-core/src/commonMain/kotlin/androidx/compose/ui/node/LayoutNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/compose/ui/node/LayoutNodeWrapper.kt
D ui/ui-core/src/commonMain/kotlin/androidx/compose/ui/node/ModifiedFocusNode.kt
M ui/ui-core/src/desktopMain/kotlin/androidx/compose/ui/platform/DesktopOwner.kt
Description
No description yet.