Status Update
No update yet.
Comments
ki...@google.com
da...@gmail.com
Could you look into it @christofferqa?
The issue is with this class:
class MySpi : Spi {
@Volatile
private var myApi: Api? = null
// Incorrectly rewritten to return null;
override fun createApi(): Api {
return myApi ?: synchronized(this) {
myApi ?: MyApi().also { myApi = it }
}
}
}
The error seems to be that the ArgumentPropagator believes that the fieldState of myApi is ExactDynamicType(@NotNull MyApi) while it should be ExactDynamicType(@Nullable MyApi)
It then removes the first branch (assuming myApi is not null):
return myApi ?: synchronized(this) {
myApi ?: MyApi().also { myApi = it }
}
is rewritten into:
return myApi
And then it eventually concludes that myApi is always null, replacing the code by
return null
The ArgumentPropagatorCodeScanner analyzes the assignment myApi = it and correctly set join the state to ExactDynamicType(@NotNull MyApi)
However the ArgumentPropagator fails to understand that myApi can be read before being written in the method, relying on the default null value, so it fails to join null to the dynamic type.
sh...@google.com
sm...@google.com
Yes I can take a look. Would it be possible for you to add a regression test of this issue?
ki...@gmail.com
Project: r8
Branch: main
Author: Christoffer Adamsen <
Link:
Reproduce field propagation issue with ServiceLoader
Expand for full commit details
Reproduce field propagation issue with ServiceLoader
Bug: b/389737060
Change-Id: Id850448f68b999194bc0380dfca625f4f68bc31b
Files:
- A
src/test/java/com/android/tools/r8/ir/optimize/membervaluepropagation/DefaultFieldValueJoinerWithServiceLoaderTest.java
Hash: 6ba9af34b15f2a0d3fe356f6e7a5a4071128aed9
Date: Wed Feb 12 09:31:01 2025
sm...@google.com
Project: r8
Branch: main
Author: Christoffer Adamsen <
Link:
Account for ServiceLoaders in field value propagation
Expand for full commit details
Account for ServiceLoaders in field value propagation
Fixes: b/389737060
Change-Id: Ide438a8e1b0541f3ce2385087f06f8b9909ab3c5
Files:
- M
src/main/java/com/android/tools/r8/optimize/argumentpropagation/propagation/DefaultFieldValueJoiner.java - M
src/test/java/com/android/tools/r8/ir/optimize/membervaluepropagation/DefaultFieldValueJoinerWithServiceLoaderTest.java
Hash: 692fff07b70f6ee5ac520b179aed5e125a0d4848
Date: Wed Feb 12 09:34:04 2025
ki...@gmail.com
Project: r8
Branch: 8.9
Author: Christoffer Adamsen <
Link:
Account for ServiceLoaders in field value propagation
Expand for full commit details
Account for ServiceLoaders in field value propagation
Fixes: b/389737060
Change-Id: Ide438a8e1b0541f3ce2385087f06f8b9909ab3c5
Files:
- M
src/main/java/com/android/tools/r8/optimize/argumentpropagation/propagation/DefaultFieldValueJoiner.java - M
src/test/java/com/android/tools/r8/ir/optimize/membervaluepropagation/DefaultFieldValueJoinerWithServiceLoaderTest.java
Hash: 76cad195cf43c16aa9e7b0203e51662036587e71
Date: Thu Feb 13 10:33:29 2025
sm...@google.com
Project: r8
Branch: 8.9
Author: Christoffer Adamsen <
Link:
Version 8.9.28
Expand for full commit details
Version 8.9.28
Bug: b/389737060
Change-Id: I42c8d3194dc053e3a16eef8ea1c4b3aced6752d6
Files:
- M
src/main/java/com/android/tools/r8/Version.java
Hash: 668c1778e857c1bc8e3f9308a65ddc01a6c14898
Date: Thu Feb 13 10:33:34 2025
sm...@google.com
Project: r8
Branch: 8.9
Author: Christoffer Adamsen <
Link:
Reproduce field propagation issue with ServiceLoader
Expand for full commit details
Reproduce field propagation issue with ServiceLoader
Bug: b/389737060
Change-Id: Id850448f68b999194bc0380dfca625f4f68bc31b
Files:
- A
src/test/java/com/android/tools/r8/ir/optimize/membervaluepropagation/DefaultFieldValueJoinerWithServiceLoaderTest.java
Hash: a76d3e8637b5280dcc972ed9fabc74bb503cc30c
Date: Thu Feb 13 10:33:24 2025
sm...@google.com
Project: r8
Branch: 8.8
Author: Christoffer Adamsen <
Link:
Reproduce field propagation issue with ServiceLoader
Expand for full commit details
Reproduce field propagation issue with ServiceLoader
Bug: b/389737060
Change-Id: Id850448f68b999194bc0380dfca625f4f68bc31b
Files:
- A
src/test/java/com/android/tools/r8/ir/optimize/membervaluepropagation/DefaultFieldValueJoinerWithServiceLoaderTest.java
Hash: a63678f7ebb3321af74c9846be9c851e4da78e4f
Date: Thu Feb 13 10:33:55 2025
sm...@google.com
Project: r8
Branch: 8.8
Author: Christoffer Adamsen <
Link:
Version 8.8.35
Expand for full commit details
Version 8.8.35
Bug: b/389737060
Change-Id: I2361f77b42b529f2cbdfbf60fbe4a95e405ba716
Files:
- M
src/main/java/com/android/tools/r8/Version.java
Hash: d280891c805561bc120f5f96841b50353e74edfe
Date: Thu Feb 13 10:34:06 2025
ap...@google.com
Project: r8
Branch: 8.8
Author: Christoffer Adamsen <
Link:
Account for ServiceLoaders in field value propagation
Expand for full commit details
Account for ServiceLoaders in field value propagation
Fixes: b/389737060
Change-Id: Ide438a8e1b0541f3ce2385087f06f8b9909ab3c5
Files:
- M
src/main/java/com/android/tools/r8/optimize/argumentpropagation/propagation/DefaultFieldValueJoiner.java - M
src/test/java/com/android/tools/r8/ir/optimize/membervaluepropagation/DefaultFieldValueJoinerWithServiceLoaderTest.java
Hash: 05dd13d906b60efdf03caea7067dedf67b7c6a2e
Date: Thu Feb 13 10:34:00 2025
sm...@google.com
Project: r8
Branch: 8.7
Author: Christoffer Adamsen <
Link:
Account for ServiceLoaders in field value propagation
Expand for full commit details
Account for ServiceLoaders in field value propagation
Fixes: b/389737060
Change-Id: Ide438a8e1b0541f3ce2385087f06f8b9909ab3c5
Files:
- M
src/main/java/com/android/tools/r8/optimize/argumentpropagation/propagation/DefaultFieldValueJoiner.java - M
src/test/java/com/android/tools/r8/ir/optimize/membervaluepropagation/DefaultFieldValueJoinerWithServiceLoaderTest.java
Hash: d7dcc9001453052f772056337d3c120dba34fc46
Date: Thu Feb 13 10:34:31 2025
sm...@google.com
Project: r8
Branch: 8.7
Author: Christoffer Adamsen <
Link:
Version 8.7.35
Expand for full commit details
Version 8.7.35
Bug: b/389737060
Change-Id: Icfb60f565b329600b5f167a496a39a61ebff9ea6
Files:
- M
src/main/java/com/android/tools/r8/Version.java
Hash: 1be71bdf4455bbc565502b4c3bbbae64608c57a6
Date: Thu Feb 13 10:34:38 2025
ap...@google.com
Project: r8
Branch: 8.7
Author: Christoffer Adamsen <
Link:
Reproduce field propagation issue with ServiceLoader
Expand for full commit details
Reproduce field propagation issue with ServiceLoader
Bug: b/389737060
Change-Id: Id850448f68b999194bc0380dfca625f4f68bc31b
Files:
- A
src/test/java/com/android/tools/r8/ir/optimize/membervaluepropagation/DefaultFieldValueJoinerWithServiceLoaderTest.java
Hash: 7272540b4f7850ef22543defc221660359704ea2
Date: Thu Feb 13 10:34:26 2025
ap...@google.com
Project: r8
Branch: 8.9
Author: Christoffer Adamsen <
Link:
Account for ServiceLoaders in field value propagation
Expand for full commit details
Account for ServiceLoaders in field value propagation
Fixes: b/389737060
Change-Id: Ide438a8e1b0541f3ce2385087f06f8b9909ab3c5
Files:
- M
src/main/java/com/android/tools/r8/optimize/argumentpropagation/propagation/DefaultFieldValueJoiner.java - M
src/test/java/com/android/tools/r8/ir/optimize/membervaluepropagation/DefaultFieldValueJoinerWithServiceLoaderTest.java
Hash: 76cad195cf43c16aa9e7b0203e51662036587e71
Date: Thu Feb 13 10:33:29 2025
ap...@google.com
Project: r8
Branch: 8.9
Author: Christoffer Adamsen <
Link:
Reproduce field propagation issue with ServiceLoader
Expand for full commit details
Reproduce field propagation issue with ServiceLoader
Bug: b/389737060
Change-Id: Id850448f68b999194bc0380dfca625f4f68bc31b
Files:
- A
src/test/java/com/android/tools/r8/ir/optimize/membervaluepropagation/DefaultFieldValueJoinerWithServiceLoaderTest.java
Hash: a76d3e8637b5280dcc972ed9fabc74bb503cc30c
Date: Thu Feb 13 10:33:24 2025
ap...@google.com
This should now be fixed in R8 8.7.36, 8.8.36 and 8.9.28.
ap...@google.com
Project: r8
Branch: 8.8
Author: Christoffer Adamsen <
Link:
Version 8.8.36
Expand for full commit details
Version 8.8.36
Bug: b/389737060
Change-Id: I9ac9a6eda36030b2569bf6839f9b55257f0d2888
Files:
- M
src/main/java/com/android/tools/r8/Version.java
Hash: d228eeda266e288da18698a2fa464fc97b0303c3
Date: Thu Feb 13 12:31:37 2025
an...@google.com
Project: r8
Branch: 8.8
Author: Christoffer Adamsen <
Link:
Fix call to addDataResources in test
Expand for full commit details
Fix call to addDataResources in test
This was added in 8.9.
Bug: b/389737060
Change-Id: I604550f0c0034256f71c03874eeb4798f7079f18
Files:
- M
src/test/java/com/android/tools/r8/ir/optimize/membervaluepropagation/DefaultFieldValueJoinerWithServiceLoaderTest.java
Hash: 58502e8fa34f0abe33a254671faf1b74e0668c86
Date: Thu Feb 13 12:30:57 2025
sm...@google.com
Project: r8
Branch: 8.7
Author: Christoffer Adamsen <
Link:
Version 8.7.36
Expand for full commit details
Version 8.7.36
Bug: b/389737060
Change-Id: Ib57157e3ca8863dcb097a3aa0a1e840c546a4392
Files:
- M
src/main/java/com/android/tools/r8/Version.java
Hash: de384a5950a14b2244dc74819fffd0306cae7065
Date: Thu Feb 13 12:28:52 2025
sm...@google.com
Project: r8
Branch: 8.7
Author: Christoffer Adamsen <
Link:
Fix call to addDataResources in test
Expand for full commit details
Fix call to addDataResources in test
This was added in 8.9.
Bug: b/389737060
Change-Id: I04d342dc297474d141362290f9ccf22c48332446
Files:
- M
src/test/java/com/android/tools/r8/ir/optimize/membervaluepropagation/DefaultFieldValueJoinerWithServiceLoaderTest.java
Hash: 981af34dd96a316d0c11972d80ce31ab301ec6c1
Date: Thu Feb 13 12:28:09 2025
ki...@gmail.com
Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:
- Android Studio Meerkat Feature Drop | 2024.3.2 Beta 1
- Android Gradle Plugin 8.10.0-beta01
We encourage you to try the latest update.
If you notice further issues or have questions, please file a new bug report.
Thank you for taking the time to submit feedback — we really appreciate it!
sm...@google.com
The fixes for this issue are now also available in:
- Android Studio Meerkat | 2024.3.1 Patch 1
- Android Gradle Plugin 8.9.1
We encourage you to try the latest update.
If you notice further issues or have questions, please file a new bug report.
ki...@gmail.com
Is that documented anywhere? The AndroidX introductory pages and the migration guide didn't note Java 8 source compatibility as a requirement.
I now added:
compileOptions {
sourceCompatibility JavaVersion.VERSION_1_8
targetCompatibility JavaVersion.VERSION_1_8
}
It compiles fine and part 2 of this bug (fast clicking multiple items in a row) seems fixed. However, onClick() is still triggered after enabling selection with a long click. I can also confirm the bugs you disovered in
Thanks for investigating and fixing the bugs on "your" side of the library.
PS: I don't get the point of burying AndroidX bugs in Google's private trackers and linking to them here. The public bug tracker is becoming more and more useless, sorry.
sm...@google.com
*Question*
This is repro-able in the original demo app you uploaded?
*Ask*
Would you mind trying to repro the problem with FancySelectionDemoActivity (from the AndroidX samples folder)? Each child view has an OnClickListener that turns the background dark. So it's jarringly obvious when OnClick is handled.
I'd like to figure this one out, because OnClick firing on initial selection would be a stable release blocker for me, but firing on an existing selection not so, since that would seem an uncommon action by users.
As to public vs private bugs. I'll make an effort to prioritize public issues over private issues. FWIW, I'm a part time contributor to AndroidX. I've been tracking my work using internal bugs, because
1) that's what is "normal" for me, and
2) I track prospective work ideas there that I don't want made public (because people will look at them as promises, which they aren't).
Does your comment on public vs private apply to other components or just RecyclerView-Selection? I'm happy to relay feedback if it applies to others.
ki...@gmail.com
Can you attach an Android Studio project of FancySelectionDemoActivity?
sm...@google.com
FancySelectionDemoActivity is accesible via SupportV7Demos
You can launch it directly from android studio, or it is accessible from the API Demo app under RecyclerView > Selection > "Gesture and Pointer (for Chromebooks!)"
ki...@gmail.com
sm...@google.com
I guess my hands are shakier than yours :)
I updated
Thanks again for helping out, your feedback is helpful and appreciated!
Description
Version used: 1.1.0-rc01
Theme used: Theme.AppCompat.Light.DarkActionBar
Devices/Android versions reproduced on: Motorola Moto G6, Android 9
When the item views of a RecyclerView have OnClickListeners attached, the behaviour of firing onClick events during selection is quite unpredictable. As soon as at least one item was selected, classic ListView did no longer fire any click events for individual list items until all items were unselected.
Current recyclerview-selection exhibits two behaviours I would consider a bug, but maybe I'm using the API in a wrong way:
1. When long-clicking an item to enable multi-item selection, the item is marked as selected/activated as expected. But as soon as you release the finger, an onClick event will be triggered, despite the fact that RecyclerView is currently in selection mode. This behaviour is new since 1.1.0-rc01 and was not present in 1.0.0.
2. After enabling selection mode by long-clicking an item, you can select/activate other items by simply clicking on them. This works fine as long as you click through the items slowly. Then one by one gets selected and no onClick events get fired. But when you click a bit faster, every second item is not selected, but instead clicked (triggering onClick event). This problem existed in 1.0.0 and is still present in 1.1.0-rc01.
The following log shows a sequence of onItemStateChanged and onClick events triggered by long-clicking item 0 to enable selection, then clicking items 1, 2 and 3 quickly.
Expected result: Item 0 is selected, then items 1, 2 and 3 are selected, no onClicks get triggered.
Result on my device: Item 0 is selected, then onClick is triggered for item 0. Items 1 and 3 are selected and item 2 fires an onClick event in between.
click item 0 and hold button:
2020-07-13 21:55:01.402 15005-15005/com.example.recyclerviewdemo E/onItemStateChanged: 0: true
item 0 is selected, now release finger:
2020-07-13 21:55:02.306 15005-15005/com.example.recyclerviewdemo E/onClick: item 0
now click (and release) items 1, 2 and 3 quickly:
2020-07-13 21:55:06.850 15005-15005/com.example.recyclerviewdemo E/onItemStateChanged: 1: true
2020-07-13 21:55:07.038 15005-15005/com.example.recyclerviewdemo E/onClick: item 2
2020-07-13 21:55:07.236 15005-15005/com.example.recyclerviewdemo E/onItemStateChanged: 3: true
Attached is an Android Studio project to reproduce the behaviour.
Item IDs == item positions for brevity, the library behaves the same way in a more complex project with "real" item IDs and a custom key provider.