Status Update
No update yet.
Comments
je...@google.com
ap...@google.com
Android 5.0, 5.1: it shows context menu at top of screen, not as popup. See screenshots.
Android framework doesn't support floating toolbar before 23. So this is intended behavior.
The crash information suggests that this is an error from Snapshot. chuckj@ can you please take a look? I don't know what exactly caused the readError in Snapshot, any suggestions? Thanks a lot!
ap...@google.com
This looks like another instance of 193006595 which I am looking at now.
ap...@google.com
Branch: androidx-main
commit beeb84e7be604088ad40e080a8d0adb1bacbf695
Author: Chuck Jazdzewski <chuckj@google.com>
Date: Thu Jul 08 10:04:28 2021
Remove updating the transparent snapshot
A transparent snapshot is create for the block exeucted by
`Snapshot.observe()` which registers read and write observers
but without creating a snapshot. The code to advance the
global snapshot, however, created a new transparent snapshot in
an attempt to update it to the new global snapshot it just
created. This is not necessary, however, as the transparent
snapshot will retrieve the current global snapshot from
`currentGlobalSnapshot` instead of `previousSnapshot` if
`previousSnapshot` is `null`. With the previous code, if the
global snapshot is advanced by applying a new snapshot the
"updated" transparent snapshot will be left referring to an
older snapshot instead of the most recent global snapshot.
Any snapshot object created in the newly applied snapshot
will throw an exception when it is accessed, as reported in
the bugs. The solution is to remove the apparent vetiagal code.
Test: ./gradlew :compose:r:r:tDUT
Fixes:
Change-Id: I2c0d0b8f57bf70e5a98ea36ed141d97142a5e53e
M compose/runtime/runtime/src/commonMain/kotlin/androidx/compose/runtime/snapshots/Snapshot.kt
M compose/runtime/runtime/src/test/kotlin/androidx/compose/runtime/snapshots/SnapshotTests.kt
tc...@google.com
ae...@google.com
Hi Jelle. I was chatting with Doris today about top animation priorities before beta and deprecation+removal of AnimationClockObservable (filed as internal (in general, API deletions are higher priority than API additions in these last few weeks before beta). Would you be able to temporarily put aside the infinite animation work I saw you're working on this week to complete the clock transition?
pa...@google.com
I think the infinite animation work is almost done so it wouldn't be worth postponing. Also we are removing other awkward APIs on our side due to this change. Is something preventing us from just deprecating the APIs? If this is only about some tests migration they can depend on test-utils which is our internal package.
ti...@google.com
Re #7:
If infinite animation work is almost done, please go ahead and finish. We are in desperate need for help deprecate AnimationClockObservable. My plate is overflowing with API finalization for Animatable and AnimatedVisibility right now, which won't leave enough time for the clock deprecation. :(
Could Jelle loan us a helpful hand on this high priority deprecation, if he's not swamped with critical issues himself? (It is high priority because API changes as such must be done before beta.)
je...@google.com
The infinite animation work is in state of completion now, and I'll start working on migration from AnimationClockObservable today.
My apologies for not responding earlier, I had to take a few days off due to circumstances. Things are better now though!
ti...@google.com
Thank you so much Jelle! I really appreciate that.:)
ap...@google.com
Branch: androidx-main
commit ff9e1216e79fe9480ba7ee9bcb490432221f324c
Author: Jelle Fresen <jellefresen@google.com>
Date: Thu Feb 04 19:38:09 2021
Remove MockAnimationClock
When an object requires a clock and you don't care about the clock,
create the object in composition using it's rememberXxx factory that
retrieves the ambient clock.
Bug: 161247083
Test: ./gradlew compose:foundation:foundation:cC && \
./gradlew compose:ui:ui-test:cC
Change-Id: I383420bacdc61ba27204b25bddb6648db6231d5d
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/ScrollTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/ScrollableTest.kt
D compose/test-utils/src/commonMain/kotlin/androidx/compose/testutils/MockAnimationClock.kt
M compose/ui/ui-test/src/androidAndroidTest/kotlin/androidx/compose/ui/test/gesturescope/SendSwipeTest.kt
ap...@google.com
Branch: androidx-main
commit 58bcedbc6dd053649cba35fd75a0347a94aab086
Author: Jelle Fresen <jellefresen@google.com>
Date: Thu Feb 04 19:01:17 2021
Remove manual clocks from material androidTest
Instead of injecting a ManualAnimationClock in the tests, create the
state objects in composition and rely on `ComposeTestRule.mainClock` to
manually advance time.
Bug: 161247083
Test: ./gradlew compose:material:material:cC
Change-Id: I8a074549e7ea939a0f30217239beee0d65635039
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/BackdropScaffoldTest.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/BottomSheetScaffoldTest.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/ModalBottomSheetTest.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/SwipeToDismissTest.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/SwipeableTest.kt
Description
No description yet.