Fixed
Status Update
No update yet.
Comments
je...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 9082f62682f853ad5251a1c79dde9eccba7abdd9
Author: Max Alfonso-Ying <maxying@google.com>
Date: Thu Apr 18 00:34:40 2024
[M2 text field] Apply background to decoration box
...instead of to the BasicTextField, so changing the
backgroundColor will properly change the decoration
box's background color.
Fixes:
Test: added unit tests
Relnote: "Fix backgroundColor not applying to
TextFieldDecorationBox and OutlinedTextFieldDecorationBox.
Decoration boxes now accept a `shape` parameter."
Change-Id: I371c26718597cb36ac537e9412ce476532afb40d
M compose/material/material/api/current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/TextFieldDecorationBoxDemos.kt
M compose/material/material/src/androidInstrumentedTest/kotlin/androidx/compose/material/textfield/TextFieldDecorationBoxTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/OutlinedTextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextFieldDefaults.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextFieldImpl.kt
https://android-review.googlesource.com/3046833
Branch: androidx-main
commit 9082f62682f853ad5251a1c79dde9eccba7abdd9
Author: Max Alfonso-Ying <maxying@google.com>
Date: Thu Apr 18 00:34:40 2024
[M2 text field] Apply background to decoration box
...instead of to the BasicTextField, so changing the
backgroundColor will properly change the decoration
box's background color.
Fixes:
Test: added unit tests
Relnote: "Fix backgroundColor not applying to
TextFieldDecorationBox and OutlinedTextFieldDecorationBox.
Decoration boxes now accept a `shape` parameter."
Change-Id: I371c26718597cb36ac537e9412ce476532afb40d
M compose/material/material/api/current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/TextFieldDecorationBoxDemos.kt
M compose/material/material/src/androidInstrumentedTest/kotlin/androidx/compose/material/textfield/TextFieldDecorationBoxTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/OutlinedTextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextFieldDefaults.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextFieldImpl.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit d714d90ed827e4ece35d8d3803a4243344d174d5
Author: Jelle Fresen <jellefresen@google.com>
Date: Tue Jul 21 18:32:55 2020
Rename bounds to unclippedBounds in SemanticsNodeInteraction API
The functions in SemanticsNodeInteraction that refer to "bounds" are now
actually using unclipped bounds. Make this explicit to avoid confusion
with "bounds" in SemanticsNode, where it exclusively refers to _clipped_
bounds.
Bug: 161336532
Test: ./gradlew ui:ui-test:cC
Relnote: "Renamed `SemanticsNodeInteraction.getBoundsInRoot()` to
`SemanticsNodeInteraction.getUnclippedBoundsInRoot()`"
Change-Id: Icafdf63b2e2f03f48d5b51371e733917dedcf422
M ui/ui-foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/lazy/LazyColumnForTest.kt
M ui/ui-foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/lazy/LazyRowForTest.kt
M ui/ui-material/src/androidAndroidTest/kotlin/androidx/compose/material/AppBarTest.kt
M ui/ui-material/src/androidAndroidTest/kotlin/androidx/compose/material/BottomNavigationTest.kt
M ui/ui-material/src/androidAndroidTest/kotlin/androidx/compose/material/SnackbarTest.kt
M ui/ui-material/src/androidAndroidTest/kotlin/androidx/compose/material/TabTest.kt
M ui/ui-test/api/current.txt
M ui/ui-test/api/public_plus_experimental_current.txt
M ui/ui-test/api/restricted_current.txt
M ui/ui-test/src/main/java/androidx/ui/test/BoundsAssertions.kt
https://android-review.googlesource.com/1369517
Branch: androidx-master-dev
commit d714d90ed827e4ece35d8d3803a4243344d174d5
Author: Jelle Fresen <jellefresen@google.com>
Date: Tue Jul 21 18:32:55 2020
Rename bounds to unclippedBounds in SemanticsNodeInteraction API
The functions in SemanticsNodeInteraction that refer to "bounds" are now
actually using unclipped bounds. Make this explicit to avoid confusion
with "bounds" in SemanticsNode, where it exclusively refers to _clipped_
bounds.
Bug: 161336532
Test: ./gradlew ui:ui-test:cC
Relnote: "Renamed `SemanticsNodeInteraction.getBoundsInRoot()` to
`SemanticsNodeInteraction.getUnclippedBoundsInRoot()`"
Change-Id: Icafdf63b2e2f03f48d5b51371e733917dedcf422
M ui/ui-foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/lazy/LazyColumnForTest.kt
M ui/ui-foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/lazy/LazyRowForTest.kt
M ui/ui-material/src/androidAndroidTest/kotlin/androidx/compose/material/AppBarTest.kt
M ui/ui-material/src/androidAndroidTest/kotlin/androidx/compose/material/BottomNavigationTest.kt
M ui/ui-material/src/androidAndroidTest/kotlin/androidx/compose/material/SnackbarTest.kt
M ui/ui-material/src/androidAndroidTest/kotlin/androidx/compose/material/TabTest.kt
M ui/ui-test/api/current.txt
M ui/ui-test/api/public_plus_experimental_current.txt
M ui/ui-test/api/restricted_current.txt
M ui/ui-test/src/main/java/androidx/ui/test/BoundsAssertions.kt
Description
When asserting the position of a node, or when printing positions of nodes in the semantics tree, use the unclipped bounds instead of the clipped bounds. Using the clipped bounds is confusing to the user, and makes it impossible to distinguish between a correctly sized node that is clipped to size S, and an incorrectly sized node that is clipped to size S.