camera-view and camera-extensions projects should enable API tracking [161377155]

Fixed

Feature Request

Status Update

No update yet.

Description

al...@google.com

created issue #1

Jul 15, 2020 07:38PM

The camera-view and camera-extensions projects contain API lint errors and must address these issues and enable API tracking per Jetpack versioning guidelines to continue releasing.

Comments

av...@gmail.com <av...@gmail.com> #2Jul 19, 2020 01:18PM

Hi Ed, Thank you so much for these suggestions. I've been reviewing them and merging them in. Hopefully it should be live. I've included a thank you note too in the article.

ni...@google.com <ni...@google.com> #3Jul 21, 2020 12:17AM

Great! Thanks a lot, I'll look for the live updates soon!

al...@google.com <al...@google.com> #4Jul 21, 2020 12:59AM

API lint goes through Metalava and runs with updateApi. Have you run updateApi yet for the two projects?

ni...@google.com <ni...@google.com> #5Jul 21, 2020 01:22AM

Yeah, I ran updateApi and it had no issues generating the api. From a quick glance it does look like the lint-baseline.xml does have some of the public API in it. However, it also looks like the lint-baseline.xml has some out of date suppressions. If the goal is to clean up the lint-baseline.xml of API methods then I can go ahead and do that.

al...@google.com <al...@google.com> #6Jul 21, 2020 02:12PM

As long as it's passing, you should be good. I was encountering API lint issues when I ran updateApi locally, but those may have been resolved already.

xi...@google.com <xi...@google.com> Jul 21, 2020 04:44PM

Reassigned to xi...@google.com.

ap...@google.com <ap...@google.com> #7Jul 23, 2020 01:33PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 6a1a0e635120e931d39270da80113d2cecc4e412
Author: Alan Viverette <alanv@google.com>
Date: Fri Jun 26 12:48:06 2020

Unify top-level API task configuration

Explicitly disables API tasks for camera modules that are missing API
files -- filed

b/161377155

to track fix.

Bug: 129362030
Test: ./gradlew bOS
Change-Id: Ibf71bb38177f3cbdc1078cfddf3f4488d176ad5c

M buildSrc/src/main/kotlin/androidx/build/AndroidXExtension.kt
M buildSrc/src/main/kotlin/androidx/build/AndroidXPlugin.kt
A buildSrc/src/main/kotlin/androidx/build/checkapi/ApiTasks.kt
M buildSrc/src/main/kotlin/androidx/build/checkapi/CheckApi.kt
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaTasks.kt
M buildSrc/src/main/kotlin/androidx/build/resources/ResourceTasks.kt
M camera/camera-extensions/build.gradle
M camera/camera-view/build.gradle
M lifecycle/lifecycle-extensions/build.gradle
M security/identity-credential/build.gradle
M window/window-extensions/build.gradle
M window/window-sidecar/build.gradle

https://android-review.googlesource.com/1351330

xi...@google.com <xi...@google.com> #8Aug 12, 2020 09:54PM

For camera-view, there are LINT issues related to CameraView. CameraView is in the process of being removed. We will generate the api text file afterwards.

src/main/java/androidx/camera/view/CameraView.java:469: error: Methods accepting `File` should also accept `FileDescriptor` or streams: method androidx.camera.view.CameraView.ssrc/main/java/androidx/camera/view/CameraView.java:545: error: Must avoid boxed primitives (`java.lang.Integer`) [AutoBoxing]
src/main/java/androidx/camera/view/CameraView.java:549: error: Must avoid boxed primitives (`java.lang.Integer`) [AutoBoxing]

ho...@google.com <ho...@google.com> #9Aug 13, 2020 01:09AM

Hi Xi,

Is it related to the startRecording()? Does that means I need to to do "./gradlew camera:camera-view:updateApi"?

xi...@google.com <xi...@google.com> #10Aug 13, 2020 03:28PM

No worries. I will suppress the warning and generate the text file.

ap...@google.com <ap...@google.com> #11Oct 28, 2020 04:41PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit dc6020ab6ddff10f3b6802eef3722746a53a5791
Author: Xi Zhang <xizh@google.com>
Date: Mon Oct 26 15:50:41 2020

CameraController: only mirroring takePicture() when the metadata is not set explicitly.

API review feedback:

"So if the user doesn't want mirroring, they get it no matter what. This should respect the user's choices, I think - if you want to set mirroring when no metadata was provided, that's more reasonable, but that should still be documented."

This CL changes the behavior to only mirroring the output when the field is not set by the app.

- In ImageCapture.Metadata, add an internal API for whether the mirroring has been set by the app.
- In CameraController, only mirror when it's not set by the app.

Bug: 161377155
Test: manual test and ./gradlew bOS
Change-Id: I7d4e7941f7f25203ad4107d5bbe37cfeeaa68fba

M camera/camera-core/src/main/java/androidx/camera/core/ImageCapture.java
M camera/camera-core/src/test/java/androidx/camera/core/ImageCaptureTest.kt
M camera/camera-view/src/androidTest/java/androidx/camera/view/CameraControllerDeviceTest.kt
M camera/camera-view/src/main/java/androidx/camera/view/CameraController.java

https://android-review.googlesource.com/1475464

ap...@google.com <ap...@google.com> #12Oct 29, 2020 06:19PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 0c12b0b01c517d7173b54a3bfee9aae9154680b6
Author: Xi Zhang <xizh@google.com>
Date: Tue Oct 27 16:07:22 2020

Do not wrap SurfaceProvider

This CL is walking back from a premature optimization in a previous CL aosp/1457478. The optimization made core exceptions more catchable by binding use cases before the controller is attached to a PreviewView.

However, it breaks the behavior that CameraController only works when attached to Preview. This will not work, if there are 2 controllers created, as pointed out by API review. The second controller will fail to construct because the camera is already attached to use cases.

Bug: 161377155
Test: manual test and ./gradlew bOS
Change-Id: I197e039cbb4bdbe3d6278bf3737ef6f1ff560e9b

M camera/camera-view/src/androidTest/java/androidx/camera/view/CameraControllerDeviceTest.kt
M camera/camera-view/src/main/java/androidx/camera/view/CameraController.java
M camera/camera-view/src/main/java/androidx/camera/view/PreviewView.java

https://android-review.googlesource.com/1477494

ap...@google.com <ap...@google.com> #13Oct 30, 2020 12:38AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 96a0849e3e8e5aaafae2f90ce5a056c6c56c8bf2
Author: Xi Zhang <xizh@google.com>
Date: Wed Oct 28 09:49:26 2020

CameraController: allow use cases to be enabled/disabled together.

API review feedback:

"apps may want to switch between, say, image analysis and image capture in one step. Right now that seems to be:

setImageAnalysisEnabled(false)
setImageCaptureEnabled(true)

Will that cause 2 pipeline restarts, or just one? If 2, can we offer a single method to switch between modes? Perhaps a bitfield?

setEnabledUseCases(IMAGE_ANALYSIS | IMAGE_CAPTURE);"

- Replace setXXXEnabled() methods, with a setEnabledUseCases() method and bitwise options.
- The isXXXEnabled() methods are kept for convinient access.

Bug: 161377155
Test: manual test and ./gradlew bOS
Change-Id: I72aaa0c86a1fd483cf3f74b67e1f4aca200cdb10

M camera/camera-view/src/androidTest/java/androidx/camera/view/CameraControllerDeviceTest.kt
M camera/camera-view/src/main/java/androidx/camera/view/CameraController.java
M camera/integration-tests/viewtestapp/src/androidTest/java/androidx/camera/integration/view/CameraControllerFragmentTest.kt
M camera/integration-tests/viewtestapp/src/main/java/androidx/camera/integration/view/CameraControllerFragment.java

https://android-review.googlesource.com/1478996

ap...@google.com <ap...@google.com> #14Oct 30, 2020 03:48PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 43e9d9f385321ddb5341b6379de53fad89f5b94d
Author: Xi Zhang <xizh@google.com>
Date: Thu Oct 29 18:41:59 2020

CameraController: mark bitwise fields final

Follow-up of the previous CL.

Bug: 161377155
Test: manual test and ./gradlew bOS
Change-Id: I606cc66ca0fbe259208068f8e994943f48c66cea

M camera/camera-view/src/main/java/androidx/camera/view/CameraController.java

https://android-review.googlesource.com/1480414

ap...@google.com <ap...@google.com> #15Oct 30, 2020 06:37PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit df0cc315765c32f5bdbcddeae061ba7c09f7d97d
Author: Xi Zhang <xizh@google.com>
Date: Fri Oct 30 09:31:25 2020

Add missing MainThread check

Bug: 161377155
Test: manual test and ./gradlew bOS
Change-Id: If8e4c29dd8a7452c63dddcb124596ebbab726fcc

M camera/camera-view/src/main/java/androidx/camera/view/CameraController.java

https://android-review.googlesource.com/1481600

ap...@google.com <ap...@google.com> #16Nov 13, 2020 12:09AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit ff218ac04dce0084481a0c94d5ef6ae4ec585a00
Author: Xi Zhang <xizh@google.com>
Date: Wed Aug 12 14:39:12 2020

Generate api.txt for PreviewView

- Generate the api.txt for PreviewView. Doc for API review: go/camerax-previewview
- Generate the api.txt for CameraControler. Doc for API review: go/camera-controller-api-review

The CameraView API is manually removed from the generated txt file. CameraView is in the process of being removed and replaced. See: go/camerax-view-beta

Relnote: generate api.txt for camera-view artifact.

Bug: 161377155
Test: manual test and ./gradlew bOS
Change-Id: I890fbcdf696d921ca48af6ec98d0e794775361f8

A camera/camera-view/api/api_lint.ignore
A camera/camera-view/api/current.txt
A camera/camera-view/api/public_plus_experimental_current.txt
A camera/camera-view/api/restricted_current.txt
M camera/camera-view/build.gradle
M camera/camera-view/src/main/java/androidx/camera/view/CameraController.java
M camera/camera-view/src/main/java/androidx/camera/view/video/Metadata.java
M camera/camera-view/src/main/java/androidx/camera/view/video/OutputFileOptions.java

https://android-review.googlesource.com/1398857

xi...@google.com <xi...@google.com> #17Nov 13, 2020 12:12AM

Reassigned to ca...@google.com.

View has enabled API tracking. Extension is WIP. Assign the bug back to the pool.

au...@google.com <au...@google.com> #18Oct 29, 2021 12:12AM

Any updates here? The API are still not being tracked in camera-extensions project.

ch...@google.com <ch...@google.com> #19Oct 29, 2021 02:20AM

Accepted by ch...@google.com.

aosp/1767746 has been updated for API review. After it is merged, the API in camera-extensions project will be tracked.

ap...@google.com <ap...@google.com> #20Nov 11, 2021 09:23AM

Project: platform/frameworks/support
Branch: androidx-main

commit 351491690bdeae3147fd84219767e5d3c2b23252
Author: Charcoal Chen <charcoalchen@google.com>
Date: Thu Jul 15 17:00:45 2021

Review Extensions API

- Generate api.txt for camera-extensions artifact
- Unhide the extensions APIs

- Doc for API review: go/camerax-extensions-api

Relnote: "Update api files for camera-extensions artifact."

Bug: 161377155
Test: ./gradlew camera:camera-extensions:checkApi
Change-Id: If683a4952044f06bded3e87d6fa47d7aff2ad0e9

M camera/camera-extensions/src/main/java/androidx/camera/extensions/ExtensionMode.java
M camera/camera-extensions/src/main/java/androidx/camera/extensions/ExtensionsInfo.java
M camera/camera-extensions/build.gradle
A camera/camera-extensions/api/public_plus_experimental_current.txt
A camera/camera-extensions/api/current.txt
A camera/camera-extensions/api/restricted_current.txt
M camera/camera-extensions/src/main/java/androidx/camera/extensions/ExtensionsManager.java

https://android-review.googlesource.com/1767746

ch...@google.com <ch...@google.com> #21Nov 11, 2021 11:55AM

Marked as fixed.

API tracking of camera-extensions part should have been enabled after aosp/1767746 is merged. Update the issue status as fixed.