ActivityResultLauncher fails in Fragment.onCreate() [161464278]

Fixed

Bug

Status Update

No update yet.

Description

su...@twofortyfouram.com

created issue #1

Jul 16, 2020 08:08PM

Component used: Fragment
Version used: 1.3.0-alpha06

STEPS TO REPRODUCE
1. Try calling ActivityResultLauncher.launch() during Fragment.onCreate()

RESULTS
Actual: Exception is thrown because fragment is not in created state. Exception is included below.
Expected: No exception is thrown.

NOTES
I called super.onCreate() first. The issue seems to be that the ActivityResultLauncher is looking at the lifecycle to be set to CREATED.

java.lang.IllegalStateException: Operation cannot be started before fragment is in created state
at androidx.fragment.app.Fragment$8.launch(Fragment.java:3351)
at androidx.activity.result.ActivityResultLauncher.launch(ActivityResultLauncher.java:42)
at com.twofortyfouram.locale.sdk.host.edit.AbstractSupportPluginEditFragment.onCreate(AbstractSupportPluginEditFragment.java:173)
at androidx.fragment.app.Fragment.performCreate(Fragment.java:2867)
at androidx.fragment.app.FragmentStateManager.create(FragmentStateManager.java:444)
at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:1287)
at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:1444)
at androidx.fragment.app.FragmentManager.moveFragmentToExpectedState(FragmentManager.java:1522)
at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:1575)
at androidx.fragment.app.BackStackRecord.executeOps(BackStackRecord.java:455)
at androidx.fragment.app.FragmentManager.executeOps(FragmentManager.java:2299)
at androidx.fragment.app.FragmentManager.executeOpsTogether(FragmentManager.java:2084)
at androidx.fragment.app.FragmentManager.removeRedundantOperationsAndExecute(FragmentManager.java:2022)
at androidx.fragment.app.FragmentManager.execPendingActions(FragmentManager.java:1924)
at androidx.fragment.app.FragmentManager$5.run(FragmentManager.java:489)
at android.os.Handler.handleCallback(Handler.java:873)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loop(Looper.java:193)
at android.app.ActivityThread.main(ActivityThread.java:6669)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)

Comments

il...@google.com <il...@google.com> #2Jul 17, 2020 12:23AM

Assigned to jb...@google.com.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

ap...@google.com <ap...@google.com> #3Jul 28, 2020 05:32PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 0ae36378b0381b8da2746fbac9c6bf8f837c495d
Author: Jeremy Woods <jbwoods@google.com>
Date: Fri Jul 17 02:10:30 2020

Ensure ActivityResultLauncher can be launched in onCreate

When attempting to launch an ActivityResultLauncher in onCreate() of a
Fragment, it fails since the the Fragment's Lifecycle does not move to
CREATED until after the onCreate() callback in executed. We should
register the callback as soon as the fragment is attached since that is
the point at which we have all of the needed information.

This change also adds tests to verify that ComponentActivity does not
suffer from the same issue.

Test: Added Activity and Fragment tests
Bug: 161464278
RelNote: "You can now call launch() on an ActivityResultLauncher in the
onCreate() lifecycle method of a fragment."

Change-Id: Ifd98f308fdfbd7c9ce3ae93d032b140d6f3ec35e

M activity/activity/src/androidTest/AndroidManifest.xml
A activity/activity/src/androidTest/java/androidx/activity/ComponentActivityResultTest.kt
M fragment/fragment/api/1.3.0-alpha07.txt
M fragment/fragment/api/current.txt
M fragment/fragment/api/public_plus_experimental_1.3.0-alpha07.txt
M fragment/fragment/api/public_plus_experimental_current.txt
M fragment/fragment/api/restricted_1.3.0-alpha07.txt
M fragment/fragment/api/restricted_current.txt
A fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentActivityResultTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/Fragment.java

https://android-review.googlesource.com/1365186

jb...@google.com <jb...@google.com> #4Jul 28, 2020 06:04PM

Marked as fixed.

This has been fixed internally and will be available in the Fragment 1.3.0-alpha08 release.

va...@gmail.com <va...@gmail.com> #5Oct 21, 2023 07:45PM

Have the same issue on version 1.5.4

override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
super.onViewCreated(view, savedInstanceState)

if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.TIRAMISU) {
checkPermission(Permission.NOTIFICATION, R.string.notification_permission_not_granted)
}
}

jb...@google.com <jb...@google.com> #6Oct 23, 2023 03:06PM

@ #5: Please upload a new issue with a minimal sample project that reproduces this issue using the latest version of Activity and Fragment.

pa...@wagwalking.com <pa...@wagwalking.com> #7Nov 20, 2023 05:18PM

This is still happening!

il...@google.com <il...@google.com> #8Nov 27, 2023 06:37PM

Re comment#7 - you'll want to file a new issue with a sample project.