Fixed
Status Update
Comments
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 1e7648eafb97ac34f38a0f781e906aaa27821c52
Author: Ralston Da Silva <ralu@google.com>
Date: Tue Aug 11 04:16:16 2020
Move focus logic out of AndroidComposeView to a common class called FocusManager.
Focus Manager includes an additional function to clear focus.
This is in preparation to a follow-up CL that will clear focus when a user clicks outside a textField.
This CL also removes the old deprecated FocusManager code.
Bug: 161487952
Bug: 162206799
Fixes: 162206799
Test: ./gradlew compose:ui:ui:testDebugUnitTest --tests androidx.compose.ui.focus.FocusManagerTest
RelNote: Added FocusManager that moves common focus logic out of AndroidComposeView
Change-Id: I528ef86e1599baed36b70054b966a47dc016260d
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_current.txt
D ui/ui-core/src/androidMain/kotlin/androidx/compose/ui/focus/FocusManager.kt
M ui/ui-core/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidOwner.kt
M ui/ui-core/src/androidMain/kotlin/androidx/compose/ui/platform/Wrapper.kt
A ui/ui-core/src/commonMain/kotlin/androidx/compose/ui/focus/FocusManager.kt
M ui/ui-core/src/desktopMain/kotlin/androidx/compose/ui/platform/DesktopOwner.kt
A ui/ui-core/src/test/kotlin/androidx/compose/ui/focus/FocusManagerTest.kt
https://android-review.googlesource.com/1395818
Branch: androidx-master-dev
commit 1e7648eafb97ac34f38a0f781e906aaa27821c52
Author: Ralston Da Silva <ralu@google.com>
Date: Tue Aug 11 04:16:16 2020
Move focus logic out of AndroidComposeView to a common class called FocusManager.
Focus Manager includes an additional function to clear focus.
This is in preparation to a follow-up CL that will clear focus when a user clicks outside a textField.
This CL also removes the old deprecated FocusManager code.
Bug: 161487952
Bug: 162206799
Fixes: 162206799
Test: ./gradlew compose:ui:ui:testDebugUnitTest --tests androidx.compose.ui.focus.FocusManagerTest
RelNote: Added FocusManager that moves common focus logic out of AndroidComposeView
Change-Id: I528ef86e1599baed36b70054b966a47dc016260d
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_current.txt
D ui/ui-core/src/androidMain/kotlin/androidx/compose/ui/focus/FocusManager.kt
M ui/ui-core/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidOwner.kt
M ui/ui-core/src/androidMain/kotlin/androidx/compose/ui/platform/Wrapper.kt
A ui/ui-core/src/commonMain/kotlin/androidx/compose/ui/focus/FocusManager.kt
M ui/ui-core/src/desktopMain/kotlin/androidx/compose/ui/platform/DesktopOwner.kt
A ui/ui-core/src/test/kotlin/androidx/compose/ui/focus/FocusManagerTest.kt
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 24272668ca52565f8aa7dc1328b3d0b4816af4bf
Author: Ralston Da Silva <ralu@google.com>
Date: Wed Aug 12 05:32:50 2020
Allow a user to click outside a focusable component to clear focus
Bug: 161487952
Test: Added new test androidx.compose.ui.focus.SetRootFocus
Relnote: Added a modifier param to SelectionContainer
Change-Id: I4aadafd87d5705b96f73cd49af84728a463c1cc5
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_current.txt
A ui/ui-core/src/androidAndroidTest/kotlin/androidx/compose/ui/focus/SetRootFocus.kt
M ui/ui-core/src/androidMain/kotlin/androidx/compose/ui/platform/Wrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/compose/ui/selection/SelectionContainer.kt
M ui/ui-foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/ClickableTest.kt
https://android-review.googlesource.com/1397870
Branch: androidx-master-dev
commit 24272668ca52565f8aa7dc1328b3d0b4816af4bf
Author: Ralston Da Silva <ralu@google.com>
Date: Wed Aug 12 05:32:50 2020
Allow a user to click outside a focusable component to clear focus
Bug: 161487952
Test: Added new test androidx.compose.ui.focus.SetRootFocus
Relnote: Added a modifier param to SelectionContainer
Change-Id: I4aadafd87d5705b96f73cd49af84728a463c1cc5
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_current.txt
A ui/ui-core/src/androidAndroidTest/kotlin/androidx/compose/ui/focus/SetRootFocus.kt
M ui/ui-core/src/androidMain/kotlin/androidx/compose/ui/platform/Wrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/compose/ui/selection/SelectionContainer.kt
M ui/ui-foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/ClickableTest.kt
ap...@google.com <ap...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 09663afd4cabe568f094ad0cadff5d4422d07b4e
Author: Ralston Da Silva <ralu@google.com>
Date: Fri Sep 18 16:47:32 2020
Add API to programmatically clear focus
Add an ambient called FocusManager that has a clearFocus() function.
Bug: 161487952
Test: ./gradlew compose:ui:ui:connectedCheck -P android.testInstrumentationRunnerArguments.class=androidx.compose.ui.focus.FocusManagerAmbientTest
Relnote: Added API to programmatically clear focus
Change-Id: Ie1dc27dd6d2d0260cdeb363f072bbb609ea10c19
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/public_plus_experimental_current.txt
M compose/ui/ui/api/restricted_current.txt
A compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/focus/FocusManagerAmbientTest.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/input/pointer/PointerInputEventProcessorTest.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeView.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusManager.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/Owner.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/platform/Ambients.kt
M compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/platform/DesktopOwner.kt
M compose/ui/ui/src/test/kotlin/androidx/compose/ui/focus/FocusManagerTest.kt
M compose/ui/ui/src/test/kotlin/androidx/compose/ui/node/LayoutNodeTest.kt
https://android-review.googlesource.com/1432211
Branch: androidx-master-dev
commit 09663afd4cabe568f094ad0cadff5d4422d07b4e
Author: Ralston Da Silva <ralu@google.com>
Date: Fri Sep 18 16:47:32 2020
Add API to programmatically clear focus
Add an ambient called FocusManager that has a clearFocus() function.
Bug: 161487952
Test: ./gradlew compose:ui:ui:connectedCheck -P android.testInstrumentationRunnerArguments.class=androidx.compose.ui.focus.FocusManagerAmbientTest
Relnote: Added API to programmatically clear focus
Change-Id: Ie1dc27dd6d2d0260cdeb363f072bbb609ea10c19
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/public_plus_experimental_current.txt
M compose/ui/ui/api/restricted_current.txt
A compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/focus/FocusManagerAmbientTest.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/input/pointer/PointerInputEventProcessorTest.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeView.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusManager.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/Owner.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/platform/Ambients.kt
M compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/platform/DesktopOwner.kt
M compose/ui/ui/src/test/kotlin/androidx/compose/ui/focus/FocusManagerTest.kt
M compose/ui/ui/src/test/kotlin/androidx/compose/ui/node/LayoutNodeTest.kt
Description
Usecases: