Fixed
Status Update
No update yet.
Comments
ma...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
https://android-review.googlesource.com/1123258
https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
na...@gmail.com
an...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
https://android-review.googlesource.com/1288456
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
an...@google.com
After https://android-review.googlesource.com/c/platform/frameworks/support/+/1413667 we can do smoothScrollBy() and snapToItemIndex().
As part of this ticket we should now implement smoothScrollToItemIndex() functionality
As part of this ticket we should now implement smoothScrollToItemIndex() functionality
je...@google.com
FYI: this also needs to be implemented in the test harness as an action on SemanticsNodeInteraction because you don't always have access to the LazyListState.
For example:
rule.onNodeWithTag("my-lazy-column").performScrollToIndex(60)
rule.onNodeWithTag("my-lazy-column").performScrollToKey(MyItemKey("season6-episode12"))
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 14511a46e45e620505a22c007211df14848e436c
Author: Jelle Fresen <jellefresen@google.com>
Date: Mon Mar 22 18:59:38 2021
Add scroll to item actions for LazyLists in tests
Defines a set of SemanticsPropertyKeys that are added in LazyList and
used in test actions to the effect of scrolling a LazyList to an item
that might not yet be composed.
Bug: 182259407
Bug: 178483889
Bug: 161584524
Fix: 183714443
Test: LazySemanticsTest, ScrollToIndexTest, ScrollToKeyTest
Relnote: "Added `SemanticsActions.ScrollToIndex` to scroll a list with
indexed items to the item with a certain index, and
`SemanticsProperties.IndexForKey` to get the index of an item in a list
with keyed items. Both actions are implemented by LazyList."
Relnote: "Added `SemanticsNodeInteraction.performScrollToIndex` that
scrolls a list to the given index, and
`SemanticsNodeInteraction.performScrollToKey` that scrolls a list to the
item with the given key."
Change-Id: I4fe63399fb620794651e1973730658877bcfeff4
M compose/foundation/foundation/api/1.0.0-beta06.txt
M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/public_plus_experimental_1.0.0-beta06.txt
M compose/foundation/foundation/api/public_plus_experimental_current.txt
M compose/foundation/foundation/api/restricted_1.0.0-beta06.txt
M compose/foundation/foundation/api/restricted_current.txt
A compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/lazy/LazySemanticsTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/LazyList.kt
A compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/LazySemantics.kt
M compose/ui/ui-test/api/public_plus_experimental_1.0.0-beta06.txt
M compose/ui/ui-test/api/public_plus_experimental_current.txt
A compose/ui/ui-test/src/androidAndroidTest/kotlin/androidx/compose/ui/test/actions/ScrollToIndexTest.kt
A compose/ui/ui-test/src/androidAndroidTest/kotlin/androidx/compose/ui/test/actions/ScrollToKeyTest.kt
M compose/ui/ui-test/src/commonMain/kotlin/androidx/compose/ui/test/Actions.kt
M compose/ui/ui-test/src/commonMain/kotlin/androidx/compose/ui/test/Filters.kt
M compose/ui/ui-test/src/commonMain/kotlin/androidx/compose/ui/test/Output.kt
M compose/ui/ui/api/1.0.0-beta06.txt
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/public_plus_experimental_1.0.0-beta06.txt
M compose/ui/ui/api/public_plus_experimental_current.txt
M compose/ui/ui/api/restricted_1.0.0-beta06.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/semantics/SemanticsProperties.kt
https://android-review.googlesource.com/1649407
Branch: androidx-main
commit 14511a46e45e620505a22c007211df14848e436c
Author: Jelle Fresen <jellefresen@google.com>
Date: Mon Mar 22 18:59:38 2021
Add scroll to item actions for LazyLists in tests
Defines a set of SemanticsPropertyKeys that are added in LazyList and
used in test actions to the effect of scrolling a LazyList to an item
that might not yet be composed.
Bug: 182259407
Bug: 178483889
Bug: 161584524
Fix: 183714443
Test: LazySemanticsTest, ScrollToIndexTest, ScrollToKeyTest
Relnote: "Added `SemanticsActions.ScrollToIndex` to scroll a list with
indexed items to the item with a certain index, and
`SemanticsProperties.IndexForKey` to get the index of an item in a list
with keyed items. Both actions are implemented by LazyList."
Relnote: "Added `SemanticsNodeInteraction.performScrollToIndex` that
scrolls a list to the given index, and
`SemanticsNodeInteraction.performScrollToKey` that scrolls a list to the
item with the given key."
Change-Id: I4fe63399fb620794651e1973730658877bcfeff4
M compose/foundation/foundation/api/1.0.0-beta06.txt
M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/public_plus_experimental_1.0.0-beta06.txt
M compose/foundation/foundation/api/public_plus_experimental_current.txt
M compose/foundation/foundation/api/restricted_1.0.0-beta06.txt
M compose/foundation/foundation/api/restricted_current.txt
A compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/lazy/LazySemanticsTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/LazyList.kt
A compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/LazySemantics.kt
M compose/ui/ui-test/api/public_plus_experimental_1.0.0-beta06.txt
M compose/ui/ui-test/api/public_plus_experimental_current.txt
A compose/ui/ui-test/src/androidAndroidTest/kotlin/androidx/compose/ui/test/actions/ScrollToIndexTest.kt
A compose/ui/ui-test/src/androidAndroidTest/kotlin/androidx/compose/ui/test/actions/ScrollToKeyTest.kt
M compose/ui/ui-test/src/commonMain/kotlin/androidx/compose/ui/test/Actions.kt
M compose/ui/ui-test/src/commonMain/kotlin/androidx/compose/ui/test/Filters.kt
M compose/ui/ui-test/src/commonMain/kotlin/androidx/compose/ui/test/Output.kt
M compose/ui/ui/api/1.0.0-beta06.txt
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/public_plus_experimental_1.0.0-beta06.txt
M compose/ui/ui/api/public_plus_experimental_current.txt
M compose/ui/ui/api/restricted_1.0.0-beta06.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/semantics/SemanticsProperties.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 59dca3bb1906b988bcc55a2bc44f93063e87a48f
Author: Jelle Fresen <jellefresen@google.com>
Date: Thu Apr 08 16:20:32 2021
Add scroll to matcher action for LazyLists in tests
Adds an action to SemanticsNodeInteraction to scroll to content in a
LazyList identified by a SemanticsMatcher. Adds a filter as well to find
nodes that support this scroll action.
Fix: 161584524
Fix: 182259407
Fix: 182260995
Test: Added ScrollToNodeTest
Relnote: "Added `performScrollToNode(matcher: SemanticsMatcher)` that
scrolls a scrollable container to the content that is matched by the
given matcher."
Change-Id: Ic1cb855e351c7bb683962d618d68782628b70f62
M compose/ui/ui-test/src/commonMain/kotlin/androidx/compose/ui/test/Actions.kt
M compose/ui/ui-test/api/current.txt
M compose/ui/ui-test/api/public_plus_experimental_current.txt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/LazyListState.kt
A compose/ui/ui-test/src/androidAndroidTest/kotlin/androidx/compose/ui/test/actions/ScrollToNodeTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/LazySemantics.kt
M compose/ui/ui-test/src/commonMain/kotlin/androidx/compose/ui/test/Filters.kt
M compose/ui/ui-test/api/restricted_current.txt
https://android-review.googlesource.com/1815782
Branch: androidx-main
commit 59dca3bb1906b988bcc55a2bc44f93063e87a48f
Author: Jelle Fresen <jellefresen@google.com>
Date: Thu Apr 08 16:20:32 2021
Add scroll to matcher action for LazyLists in tests
Adds an action to SemanticsNodeInteraction to scroll to content in a
LazyList identified by a SemanticsMatcher. Adds a filter as well to find
nodes that support this scroll action.
Fix: 161584524
Fix: 182259407
Fix: 182260995
Test: Added ScrollToNodeTest
Relnote: "Added `performScrollToNode(matcher: SemanticsMatcher)` that
scrolls a scrollable container to the content that is matched by the
given matcher."
Change-Id: Ic1cb855e351c7bb683962d618d68782628b70f62
M compose/ui/ui-test/src/commonMain/kotlin/androidx/compose/ui/test/Actions.kt
M compose/ui/ui-test/api/current.txt
M compose/ui/ui-test/api/public_plus_experimental_current.txt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/LazyListState.kt
A compose/ui/ui-test/src/androidAndroidTest/kotlin/androidx/compose/ui/test/actions/ScrollToNodeTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/LazySemantics.kt
M compose/ui/ui-test/src/commonMain/kotlin/androidx/compose/ui/test/Filters.kt
M compose/ui/ui-test/api/restricted_current.txt
Description
It would be very useful if the ScrollerPosition class had one or multiple methods for scrolling to a specific element index instead of a position in pixels. The current API forces developers to do the calculate the height of each element themselves and figure out at which pixel location the desired element is from that.