ListItem: API scrub [161804681]

Fixed

Bug

Status Update

No update yet.

Description

ma...@google.com

created issue #1

Jul 21, 2020 05:55PM

API feedback for ListItem:

remove String versions from ListItem
onClick shouldn't be nullable. Make it {} by default, add enabled param OR remove onClick and make people use Modifier.clickable, if you can
Consider splitting slotted ListItem into several different ones: SingleLineListItem, TwoLinesListItem, ThreeLinesListItem. Named are verbose, but API will be much simpler and slots will be more understandable with less nullability.
Make the version of ListItem with just one RowScope: content slot
(clarify with UX) Consider having Surface in ListItem, it's hard to understand how transparent ListItem will work with SwipeToDismiss, etc

Comments

ma...@google.com <ma...@google.com> Jul 24, 2020 11:11AM

Reassigned to po...@google.com.

cl...@google.com <cl...@google.com> Aug 7, 2020 11:25AM

Reassigned to ma...@google.com.

ma...@google.com <ma...@google.com> #2Aug 7, 2020 02:23PM

bulk comment, fyi: we have added icebox to all the tickets because it was suggested by blintz in order to prevent auto-close tickets. we want to keep our Compose tickets to remain opened.

see

b/123001228#comment6

ap...@google.com <ap...@google.com> #3Aug 10, 2020 02:44PM

Marked as fixed.

So... Any updates after 2,5 years?

Issue 161804681

Description

Issue summary

Comments

ma...@google.com <ma...@google.com> Jul 24, 2020 11:11AM

cl...@google.com <cl...@google.com> Aug 7, 2020 11:25AM

ma...@google.com <ma...@google.com> #2Aug 7, 2020 02:23PM

ap...@google.com <ap...@google.com> #3Aug 10, 2020 02:44PM

Add comment

Issue metadata