Status Update
No update yet.
Comments
ma...@google.com
cl...@google.com
ma...@google.com
I am not sure I understand what you are asking for here.
The contract of onPrepareMenu in MenuProvider is:
"Called by the MenuHost right before the Menu is shown. This should be called when the menu has been dynamically updated."
If you were using Toolbar prior to the MenuHost integration, this should be a no-op for you. And if you are now switching to Toolbar, the onPrepareMenu() call should be in the proper place.
But the contract is not being violated.
If you are seeing some unexpected behavior, please provide a sample app that reproduces the error that you are observing.
ap...@google.com
reuploading my previous sample app.
It's fairly simple.
Call order with AppCompat 1.5.0-alpha01:
- onCreateMenu
- onPrepareMenu
- user opens menu
- menu is displayed
According to the contract:
"Called by the MenuHost right before the Menu is shown.
it should be:
- onCreateMenu
- user opens menu
- onPrepareMenu
- menu is displayed
build and run the sample. It has examples for both activity and fragment. Follow the print out's in the log.
Description
API feedback for ListItem:
ListItemonClickshouldn't be nullable. Make it {} by default, addenabledparam OR remove onClick and make people useModifier.clickable, if you canSingleLineListItem,TwoLinesListItem,ThreeLinesListItem. Named are verbose, but API will be much simpler and slots will be more understandable with less nullability.RowScope: contentslot