Fixed
Status Update
Comments
ma...@google.com <ma...@google.com>
cl...@google.com <cl...@google.com>
ma...@google.com <ma...@google.com> #2
What I will do in this bug:
- remove string overloads
- remove onclick in favor of simply a modifier
I won't split to different version, because it appears useless as almost every parameter goes in all three, and we actually cannot distinguish clearly between 2 and 3 lined items
I won't make a surface and, therefore, simple RowScope version, because without surface it makes no sense. Filed
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 3075528af75b89dfd79168f451d476417d392a1d
Author: Matvei Malkov <malkov@google.com>
Date: Fri Aug 07 15:13:42 2020
Refactor ListItem API slightly.
String version has been removed, click has been removed as we have Modifier.clickable, added some documentation.
Change-Id: Ib8f5742805f11b458db53b98a893c7fcb35eba00
Relnote: ListItem version with String-based API has been removed. Use slot version instead.
Fixes: 161804681
Test: ListItemTest + demos
M ui/integration-tests/demos/src/main/java/androidx/ui/demos/DemoApp.kt
M ui/integration-tests/demos/src/main/java/androidx/ui/demos/DemoFilter.kt
M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/samples/src/main/java/androidx/compose/material/samples/ListSamples.kt
M ui/ui-material/src/androidAndroidTest/kotlin/androidx/compose/material/ListItemTest.kt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/ListItem.kt
https://android-review.googlesource.com/1393112
Branch: androidx-master-dev
commit 3075528af75b89dfd79168f451d476417d392a1d
Author: Matvei Malkov <malkov@google.com>
Date: Fri Aug 07 15:13:42 2020
Refactor ListItem API slightly.
String version has been removed, click has been removed as we have Modifier.clickable, added some documentation.
Change-Id: Ib8f5742805f11b458db53b98a893c7fcb35eba00
Relnote: ListItem version with String-based API has been removed. Use slot version instead.
Fixes: 161804681
Test: ListItemTest + demos
M ui/integration-tests/demos/src/main/java/androidx/ui/demos/DemoApp.kt
M ui/integration-tests/demos/src/main/java/androidx/ui/demos/DemoFilter.kt
M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/samples/src/main/java/androidx/compose/material/samples/ListSamples.kt
M ui/ui-material/src/androidAndroidTest/kotlin/androidx/compose/material/ListItemTest.kt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/ListItem.kt
Description
API feedback for ListItem:
ListItem
onClick
shouldn't be nullable. Make it {} by default, addenabled
param OR remove onClick and make people useModifier.clickable
, if you canSingleLineListItem
,TwoLinesListItem
,ThreeLinesListItem
. Named are verbose, but API will be much simpler and slots will be more understandable with less nullability.RowScope: content
slot