Fixed
Status Update
Comments
ma...@google.com <ma...@google.com>
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit e61e200798a3f3337d0cb965e2e2ac09e334ea30
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Fri Jul 31 15:13:22 2020
General Tab Polishing
- Fixes parameter order to have required parameters first
- Renames onSelected to onClick to match other components
- Renames activeColor and inactiveColor to selectedContentColor and unselectedContentColor to be more explicit and match BottomNavigationItem
- Adds selected/unselectedContentColor parameters to the generic Tab overload that just takes `content`
- Adds ColumnScope to the generic Tab overload
Bug: b/161807532
Test: TabTest
Relnote: "Renames and reorders some parameters in Tab for consistency with other APIs"
Change-Id: Ia2d12aa787a9c8b829371070cd4379ae30049c7c
M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/samples/src/main/java/androidx/compose/material/samples/TabSamples.kt
M ui/ui-material/src/androidAndroidTest/kotlin/androidx/compose/material/TabTest.kt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/Tab.kt
https://android-review.googlesource.com/1382559
Branch: androidx-master-dev
commit e61e200798a3f3337d0cb965e2e2ac09e334ea30
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Fri Jul 31 15:13:22 2020
General Tab Polishing
- Fixes parameter order to have required parameters first
- Renames onSelected to onClick to match other components
- Renames activeColor and inactiveColor to selectedContentColor and unselectedContentColor to be more explicit and match BottomNavigationItem
- Adds selected/unselectedContentColor parameters to the generic Tab overload that just takes `content`
- Adds ColumnScope to the generic Tab overload
Bug:
Test: TabTest
Relnote: "Renames and reorders some parameters in Tab for consistency with other APIs"
Change-Id: Ia2d12aa787a9c8b829371070cd4379ae30049c7c
M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/samples/src/main/java/androidx/compose/material/samples/TabSamples.kt
M ui/ui-material/src/androidAndroidTest/kotlin/androidx/compose/material/TabTest.kt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/Tab.kt
Description
API scrub feedback:
items
in params, etc)activeColor
and firends are for contentonSelected
->onClick
activeColor
->selectedContentColor
ColumnScope
forTab
selectedContentColor
and firends to the second overload