Tab API scrub [161807532] - Issue Tracker

… >…pack Compose >

Tab API scrub

Fixed

Bug

P2

Status Update

No update yet.

Description

ma...@google.com

created issue #1

Jul 21, 2020 05:40PM

API scrub feedback:

Unify API surface with BottomNavigation (remove items in params, etc)
Make required parameters be the first
make it clear that activeColor and firends are for content
onSelected -> onClick
activeColor -> selectedContentColor
ColumnScope for Tab
add selectedContentColor and firends to the second overload

Comments

ma...@google.com <ma...@google.com> Jul 24, 2020 11:16AM

Reassigned to lp...@google.com.

ap...@google.com <ap...@google.com> #2Aug 4, 2020 07:33PM

A couple of questions:

1. Have you saw crash in real device or only in simulators?
2. Do you use dynamic feature for language ID?

lp...@google.com <lp...@google.com> Aug 4, 2020 07:36PM

Marked as fixed.

Reporter

ma...@google.com

Type

Priority

Severity

Status

Access

Default access

View

Expanded Access

Assignee

lp...@google.com

Verifier

--

Collaborators

CC

an...@google.com

cl...@google.com

je...@google.com

lp...@google.com

ma...@google.com

pa...@google.com

Code Changes

--

Pending Code Changes

--

Staffing

--

AOSP ID

--

Estimate

--

Estimate

--

Public Project Status

Public Status Summary

--

Test Field

--

Found In

--

Targeted To

--

Verified In

--

In Prod

ReportedBy