AlertDialog API scrub [161809319]

Fixed

Bug

Status Update

No update yet.

Description

ma...@google.com

created issue #1

Jul 21, 2020 05:36PM

Feedback per API scrub, to be done before alpha if possible:

Make version with two buttons slots always be auto by default
Remove AlertDialogButtonStrategy enums, as it will be auto in two slots and in one buttons slot people will be able to make it as they like
Rename onCloseRequest to onDismissRequest for consistency with other APIs
clarify in the docs what gets called when back button pressed and when touched outside. Do they both trigger onDismissRequest?
Expose backgroundColor and contentColor as params.

Comments

ma...@google.com <ma...@google.com> Jul 24, 2020 11:07AM

Reassigned to pa...@google.com.

ap...@google.com <ap...@google.com> #2Aug 7, 2020 11:42AM

Marked as fixed.

Seems like it is caused by the subcompose(BottomSheetScaffoldLayoutSlot.Fab, fab)[0].measure(looseConstraints) line in the bottom sheet. Seems like you have the floatingActionButton = {} passed in your scaffold. setting it to null instead should solve the issue.

@jossi, could you take a look if we can handle this more gracefully and whether it makes sense?

Issue 161809319

Description

Issue summary

Comments

ma...@google.com <ma...@google.com> Jul 24, 2020 11:07AM

ap...@google.com <ap...@google.com> #2Aug 7, 2020 11:42AM

Add comment

Issue metadata