Fixed
Status Update
Comments
ma...@google.com <ma...@google.com>
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 6492a281bd17da7537f453a3fc01d182c79a169e
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Mon Jul 27 17:24:43 2020
Rename BottomNavigationItem parameters
text -> label to match the Material.io documentation and the `alwaysShowLabels` parameter
onSelected -> onSelect to match the tense we use in other components
activeColor -> selectedContentColor to be more clear about what this 'color' is, and match the selected state
inactiveColor -> unselectedContentColor to be more clear about waht this 'color' is, and match the not-selected state
Additionally fixes the ordering of parameters so that all required parameters are first, followed by the Modifier param.
Bug: b/161809324
Test: ./gradlew updateApi
Relnote: "Renames BottomNavigationItem's `text` parameter to `label`, `onSelected` to `onSelect`, `activeColor` to `selectedContentColor`, `inactiveColor` to `unselectedContentColor` and updates parameter ordering to match guidelines."
Change-Id: Icb605dac9b76a0204a2a9d675530da8897f817d5
M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/samples/src/main/java/androidx/compose/material/samples/BottomNavigationSamples.kt
M ui/ui-material/src/androidAndroidTest/kotlin/androidx/compose/material/BottomNavigationTest.kt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/BottomNavigation.kt
https://android-review.googlesource.com/1373097
Branch: androidx-master-dev
commit 6492a281bd17da7537f453a3fc01d182c79a169e
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Mon Jul 27 17:24:43 2020
Rename BottomNavigationItem parameters
text -> label to match the Material.io documentation and the `alwaysShowLabels` parameter
onSelected -> onSelect to match the tense we use in other components
activeColor -> selectedContentColor to be more clear about what this 'color' is, and match the selected state
inactiveColor -> unselectedContentColor to be more clear about waht this 'color' is, and match the not-selected state
Additionally fixes the ordering of parameters so that all required parameters are first, followed by the Modifier param.
Bug:
Test: ./gradlew updateApi
Relnote: "Renames BottomNavigationItem's `text` parameter to `label`, `onSelected` to `onSelect`, `activeColor` to `selectedContentColor`, `inactiveColor` to `unselectedContentColor` and updates parameter ordering to match guidelines."
Change-Id: Icb605dac9b76a0204a2a9d675530da8897f817d5
M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/samples/src/main/java/androidx/compose/material/samples/BottomNavigationSamples.kt
M ui/ui-material/src/androidAndroidTest/kotlin/androidx/compose/material/BottomNavigationTest.kt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/BottomNavigation.kt
lp...@google.com <lp...@google.com>
lp...@google.com <lp...@google.com> #3
Discussed further offline, onSelect
should be renamed to onClick
for consistency (with Tab and other components).
ap...@google.com <ap...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-master-dev
commit dfd1e72afa17243e42449e955f08213f0a4afcd4
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Wed Sep 09 17:04:47 2020
Renames BottomNavigationItem's onSelect parameter to onClick for consistency with other components such as Tab
Bug: b/161809324
Test: ./gradlew updateApi
Relnote: "Renames BottomNavigationItem's onSelect parameter to onClick"
Change-Id: I919251069ab307d1ed5c1c3fbf5a01bf77a85047
M compose/material/material/api/current.txt
M compose/material/material/api/public_plus_experimental_current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/samples/src/main/java/androidx/compose/material/samples/BottomNavigationSamples.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/BottomNavigationScreenshotTest.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/BottomNavigationTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/BottomNavigation.kt
https://android-review.googlesource.com/1423472
Branch: androidx-master-dev
commit dfd1e72afa17243e42449e955f08213f0a4afcd4
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Wed Sep 09 17:04:47 2020
Renames BottomNavigationItem's onSelect parameter to onClick for consistency with other components such as Tab
Bug:
Test: ./gradlew updateApi
Relnote: "Renames BottomNavigationItem's onSelect parameter to onClick"
Change-Id: I919251069ab307d1ed5c1c3fbf5a01bf77a85047
M compose/material/material/api/current.txt
M compose/material/material/api/public_plus_experimental_current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/samples/src/main/java/androidx/compose/material/samples/BottomNavigationSamples.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/BottomNavigationScreenshotTest.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/BottomNavigationTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/BottomNavigation.kt
Description
API scrub feedback for BottomNavigationItem:
text
tolabel
to matchalwaysShowLabel
paramonSelected
->onSelect