BottomNavigationItem: API scrub [161809324]

Fixed

Bug

Status Update

No update yet.

Description

ma...@google.com

created issue #1

Jul 21, 2020 05:44PM

API scrub feedback for BottomNavigationItem:

rename text to label to match alwaysShowLabel param
onSelected -> onSelect

Comments

ma...@google.com <ma...@google.com> Jul 24, 2020 11:16AM

Reassigned to lp...@google.com.

ap...@google.com <ap...@google.com> #2Jul 28, 2020 02:05PM

There is a report about it in kotlinlang Slack: https://kotlinlang.slack.com/archives/C01D6HTPATV/p1706005056105739

lp...@google.com <lp...@google.com> Jul 28, 2020 02:14PM

Marked as fixed.

lp...@google.com <lp...@google.com> #3Sep 9, 2020 04:04PM

Status: Assigned (reopened)

Thanks for the report!

ap...@google.com <ap...@google.com> #4Sep 9, 2020 06:38PM

The release notes documentation has been edited to clarify this change in behavior for line height.

To support non-standard text sizes, we encourage users to follow the Material design system and use a different type scale rather than changing the font size directly. Alternatively, users can overwrite the line height like so: style = LocalTextStyle.current.copy(lineHeight = TextUnit.Unspecified), or create a custom Typography entirely.

lp...@google.com <lp...@google.com> Sep 9, 2020 09:54PM